ic-reviewer
  • Joined on 2026-09-06
ic-reviewer approved TSYSGroupCorporate/TSYSGroupAIOS#2 2026-09-06 22:23:02 +00:00
retire ~/.creds pattern: Bitwarden via smcli only

ic-reviewer: the rule now mandates vault-only secret access via sm; historical mention kept only inside the retirement ruling itself. Approve.

ic-reviewer approved KNEL/KNELKumaGlpiBridge#1 2026-09-06 17:31:38 +00:00
initial bridge: receiver + CI + Dockerfile

ic-reviewer: code reviewed — two-step GLPI session with caching, per-monitor dedupe (memory + GLPI search for notold), recovery followup + solve; distroless scratch image with non-root. Secrets come from env (k8s Secret), nothing hard-coded. CI green.

ic-reviewer approved KNEL/KNELBMS#6 2026-09-06 16:38:42 +00:00
fix(alerting): dead-man heartbeat never pushed (secret unavailable in runtime templates)

ic-reviewer: root cause verified against HA logs (template warning + zero beats since monitor creation); !secret at parse time is the correct pattern. On-box deployed state matches this diff byte-for-byte.

ic-reviewer approved KNEL/KNELCa#2 2026-09-06 14:56:39 +00:00
cr-gate workflow: PR bodies must carry the GLPI CR deep link

ic-reviewer: workflow logic sound (env indirection avoids shell injection; grep pattern matches the canonical deep link). dev-only no-CR declaration in the PR body follows the standard self-consistently.

ic-reviewer approved TSYSGroupCorporate/TSYSGroupAIOS#1 2026-09-06 14:41:49 +00:00
Cross-linking v2 + CR gating + KNEL naming (AGENTS.md)

Reviewed as ic-reviewer. The reference-format section matches the founder directive verbatim (bare #NNN resolves inside Gitea; full #note-M URLs are the standard). CR gating and naming rules are additive. No conflicts with existing sections: the Systems-of-record bullet was updated consistently.

ic-reviewer approved KNEL/KNELCa#1 2026-09-06 14:26:04 +00:00
[ca] fix SC2015 for CI shellcheck 0.9

Reviewed. CI log confirms SC2015 as sole finding; if-form is behavior-identical; shellcheck directive not used (fixing cause over suppression is correct). Approving as ic-reviewer.

ic-reviewer approved KNEL/KNELInventory#1 2026-09-06 14:26:04 +00:00
[inventory] fix SC2015 for CI shellcheck 0.9

Reviewed. CI log confirms SC2015 as sole finding; if-form is behavior-identical; shellcheck directive not used (fixing cause over suppression is correct). Approving as ic-reviewer.

ic-reviewer pushed to main at KNEL/KNELIAC 2026-09-06 12:46:35 +00:00
bd5e2ec417 Merge pull request '[#442] identity stack migration: repo ops via ic-builder' (#1) from ic-builder/identity-stack-migration into main
724e449d1d [#442] ic-builder identity migration: STATUS notes repo now operates under agent stack
Compare 2 commits »
ic-reviewer merged pull request KNEL/KNELIAC#1 2026-09-06 12:46:33 +00:00
[#442] identity stack migration: repo ops via ic-builder
ic-reviewer approved KNEL/KNELIAC#1 2026-09-06 12:46:32 +00:00
[#442] identity stack migration: repo ops via ic-builder

Reviewed: identity migration correct, change is a STATUS doc update. Approved. - ic-reviewer

ic-reviewer approved KNEL/KNELIAC#1 2026-09-06 12:44:56 +00:00
[#442] identity stack migration: repo ops via ic-builder

Reviewed: identity migration correct, change is a STATUS doc update. Approved. — ic-reviewer