3020 Commits

Author SHA1 Message Date
gaspar-ilom
3f8317fe9a
create tb.bin blob when creating me.bin blob
automatically move into board target dir

rename blob creation file for t480 to indicate that the tb.bin is also downloaded and created

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-27 02:40:12 +01:00
Thierry Laurion
557ccb6499
Merge remote-tracking branch 'osresearch/master' into poc_t480
Resolve conficts too

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-26 19:08:24 -05:00
Thierry Laurion
54356dd536
Merge remote-tracking branch 'gaspar-ilom/poc_t480' into poc_t480 2025-02-26 19:02:35 -05:00
gaspar-ilom
e647e20b4a
refactor printing of battery state to confuse less users
only print the battery manufacturer in case there is more than one battery, otherwise omit it

make the code more readable for non-bash developers

extract common functions

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-26 23:42:02 +01:00
Thierry Laurion
d4c4e5699b
Merge pull request #1916 from tlaurion/sinit_ivy_sandy_bridge_intel_removal_fix_using_archive-org
blobs/xx30/optiplex_7010_9010.sh: use web.arhive.org to download zip containing ivy/sandy file now missing upstream.
2025-02-25 09:28:14 -05:00
Thierry Laurion
98d7982834
blobs/xx30/optiplex_7010_9010.sh: use web.arhive.org to download zip containing ivy/sandy file now missing upstream. Fix path where file is found in zip
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-25 09:24:58 -05:00
Thierry Laurion
a084cc7b4a
Merge pull request #1913 from Dasharo/novacustom_v54x_mtl_heads_v0.9.0
Add Novacustom V54 (v540tu)
2025-02-25 08:31:03 -05:00
Thierry Laurion
e00944f034
Merge remote-tracking branch 'gaspar-ilom/poc_t480' into poc_t480
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-24 17:41:52 -05:00
Thierry Laurion
a86dfe0e7f
Merge remote-tracking branch 'gaspar-ilom/poc_t480' into poc_t480 2025-02-24 17:38:30 -05:00
gaspar-ilom
60219a443c
update the T480 blob readme to better explain which blobs are there and where they come from
remove duplicate hashes

add reference to info on tpm reset because people might not read everything

rename README to README.md as it is markdown

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-24 22:41:43 +01:00
Thierry Laurion
de722cd0f2
BOARD_TESTERS.md: remove space between @ and avatar name
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-24 16:32:09 -05:00
Thierry Laurion
1fb37f01a3
blobs/xx80/README: fix gbe hash
repro

user@heads-t480:~/heads/blobs/xx80$ git status
On branch poc_t480
nothing to commit, working tree clean
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; grep $hash README; done
bash: syntax error near unexpected token `done'
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ vim README
user@heads-t480:~/heads/blobs/xx80$ vim README
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ sha256sum -c hashes.txt
gbe.bin: OK
ifd.bin: OK
me.bin: OK
user@heads-t480:~/heads/blobs/xx80$ cat hashes.txt | awk -F " " {'print $1'} | while read hash; do grep $hash README; done
d3af2dfbf128bcddfc8c5810a11478697312e5701668f719f80f3f6322db5642  gbe.bin
f2f6d5fb0a5e02964b494862032fd93f1f88e2febd9904b936083600645c7fdf  ifd.bin
1990b42df67ba70292f4f6e2660efb909917452dcb9bd4b65ea2f86402cfa16b  me.bin
user@heads-t480:~/heads/blobs/xx80$ cat .gitignore
me.bin
user@heads-t480:~/heads/blobs/xx80$ git status

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-24 16:29:00 -05:00
Thierry Laurion
d9f4cbcfc3
t480 boards: disable tracing output as for all other boards
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-24 12:11:25 -05:00
Thierry Laurion
7ce3ac709f
functions: remove now unused calc helper, readd TRACE_FUNC and DEBUG info for future tracing and debug of now hackish bashisms.
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-24 09:56:46 -05:00
gaspar-ilom
6f2e7cbefa
disable debugging on the T480
all remaining issues do not seem to be heads but coreboot related

no debugging needed anymore, issues should be reported upstream and fixed there

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-24 14:24:03 +01:00
gaspar-ilom
02bfdeec98
apply the same fix for displaying the battery state to: initrd/bin/oem-system-info-xx30
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-24 14:15:20 +01:00
gaspar-ilom
9eb7618e82
add more board tester for the T480
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-24 13:59:01 +01:00
gaspar-ilom
a45c483bdd
properly escape % chars in format string to display battery status
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-23 11:31:40 +01:00
gaspar-ilom
543ab5543e
refactor how battery status string is composed
simplify and make sure health and charge state are printed next to each other for the same battery

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-23 00:06:51 +01:00
gaspar-ilom
60faa5f05c
fix show system info battery display in case there is more than 1 battery
show health and charge state for each battery

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-23 00:04:41 +01:00
gaspar-ilom
cb8d23c45a
fix battery health and charging display in system info
calc was not found, but awk can do the job just fine and was anyway already used

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-21 22:55:14 +01:00
gaspar-ilom
1e0258b7f1
use common me_cleaner.py for T480
make circleci create the cleaned and deguarded me blob for the T480 to improve performance by allowing to reuse the workspace

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-21 14:04:53 +01:00
gaspar-ilom
aadbe93dea
move me_cleaner.py to a common utils dir under blobs/ so that it can be used by any board
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-21 12:53:43 +01:00
gaspar-ilom
0416162ded
add more volunteers as board testers for the T480
remove the not (yet) supported t480s from the board testers file

Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-19 22:10:52 +01:00
Thierry Laurion
84c0b2dac8
CircleCI: drop building d16 which causes build issues with changes to CircleCI to build for t480. Delegating needed fixes to https://github.com/linuxboot/heads/pull/1910 community effort and for the d16 club d16 board owners
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-19 13:29:01 -05:00
Thierry Laurion
67a027d4f8
CircleCI: add coreboot 24.12 in save_cache/restore_cache statements in case we change CircleCI worskpace caches leading to build artifacts being reusable in the future
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-19 11:44:52 -05:00
Thierry Laurion
384e2438d2
TESTING: CircleCI: force AVAILABLE_MEM_GB=8 so that we respect guaranteed minimal resource allocation of CircleCI being 8Gb. Will slow down builds....
Reasoning:
- t480 depends on coreboot 24.12, which in turn depends on gcc 14.2 and consumes more memory through parallelization of CircleCI builds which randomly fails if CircleCI with 24.12

Failsafe which might break builds since less threads will be used to build, will see.

TODO: reevaluate if builds take too long and timeouts on max 1h build time per step.

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-19 11:44:41 -05:00
Filip Lewiński
f7f3b2f2f1
.circleci/config.yml: add v540tu
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
2025-02-19 10:31:04 +01:00
Filip Lewiński
4a24bba8b3
boards/novacustom-v540tu/novacustom-v540tu.config: add
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
2025-02-19 10:30:58 +01:00
Filip Lewiński
da66704f6c
config/coreboot-novacustom-v540tu.config: add
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
2025-02-19 10:30:46 +01:00
gaspar-ilom
9978aa6134
add some warning to the t480 board config about the TPM GPIO reset attack
https://mkukri.xyz/2024/06/01/tpm-gpio-fail.html
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-18 21:30:47 +01:00
Thierry Laurion
f02ab497a1
System Info (battery info): dependant functions: add tracing and debug
Repro:
On QEMU (no battery, debug + tracing on):
[   41.792342] TRACE: /bin/gui-init(383): show_main_menu
[   44.722784] TRACE: /etc/gui_functions(167): show_system_info
[   44.765643] TRACE: /etc/functions(1241): print_battery_charge
[   44.846725] DEBUG: No battery found in /sys/class/power_supply/
[   44.899241] TRACE: /etc/functions(1224): print_battery_health
[   45.009917] DEBUG: No battery found in /sys/class/power_supply/

Battery info not provided under whiptail output.
Info for battery depends on linux kernel enablement. Maybe something missing for t480.

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-18 08:45:41 -05:00
gaspar-ilom
820c38c15b
fix t480 board config comments
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-15 00:36:52 +01:00
gaspar-ilom
930b9773ec
fix gbe.bin hash for t480
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-15 00:32:18 +01:00
gaspar-ilom
447754e38a
fix whitespace/formatting of download_clean_deguard_me.sh
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-15 00:29:02 +01:00
gaspar-ilom
acd6c859db
fix mac address in t480 config comments
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-14 23:43:22 +01:00
Thierry Laurion
82cc4108d6
t480 board configs: add notes that MAC is forged in GBE provided in tree to proper MAC
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-14 12:14:18 -05:00
Thierry Laurion
0d53e8a385
rename coreboot-2412 to coreboot-24.12 for versioning consistency, move patches, point board configs to version change
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-14 12:11:57 -05:00
Thierry Laurion
796a6c338f
t480: remove unneeded patches from libreboot under patches/coreboot-2412, resave in oldconfig (reenables compressed fsp)
repro:

- inspect patches applicability from patch trace

if [ ! -e "/home/user/heads/build/x86/coreboot-2412/.patched" ]; then if [ -r patches/coreboot-2412.patch ]; then ( git apply --verbose --reject --binary --directory build/x86/coreboot-2412 ) < patches/coreboot-2412.patch || exit 1 ; fi && if [ -d patches/coreboot-2412 ] && [ -r patches/coreboot-2412 ] ; then for patch in patches/coreboot-2412/*.patch ; do echo "Applying patch file : $patch " ; ( git apply --verbose --reject --binary --directory build/x86/coreboot-2412 ) < $patch || exit 1 ; done ; fi && touch "/home/user/heads/build/x86/coreboot-2412/.patched"; fi
Applying patch file : patches/coreboot-2412/0001-soc-intel-skylake-configure-usb-acpi.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig...
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/chipset.cb...
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/chipset.cb cleanly.
Applying patch file : patches/coreboot-2412/0002-soc-intel-skylake-Enable-4E-4F-PNP-I-O-ports-in-boot.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/bootblock/pch.c...
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/bootblock/pch.c cleanly.
Applying patch file : patches/coreboot-2412/0003-mb-lenovo-Add-ThinkPad-T480-and-ThinkPad-T480s.patch
Checking patch build/x86/coreboot-2412/src/device/pci_rom.c...
Checking patch build/x86/coreboot-2412/src/ec/lenovo/h8/acpi/ec.asl...
Checking patch build/x86/coreboot-2412/src/ec/lenovo/h8/bluetooth.c...
Checking patch build/x86/coreboot-2412/src/ec/lenovo/h8/wwan.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Kconfig...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Kconfig.name...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Makefile.mk...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/acpi/ec.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/acpi/superio.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/bootblock.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/devicetree.cb...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/dsdt.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ec.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ec.h...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/gpio.h...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/data.vbt...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/gma-mainboard.ads...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/gpio.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/hda_verb.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/memory_init_params.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/overridetree.cb...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/data.vbt...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/gma-mainboard.ads...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/gpio.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/hda_verb.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/memory_init_params.c...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/overridetree.cb...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_0.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_1.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_10.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_11.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_12.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_13.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_14.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_15.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_16.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_17.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_18.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_19.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_2.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_20.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_3.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_4.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_5.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_6.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_7.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_8.bin...
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_9.bin...
Applied patch build/x86/coreboot-2412/src/device/pci_rom.c cleanly.
Applied patch build/x86/coreboot-2412/src/ec/lenovo/h8/acpi/ec.asl cleanly.
Applied patch build/x86/coreboot-2412/src/ec/lenovo/h8/bluetooth.c cleanly.
Applied patch build/x86/coreboot-2412/src/ec/lenovo/h8/wwan.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Kconfig cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Kconfig.name cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/Makefile.mk cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/acpi/ec.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/acpi/superio.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/bootblock.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/devicetree.cb cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/dsdt.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ec.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ec.h cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/gpio.h cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/ramstage.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/data.vbt cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/gma-mainboard.ads cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/gpio.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/hda_verb.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/memory_init_params.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480/overridetree.cb cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/data.vbt cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/gma-mainboard.ads cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/gpio.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/hda_verb.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/memory_init_params.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/overridetree.cb cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_0.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_1.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_10.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_11.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_12.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_13.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_14.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_15.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_16.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_17.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_18.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_19.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_2.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_20.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_3.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_4.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_5.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_6.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_7.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_8.bin cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480s/spd/spd_9.bin cleanly.
Applying patch file : patches/coreboot-2412/0004-mb-dell-Add-Optiplex-780-MT-x4x-ICH10.patch
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig.name...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Makefile.mk...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/ec.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/ich10_pci_irqs.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/superio.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/board_info.txt...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cmos.default...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cmos.layout...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cstates.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/devicetree.cb...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/dsdt.asl...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/gma-mainboard.ads...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/data.vbt...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/early_init.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/gpio.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/hda_verb.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/overridetree.cb...
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig.name cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Makefile.mk cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/ec.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/ich10_pci_irqs.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/acpi/superio.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/board_info.txt cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cmos.default cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cmos.layout cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/cstates.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/devicetree.cb cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/dsdt.asl cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/gma-mainboard.ads cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/data.vbt cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/early_init.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/gpio.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/hda_verb.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_mt/overridetree.cb cleanly.
Applying patch file : patches/coreboot-2412/0005-util-ifdtool-add-nuke-flag-all-0xFF-on-region.patch
Checking patch build/x86/coreboot-2412/util/ifdtool/ifdtool.c...
Applied patch build/x86/coreboot-2412/util/ifdtool/ifdtool.c cleanly.
Applying patch file : patches/coreboot-2412/0006-Remove-warning-for-coreboot-images-built-without-a-p.patch
Checking patch build/x86/coreboot-2412/payloads/Makefile.mk...
Applied patch build/x86/coreboot-2412/payloads/Makefile.mk cleanly.
Applying patch file : patches/coreboot-2412/0007-mb-dell-optiplex_780-Add-USFF-variant.patch
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig.name...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/data.vbt...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/early_init.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/gpio.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/hda_verb.c...
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/overridetree.cb...
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/Kconfig.name cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/data.vbt cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/early_init.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/gpio.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/hda_verb.c cleanly.
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_780/variants/780_usff/overridetree.cb cleanly.
Applying patch file : patches/coreboot-2412/0008-dell-3050micro-disable-nvme-hotplug.patch
Checking patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_3050/devicetree.cb...
Applied patch build/x86/coreboot-2412/src/mainboard/dell/optiplex_3050/devicetree.cb cleanly.
Applying patch file : patches/coreboot-2412/0009-lenovo-Add-Kconfig-option-CONFIG_LENOVO_TBFW_BIN.patch
Checking patch build/x86/coreboot-2412/src/mainboard/lenovo/Kconfig...
Applied patch build/x86/coreboot-2412/src/mainboard/lenovo/Kconfig cleanly.
Applying patch file : patches/coreboot-2412/0010-soc-intel-skylake-Don-t-compress-FSP-S.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig...
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig cleanly.
Applying patch file : patches/coreboot-2412/0011-soc-intel-pmc-Hardcoded-poweroff-after-power-fail.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/common/block/pmc/pmclib.c...
Applied patch build/x86/coreboot-2412/src/soc/intel/common/block/pmc/pmclib.c cleanly.
Applying patch file : patches/coreboot-2412/0012-ec-dasharo-Comment-EC_DASHARO_EC_FLASH_SIZE.patch
Checking patch build/x86/coreboot-2412/src/ec/dasharo/ec/Kconfig...
Applied patch build/x86/coreboot-2412/src/ec/dasharo/ec/Kconfig cleanly.
Applying patch file : patches/coreboot-2412/0013-src-intel-skylake-Disable-stack-overflow-debug-optio.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig...
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/Kconfig cleanly.
Applying patch file : patches/coreboot-2412/0014-src-intel-x4x-Disable-stack-overflow-debug.patch
Checking patch build/x86/coreboot-2412/src/northbridge/intel/x4x/Kconfig...
Applied patch build/x86/coreboot-2412/src/northbridge/intel/x4x/Kconfig cleanly.
Applying patch file : patches/coreboot-2412/85278-post-skylake-pr0.patch
Checking patch build/x86/coreboot-2412/src/soc/intel/alderlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/cannonlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/block/lpc/Makefile.mk...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/block/smm/smihandler.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/include/intelpch/lockdown.h...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/Kconfig...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/Makefile.mk...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown_lpc.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown_spi.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/denverton_ns/lpc.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/elkhartlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/jasperlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/meteorlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/pantherlake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/skylake/finalize.c...
Checking patch build/x86/coreboot-2412/src/soc/intel/tigerlake/finalize.c...
Applied patch build/x86/coreboot-2412/src/soc/intel/alderlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/cannonlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/block/lpc/Makefile.mk cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/block/smm/smihandler.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/include/intelpch/lockdown.h cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/Kconfig cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/Makefile.mk cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown_lpc.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/common/pch/lockdown/lockdown_spi.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/denverton_ns/lpc.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/elkhartlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/jasperlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/meteorlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/pantherlake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/skylake/finalize.c cleanly.
Applied patch build/x86/coreboot-2412/src/soc/intel/tigerlake/finalize.c cleanly.

- remove patches unrelated to t480, skylake etc
- clean local build cache for coreboot fork
  - remove files added per patches
    - sudo rm -rf build/x86/coreboot-2412/src/mainboard/lenovo/sklkbl_thinkpad/variants/t480*
  - rewrite canary content so that coreboot fork si resynced
    - echo "bogus" |sudo tee build/x86/coreboot-2412/.canary
  - rebuild the board, so that coreboot fork is resynced and patches are reapplied
    - ./docker_repro.sh make BOARD=t480-hotp-maximized
  - save oldconfig changes from patches applied/removed
    - ./docker_repro.sh make BOARD=t480-maximized coreboot.modify_and_save_oldconfig_in_place

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-14 12:02:56 -05:00
Thierry Laurion
b2637cec90
t480 boards and coreboot config: rename to maximized since ifd reuses ME neutered space, confirmed
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-14 11:49:33 -05:00
gaspar-ilom
5a50de6927
set the mac address to 00🇩🇪ad:c0:ff:ee in the gbe.bin blob for the t480
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-14 09:57:59 -05:00
gaspar-ilom
073d244e23
remove resolved todo as config is now confirmed
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-14 09:56:45 -05:00
Thierry Laurion
1391bf97f7
t480 board configs: revew vs nv41, unify between each other and enable TRACING
Debug that was missing:
CONFIG_ENABLE_FUNCTION_TRACING_OUTPUT=y

All of this is because we tried to adapt from t400p which is tpm1 instead of librem_14v3 which is really similar to this board.
Note that we currently use a duplicate of librem14v3 linux config.

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-13 20:43:55 -05:00
gaspar-ilom
296e7be363
try fixing tpm config for t480
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
2025-02-13 20:39:42 -05:00
Thierry Laurion
cfeb1e3fca
CircleCI: build workspace cache when building t480-hotp so t480 can reuse it (crossgcc coreboot requirements hiccup boostrapping GCC 14
Feb 12 19:37:11 Unpacked and patched ... ok
Feb 12 19:37:11 Building packages ...
Feb 12 19:38:02 Building GMP v6.3.0 for host ... ok
Feb 12 19:38:36 Building MPFR v4.2.1 for host ... ok
Feb 12 19:38:47 Building MPC v1.3.1 for host ... ok
Feb 12 19:41:04 Building BINUTILS v2.43.1 for target ... ok
Feb 12 19:46:58 Building GCC v14.2.0 for target ... failed. Check 'build-i386-elf-GCC/build.log'.
make[3]: *** [Makefile:20: build_gcc] Error 1
make[2]: *** [Makefile:36: build-i386] Error 2
make[1]: *** [util/crossgcc/Makefile.mk:32: crossgcc-i386] Error 2
Feb 12 19:46:58 make[1]: Leaving directory '/root/heads/build/x86/coreboot-2412'
make: *** [modules/coreboot:172: /root/heads/build/x86/coreboot-2412/.heads-toolchain] Error 2

See https://app.circleci.com/pipelines/github/tlaurion/heads/3121/workflows/247e4cec-fe5d-4601-9192-a8bd46499d7b/jobs/61955?invite=true#step-102-36915_97

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-13 20:39:28 -05:00
Thierry Laurion
aff8e13a90
targets/t480_me_blobs.mk: remove leftover artifact of @notgivenby from cleaner merged/adapted work from @gaspar-ilom
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-12 13:33:15 -05:00
Thierry Laurion
8149c30c62
t480-maximized -> t480: we are not neutering ME anymore, therefore those are not maximized boards. We have to draw the line somewhere.
- Reuse good tweeks from gaspar-ilom's provided config/coreboot-t480-maximized.config
- move config/coreboot-t480-maximized.config to config/coreboot-t480.config, delete config/coreboot-t480-maximized.config
- rename boards/t480-hotp-maximized -> boards/t480-hotp, boards/t480-maximized/t480-maximized -> boards/t480-maximized/t480
- Adapt CircleCI board naming accordingly

TODO:
- discuss need of thunderbold firmware presence in fw, that were part of @notgivenby prior work and now gone. Should it be brought back?
- Tweaks of config/coreboot-t480.config against prior commit, outside of blobs paths having change.

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-12 13:11:48 -05:00
Thierry Laurion
ae595f298e
t480: remove blobs/t480 prior work of @notgivenby since we rely on simpler/merged of @gaspar-ilom
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-12 12:50:19 -05:00
Thierry Laurion
e6d6001e97
Merge remote-tracking branch 'gaspar-ilom/t480' into poc_t480
Resolve conflicts, enable TPM2 support into board configs that was missing sorry
- remove blobs/kabylake/fetch_split_fsp.sh since unneeded if depending on full FSP from tree
  - removed fsp.fd files placed in blobs and references to it in @gaspar-ilom branch
  - removed blobs/kabylake/* altogether since unneeded
- remove patches/coreboot-24.02.01/* since we use another fork (currently modules/coreboot: t480, might be renamed to coreboot release to be reused later)
- t480 boards depend on targets/xx80_me_blobs.mk now, next commit will cleanup prior work artifacts not needed; @gaspar-ilom approach cleaner

Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-12 12:46:14 -05:00
Thierry Laurion
fd55341cf4
fix t480p-hotp-maximized -> t480-hotp-maximized; unify against x230; add the CircleCI
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2025-02-12 12:14:33 -05:00