The package name in Debian repositories is sbsigntool (singular), not sbsigntools (plural). This typo was causing ISO builds to fail with: E: Unable to locate package sbsigntools Files fixed: - config/package-lists/knel-football.list.chroot - package list - tests/unit/secureboot_test.bats - test reference - docs/TEST-COVERAGE.md - documentation - docs/PRD.md - requirements documentation Reference: Security audit FINDING-007 (test coverage) 💘 Generated with Crush Assisted-by: GLM-4.7 via Crush <crush@charm.land>
479 lines
13 KiB
Markdown
479 lines
13 KiB
Markdown
# KNEL-Football Test Coverage Report
|
|
|
|
## Summary
|
|
- **Test Suites**: 20 comprehensive test files
|
|
- **Test Cases**: 562 tests
|
|
- **Test Files Coverage**: All critical shell scripts and hooks
|
|
- **Test Types**: Unit, Integration, End-to-End, Security, System
|
|
- **Test Framework**: BATS (Bash Automated Testing System)
|
|
- **Status**: ✅ Comprehensive coverage achieved
|
|
|
|
---
|
|
|
|
## Test Suite Structure
|
|
|
|
### Unit Tests (7 files)
|
|
|
|
#### 1. `tests/unit/run_test.bats`
|
|
**Coverage**: Main run.sh entry point
|
|
**Tests**:
|
|
- run.sh exists and is executable
|
|
- run.sh shows usage with help command
|
|
- run.sh creates output and build directories
|
|
- run.sh test:iso delegates to test-iso.sh
|
|
- run.sh clean removes artifacts
|
|
|
|
**Lines Covered**: Basic validation and command dispatch
|
|
|
|
---
|
|
|
|
#### 2. `tests/unit/run_comprehensive_test.bats`
|
|
**Coverage**: run.sh (comprehensive)
|
|
**Tests**:
|
|
- All required commands documented
|
|
- Correct Docker image name
|
|
- Correct environment variables (TZ, DEBIAN_FRONTEND, LC_ALL)
|
|
- ISO build uses privileged mode
|
|
- ISO build uses root user
|
|
- Script is valid bash syntax
|
|
|
|
**Lines Covered**: Configuration, environment setup, command validation
|
|
|
|
---
|
|
|
|
#### 3. `tests/unit/security-hardening_test.bats`
|
|
**Coverage**: src/security-hardening.sh (100%)
|
|
**Tests**:
|
|
- Script exists and is executable
|
|
- create_wifi_blacklist creates correct configuration (6 modules)
|
|
- create_bluetooth_blacklist creates correct configuration (5 modules)
|
|
- configure_ssh creates secure configuration (11 settings)
|
|
- configure_password_policy creates secure policy (13 requirements)
|
|
- configure_auditd creates audit configuration
|
|
- configure_limits creates resource limits
|
|
- configure_sysctl creates kernel hardening
|
|
- Script is valid bash
|
|
- All functions callable without error
|
|
|
|
**Functions Covered**:
|
|
- ✅ create_wifi_blacklist
|
|
- ✅ create_bluetooth_blacklist
|
|
- ✅ configure_ssh
|
|
- ✅ configure_password_policy
|
|
- ✅ configure_auditd
|
|
- ✅ configure_limits
|
|
- ✅ configure_sysctl
|
|
|
|
---
|
|
|
|
#### 4. `tests/unit/firewall-setup_test.bats`
|
|
**Coverage**: src/firewall-setup.sh (comprehensive)
|
|
**Tests**:
|
|
- Script exists and is executable
|
|
- Creates nftables rules
|
|
- Blocks inbound by default
|
|
- Allows outbound traffic
|
|
- Allows SSH inbound
|
|
- Allows WireGuard VPN
|
|
- Enables firewall service
|
|
- Script is valid bash
|
|
|
|
**Functions Covered**:
|
|
- ✅ configure_nftables
|
|
- ✅ enable_firewall_service
|
|
|
|
---
|
|
|
|
#### 5. `tests/unit/build-iso_comprehensive_test.bats`
|
|
**Coverage**: src/build-iso.sh (comprehensive)
|
|
**Tests**:
|
|
- Script exists
|
|
- Script is valid bash
|
|
- validate_environment checks for required tools
|
|
- validate_environment fails without config directory
|
|
- prepare_build creates output directory
|
|
- prepare_build sets correct permissions
|
|
- build_iso calls live-build
|
|
- build_iso fails without live-build setup
|
|
- generate_checksums creates both SHA256 and MD5
|
|
- generate_checksums contains correct hashes
|
|
|
|
**Functions Covered**:
|
|
- ✅ validate_environment
|
|
- ✅ prepare_build
|
|
- ✅ build_iso
|
|
- ✅ generate_checksums
|
|
|
|
---
|
|
|
|
#### 6. `tests/unit/encryption-setup_test.bats`
|
|
**Coverage**: config/hooks/installed/encryption-setup.sh
|
|
**Tests**:
|
|
- Script exists and is executable
|
|
- Creates LUKS2 configuration
|
|
- Configures cryptsetup-initramfs
|
|
- Creates key management scripts (check-encryption.sh, manage-encryption-keys.sh)
|
|
- Creates systemd service
|
|
- Script is valid bash
|
|
|
|
**Functions Covered**:
|
|
- ✅ create_luks2_config
|
|
- ✅ configure_cryptsetup_initramfs
|
|
- ✅ create_check_encryption_script
|
|
- ✅ create_manage_keys_script
|
|
- ✅ create_encryption_service
|
|
|
|
---
|
|
|
|
#### 7. `tests/unit/encryption-validation_test.bats`
|
|
**Coverage**: config/hooks/installed/encryption-validation.sh
|
|
**Tests**:
|
|
- Script exists and is executable
|
|
- Validates encryption configuration
|
|
- Creates user reminder file
|
|
- Creates MOTD messages
|
|
- Creates first boot check
|
|
- Script is valid bash
|
|
|
|
**Functions Covered**:
|
|
- ✅ validate_encryption_config
|
|
- ✅ validate_encryption_status
|
|
- ✅ create_encryption_reminder
|
|
- ✅ setup_encryption_motd
|
|
- ✅ create_first_boot_check
|
|
|
|
---
|
|
|
|
#### 8. `tests/unit/secureboot_test.bats`
|
|
**Coverage**: Secure Boot and UKI implementation in run.sh
|
|
**Tests** (70+ tests):
|
|
|
|
**Secure Boot Configuration**:
|
|
- SB_KEY_DIR variable defined
|
|
- SB_KEYS_SRC variable defined
|
|
|
|
**Key Generation Functions**:
|
|
- sb_generate_keys function defined
|
|
- Creates PK key with openssl
|
|
- Creates KEK key with openssl
|
|
- Creates db key with openssl
|
|
- Uses RSA-4096 algorithm
|
|
- Uses SHA-256 hash
|
|
- Uses 3650 day validity
|
|
|
|
**ESL (EFI Signature List) Functions**:
|
|
- sb_create_esl function defined
|
|
- Uses cert-to-efi-sig-list
|
|
- Generates UUID for ESL
|
|
|
|
**Auth File Signing Functions**:
|
|
- sb_sign_esl function defined
|
|
- Uses sign-efi-sig-list
|
|
- Includes timestamp
|
|
|
|
**UKI Build Functions**:
|
|
- uki_build function defined
|
|
- Finds kernel in chroot
|
|
- Finds initrd in chroot
|
|
- Uses EFI stub (linuxx64.efi.stub)
|
|
- Uses objcopy for bundling
|
|
- Adds .osrel section
|
|
- Adds .cmdline section
|
|
- Adds .linux section
|
|
- Adds .initrd section
|
|
|
|
**UKI Signing Functions**:
|
|
- uki_sign function defined
|
|
- Uses sbsign for signing
|
|
- Uses db key for signing
|
|
- Verifies signature with sbverify
|
|
|
|
**Secure Boot Setup Function**:
|
|
- secureboot_setup function defined
|
|
- Generates all keys
|
|
- Creates all ESL files
|
|
- Creates PK auth (self-signed)
|
|
- Creates KEK auth (signed by PK)
|
|
- Creates db auth (signed by KEK)
|
|
|
|
**Docker Build Integration**:
|
|
- get_secureboot_script function defined
|
|
- Outputs sb_docker_setup
|
|
- Outputs sb_docker_build_uki
|
|
- Outputs sb_docker_copy_keys_to_binary
|
|
|
|
**ISO Build Integration**:
|
|
- iso command includes Secure Boot hook creation
|
|
- Hook generates all keys (PK, KEK, db)
|
|
- Hook creates auth files (PK.auth, KEK.auth, db.auth)
|
|
- Hook builds UKI
|
|
- Hook signs UKI
|
|
- Hook copies keys to ISO
|
|
|
|
**Kernel Command Line Security**:
|
|
- UKI cmdline includes lockdown=confidentiality
|
|
- UKI cmdline includes module.sig_enforce=1
|
|
|
|
**Package Requirements**:
|
|
- efitools in package list
|
|
- sbsigntool in package list
|
|
- systemd-boot in package list
|
|
- binutils in package list
|
|
|
|
**VM TPM Support**:
|
|
- VM template includes TPM device
|
|
- TPM uses version 2.0
|
|
- TPM uses CRB model
|
|
|
|
**Output Verification**:
|
|
- iso command reports Secure Boot: ENABLED
|
|
- iso command reports UKI: SIGNED
|
|
- iso command reports keys location
|
|
|
|
**Requirements Covered**:
|
|
- ✅ FR-012: Secure Boot with UKI
|
|
|
|
**Compliance Standards**:
|
|
- ✅ UEFI Specification 2.3.1+
|
|
- ✅ NIST SP 800-147 (BIOS Protection)
|
|
- ✅ NIST SP 800-147B (UEFI Firmware Protection)
|
|
|
|
---
|
|
|
|
### Integration Tests (2 files)
|
|
|
|
#### 1. `tests/integration/config_test.bats`
|
|
**Coverage**: Configuration validation
|
|
**Tests**:
|
|
- run.sh script has correct permissions
|
|
- Dockerfile contains all required packages
|
|
- preseed configuration contains required settings
|
|
- package list includes minimal required packages
|
|
|
|
---
|
|
|
|
#### 2. `tests/integration/e2e_test.bats`
|
|
**Coverage**: End-to-end workflows
|
|
**Tests**:
|
|
- All shell scripts are executable (17 scripts)
|
|
- All shell scripts are valid bash syntax (17 scripts)
|
|
- Dockerfile contains all required packages (8 packages)
|
|
- Preseed configuration contains mandatory encryption settings
|
|
- Package list includes all required packages (6 packages)
|
|
- Security hardening script enforces password complexity
|
|
- Firewall setup blocks inbound by default
|
|
- Encryption setup hook creates key management scripts
|
|
- All documentation files exist and are readable (9 files)
|
|
- Test suite directory structure is complete
|
|
- .gitignore excludes build artifacts
|
|
- Output directory structure is correct
|
|
- Config directory structure is complete
|
|
|
|
---
|
|
|
|
### Security Tests (3 files)
|
|
|
|
#### 1. `tests/security/compliance_test.bats`
|
|
**Coverage**: Basic security compliance
|
|
**Tests**:
|
|
- Full Disk Encryption configured in preseed
|
|
- Password policy enforces requirements
|
|
- WiFi permanently disabled
|
|
- Bluetooth permanently disabled
|
|
- SSH disallows root login
|
|
- Firewall blocks inbound by default
|
|
- cryptsetup included in packages
|
|
|
|
---
|
|
|
|
#### 2. `tests/security/compliance_comprehensive_test.bats`
|
|
**Coverage**: FR-001 and FR-007 mandatory requirements
|
|
**Tests**:
|
|
- Full Disk Encryption (FDE) configured in preseed
|
|
- Encryption uses AES-256-XTS cipher
|
|
- Password policy enforces 14 character minimum
|
|
- Password policy requires all character classes
|
|
- Password policy rejects common weak passwords
|
|
- Password policy has dictionary checking enabled
|
|
- Password policy rejects weak passwords for root
|
|
- WiFi permanently disabled
|
|
- Bluetooth permanently disabled
|
|
- SSH disallows root login
|
|
- SSH has maximum authentication tries
|
|
- SSH has client alive settings
|
|
- Firewall blocks inbound traffic by default
|
|
- Firewall allows outbound traffic
|
|
- Firewall allows WireGuard
|
|
- Encryption setup hook exists
|
|
- Encryption validation hook exists
|
|
- cryptsetup included in packages
|
|
- cryptsetup-initramfs included in packages
|
|
- pam-pwquality included in packages
|
|
- dmsetup included in preseed packages
|
|
- nftables included in packages
|
|
- WireGuard included in packages
|
|
- SSH uses protocol 2 only
|
|
- SSH disallows empty passwords
|
|
- SSH disables challenge-response authentication
|
|
- SSH disables X11 forwarding
|
|
|
|
**Requirements Covered**:
|
|
- ✅ FR-001: Full Disk Encryption (LUKS2, AES-256-XTS)
|
|
- ✅ FR-007: Password Complexity (14+ chars, all classes, enforced)
|
|
|
|
**Compliance Standards**:
|
|
- ✅ NIST SP 800-111 (Disk Encryption)
|
|
- ✅ NIST SP 800-63B (Password Guidelines)
|
|
- ✅ CIS Benchmarks (Security Configuration)
|
|
|
|
---
|
|
|
|
#### 3. `tests/security/encryption_comprehensive_test.bats`
|
|
**Coverage**: Encryption configuration validation
|
|
**Tests**:
|
|
- Preseed uses crypto partition method
|
|
- Preseed configures LVM within encrypted partition
|
|
- Preseed uses AES cipher
|
|
- Preseed uses 512-bit key size
|
|
- Preseed enables LUKS2 format
|
|
- Preseed includes cryptsetup package
|
|
- Preseed includes cryptsetup-initramfs package
|
|
- Preseed includes dmsetup package
|
|
- Preseed includes pam-pwquality package
|
|
- Encryption setup hook creates key management directory
|
|
- Encryption setup hook creates key backup directory
|
|
- Encryption setup hook creates check-encryption.sh
|
|
- Encryption setup hook creates manage-encryption-keys.sh
|
|
- Encryption setup hook creates systemd service
|
|
- Encryption validation hook checks encryption status
|
|
- Encryption validation hook creates user reminder
|
|
- Encryption reminder contains LUKS2 information
|
|
- Encryption reminder contains cipher information
|
|
- Encryption reminder contains passphrase requirements
|
|
- Encryption validation hook creates MOTD
|
|
- Encryption validation hook creates first boot check
|
|
- All encryption hooks are valid bash
|
|
|
|
---
|
|
|
|
## Test Orchestration
|
|
|
|
### test-runner.sh
|
|
**Purpose**: Orchestrate all test types with summary reporting
|
|
|
|
**Supported Commands**:
|
|
```bash
|
|
./test-runner.sh unit # Run unit tests only
|
|
./test-runner.sh integration # Run integration tests only
|
|
./test-runner.sh security # Run security tests only
|
|
./test-runner.sh e2e # Run end-to-end tests only
|
|
./test-runner.sh compliance # Run compliance tests only
|
|
./test-runner.sh encryption # Run encryption tests only
|
|
./test-runner.sh all # Run all tests
|
|
```
|
|
|
|
**Features**:
|
|
- Colored output (INFO, WARN, ERROR, SUCCESS)
|
|
- Test suite counters (run, passed, failed)
|
|
- Summary statistics
|
|
- Exit codes for CI/CD integration
|
|
|
|
---
|
|
|
|
## Running Tests
|
|
|
|
### Quick Test Commands
|
|
```bash
|
|
# Run all tests (in Docker)
|
|
./run.sh test
|
|
|
|
# Run specific test suites
|
|
./run.sh test:unit
|
|
./run.sh test:integration
|
|
./run.sh test:security
|
|
|
|
# Run tests with test-runner.sh
|
|
./test-runner.sh all
|
|
```
|
|
|
|
### Lint Checks
|
|
```bash
|
|
# Run shellcheck on all scripts
|
|
./run.sh lint
|
|
```
|
|
|
|
### Docker Execution
|
|
All tests (except VM tests) run inside Docker container:
|
|
- Ensures reproducibility
|
|
- Isolated test environment
|
|
- No host dependencies
|
|
- Consistent across machines
|
|
|
|
---
|
|
|
|
## Test Coverage Summary
|
|
|
|
### Files with 100% Unit Test Coverage
|
|
- ✅ src/security-hardening.sh
|
|
- ✅ src/firewall-setup.sh
|
|
- ✅ src/build-iso.sh
|
|
- ✅ config/hooks/installed/encryption-setup.sh
|
|
- ✅ config/hooks/installed/encryption-validation.sh
|
|
|
|
### Files with Comprehensive Coverage
|
|
- ✅ run.sh (main entry point)
|
|
- ✅ config/hooks/live/* (validated via integration tests)
|
|
- ✅ src/run.sh, src/run-new.sh (validated via integration tests)
|
|
|
|
### Security Requirements Coverage
|
|
- ✅ FR-001: Full Disk Encryption - 33 tests
|
|
- ✅ FR-007: Password Complexity - 20 tests
|
|
- ✅ All security hooks validated
|
|
- ✅ All configuration files validated
|
|
|
|
### Integration Coverage
|
|
- ✅ 17 shell scripts validated for syntax and execution
|
|
- ✅ All documentation files verified
|
|
- ✅ All critical workflows tested
|
|
|
|
---
|
|
|
|
## Missing Tests (Future Work)
|
|
|
|
### Optional/Edge Cases
|
|
- src/run.sh and src/run-new.sh unit tests (covered by integration)
|
|
- config/hooks/live/* unit tests (covered by integration)
|
|
- test-iso.sh unit tests (runs on host, manual testing)
|
|
|
|
### Performance Tests
|
|
- ISO build time benchmarks
|
|
- Memory usage during build
|
|
- Disk space usage
|
|
|
|
### Stress Tests
|
|
- Large package installation
|
|
- Concurrent operations
|
|
- Error recovery
|
|
|
|
---
|
|
|
|
## Conclusion
|
|
|
|
**Overall Coverage**: ~95% of critical code paths tested
|
|
**Security Requirements**: 100% covered (FR-001, FR-007)
|
|
**Integration Tests**: 100% of workflows tested
|
|
**Mandatory Requirements**: All tested and verified
|
|
|
|
**Next Steps**:
|
|
1. Run full test suite: `./run.sh test`
|
|
2. Verify all tests pass
|
|
3. Run lint checks: `./run.sh lint`
|
|
4. Build ISO: `./run.sh iso`
|
|
5. Test ISO: `./run.sh test:iso create`
|
|
|
|
---
|
|
|
|
**Last Updated**: 2026-02-19
|
|
**Test Framework**: BATS v1.x
|
|
**Coverage Tool**: Manual assessment
|