Commit Graph

630 Commits

Author SHA1 Message Date
Scott Fennell
47c26d971b remove dangling ptr 2018-11-06 12:03:07 -06:00
Scott Fennell
2607439227 change nullptr to NULL 2018-11-06 11:36:34 -06:00
Scott Fennell
66b3d984ff Merge branch 'master' into scan-build 2018-11-06 11:24:09 -06:00
Scott Fennell
21c01a5454 scan-build changes
This reverts commit e86027f825.
2018-11-06 11:23:12 -06:00
Scott Fennell
c34d2c6947 move dependance on java.se.ee to third party jars to support java 11 2018-11-05 14:01:52 -06:00
dbankieris
348bbb3798
Add ExecutiveException.hh to sim_services.i (#691)
* Add ExecutiveException.hh to sim_services.i and files_to_ICG.hh
* Update version number

Fixes #690
2018-10-30 13:49:55 -05:00
Scott Fennell
d2e81257c2 #687 do not warn or convert unit -- 2018-10-30 10:40:46 -05:00
John M. Penn
a29045005c Create a suite of unicode utilities. 2018-10-25 15:14:52 -05:00
Scott Fennell
e86027f825 revert scan-build changes, need further testing before merge 2018-10-22 15:11:29 -05:00
Scott Fennell
86ef489617 -std=c++11 to data_products 2018-10-22 13:58:08 -05:00
Scott Fennell
389e2837fc add -std=c++11 to MonteCarlo 2018-10-22 11:40:55 -05:00
Scott Fennell
587ce0aab5 #673 add break and remove trailing whitespace from @pappyvw review 2018-10-20 14:33:14 -05:00
Scott Fennell
bc35e64406
Merge pull request #673 from nasa/#scan-build
#671 fix all non memory manager scan-build bugs.
2018-10-20 13:16:35 -05:00
Pappy Van Winkle
121fa84081 Use correct format specifiers.
Used http://www.cplusplus.com/reference/cstdio/printf/ as a reference.
2018-10-11 22:52:04 -05:00
Pappy Van Winkle
af2575da5b Remove all unused variables (style warning). 2018-10-11 22:05:50 -05:00
Scott Fennell
5b63559312 fix error message syntax errors 2018-10-03 15:31:22 -05:00
Scott Fennell
53886fb54d add else block for code clarity and to aid static analysis JITInputFile.cpp 2018-10-03 10:49:11 -05:00
Scott Fennell
8f20710761 replace garbage value on enum error PythonPrint.cpp 2018-10-03 10:45:15 -05:00
Scott Fennell
b65b092e3b handle garbage values/invalid input MatLab4.cpp 2018-10-03 10:35:10 -05:00
Scott Fennell
072e1855dd handle memory leak on early exit parseLogHeader.cpp 2018-10-03 10:34:45 -05:00
Scott Fennell
d1957c650b handle garbage values/invalid input ClassicCheckPointAgent 2018-10-03 10:34:11 -05:00
Scott Fennell
ba0c310e64 remove potential memory leak 2018-10-02 10:58:53 -05:00
Scott Fennell
1c387551f6 replace delete with delete[] MatLab4.cpp 2018-10-02 10:51:44 -05:00
Scott Fennell
b10b56e671 initialize variable removing condition on garbage variable MatLab.cpp 2018-10-02 10:40:14 -05:00
Scott Fennell
d16064aaf0 move strlen statement 2018-10-02 10:38:59 -05:00
Scott Fennell
3c7a93c3ca remove memory leaks parseLogHeader.cpp 2018-10-02 10:38:09 -05:00
Scott Fennell
33b74c07c9 remove memory leaks var.cpp 2018-10-01 16:49:55 -05:00
Scott Fennell
e4dcd42b2b fix unreachable code MonteVarFile.cpp 2018-10-01 16:22:27 -05:00
Scott Fennell
28863c58a6 remove memory leaks and garbage return values TrickBinary.cpp 2018-10-01 15:55:04 -05:00
Scott Fennell
a60cc3f2ae remove dead assignment and memory leaks var.cpp 2018-10-01 14:28:26 -05:00
Scott Fennell
605f5d0f6d remove dead assignment DataRecordGroup.cpp 2018-10-01 14:16:19 -05:00
Scott Fennell
0b2218e449 remove dead assignment IPPython.cpp 2018-10-01 13:55:02 -05:00
Scott Fennell
424043b146 remove 'delete this' double delete in JSONVariableServerThread destructor 2018-10-01 13:33:51 -05:00
Scott Fennell
2cdd4bf380 free memory leaks MonteVarFile.cpp 2018-10-01 13:24:37 -05:00
Scott Fennell
7b3b47aa39 init value and style change VariableServerListenThread.cpp 2018-10-01 10:26:17 -05:00
Scott Fennell
2c43321076 remove dead assignments VariableServerThread_loop 2018-10-01 10:13:39 -05:00
Scott Fennell
d701040d22 handle invalid swap magic and delete dangling pointers MatLab.cpp 2018-09-28 11:17:42 -05:00
Scott Fennell
ac6fd26a6d initialize size for Matlab::Matlab to remove garbage value edge case 2018-09-28 10:53:17 -05:00
Scott Fennell
221ced44a0 remove dead assignment, divide by zero, memory leak in log.cpp 2018-09-28 10:38:40 -05:00
Scott Fennell
60e39e2838 remove another dead assignment Delta.cpp 2018-09-28 10:13:22 -05:00
Scott Fennell
7dfcf15a43 remove dead assignment Delta.cpp 2018-09-28 10:12:42 -05:00
Scott Fennell
406f3bb207 remove unnecessary strdup causing memory leak 2018-09-28 10:07:20 -05:00
Scott Fennell
b7d24b60d6 eqparse_funcsub.c remove dead assignment 2018-09-28 09:53:14 -05:00
Scott Fennell
dac6893062 eqparse_funcsub.c remove dead strlen 2018-09-28 09:52:09 -05:00
Scott Fennell
5322bea815 correct all MatLab.cpp 'delete' to 'delete []' 2018-09-27 16:01:40 -05:00
Scott Fennell
6ee1a97c23 change delete to delete [] in MatLab.cpp 2018-09-27 15:45:15 -05:00
Scott Fennell
ffb3749a5a prevent garbage value in default switch case MatLab4 2018-09-27 15:37:34 -05:00
Scott Fennell
2f328f6697 prevent garbage value loaded as value in LogGroup::getValueAtTime 2018-09-27 14:32:35 -05:00
Scott Fennell
8315f95a8c remove dead assignment eqparse 2018-09-27 10:54:49 -05:00
Scott Fennell
6619ecb92f move commented prints in FieldDescription to debug_level 4 2018-09-27 08:10:05 -05:00
Scott Fennell
855510da63 handle edge default case for uninitialized value in eqparse 2018-09-26 15:10:49 -05:00
Scott Fennell
55db7fc708 remove dead assignment in EQParse 2018-09-26 15:07:06 -05:00
Scott Fennell
a9f84d1d9f various static analyser bug fixes 2018-09-26 14:27:03 -05:00
Scott Fennell
53f3b308f5 Merge branch 'master' of https://github.com/nasa/trick 2018-09-25 10:41:35 -05:00
Scott Fennell
77e0e73b3f various static analyser bug fixes 2018-09-25 10:41:14 -05:00
jmpenn
fccf32093b
Explicitly specify void arg for C functions that take no arguments. (#670)
* Clock empty args to void

* command_line func empty args to void

* DataRecord func empty args to void

* debug_pause func empty args to void

* echojobs func empty args to void

* ExternalApplication func empty args to void

* FrameLog func empty args to void

* MasterSlave func empty args to void

* MonteCarlo func empty args to void

* outdllist func proto empty args to void

* sie func empty args to void

* SimTime func empty args to void

* UnitTest func empty args to void

* var_server func empty args to void

* wcs func empty args to void
2018-09-19 11:25:04 -05:00
jmpenn
9a5ecd1294
Replace unreliable 'divide-by-zero' way of generating NaNs with math.h NAN in deuler routines. (#668) 2018-09-17 11:04:53 -05:00
jmpenn
00b4b2c8d9
Fix incorrect initialization of units in trick-qp, and incorrect generation of XML that caused fermi tables to crash. (#666) 2018-09-13 14:00:29 -05:00
jmpenn
fcbd99aaf4
Two Java plot fixes (#665)
* MinY and MaxY of Plot axis should never be the same, even with flatline data.

* In addition to a null check, add a empty units String check.
2018-09-06 14:46:08 -05:00
jmpenn
c112290265
Replace iText Java PDF library with PDFBox. (#664) 2018-09-04 16:59:06 -05:00
Derek Bankieris
3032aae3e4 Trick View: use fixed width for binary format
Closes #661
2018-08-28 08:22:56 -05:00
jmpenn
7b694931ef
Warning fixes (#658)
* Suppress expected, benign warnings from Bison and Flex generated code.

* Trick::MessageThreadedCout::thread_body should return NULL.
2018-08-16 16:02:11 -05:00
John M. Penn
8f5123e480 Included stdexcept in TRK_DataLog.cpp. Ref #657 2018-08-13 19:06:48 -05:00
John M. Penn
3ff8fc6bc0 Fix enums in MonteCarlo_test.cpp. REF #650 2018-08-08 14:36:10 -05:00
jmpenn
84f67ef79f
Update all enums in MonteCarlo with prefixes, so as to not conflict with other enums. (#650) 2018-07-25 13:05:10 -05:00
jmpenn
6f82d11122
Refactoring in trkConvert (#649)
* refactoring: DocWindow constructor to take datalog rather than filename.

* Neatening DocWindow.cpp
2018-07-19 17:45:47 -05:00
Scott Fennell
951aae4be4
Merge pull request #648 from nasa/java-update
#647 update deprecated code
2018-07-13 15:46:33 -05:00
Scott Fennell
a6274680a5 #647 update depricated code 2018-07-13 15:15:35 -05:00
jmpenn
b0b0cdf21b
Add Search and Documentation for trkConvert (#646)
* Add Export of variable list to file.

* Create DocWindow:formattedSave, and implement saveAsCSV etc in terms of it.

* Minor spacing changes

* Add text text UI parts to DocWindow.

* Add foreward and reverse search by pattern.

* Document and configuration for Mac.
2018-07-13 13:43:03 -05:00
Scott Fennell
a0eaf5b794 #624 Remove invalid delete in empty rec_buffer, checkpoint load no longer crashes. 2018-07-09 09:23:28 -05:00
jmpenn
402f7c152b
Added GUI to trkConvert. (#641) 2018-06-28 16:16:48 -05:00
anon
34dcffa7f7 add C headers to trk_DataLog.cpp 2018-06-28 10:18:49 -05:00
John M. Penn
f87657c747 Break out classes into separate files. #639 2018-06-25 11:44:00 -05:00
Derek Bankieris
f8edd98780 Replace CC w/ CXX in Trk2csv makefile
Fixes #638
2018-06-25 10:44:51 -05:00
Derek Bankieris
ed5a5426b1 Revert "Infer TRICK_HOME automatically"
This reverts commit 6e18294100.
Refs #637
2018-06-22 08:12:38 -05:00
Derek Bankieris
6e18294100 Infer TRICK_HOME automatically
Refs #358
2018-06-21 11:40:40 -05:00
jmpenn
882b568b86
Fix enums in MonteCarlo ExitStatus to less susceptible to conflict wi… (#628)
* Fix enums in MonteCarlo ExitStatus to less susceptible to conflict with other code. ref #609

* Add MC_ prefix to ExitStatus enums. Ref #609
2018-06-05 15:10:08 -05:00
Alex Lin
6ce60cb2ec Is Trick ICG missing some uses of TRICK_ICG #608
Some functions changed signatures in 3.5, others in 3.7.
2018-05-18 08:38:28 -05:00
Alex Lin
a8314b1497
Merge pull request #615 from nasa/framelog_fix
#588 top_of_frame and _end_of_frame fix for scheduled threads
2018-05-16 09:16:36 -05:00
Alex Lin
bf1ab16793
Merge pull request #617 from iamthad/pr_set_ptracer
Fix debugger attach when ptrace is restricted
2018-05-16 09:16:14 -05:00
Alex Lin
1e783fb49c When we are copying recorded data into a buffer we use a pointer to track the
buffer position.  This pointer wasn't used in DR_Changes_Step and was corrupting
the pointer initialization later in the write function.
2018-05-16 09:08:39 -05:00
anon
0212ed1650 #588 top_of_frame and _end_of_frame for child threads 2018-05-11 09:49:17 -05:00
Thadeus Fleming
54fe22684a Fix debugger attach when ptrace is restricted
Trick's backtrace or attach functionality fails on systems like Ubuntu
where the use of ptrace(2) is restricted. Where it is defined, use the
PR_SET_PTRACER prctl with the argument PR_SET_PTRACER_ANY to allow any
process to attach.
2018-05-10 07:19:30 -05:00
Alex Lin
be6f9dc855 Trick will not compile with llvm 6.0 and Xcode 9.2 on the mac. #579
Found a new language option we need to set in ICG when llvm >= 6.0 to parse
header files correctly.  The option is DoubleSquareBracketAttributes.
2018-05-07 16:26:20 -05:00
Derek Bankieris
62f95e784f Default exit confirmation dialog to off
Worst feature ever.

Closes #612
2018-05-07 08:10:31 -05:00
Alex Lin
f412125715 Is Trick ICG missing some uses of TRICK_ICG #608
Yes, it is, it's missing all of them.  Any clang/llvm version 3.5 and
above.  So it's been broken for a while.  We inherit from a
clang class that processes preprocessing statements.  If we override
virtual functions of a certain signature, we can inject our code into
the preprocessing process.  In this case we're looking for the use
of TRICK_ICG.  Clang changed the function signature in version 3.5.
From 3.5 on our functions were never called, so we never would find
TRICK_ICG.  I created new signatures for the functions post 3.5 so
they will work again.
2018-04-23 16:40:32 -05:00
Alex Lin
f6d000ac6e
Merge pull request #599 from iamthad/hammen-docs-fix-17
Port Hammen doxygen documentation fix to Trick 17
2018-04-12 08:51:42 -05:00
Alex Lin
2db059679b
Merge pull request #590 from abrogley/unit-test-return-code
Unit test exit code
2018-04-12 08:47:44 -05:00
Alex Lin
1525d2f634
Merge pull request #589 from iamthad/fix-io-63
Only left-shift `FieldDescription::io` when `io_found == true`
2018-04-12 08:46:08 -05:00
jmpenn
9d7ba05c76
Implement Event condition and action lists as array of ptrs to objects rather than contiguous arrays. ref #587 (#597) 2018-04-10 17:17:21 -05:00
John M. Penn
ad05aad2d2 Merge branch 'master' into Issue595 2018-04-10 16:07:46 -05:00
Scott Fennell
af6727408c Limit log file size (#594)
* #585 create new method to set max file size for DataRecordGroups.  Needs testing and DRD interface function

* #585 dre implementation and other improvements, needs more work

* #585 update dre, add intf for drd max size functions. Still requires better comments, wiki updates, some refactoring, and testing

* #585 refactor trick-dre

* format trick-dre

* improve readability of dre output for set_max_file_size
2018-04-10 16:02:44 -05:00
John M. Penn
adf4482135 Update MemoryManager::delete_var to just issue a warning message when debug_level > 0. ref #595 2018-04-10 15:34:06 -05:00
John M. Penn
f3be6c9ec0 Add a Memory Manager Test and a MM input parser error msg fix. Ref #587 2018-04-06 15:18:33 -05:00
Aaron Brogley
0d7a082b2f Adding Trick Unit Test return code functionality. 2018-03-28 10:09:22 -05:00
David Hammen
ba24d52801 Fixed a code bug and a comment bug in er7_utils, mostly so I can submit a new pull request against Trick 15.2.3. References #416. 2018-03-28 09:48:26 -05:00
David Hammen
7779dc568b Compile clean with clang++ -Wdocumentation.
I made a number of changes to Trick to make it compile clean with
clang++ -Wdocumentation, which checks doxygen comments. The changes
were either to comments or to parameter names in function declarations.
None of the changes have any impact on the compiled code.
2018-03-28 09:44:23 -05:00
Thadeus Fleming
db07582616 Only left-shift FieldDescription::io when io_found == true
The `io` field of `FieldDescription` takes a default value of 15. In
`FieldDescription::parseComment`, it may be updated as specified in the comment
text. There are 4 possible cases:

1) Neither IO attributes nor checkpoint IO attributes are found in the comment
2) IO attributes are found in the comment, but checkpoint IO attributes are not
3) Checkpoint IO attributes are found in the comment, but IO attributes are not
4) Both IO attributes and checkpoint IO attributes are found in the comment

In case 2, the IO attributes are copied into the checkpoint IO attributes by the
statement `io |= (io << 2)`. However, this also erroneously runs in case 1,
causing the default value of 15 to change to 63.

By testing `io_found == true`, this logic occurs only in case 2.

Fixes #568
2018-03-27 09:37:26 -05:00
Scott Fennell
f68950db9f
Merge pull request #581 from nasa/java-unit-test
Java GUI unit tests reintegrated with Trick
2018-03-21 09:04:04 -05:00
Scott Fennell
a1aaf52ce7 #521 preparation for java 10 support for xmls annotation and improved safety of file separator call 2018-03-21 08:27:11 -05:00