Sajith Sasidharan
22977352bb
Document parameters of ResultsRenderer classes
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
79be795566
Remove unused want_json()
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
23a51117d2
Rename r to check_results
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
fae4f44404
Prefer req to ctx
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cdb3747470
Remove nevow imports
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
de99912641
Replace ctx references with req references
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
1ee756c8df
Use Beautiful Soup to check for favicon
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
2e60408bf6
Wrap counters in <span> tags
...
Unless the rendered page contains strings of the form "Objects
Checked: <span>n</span>" etc, test_POST_DIRURL_deepcheck will not
pass.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
33ddac879c
Remove unused code
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
8094b3144d
Use SlotsSequenceElement to render all objects
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
4e594b09bf
Use SlotsSequenceElement to render corrupt shares
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
46cb3b6bc3
Use SlotsSequenceElement to render servers with corrupt shares
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c41bca24f5
Use SlotsSequenceElement to render deep check results problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
bbd6bde478
Use SlotsSequenceElement to render remaining corrupt shares
...
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
19f6ec7102
Use SlotsSequenceElement to render servers with corrupt shares
...
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
e0c686bb92
Use SlotsSequenceElement to render post-repair problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
f168dcd19c
Use SlotsSequenceElement to render pre-repair problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c7aa789a22
Fix "class has no children attribute" error
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cfb1560d15
Render "all objects" table using SlotsSequenceElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
3783349ea7
Add span tags to "deep check and repair results" template
...
Tests expect <span> tags around these numbers, let us add those.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c4be4b566c
Make TestRequest an object
...
Wouldn't pass PythonTwoRegressions.test_new_style_classes without
this.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
048840ac99
Stringify numbers
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c44a167a66
Remove WebRenderingMixin from WebResultsRendering
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
02cd42c130
Simplify WebResultsRendering.test_literal
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
77120ba70c
Update tests for ResultsRenderer classes
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
0d1269264a
Stringify numbers in DeepCheckResultsRenderer
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
7237fef630
Add property client to CheckAndRepairResultsRendererElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
19db5fb312
Update "deep check and repair results" template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
e4efcdd925
Make DeepCheckAndRepairResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
842b2b6be5
Use twisted tags in "deep check and repair results" template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
27e5ce090a
Update deep check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c33c0a884d
Make DeepCheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
9dcaa104c5
Use twisted tags in deep check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
0eea108123
Make CheckAndRepairResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
d9005fcccc
Use twisted tags in check and repair results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
80e9f48551
Add line breaks in a comment
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
6f1601aeeb
Stringify numbers before wrapping them up in tags
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
d2540b89d3
Use twisted web tags in ResultsBase
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
8e37bb1ebb
Make ResultsBase a base class of CheckResultsRendererElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
fea4e516f3
Make CheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
9d104f5893
Use twisted tags in check results template file
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cbc414725c
Use "output" as format argument
...
Nearly everywhere else the query argument for output format is "t";
but here "t" is used for operations, and "output" is used for output
format.
The test suite will fail without this.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c15001269f
Avoid using a Python keyword as a renderer name
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
3901559e34
Make LiteralCheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
ebf23a4f0e
Use twisted web tags in literal check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
950d111793
Use POST target paths without pre-existing query arguments
...
`action="."` on `/uri/URI:DIR2:$DIRCAP` will render as `/uri/`, which
is not the result we want.
2020-06-17 21:16:38 -04:00
Sajith Sasidharan
55170dcd2b
Rearrange imports
2020-06-17 15:45:08 -04:00
Sajith Sasidharan
7a23c8ed6c
Merge pull request #724 from sajith/3312.webui-directory-fix
...
Fix for "the webapi does not allow empty pathname components"
Fixes: ticket:3312
2020-06-17 10:55:21 -04:00
Sajith Sasidharan
fe967d208b
Merge pull request #727 from sajith/3315.operations-reload-mixin-nevow-to-twisted
...
Replace nevow with twisted.web in operations.ReloadMixin
Fixes: ticket:3315
2020-06-16 19:17:27 -04:00
Sajith Sasidharan
bd20f8d6f4
Update newsfragment text
2020-06-16 12:10:44 -04:00
