Use SlotsSequenceElement to render servers with corrupt shares

src/allmydata/web/check_results.py

@@ -536,24 +536,23 @@ class DeepCheckResultsRendererElement(Element, ResultsBase, ReloadMixin):
             return tag
         return ""
 
-    # TODO: use SlotsSequenceElement to render this.
     @renderer
     def servers_with_corrupt_shares(self, ctx, data):
         servers = [s
                    for (s, storage_index, sharenum)
                    in self.monitor.get_status().get_corrupt_shares()]
         servers.sort(key=lambda s: s.get_longname())
-        return servers
 
-    @renderer
-    def server_problem(self, req, tag):
-    # def server_problem(self, ctx, server):
-        # TODO: where do `server` come from now?
-        data = [server.get_name()]
-        nickname = server.get_nickname()
-        if nickname:
-            data.append(" (%s)" % self._html(nickname))
-        return tag(data)
+        problems = []
+
+        for server in servers:
+            name = [server.get_name()]
+            nick = server.get_nickname()
+            if nick:
+                name.append(" (%s)" % self._html(nickname))
+            problems.append(name)
+
+        return SlotsSequenceElement(tag, problems)
 
     @renderer
     def corrupt_shares_p(self, req, tag):

src/allmydata/web/deep-check-results.xhtml

@@ -34,8 +34,8 @@
 <div t:render="servers_with_corrupt_shares_p">
 <h2>Servers on which corrupt shares were found</h2>
 <ul t:render="servers_with_corrupt_shares">
-  <li t:pattern="item" t:render="server_problem"/>
-  <li t:pattern="empty">None</li>
+  <li t:render="item"/>
+  <li t:render="empty">None</li>
 </ul>
 </div>