Commit Graph

191 Commits

Author SHA1 Message Date
Victor Woeltjen
74b9d68dc8 [Plot] Update failing specs
Update failing specs after changes for WTD-806.
2015-04-17 16:42:15 -07:00
Victor Woeltjen
955c4209f0 [Plot] Add placeholder specs
Add placeholder specs for new scripts introduced to support
merging real-time and historical telemetry, WTD-806.
2015-04-17 15:11:22 -07:00
Victor Woeltjen
62958280b7 [Plot] Avoid clearing domain offset
Avoid clearing domain offset unnecessarily by fixing
variable reference; WTD-806.
2015-04-17 15:05:56 -07:00
Victor Woeltjen
8ba9c0553a [Plot] Begin integrating with telemetry handler
Miscellaneous tweaks and fixes to begin showing merged
real-time and historical telemetry, WTD-806.
2015-04-17 14:53:21 -07:00
Victor Woeltjen
5cc89e7983 [Plot] Update PlotController
Update plot controller to request historical telemetry,
WTD-806.
2015-04-17 14:09:39 -07:00
Victor Woeltjen
9f390de213 [Plot] Add clarifying comments
Add clarifying comments to PlotLine, added to simplify merging
of real-time with historical data, WTD-806.
2015-04-17 14:04:46 -07:00
Victor Woeltjen
7370b1a87f [Plot] Use new API from PlotUpdater
Use PlotLine and PlotLineBuffer from PlotUpdater, to enable
merging of real-time and historical telemetry. WTD-806.
2015-04-17 14:00:00 -07:00
Victor Woeltjen
4d34f19aa2 [Plot] Complete coverage of PlotLineBuffer
WTD-806.
2015-04-17 12:26:44 -07:00
Victor Woeltjen
6551e9212d [Plot] Fix insertion in PlotLineBuffer
WTD-806.
2015-04-17 12:13:17 -07:00
Victor Woeltjen
b20643018a [Plot] Complete PlotLineBuffer
Complete implementation of PlotLineBuffer, which is responsible
for managing the displayable buffer for an individual plot line.
WTD-806.
2015-04-17 12:06:44 -07:00
Victor Woeltjen
15b1c824e3 [Plot] Begin separating out plot line handling
Begin separating out plot line buffer from the rest of plot;
managing this buffer separately will aid in merging realtime
and hsitorical data, WTD-806.
2015-04-17 11:35:24 -07:00
Victor Woeltjen
9215eb1427 [Plot] Begin updating plot
Begin updating plot to merge realtime and historical
telemetry, WTD-806.
2015-04-16 16:48:03 -07:00
Victor Woeltjen
03e1633a22 [Timeline] Track realtime index in updater
Track realtime index in PlotUpdater to facilitate prepending of
historical data portion on-demand, WTD-806.
2015-04-16 16:41:09 -07:00
Victor Woeltjen
c10253c01d [Plot] Add note about test priority
WTD-1070.
2015-04-06 14:30:13 -07:00
Victor Woeltjen
e01c45df2e [Plot] Test 2D chart drawing
Test drawing using fallback canvas 2D API, WTD-1070.
2015-04-06 14:27:43 -07:00
Victor Woeltjen
3db8c1a32d [Plot] Try multiple chart options
Choose among multiple chart options, WTD-1070.
2015-04-06 14:15:34 -07:00
Victor Woeltjen
eba980c720 [Plot] Implement canvas 2d methods
Implement methods in 2D canvas to support fallback when
WebGL is unavailable, WTD-1070.
2015-04-06 13:56:27 -07:00
Victor Woeltjen
0626a6080e [Plot] Add 2d chart
Add skeleton class for implementation of charting
functionality which uses canvas' 2D API for rendering,
WTD-1070.
2015-04-06 13:49:13 -07:00
bwyu
1e6142ad45 WTD-842: Fixing mouse click in a plot area gets interpreted as a marquee zoom with an extent of zero. 2015-03-13 15:26:08 -07:00
Charles Hacskaylo
c640d6238b [Frontend] Markup and CSS mods to fix click area in btn-menu objects
WTD-1002
WTD-942
Mods to markup and CSS to make click-area of menu buttons occupy full area of button
2015-03-06 10:55:40 -08:00
bwyu
7c4cbb3107 Merge remote-tracking branch 'origin/open852' into open-master 2015-02-11 15:39:23 -08:00
bwyu
471e86bd6d Merge remote-tracking branch 'origin/open840' into open-master 2015-02-11 13:19:07 -08:00
Victor Woeltjen
7c5c96ff1d [Plot] Use GL-reported buffer size
Use the buffer width/height reported by WebGL when
configuring the viewport to ensure that data aligns
correctly to canvas size when drawn. WTD-852.
2015-02-09 16:10:20 -08:00
Victor Woeltjen
790397ae0f [Plot] Add test for buffer size
Add test case for usage of drawing buffer size as
reported by WebGL (instead of assuming we always got
the full size we requested.) WTD-852.
2015-02-09 16:07:05 -08:00
bwyu
61bb85df58 Merge remote-tracking branch 'origin/open751' into open-master 2015-02-06 18:08:12 -08:00
Victor Woeltjen
f78226bc69 [Plot] Unsubscribe on destroy
Unsubscribe when a plot view is destroyed; this avoids resource
leaks which cause WTD-840.
2015-02-05 17:37:47 -08:00
Victor Woeltjen
63345bbd3b [Plot] Add test for resource release
Add test to detect plot failing to release its subscriptions,
which causes WTD-840.
2015-02-05 17:34:37 -08:00
Victor Woeltjen
4ac25ab093 Merge branch 'open751' into open840
Merge in necessary changes to reproduce WTD-840 in order to
address WTD-840
2015-02-05 17:23:06 -08:00
bwyu
def47addb3 Merge remote-tracking branch 'origin/open734' into open-master 2015-02-04 12:24:23 -08:00
Victor Woeltjen
494cce9b2f [Plot] Complete specs for plot updater
Complete specs for plot updater; particularly, address
case (and fix bug in case) where maximum buffer size
has been hit. WTD-751.
2015-02-03 10:35:03 -08:00
Victor Woeltjen
ed0e0709c5 [Plot] Spec for plot updater
Spec for plot updater, added for WTD-751.
2015-02-02 18:14:08 -08:00
Victor Woeltjen
2ea4e7a47a [Plot] Update plot controller spec
Update plot controller spec to reflect changes introduced
for WTD-751 and WTD-784.
2015-02-02 16:17:17 -08:00
Victor Woeltjen
e6f1328d9d [Plot] Update specs
Update specs with minor changes related to using
telemetrySubscriber to populate plot with streaming
data, WTD-751 and WTD-784.
2015-02-02 15:44:36 -08:00
Victor Woeltjen
757665683e [Plot] Use a lossless subscription
Utilize lossless subscription to ensure that points are not
overwritten before being plotted from live telemetry.
WTD-784.
2015-01-30 15:36:57 -08:00
Victor Woeltjen
b1485e716c [Plot] Fix disappearing plot bug
Fix buffer resize operation as plots fill, WTD-782.
2015-01-30 12:28:39 -08:00
Victor Woeltjen
4fb750c0e0 [Plot] Update/suppress specs
Update specs and suppress failures; intermediate commit
for updates to plot for WTD-751.
2015-01-29 12:34:58 -08:00
Victor Woeltjen
a0137b341e [Plot] Fix bug for panels
Fix bug wherein number of points-to-plot is misreported
with multiple traces in a plot; clean up on modifications
to plot to self-cache streaming telemetry, to remove
other cache, WTD-751.
2015-01-29 12:27:04 -08:00
Victor Woeltjen
230ba3eb5c [Plot] Add comments
Add comments to plot code introduced to handle
subscribed telemetry only, to work around removal
of the cache to reduce memory usage, WTD-751.
2015-01-29 12:10:00 -08:00
Victor Woeltjen
5e2e0b4116 [Plot] Fix wiring on plot updater
Fix usages of the plot updater, introduced to track real-time
telemetry to remove the need to cache values elsewhere. This
allows memory usage to be decreased for WTD-751.
2015-01-29 11:22:31 -08:00
Victor Woeltjen
57f20ba110 [Plot] Amend plot updater
Amend plot updater to correctly expose information for real-time
plotting without history, allowing removal of cache to free
memory; WTD-751.
2015-01-29 11:19:22 -08:00
Victor Woeltjen
b615a3c888 [Plot] Wire in updater
Wire in updater for use in plots (to cache values at
the plot level, allowing removal of a global cache to
reduce memory consumption for WTD-751.)
2015-01-29 09:51:18 -08:00
Victor Woeltjen
f3900cdd2a [Plot] Add PlotUpdater
Add PlotUpdater, which will track streaming data from within
the plot. Allows removal of the cache for WTD-751.
2015-01-29 09:05:40 -08:00
Victor Woeltjen
a0f216764b [Plot] Cancel interval correctly
Fix approach used for interval cancellation associated
with resource leak closing for WTD-717; this avoids the
exception observed in WTD-750.
2015-01-28 15:53:13 -08:00
Victor Woeltjen
b915a90305 [Views] Fix glyphs
Use correct glyphs for Plot, Scrolling, and Items views.
WTD-734.
2015-01-27 14:50:45 -08:00
Victor Woeltjen
6947e0aa42 [Performance] Update specs
Add tests to verify that directives stop polling after their
scope is destroyed (to prevent resource leaks); those changes
address resource leaks identified in the context of WTD-717.
2015-01-27 08:50:11 -08:00
Victor Woeltjen
5ee872713f [Performance] Release interval from mct-chart
Stop checking for size changes after scope is destroyed
in mct-chart; part of ongoing resolution of resource leaks
which may contribute to WTD-717.
2015-01-26 17:56:52 -08:00
Victor Woeltjen
0ef6c59643 [Plot] Add a key to view definition
Add a value for key to the definition of Plot view;
this avoids defaulting to Plot as a view for all
objects, WTD-628.
2015-01-06 10:03:24 -08:00
Victor Woeltjen
78b636dafe [Telemetry] Update plot specs
Update plot specs to reflect refactoring out of formatter
for telemetry values, WTD-599.
2014-12-24 12:17:05 -08:00
Victor Woeltjen
f63038a83f [Telemetry] Move formatter spec
Move spec for formatting of telemetry values from the
plot bundle to the telemetry bundle, to reflect its
exposure as a reusable service exposed by that bundle.
WTD-599.
2014-12-24 11:39:29 -08:00
Victor Woeltjen
74f2af1011 [Telemetry] Expose telemetryFormatter
Expose telemetryFormatter as a service; additionally, fix
some structural issues to make sure this is passed around
as needed among plot components. WTD-599.
2014-12-24 11:14:38 -08:00
Victor Woeltjen
fc0376296d [Telemetry] Refactor plot to use TelemetryFormatter
Refactor plot view to use an injected telemetry formatter,
instead of explicitly including moment. WTD-599.
2014-12-24 10:59:34 -08:00
Victor Woeltjen
b080f90f64 [Telemetry] Move formatter implementation
Move implementation of formatter used for display
of domain values out of plot, and into the telemetry
bundle, from which it can be exposed as a general-use
service. WTD-599.
2014-12-24 10:34:43 -08:00
Victor Woeltjen
453b853a75 [Telemetry] Add skeleton formatter
Add skeleton for implementation of a formatter for
telemetry data, including reorganizing libraries
such that moment.min.js only occurs once. WTD-599.
2014-12-24 10:28:58 -08:00
Victor Woeltjen
921aad9e2f [Plot] Update plot immediately on mode change
Make sure current telemetry is drawn immediately upon
switching between Overlaid and Stacked plot modes.
WTD-625.
2014-12-12 15:14:20 -08:00
Victor Woeltjen
662412a31d [Plot] Avoid displaying bad labels
Avoid displaying bad labels for tick marks, or in the
coordinates shown on hover. Done in the context of
refactoring to support WTD-625.
2014-12-12 15:07:06 -08:00
Victor Woeltjen
b1158ce230 [Plot] Add JSDoc for stack plots
Add JSDoc for new classes introduced (and revised interfaces
exposed by existing classes) to support stacked plots,
WTD-625.
2014-12-12 14:37:06 -08:00
Victor Woeltjen
80852177c7 [Plot] Complete specs related to stacked mode
Add specs for SubPlot, which was introduced to support
presenting multiple plot areas within a single plot
view (stacked plots, WTD-625.)
2014-12-12 13:20:50 -08:00
Victor Woeltjen
c8c50f8fb1 [Plot] Add specs for plotting modes
Add specs for stacked/overlaid plot modes. WTD-625.
2014-12-12 12:56:26 -08:00
Victor Woeltjen
112d94e189 [Plot] Specs for PlotModeOptions
Add specs for PlotModeOptions, introduced to
allow switching between Stacked and Overlaid
mode for WTD-625.
2014-12-12 11:20:04 -08:00
Victor Woeltjen
7ea63fce8c [Plot] Add specs for PlotPanZoomStackGroup
Add specs to verify the behavior of PlotPanZoomStackGroup,
which is responsible for synchronizing the domain axis
between multiple sub-plots in a stacked plot view.
WTD-625.
2014-12-12 11:10:52 -08:00
Victor Woeltjen
a2d22a4558 [Plot] Restore coverage on PlotController
Restore full test coverage on PlotController after
refactoring for WTD-625, stacked plots.
2014-12-12 10:08:58 -08:00
Victor Woeltjen
4586146da2 [Plot] Remove failing specs
Remove specs which fail due to refactoring for
WTD-625.
2014-12-12 09:49:44 -08:00
Victor Woeltjen
a677ed258e [Plot] Add skeleton specs for stacked plots
Add skeleton specs for classes introduced to support
stacked plot mode, WTD-625.
2014-12-12 09:44:05 -08:00
Victor Woeltjen
06036ce8b3 [Plot] Restore range tick marks
Restore range tick marks; these were lost in refactoring
to support multiple subplots-per-view due to a missed
occurrence of an out-of-date interface usage. WTD-625.
2014-12-11 19:36:01 -08:00
Victor Woeltjen
188e98a78b [Plot] Update stacked plots immediately
When changes to pan-zoom bounds are made in one
subplot, this will effect the pan-zoom bounds of
other subplots. Ensure this occurs immediately.
WTD-625.
2014-12-11 19:33:09 -08:00
Victor Woeltjen
9c1d72f917 [Plot] Integrate PlotPanZoomStackGroup
Utilize PlotPanZoomStackGroup; that is, utilize changes
such that a set of pan-zoom stacks can be treated as one,
while their domain axis synchronizes, and their range
axis does not. WTD-625.
2014-12-11 19:21:52 -08:00
Victor Woeltjen
0ce0517e09 [Plot] Initially implement synced pan/zoom stack
Initially implement a synchronized pan/zoom stack,
which maintains the same domain axis bounds for all
subplots in a stacked plot view, but allows each to
have independent range axes. WTD-625.
2014-12-11 17:27:44 -08:00
Victor Woeltjen
9344809998 [Plot] Restrict hover coordinates
Only show hover coordinates in a stacked plot for
the plot which the user is specifically hovering
over. WTD-625.
2014-12-11 17:09:08 -08:00
Victor Woeltjen
1b6ce10dd9 [Plot] Change style when stacked
Change plot style when in stacked plot mode, such that
plots stack as expected. (Without this change, the
gl-plot class's height of 100% will cause all plots to
fill the full vertical space, effectively acting
overlaid.) WTD-625.
2014-12-11 17:02:07 -08:00
Victor Woeltjen
cd8deca1b3 [Plot] Add initial stack-plot implementation
Add initial implementation of stacked mode for
Plot view. Note that this will not stack correctly
due to markup/style issues. WTD-625.
2014-12-10 20:16:23 -08:00
Victor Woeltjen
eb90a3eeba [Plot] Fix refactoring issues
Fix issues related to refactoring of view-level
to subplot-level behavior, such that previous
functionality is restored. This refactoring
supports introduction of a stacked-plot mode,
for WTD-625.
2014-12-10 20:04:10 -08:00
Victor Woeltjen
784b2b6186 [Plot] Begin refactoring for stacked plots
Begin refactoring Plot view to support stacked plots;
separate out behavior which needs to occur per-plot
from area which should occur per-view, and add a
handler for the Overlay mode. WTD-625.
2014-12-10 19:51:27 -08:00
Victor Woeltjen
1c3d2d923f [Plot] Add notion of subplots to template
Add notion of subplots to the plot template; these
are elements within a stacked plot. WTD-625.
2014-12-10 18:55:47 -08:00
Victor Woeltjen
01f1a92d09 [Plot] Get/set from overlay switcher
Get/set mode from the plot mode switcher; only show
the switcher if there is more than one mode available
(which should only occur when there is more than one
telemetry object in the plot.) WTD-625.
2014-12-10 18:38:42 -08:00
Victor Woeltjen
3a0e80d360 [Plot] Add switcher for Stacked/Overlaid
Add switcher to handle changing between Stacked and Overlaid
plots. WTD-625.
2014-12-10 18:29:18 -08:00
Victor Woeltjen
622f1f8be7 [Plot] Add JSDoc
Add inline comments to Plot scripts. WTD-533.
2014-12-02 14:40:11 -08:00
Victor Woeltjen
870172ec6f [Plot] Complete specs for plot
Complete specs for transitioned plot view, WTD-533.
2014-12-02 11:08:21 -08:00
Victor Woeltjen
2f475fc17a [Plot] Fill in specs
Fill in specs for elements used by the PlotController
in order to improve coverage of the plot bundle.
WTD-533.
2014-12-02 10:11:46 -08:00
Victor Woeltjen
ae05ed903b [Plot] Add skeleton specs
Add skeleton specs for remaining plot scripts.
WTD-533.
2014-12-01 19:45:23 -08:00
Victor Woeltjen
86711735b7 [Plot] Organize plot elements
Place elements of the PlotController into a separate
directory inside of the source folder for the plot
plug-in, in preparation for review and integration.
Part of ongoing plot transition to Angular, WTD-533.
2014-12-01 18:21:51 -08:00
Victor Woeltjen
ad802e674e [Plot] Spec for PlotController
Fill in spec for PlotController, which is the primary
handler of logic associated with plot views, transitioned
for WTD-533.
2014-12-01 18:13:03 -08:00
Victor Woeltjen
c9300e8611 [Plot] Initial spec for PlotController
Add initial spec for PlotController, the main controller
to support the plot view. WTD-533.
2014-12-01 16:44:16 -08:00
Victor Woeltjen
e1298db760 [Plot] Separate out plot axis
Separate plot axis (as prepared for the plot's
Angular template) into its own script. WTD-533
2014-12-01 16:35:38 -08:00
Victor Woeltjen
bb708e9a05 [Plot] Separate out formatter
Separate out plot label formatter to simplify PlotController,
to simplify test and maintenance. WTD-533
2014-12-01 15:28:20 -08:00
Victor Woeltjen
5bfa9c76a7 [Plot] Separate out positioning
Separate out pixel-to-plot-coordinate conversion into its
own script, to simplify PlotController for testing and
maintainability. WTD-533.
2014-12-01 14:14:31 -08:00
Victor Woeltjen
1b4286344d [Plot] Separate out pan/zoom stack
Create a separate script/class for the pan-zoom stack,
to simplify PlotController for testability and
maintainability. WTD-533.
2014-12-01 13:48:38 -08:00
Victor Woeltjen
ac00c52589 [Plot] Rename plot preparer
Rename the script used to prepare plot data for
rendering. WTD-533.
2014-12-01 13:27:30 -08:00
Victor Woeltjen
f3b83e0db7 [Plot] Icons for plot controls
Add icons for plot pan/zoom controls, to step
back through or undo pan/zoom states. WTD-533.
2014-12-01 13:04:24 -08:00
Victor Woeltjen
7836fe5fbb [Plot] Make PlotPalette constructor-like
Make PlotPalette look like a constructor, in order
to remain consistent with code style guidelines.
WTD-533.
2014-12-01 10:16:59 -08:00
Victor Woeltjen
8cb3ce4fd9 [Plot] Rename GLPlot to GLChart
Rename the GLPlot script (which handles drawing
of lines/boxes to canvas elements) to GLChart,
to distinguish it from the broader plot view.
WTD-533.
2014-12-01 10:12:07 -08:00
Victor Woeltjen
b556b5e4f2 [Plot] Bring in scripts from sandbox branch
Bring in scripts for plotting from the sandbox
branch to begin transitioning/integrating plot
view. WTD-533.
2014-12-01 09:41:39 -08:00