Repro (order important because hotp includes the other variant)
./docker_repro.sh make BOARD=UNTESTED_t440p-hotp-maximized board.move_untested_to_tested
./docker_repro.sh make BOARD=UNTESTED_t440p-maximized board.move_untested_to_tested
./docker_repro.sh make BOARD=UNTESTED_w541-hotp-maximized board.move_untested_to_tested
./docker_repro.sh make BOARD=UNTESTED_w541-maximized board.move_untested_to_tested
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Unfortunately the helper doesn't deal well with board inclusion: sed call is imperfect, and board config needs to be manually edited.
TODO: fix the helper when it will be the time to move back to tested/untested
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
With 3466272a69f1345340f5eeda05a5dd338883f8eb T480 thermal codepath does not break other boards anymore.
We move it back to circleci and maintained.
This reverts commit 730fdd1b25384bacc8e491c543709f5967651ffb.
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
all remaining issues do not seem to be heads but coreboot related
no debugging needed anymore, issues should be reported upstream and fixed there
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
Repro:
- sed -i 's/24.02.01/2412/g' boards/*/*.config
- docker_repro.sh
- git status | grep boards | awk -F "/" {'print $2'} | while read board; do make BOARD=$board coreboot.save_in_oldconfig_format_in_place; done
Manually modify CircleCI board dependencies. As of now, librem + dasharo reuses 24.02.01 crossgcc buildstack, and all other coreboot dependent boards rely on 2412
- save cache switched to reuse x230-hotp-maximized since most boards depend on 2412 coreboot buildstack
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Debug that was missing:
CONFIG_ENABLE_FUNCTION_TRACING_OUTPUT=y
All of this is because we tried to adapt from t400p which is tpm1 instead of librem_14v3 which is really similar to this board.
Note that we currently use a duplicate of librem14v3 linux config.
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
- Reuse good tweeks from gaspar-ilom's provided config/coreboot-t480-maximized.config
- move config/coreboot-t480-maximized.config to config/coreboot-t480.config, delete config/coreboot-t480-maximized.config
- rename boards/t480-hotp-maximized -> boards/t480-hotp, boards/t480-maximized/t480-maximized -> boards/t480-maximized/t480
- Adapt CircleCI board naming accordingly
TODO:
- discuss need of thunderbold firmware presence in fw, that were part of @notgivenby prior work and now gone. Should it be brought back?
- Tweaks of config/coreboot-t480.config against prior commit, outside of blobs paths having change.
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Resolve conflicts, enable TPM2 support into board configs that was missing sorry
- remove blobs/kabylake/fetch_split_fsp.sh since unneeded if depending on full FSP from tree
- removed fsp.fd files placed in blobs and references to it in @gaspar-ilom branch
- removed blobs/kabylake/* altogether since unneeded
- remove patches/coreboot-24.02.01/* since we use another fork (currently modules/coreboot: t480, might be renamed to coreboot release to be reused later)
- t480 boards depend on targets/xx80_me_blobs.mk now, next commit will cleanup prior work artifacts not needed; @gaspar-ilom approach cleaner
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
with exception of
- qemu boards not being *quiet: quiet=n
- qemu boards not being *prod* having pcap=y
- qemy boards not being *prod* have debug+tracing=y
- qemu tpm1 boards have '#pcap=n'
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
