ExternalVendorCode/corda
1
0
Fork 0
mirror of https://github.com/corda/corda.git synced 2025-06-17 06:38:21 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

NOTICK - Small tidy up based on lint suggestions

Browse Source 
Move functions into .cxx files and out of the inline implementation in
the headers, std::move constructor params.
This commit is contained in:
Katelyn Baker
2019-08-17 16:19:02 +01:00
parent 3c3f5f5e04
commit 81e9e8a842
4 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
experimental/cpp-serializer/src/amqp/consumer/CompositeReader.h
View File

@ -30,7 +30,7 @@ namespace amqp {
std::vector<std::weak_ptr<amqp::Reader>> & readers_ std::vector<std::weak_ptr<amqp::Reader>> & readers_
); );
~CompositeReader() = default; ~CompositeReader() override = default;
std::any read (pn_data_t *) const override; std::any read (pn_data_t *) const override;

1
experimental/cpp-serializer/src/amqp/consumer/PropertyReader.h
View File

@ -22,6 +22,7 @@ namespace amqp {
static std::shared_ptr<PropertyReader> make (const FieldPtr &); static std::shared_ptr<PropertyReader> make (const FieldPtr &);
static std::shared_ptr<PropertyReader> make (const std::string &); static std::shared_ptr<PropertyReader> make (const std::string &);
PropertyReader() = default;
~PropertyReader() override = default; ~PropertyReader() override = default;
std::string readString(pn_data_t *) const override = 0; std::string readString(pn_data_t *) const override = 0;

7
experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.cxx
View File

@ -6,6 +6,13 @@
/******************************************************************************/ /******************************************************************************/
amqp::
RestrictedReader::RestrictedReader (std::string type_)
: m_type (std::move (type_))
{ }
/******************************************************************************/
const std::string amqp::RestrictedReader::m_name { // NOLINT const std::string amqp::RestrictedReader::m_name { // NOLINT
"Restricted Reader" "Restricted Reader"
}; };

7
experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.h
View File

@ -23,11 +23,8 @@ namespace amqp {
const std::string m_type; const std::string m_type;
public : public :
RestrictedReader (const std::string & type_) RestrictedReader (std::string);
: m_type (type_) ~RestrictedReader() override = default;
{ }
~RestrictedReader() = default;
std::any read(pn_data_t *) const override ; std::any read(pn_data_t *) const override ;