NOTICK - Small tidy up based on lint suggestions

Move functions into .cxx files and out of the inline implementation in
the headers, std::move constructor params.
This commit is contained in:
Katelyn Baker 2019-08-17 16:19:02 +01:00
parent 3c3f5f5e04
commit 81e9e8a842
4 changed files with 11 additions and 6 deletions

View File

@ -30,7 +30,7 @@ namespace amqp {
std::vector<std::weak_ptr<amqp::Reader>> & readers_
);
~CompositeReader() = default;
~CompositeReader() override = default;
std::any read (pn_data_t *) const override;

View File

@ -22,6 +22,7 @@ namespace amqp {
static std::shared_ptr<PropertyReader> make (const FieldPtr &);
static std::shared_ptr<PropertyReader> make (const std::string &);
PropertyReader() = default;
~PropertyReader() override = default;
std::string readString(pn_data_t *) const override = 0;

View File

@ -6,6 +6,13 @@
/******************************************************************************/
amqp::
RestrictedReader::RestrictedReader (std::string type_)
: m_type (std::move (type_))
{ }
/******************************************************************************/
const std::string amqp::RestrictedReader::m_name { // NOLINT
"Restricted Reader"
};

View File

@ -23,11 +23,8 @@ namespace amqp {
const std::string m_type;
public :
RestrictedReader (const std::string & type_)
: m_type (type_)
{ }
~RestrictedReader() = default;
RestrictedReader (std::string);
~RestrictedReader() override = default;
std::any read(pn_data_t *) const override ;