diff --git a/experimental/cpp-serializer/src/amqp/consumer/CompositeReader.h b/experimental/cpp-serializer/src/amqp/consumer/CompositeReader.h index d6280b8a63..444a07d871 100644 --- a/experimental/cpp-serializer/src/amqp/consumer/CompositeReader.h +++ b/experimental/cpp-serializer/src/amqp/consumer/CompositeReader.h @@ -30,7 +30,7 @@ namespace amqp { std::vector> & readers_ ); - ~CompositeReader() = default; + ~CompositeReader() override = default; std::any read (pn_data_t *) const override; diff --git a/experimental/cpp-serializer/src/amqp/consumer/PropertyReader.h b/experimental/cpp-serializer/src/amqp/consumer/PropertyReader.h index c0fce32654..70f749dafd 100644 --- a/experimental/cpp-serializer/src/amqp/consumer/PropertyReader.h +++ b/experimental/cpp-serializer/src/amqp/consumer/PropertyReader.h @@ -22,6 +22,7 @@ namespace amqp { static std::shared_ptr make (const FieldPtr &); static std::shared_ptr make (const std::string &); + PropertyReader() = default; ~PropertyReader() override = default; std::string readString(pn_data_t *) const override = 0; diff --git a/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.cxx b/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.cxx index 4337c56381..94fe3a238d 100644 --- a/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.cxx +++ b/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.cxx @@ -6,6 +6,13 @@ /******************************************************************************/ +amqp:: +RestrictedReader::RestrictedReader (std::string type_) + : m_type (std::move (type_)) +{ } + +/******************************************************************************/ + const std::string amqp::RestrictedReader::m_name { // NOLINT "Restricted Reader" }; diff --git a/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.h b/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.h index 05c5ea810e..247eb279bb 100644 --- a/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.h +++ b/experimental/cpp-serializer/src/amqp/consumer/RestrictedReader.h @@ -23,11 +23,8 @@ namespace amqp { const std::string m_type; public : - RestrictedReader (const std::string & type_) - : m_type (type_) - { } - - ~RestrictedReader() = default; + RestrictedReader (std::string); + ~RestrictedReader() override = default; std::any read(pn_data_t *) const override ;