mirror of
https://github.com/corda/corda.git
synced 2024-12-18 20:47:57 +00:00
Addressed release comments.
This commit is contained in:
parent
ccf231440f
commit
3ccddf91ea
8
.github/PULL_REQUEST_TEMPLATE.md
vendored
8
.github/PULL_REQUEST_TEMPLATE.md
vendored
@ -10,8 +10,8 @@ Once you have submitted a PR you are responsible for keeping it up to date until
|
||||
## PR Checklist
|
||||
|
||||
1. Ensure any new code is tested as described [here](https://docs.corda.net/testing.html)
|
||||
1. Ensure you have done any relevant automated testing and manual testing
|
||||
2. Add your changes to `docs/source/changelog.rst`
|
||||
3. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html)
|
||||
4. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now
|
||||
2. Ensure you have done any relevant automated testing and manual testing
|
||||
3. Add your changes to `docs/source/changelog.rst`
|
||||
4. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html)
|
||||
5. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now
|
||||
and add to this Pull Request that you have read, and agreed to, the agreement.
|
||||
|
@ -6,4 +6,5 @@ Release process
|
||||
|
||||
release-notes
|
||||
changelog
|
||||
codestyle
|
||||
codestyle
|
||||
testing
|
@ -16,8 +16,8 @@ There are several distinct test suites each with a different purpose;
|
||||
|
||||
**Other**: These include tests such as performance tests, stress tests, etc, and may be in an external repo.
|
||||
|
||||
These tests are mostly written with JUnit and can be run via ``gradle`` with ``gradlew test integrationTest smokeTest``
|
||||
or any combination of these three.
|
||||
These tests are mostly written with JUnit and can be run via ``gradle``. On windows run ``gradlew test integrationTest
|
||||
smokeTest`` and on unix run ``./gradlw test integrationTest smokeTest`` or any combination of these three arguments.
|
||||
|
||||
Before creating a pull request please make sure these pass.
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user