From 3ccddf91eab3cb4ae95ac7fa22e1042ef005f64c Mon Sep 17 00:00:00 2001 From: Clinton Alexander Date: Tue, 5 Sep 2017 17:38:53 +0100 Subject: [PATCH] Addressed release comments. --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++---- docs/source/release-process-index.rst | 3 ++- docs/source/testing.rst | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 66ff0a88b1..7946da9d1f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,8 +10,8 @@ Once you have submitted a PR you are responsible for keeping it up to date until ## PR Checklist 1. Ensure any new code is tested as described [here](https://docs.corda.net/testing.html) -1. Ensure you have done any relevant automated testing and manual testing -2. Add your changes to `docs/source/changelog.rst` -3. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html) -4. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now +2. Ensure you have done any relevant automated testing and manual testing +3. Add your changes to `docs/source/changelog.rst` +4. Update any documentation in `docs/source` relating to your changes and learn how to build them [here](https://docs.corda.net/building-the-docs.html) +5. If you are contributing for the first time please read the agreement in [CONTRIBUTING](../contributing.md) now and add to this Pull Request that you have read, and agreed to, the agreement. diff --git a/docs/source/release-process-index.rst b/docs/source/release-process-index.rst index 9e5276f786..1b59977668 100644 --- a/docs/source/release-process-index.rst +++ b/docs/source/release-process-index.rst @@ -6,4 +6,5 @@ Release process release-notes changelog - codestyle \ No newline at end of file + codestyle + testing \ No newline at end of file diff --git a/docs/source/testing.rst b/docs/source/testing.rst index 69a81a706a..c082361d2d 100644 --- a/docs/source/testing.rst +++ b/docs/source/testing.rst @@ -16,8 +16,8 @@ There are several distinct test suites each with a different purpose; **Other**: These include tests such as performance tests, stress tests, etc, and may be in an external repo. -These tests are mostly written with JUnit and can be run via ``gradle`` with ``gradlew test integrationTest smokeTest`` -or any combination of these three. +These tests are mostly written with JUnit and can be run via ``gradle``. On windows run ``gradlew test integrationTest +smokeTest`` and on unix run ``./gradlw test integrationTest smokeTest`` or any combination of these three arguments. Before creating a pull request please make sure these pass.