pmo: loop quality audit — default_class=code, reopen 522/495, park 497, verify 524

2026-08-29 09:04:45 -05:00
parent f2698b741c
commit eeeb05e733
5 changed files with 54 additions and 0 deletions
@@ -0,0 +1,51 @@
+# REPORT — 20260829 08:30 — mred `version update` (Redmine 524 finish turn)
+
+Repo: ukrrs/mopac-redmine-go, branch `main`, pushed `788f6fe..5abd352`.
+Prior state: main@788f6fe clean, zero delivered from the study turn; this
+turn implemented the full scope. All dev ran inside the digest-pinned
+Docker builder (`./dev.sh`); TDD (tests red first, then implementation).
+
+## Diff summary (3 atomic conventional commits, pushed to origin/main)
+
+| Commit | Content |
+|---|---|
+| `26824c3` feat(redmine) | `Client.UpdateVersion` (PUT /versions/N.json — partial: only set fields serialized; the 204 empty body is never parsed, `out=nil` path) and `Client.GetVersion` (GET /versions/N.json, backs the `-o json` re-fetch). Fake Redmine gained the matching PUT/GET endpoints (partial apply, 204-with-empty-body, 404 on unknown id) plus a `Version(id)` assertion accessor. |
+| `37118f0` feat(cli) | `mred version update ID [--status open|closed] [--due YYYY-MM-DD] [--name NAME]`. At least one flag required → exit 1 usage error otherwise; `--status` validated to open\|closed; only provided flags sent. Text mode prints `updated version #N`; `-o json` re-fetches and emits the stored version; exit codes 0/1/2 per house convention; help/usage text updated. |
+| `5abd352` docs(readme) | Command-reference row, quickstart example, library-surface signatures (`GetVersion`/`UpdateVersion`), partial-update + 204 note, status-table line. |
+
+## Verification
+
+- `./dev.sh check` (build + vet + test, Docker): **green**, all packages.
+- `./dev.sh smoke` (real CLI vs containerized fake, port 8601): **smoke: OK**
+  (existing surface unregressed; redaction pass clean).
+- New tests, all table-driven against the existing fake:
+  - Library: `TestUpdateVersionPartial` (4 cases: status flip, due change,
+    name change, combined — each pins the exact PUT request body so
+    "only provided flags are sent" is asserted, plus untouched-attribute
+    survival; every case round-trips the 204-empty-body reply),
+    `TestGetVersion` (round-trip + 404→`ErrNotFound`),
+    `TestUpdateVersionMissing` (404 mapping with parseable `http 404`).
+  - CLI: `TestVersionUpdate` (8 cases: status flip, due change, name
+    change, combined flags with stored-state assertions, no-flags usage
+    error, bad-status usage error, non-numeric id usage error, unknown id
+    → exit 2 with `http 404` on stderr) and `TestVersionUpdateJSONRefetches`
+    (json mode re-fetches and emits the updated version).
+  - Count: 22 passing test entries (4 top-level functions, 12 table
+    subtests). Full suite: 3 packages ok, 0 failures.
+
+## Production read verification (read-only, after push)
+
+Using the 0600 config derived from `~/.creds/redmine.env`
+(`~/.config/mred/env`, per the documented bootstrap):
+
+- `mred version list -p MOPAC` → **exit 0**, all **5** versions present
+  (34 closed V1 Core due 2026-08-28; 35 open Beta due 2026-08-31;
+  36 open Production due 2026-09-01; 37 closed Phase 3 - Integrations
+  due 2026-09-07; 38 open Selfhost Alpha due 2026-08-29).
+- `mred version list -p MOPAC -o json` → 5 ids, exit 0.
+- **No mutation of production**: the only commands run against the live
+  tracker are `version list` reads (GET). `version update` was exercised
+  exclusively against the fake.
+
+No journal/status writes were made to Redmine 524 — left Resolved for
+PMO re-verification per protocol.
@@ -98,3 +98,4 @@
 2026-08-29T07:22:01-05:00 | PMO | Charles: 0800 = SOFT deadline; work to prod ALL DAY (fast/quality/cost/parallel), wiring tonight 1900. 0758 hard-stop killed; 0745 cutover checkpoint + 0900 chain check armed; heartbeat 1h continues. q16 stays serial-behind-q15 (same repo); 522 inherited by loop if q16 slips
 2026-08-29T07:50:23-05:00 | PMO | CUTOVER COMPLETE: q15 verified (REPORT 07:32, tests green, live proof) -> 521 Resolved. Scope->Beta(35) + max_rounds 12 applied, container restarted healthy, 5 Beta tasks in scope, first loop-driven Beta turn (524) RUNNING on flash. 497 parked In Progress (1900 wiring). 523: criteria 1/2/4 PASS, 3=teardown pending. q15's worker had requeued 523 itself to proof the container (benign mystery solved). Remaining crush work: teardown after 522/495 land or fail-verify
 2026-08-29T08:03:45-05:00 | PMO | hb 08:02: 524 loop turn = NON-DELIVERY (flash round_limit x12, 0 commits, false Resolved) -> finish turn q17 dispatched on 5.2 (parallel repo, no conflict); evidence noted on 492 (dispatcher = real fix); 522 turning on flash, verdict at ~08:05, if bust: stop loop -> crush finish -> restart (serial, 10s outage); 495 next in scope
+2026-08-29T09:04:45-05:00 | PMO | hb 09:02 audit: q17 good (524 verified+archived). Loop flash non-deliveries confirmed on 521(re-noise,harmless)/522/495/497 (495 burned 131k tok) -> systemic fix: default_class=code (all loop turns -> glm-5.2), container restarted; 522+495 reopened New (re-turn on 5.2), 497 re-parked In Progress (hard block until 1900 wiring), all statuses verified live. 521 Resolved (its 2nd loop turn was noise; real work was q15). Beta: loop redoes 522+495 on 5.2 now
@@ -17,3 +17,4 @@
 2026-08-29T06:02:15-05:00 wake sent (pending=4 active=1)
 2026-08-29T07:02:15-05:00 wake sent (pending=5 active=1)
 2026-08-29T08:02:15-05:00 wake sent (pending=5 active=0)
+2026-08-29T09:02:15-05:00 wake sent (pending=6 active=0)
@@ -0,0 +1 @@
+All context gathered. Setting up the work plan, then going test-first.Writing the red tests — library first (after `TestVersionRoundTrip`), then CLI (after `TestVersionCommands`):Now the CLI table-driven test:Confirming red (compile failure = missing API, which is the red state):Red confirmed. Implementing fake handlers + accessor:Now the library methods:Now the CLI subcommand, dispatch, and usage text:Green. Running the full gate + counting tests:Full gate green, 22 new test passes. Running smoke while I update the README:Smoke OK. Committing in three atomic chunks:Pushed. Now the production read-only verification:All 5 versions intact, exit 0. Capturing the JSON variant for the report, then writing it:524 delivered. `mred version update` shipped TDD-first (red → green): library `UpdateVersion` (partial PUT, 204 never parsed) + `GetVersion`, fake endpoints, CLI subcommand with 0/1/2 conventions, README rows — 3 atomic commits pushed (`788f6fe..5abd352`). Gates: `./dev.sh check` green, smoke OK, 22 new test entries passing. Prod read-only verified: `mred version list -p MOPAC` exit 0, all 5 versions intact, no live writes. Report at `~/.coordinate/inbox-pmo/REPORT-20260829-0830-mred-version-update.md`; ticket 524 left untouched for PMO.
				`@@ -0,0 +1 @@`
				All context gathered. Setting up the work plan, then going test-first.Writing the red tests — library first (after `TestVersionRoundTrip`), then CLI (after `TestVersionCommands`):Now the CLI table-driven test:Confirming red (compile failure = missing API, which is the red state):Red confirmed. Implementing fake handlers + accessor:Now the library methods:Now the CLI subcommand, dispatch, and usage text:Green. Running the full gate + counting tests:Full gate green, 22 new test passes. Running smoke while I update the README:Smoke OK. Committing in three atomic chunks:Pushed. Now the production read-only verification:All 5 versions intact, exit 0. Capturing the JSON variant for the report, then writing it:524 delivered. `mred version update` shipped TDD-first (red → green): library `UpdateVersion` (partial PUT, 204 never parsed) + `GetVersion`, fake endpoints, CLI subcommand with 0/1/2 conventions, README rows — 3 atomic commits pushed (`788f6fe..5abd352`). Gates: `./dev.sh check` green, smoke OK, 22 new test entries passing. Prod read-only verified: `mred version list -p MOPAC` exit 0, all 5 versions intact, no live writes. Report at `~/.coordinate/inbox-pmo/REPORT-20260829-0830-mred-version-update.md`; ticket 524 left untouched for PMO.