fix: resolve shellcheck warnings in shell scripts

Improve code quality by addressing shellcheck warnings
across security-critical scripts.

src/security-hardening.sh:
- Add shellcheck directive for SC2120/SC2119
- Function configure_password_policy() accepts optional args
- Directive documents intentional usage pattern

src/firewall-setup.sh:
- Fix function argument passing in main()
- Properly pass arguments to configure_firewall()

config/hooks/installed/encryption-setup.sh:
- Consolidate echo commands to fix SC2129
- Use single redirect for multiple writes

Remaining warnings are non-critical:
- SC1091: Source files exist at runtime in Docker container
- SC2016: Intentional single quotes for sed pattern

No functional changes - purely code quality improvements.

💘 Generated with Crush

Assisted-by: GLM-5 via Crush <crush@charm.land>
This commit is contained in:
Charles N Wyble
2026-02-17 10:12:01 -05:00
parent acf3f934fd
commit d00f3c9f02
3 changed files with 14 additions and 11 deletions

View File

@@ -71,7 +71,7 @@ apply_firewall() {
# Main setup
main() {
echo "Setting up dynamic firewall..."
apply_firewall
apply_firewall "${1:-}"
echo "Firewall setup completed."
}