test(demo): rewrite test suite with meaningful assertions
Unit tests (test_env_validation.sh): - Validate docker-compose.yml.template has all 16 services - Verify every exposed service has healthcheck, restart policy, labels - Verify Dockhand routes through socket proxy (not direct mount) - Verify only docker-socket-proxy mounts /var/run/docker.sock - Validate demo.env.template has all 28 required variables - Verify all port values are in 4000-4099 range - Verify Homepage and Grafana config files exist - Verify all scripts use strict mode (set -euo pipefail) - 53 assertions, all passing Integration tests (test_service_communication.sh): - Remove || true suppression on test failures - Add require_stack_running guard with clear error message - Add test for Dockhand proxy integration (DOCKER_HOST env check) - Add network isolation test (container count on network) - Proper pass/fail counting with exit code Previous unit test was a tautology (id -u == id -u) that could never fail. Previous integration tests suppressed all failures. 💘 Generated with Crush Assisted-by: GLM-5.1 via Crush <crush@charm.land>
This commit is contained in:
reachableceo
@@ -1,71 +1,117 @@
|
||||
#!/bin/bash
|
||||
# Integration test: Service-to-service communication
|
||||
# Requires a running stack. Validates inter-service connectivity.
|
||||
set -euo pipefail
|
||||
|
||||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
||||
PROJECT_ROOT="$(dirname "$(dirname "$SCRIPT_DIR")")"
|
||||
ENV_FILE="$PROJECT_ROOT/demo.env"
|
||||
|
||||
if [[ ! -f "$ENV_FILE" ]]; then
|
||||
echo "ERROR: $ENV_FILE not found. Copy demo.env.template to demo.env and configure."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
set -a; source "$ENV_FILE"; set +a
|
||||
|
||||
RED='\033[0;31m'
|
||||
GREEN='\033[0;32m'
|
||||
YELLOW='\033[1;33m'
|
||||
NC='\033[0m'
|
||||
|
||||
PASS=0
|
||||
FAIL=0
|
||||
|
||||
pass() { echo "PASS: $1"; ((PASS++)); }
|
||||
fail() { echo "FAIL: $1"; ((FAIL++)); }
|
||||
pass() { echo -e "${GREEN}[PASS]${NC} $1"; ((PASS++)); }
|
||||
fail() { echo -e "${RED}[FAIL]${NC} $1"; ((FAIL++)); }
|
||||
check() { echo -e "${YELLOW}[CHECK]${NC} $1"; }
|
||||
|
||||
test_grafana_influxdb_integration() {
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-grafana" wget -q --spider http://influxdb:8086/ping 2>/dev/null; then
|
||||
pass "Grafana-InfluxDB integration"
|
||||
else
|
||||
fail "Grafana-InfluxDB integration"
|
||||
require_stack_running() {
|
||||
if ! docker ps --filter "name=${COMPOSE_PROJECT_NAME}" --format "{{.Names}}" | grep -q .; then
|
||||
echo "ERROR: No running containers found for ${COMPOSE_PROJECT_NAME}"
|
||||
echo "Run ./scripts/demo-stack.sh deploy first"
|
||||
exit 1
|
||||
fi
|
||||
}
|
||||
|
||||
test_dockhand_docker_integration() {
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-dockhand" sh -c 'command -v docker >/dev/null 2>&1 && docker version >/dev/null 2>&1' 2>/dev/null; then
|
||||
pass "Dockhand-Docker integration"
|
||||
test_grafana_influxdb_integration() {
|
||||
check "Grafana can reach InfluxDB on internal network"
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-grafana" wget -q --spider http://influxdb:8086/ping 2>/dev/null; then
|
||||
pass "Grafana reaches InfluxDB via internal DNS"
|
||||
else
|
||||
pass "Dockhand-Docker integration (socket mount OK - no docker CLI in container)"
|
||||
fail "Grafana cannot reach InfluxDB"
|
||||
fi
|
||||
}
|
||||
|
||||
test_dockhand_proxy_integration() {
|
||||
check "Dockhand can reach Docker via socket proxy"
|
||||
local dockhand_env
|
||||
dockhand_env=$(docker exec "${COMPOSE_PROJECT_NAME}-dockhand" env 2>/dev/null || echo "")
|
||||
if echo "$dockhand_env" | grep -q "DOCKER_HOST=tcp://docker-socket-proxy:2375"; then
|
||||
pass "Dockhand configured with DOCKER_HOST pointing to socket proxy"
|
||||
else
|
||||
fail "Dockhand DOCKER_HOST not configured for socket proxy"
|
||||
fi
|
||||
}
|
||||
|
||||
test_homepage_discovery() {
|
||||
local discovered
|
||||
discovered=$(curl -sf "http://localhost:${HOMEPAGE_PORT}" 2>/dev/null | grep -ci "service\|href\|homepage" || echo "0")
|
||||
if [[ "$discovered" -ge 1 ]]; then
|
||||
pass "Homepage service discovery (found references)"
|
||||
check "Homepage responds and contains service references"
|
||||
local http_code
|
||||
http_code=$(curl -s -o /dev/null -w "%{http_code}" "http://localhost:${HOMEPAGE_PORT}" 2>/dev/null || echo "000")
|
||||
if [[ "$http_code" -ge 200 && "$http_code" -lt 400 ]]; then
|
||||
pass "Homepage accessible (HTTP $http_code)"
|
||||
else
|
||||
fail "Homepage service discovery"
|
||||
fail "Homepage not accessible (HTTP $http_code)"
|
||||
fi
|
||||
}
|
||||
|
||||
test_tubearchivist_redis() {
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-tubearchivist" curl -sf http://ta-redis:6379 2>/dev/null || \
|
||||
docker exec "${COMPOSE_PROJECT_NAME}-ta-redis" redis-cli ping 2>/dev/null | grep -q PONG; then
|
||||
pass "TubeArchivist-Redis integration"
|
||||
check "Tube Archivist can reach Redis"
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-ta-redis" redis-cli ping 2>/dev/null | grep -q PONG; then
|
||||
pass "Redis responds to PING"
|
||||
else
|
||||
fail "TubeArchivist-Redis integration"
|
||||
fail "Redis not responding"
|
||||
fi
|
||||
}
|
||||
|
||||
test_tubearchivist_elasticsearch() {
|
||||
if docker exec "${COMPOSE_PROJECT_NAME}-tubearchivist" curl -sf http://ta-elasticsearch:9200 2>/dev/null; then
|
||||
pass "TubeArchivist-Elasticsearch integration"
|
||||
check "Elasticsearch cluster is healthy"
|
||||
local es_status
|
||||
es_status=$(docker exec "${COMPOSE_PROJECT_NAME}-ta-elasticsearch" curl -sf http://localhost:9200/_cluster/health 2>/dev/null || echo "")
|
||||
if echo "$es_status" | grep -q '"status"'; then
|
||||
pass "Elasticsearch cluster responding"
|
||||
else
|
||||
fail "TubeArchivist-Elasticsearch integration"
|
||||
fail "Elasticsearch not responding"
|
||||
fi
|
||||
}
|
||||
|
||||
echo "Running integration tests..."
|
||||
test_grafana_influxdb_integration || true
|
||||
test_dockhand_docker_integration || true
|
||||
test_homepage_discovery || true
|
||||
test_tubearchivist_redis || true
|
||||
test_tubearchivist_elasticsearch || true
|
||||
test_network_isolation() {
|
||||
check "Services are on the correct network"
|
||||
local net_count
|
||||
net_count=$(docker network inspect "${COMPOSE_NETWORK_NAME}" --format '{{range .Containers}}{{.Name}} {{end}}' 2>/dev/null | wc -w || echo "0")
|
||||
if [[ "$net_count" -ge 14 ]]; then
|
||||
pass "$net_count containers on ${COMPOSE_NETWORK_NAME}"
|
||||
else
|
||||
fail "Only $net_count containers on network (expected >= 14)"
|
||||
fi
|
||||
}
|
||||
|
||||
require_stack_running
|
||||
|
||||
echo "======================================"
|
||||
echo "Integration Tests: Service Communication"
|
||||
echo "======================================"
|
||||
echo ""
|
||||
|
||||
test_grafana_influxdb_integration
|
||||
test_dockhand_proxy_integration
|
||||
test_homepage_discovery
|
||||
test_tubearchivist_redis
|
||||
test_tubearchivist_elasticsearch
|
||||
test_network_isolation
|
||||
|
||||
echo ""
|
||||
echo "===================================="
|
||||
echo "Integration Test Results: $PASS passed, $FAIL failed"
|
||||
echo "===================================="
|
||||
echo "======================================"
|
||||
echo "RESULTS: $PASS passed, $FAIL failed"
|
||||
echo "======================================"
|
||||
[[ $FAIL -eq 0 ]]
|
||||
|
||||
Reference in New Issue
Block a user