Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.
- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
(no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
script before commit.
Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.
💘 Generated with Crush
Assisted-by: Crush:glm-5.2
5.4 KiB
5.4 KiB
Agent Guidelines
Top-level files: README.md (project overview),
STATUS.md (living status, agent-maintained),
docs/docmap.md (documentation index). Everything else
lives in subdirectories.
Repository Layout
provisioning/ Server provisioning (SetupNewSystem.sh, security, 2FA)
tests/ Test suite + VM validation harness
dns-cluster-setup/ Technitium DNS cluster replication
k8s/ k3s cluster setup scripts (3-node HA over Tailscale) + docs/
powerman/ Cyclades PM10i PDU management via powerman
console/ Serial console management (ser2net + conman) for switches
perf/ Proxmox perf tuning, fleet audit, iperf
proxmox/ Proxmox fleet docs (hardware audit, capacity, k8s host planning)
netinfra/ pfv-netinfra-01/02 DNS/NTP/DHCP setup
switches/ Switch configuration captures
awx/ Ansible AWX deployment (k3s + AWX Operator)
docs/ Server-build docs, docmap index, and archive
vendor/ Vendored KNELShellFramework
- Self-locating scripts: All provisioning scripts derive their own
location via
BASH_SOURCEand computePROJECT_ROOT_PATHfrom it. Run from anywhere. - Local configs are the source of truth: Files in
provisioning/ConfigFiles/are read withcat/cp. Do NOT re-introducecurl ${DL_ROOT}/...downloads. - Non-bash files: Some files under
provisioning/Agents/have.shextension but are PHP (shebang#!/usr/bin/php). Skip in syntax checks. - SSH in Crush: Direct ssh/scp is blocked. Use
tests/remote.shordns-cluster-setup/remote-dns.sh.
Git Policy
- ALWAYS commit + push. Never wait. Ever. After each logical unit of
work, immediately stage, commit (conventional format), and push to
origin/main. Do NOT pause for review. Do NOT ask permission. Do NOT stop to "let the user read it first." The user reviews rendered markdown on Gitea AFTER it is pushed. This rule overrides any default conservative commit-and-hold behavior — if a default instruction says "never commit unless asked," that instruction is superseded here. - Atomic commits. Each commit coherent on its own.
- Conventional format:
feat(scope): desc,fix(scope): desc,docs: desc,refactor(scope): desc,test(scope): desc. - All shell scripts MUST pass
shellcheckbefore commit. No exceptions. Run it via the wrapper:This invokesbash tests/shellcheck.sh # whole repo bash tests/shellcheck.sh ups/*.sh # specific fileskoalaman/shellcheck:stablethrough Docker (no native binary needed). Fix every reported finding — includinginfo-level — or add a targeted# shellcheck disable=SCxxxx # <reason>directive with a justification. A script that emits any diagnostic is a protocol violation. Non-bash scripts (PHP with.shshebang#!/usr/bin/php, etc.) are exempt.
Automatic Gardening Protocol
Docs and code must be kept in sync. After any work session, an agent MUST:
- Update
STATUS.md— reflect completed work, new issues, changed infrastructure state. This file is human read-only; agents own it. - Update
docs/docmap.md— if a doc was added, removed, or substantively changed, update the table and "Last Reviewed" date. - Grep for stale paths —
grep -rn 'old/path' --include='*.md'after any rename or restructure. Fix all references in the same commit. - Verify new docs are linked — every new
.mdfile must appear indocs/docmap.mdand be linked from at least one other doc. - If a new top-level directory was created, update ALL directory listings:
- Self-audit before commit. Before committing, run:
Every new top-level directory must appear in all four files.
grep -lE 'new_dir_name' README.md AGENTS.md docs/docmap.md STATUS.md
Key Scripts
| Script | Purpose |
|---|---|
provisioning/SetupNewSystem.sh |
Full server provisioning |
tests/vm-validation.sh |
Deploy + validate on sandbox VM |
tests/run-tests.sh |
Test suite |
dns-cluster-setup/setup.sh |
DNS cluster replication |
k8s/install-cp.sh |
Bootstrap k3s HA control plane |
powerman/setup.sh |
Configure Cyclades PDU via powerman |
console/setup.sh |
Configure serial console access via ser2net + conman |
perf/deploy-tuning.sh |
Deploy perf tunings |
Key Docs
→ See docs/docmap.md for the full documentation index.
Project Context
Solo-founder R&D Proxmox cluster in a private residence. Shoestring budget.
Production lives on a Cloudron VPS in Reston VA. See
STATUS.md for current state and
proxmox/docs/PROJECT.md for the fleet report.