chore: enforce shellcheck across the repo

Establish shellcheck as a mandatory pre-commit quality gate and bring all 93
shell scripts to a clean state.

- tests/shellcheck.sh: wrapper that runs koalaman/shellcheck:stable via Docker
  (no native binary needed), skips vendored + upstream librenms-agent scripts.
- .shellcheckrc: documents intentional codebase-wide disables (dynamic source
  paths SC1090/SC1091, client-side ssh expansion SC2029).
- AGENTS.md: new Git Policy rule mandating clean shellcheck for every shell
  script before commit.

Fixes applied (real bugs + quality): missing quote in netinfra/gather-configs.sh
(caused cascading parse errors), unquoted expansions, declare-and-assign masking,
egrep -> grep -E, $FUNCNAME array indexing, unused variable removal, cd || exit.
Intentional patterns (sourced config, sysfs/ps diagnostics, ssh heredocs that
expand local config) get justified targeted disables.

💘 Generated with Crush

Assisted-by: Crush:glm-5.2

This commit is contained in:

mrcharles

2026-07-30 08:56:31 -05:00

parent 54e9927167

commit 0fa0692c37

37 changed files with 226 additions and 89 deletions

									
										k8s/env.sh
									
		+1
		
												View File
												
				@@ -1,4 +1,5 @@

				#!/usr/bin/bash

				# shellcheck disable=SC2034 # sourced config file; variables are consumed by scripts that source this

				# k8s/env.sh — shared config for all k8s scripts. Source this.

				#

				# All cluster communication goes over Tailscale IPs. No LAN IPs, ever.