KNEL/KNELIAC
9
0
Fork 0
Code Pull Requests Actions Packages Releases Activity

[#454] adopt enforcement framework + STATUS; modernize librenms agent scripts

Browse Source 
check-rules green; shellcheck fixes to dpkg.sh/os-updates.sh (legacy
backticks, unquoted vars, array-quoted command builders); Discourse
pointers added to basis docs; awx/k8s/compliance repos referenced.
https://projects.knownelement.com/issues/454
This commit is contained in:
mrcharles
2026-09-05 05:35:44 -05:00
parent 2eccacd024
commit 962a8f197d
19 changed files with 829 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files
roles/oam/files/librenms/dpkg.sh
+14 -10
View File
@@ -5,18 +5,22 @@
if [ -x /usr/bin/dpkg-query ]; then
DATE=$(date +%s)
FILE=/var/cache/librenms/agent-local-dpkg
[ -d /var/cache/librenms ] || mkdir -p /var/cache/librenms
if [ ! -e $FILE ]; then
dpkg-query -W --showformat='${Status} ${Package} ${Version} ${Architecture} ${Installed-Size}\n'|grep " installed "|cut -d\ -f4- > $FILE
refresh() {
dpkg-query -W --showformat='${Status} ${Package} ${Version} ${Architecture} ${Installed-Size}\n' \
| grep " installed " | cut -d\ -f4- > "$FILE"
}
if [ ! -e "$FILE" ]; then
refresh
fi
FILEMTIME=$(stat -c %Y $FILE)
FILEAGE=$(($DATE-$FILEMTIME))
if [ $FILEAGE -gt 1800 ]; then
dpkg-query -W --showformat='${Status} ${Package} ${Version} ${Architecture} ${Installed-Size}\n'|grep " installed "|cut -d\ -f4- > $FILE
FILEMTIME=$(stat -c %Y "$FILE")
FILEAGE=$((DATE - FILEMTIME))
if [ "$FILEAGE" -gt 1800 ]; then
refresh
fi
echo "<<<dpkg>>>"
cat $FILE
cat "$FILE"
fi
roles/oam/files/librenms/os-updates.sh
+28 -28
View File
@@ -9,62 +9,62 @@
# restart snmpd and activate the app for desired host #
#--------------------------------------------------------------#
# please make sure you have the path/binaries below #
################################################################
################################################################
BIN_WC='/usr/bin/wc'
BIN_GREP='/bin/grep'
CMD_GREP='-c'
CMD_WC='-l'
CMD_GREP=(-c)
CMD_WC=(-l)
BIN_ZYPPER='/usr/bin/zypper'
CMD_ZYPPER='-q lu'
CMD_ZYPPER=(-q lu)
BIN_YUM='/usr/bin/yum'
CMD_YUM='-q check-update'
CMD_YUM=(-q check-update)
BIN_DNF='/usr/bin/dnf'
CMD_DNF='-q check-update'
CMD_DNF=(-q check-update)
BIN_APT='/usr/bin/apt-get'
CMD_APT='-qq -s upgrade'
CMD_APT=(-qq -s upgrade)
BIN_PACMAN='/usr/bin/pacman'
CMD_PACMAN='-Sup'
CMD_PACMAN=(-Sup)
################################################################
# Don't change anything unless you know what are you doing #
################################################################
if [ -f $BIN_ZYPPER ]; then
if [ -f "$BIN_ZYPPER" ]; then
# OpenSUSE
UPDATES=`$BIN_ZYPPER $CMD_ZYPPER | $BIN_WC $CMD_WC`
if [ $UPDATES -ge 2 ]; then
echo $(($UPDATES-2));
UPDATES=$("$BIN_ZYPPER" "${CMD_ZYPPER[@]}" | "$BIN_WC" "${CMD_WC[@]}")
if [ "$UPDATES" -ge 2 ]; then
echo $((UPDATES - 2));
else
echo "0";
fi
elif [ -f $BIN_DNF ]; then
elif [ -f "$BIN_DNF" ]; then
# Fedora
UPDATES=`$BIN_DNF $CMD_DNF | $BIN_WC $CMD_WC`
if [ $UPDATES -ge 1 ]; then
echo $(($UPDATES-1));
UPDATES=$("$BIN_DNF" "${CMD_DNF[@]}" | "$BIN_WC" "${CMD_WC[@]}")
if [ "$UPDATES" -ge 1 ]; then
echo $((UPDATES - 1));
else
echo "0";
fi
elif [ -f $BIN_PACMAN ]; then
elif [ -f "$BIN_PACMAN" ]; then
# Arch
UPDATES=`$BIN_PACMAN $CMD_PACMAN | $BIN_WC $CMD_WC`
if [ $UPDATES -ge 1 ]; then
echo $(($UPDATES-1));
UPDATES=$("$BIN_PACMAN" "${CMD_PACMAN[@]}" | "$BIN_WC" "${CMD_WC[@]}")
if [ "$UPDATES" -ge 1 ]; then
echo $((UPDATES - 1));
else
echo "0";
fi
elif [ -f $BIN_YUM ]; then
elif [ -f "$BIN_YUM" ]; then
# CentOS / Redhat
UPDATES=`$BIN_YUM $CMD_YUM | $BIN_WC $CMD_WC`
if [ $UPDATES -ge 1 ]; then
echo $(($UPDATES-1));
UPDATES=$("$BIN_YUM" "${CMD_YUM[@]}" | "$BIN_WC" "${CMD_WC[@]}")
if [ "$UPDATES" -ge 1 ]; then
echo $((UPDATES - 1));
else
echo "0";
fi
elif [ -f $BIN_APT ]; then
elif [ -f "$BIN_APT" ]; then
# Debian / Devuan / Ubuntu
UPDATES=`$BIN_APT $CMD_APT | $BIN_GREP $CMD_GREP 'Inst'`
if [ $UPDATES -ge 1 ]; then
echo $UPDATES;
UPDATES=$("$BIN_APT" "${CMD_APT[@]}" | "$BIN_GREP" "${CMD_GREP[@]}" 'Inst')
if [ "$UPDATES" -ge 1 ]; then
echo "$UPDATES";
else
echo "0";
fi