ExternalVendorCode/trick
1
0
Fork 0
mirror of https://github.com/nasa/trick.git synced 2024-12-19 21:27:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable setting TCP_NODELAY on UDP sockets

Browse Source 
The TCP_NODELAY socket option disables Nagle's algorithm on TCP sockets,
improving latency at the cost of throughput. This option is
TCP-specific, and it is an error to use it on any other kind of socket,
including UDP. It is also unnecessary, since UDP is datagram-based and
does not buffer data to be transmitted.
This commit is contained in:
Thadeus Fleming 2019-01-28 10:32:32 -06:00
parent 2a059719ba
commit 60c4120f98
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
trick_source/trick_utils/comm/src/tc_init_udp_client.c
View File

@ -29,7 +29,6 @@ int tc_init_udp_client(TCDevice * udp_client_device)
int debug = 1;
int on = 1;
struct hostent *h;
int the_socket;
struct sockaddr_in sockin;
@ -60,10 +59,6 @@ int tc_init_udp_client(TCDevice * udp_client_device)
return (TC_COULD_NOT_OPEN_SOCKET);
}
/* Turn off data buffering. This causes data to be sent immediately rather than queuing it up until the transmit
buffer is filled. */
setsockopt(the_socket, IPPROTO_TCP, TCP_NODELAY, (const char *) &on, (socklen_t) sizeof(on));
sockin.sin_family = TRICKCOMM_SOCKET_FAMILY;
sockin.sin_addr.s_addr = htonl(INADDR_ANY);
sockin.sin_port = htons(0);

6
trick_source/trick_utils/comm/src/tc_init_udp_server.c
View File

@ -59,12 +59,6 @@ int tc_init_udp_server( /* RETURN: -- 0 for success */
return (-1);
}
/* Turn off data buffering. This causes data to be written immediately to the receiving socket rather than queing
it up until the transmit buffer is filled. */
setsockopt(udp_server_device->socket, IPPROTO_TCP, TCP_NODELAY, (const char *) &yes, (socklen_t) sizeof(yes));
sockin.sin_addr.s_addr = INADDR_ANY;
sockin.sin_family = TRICKCOMM_SOCKET_FAMILY;
sockin.sin_port = htons((short) (udp_server_device->port));