Commit Graph

8462 Commits

Author SHA1 Message Date
Jean-Paul Calderone
13dae392cb Go with a shorter name 2021-08-11 14:41:18 -04:00
Jean-Paul Calderone
6931d10ace Fix mis-merge: use argv parameter instead of sys.argv 2021-08-11 14:40:22 -04:00
Jean-Paul Calderone
975f268d8d Provide enough output to debug the failure 2021-08-11 14:39:32 -04:00
Jean-Paul Calderone
fd3d3bc688 Give the py3 static checker something to resolve unicode to
It's pretty much just a bug in the static checker. :/
2021-08-11 14:27:21 -04:00
Jean-Paul Calderone
1d75bbfd72 str is a kind of weird future thing; coerce another way 2021-08-11 14:25:47 -04:00
Jean-Paul Calderone
4d41e30ce9 Just pass unicode at this layer 2021-08-11 14:25:40 -04:00
Jean-Paul Calderone
d56c218586 Options are defined with unicode now; argv better be unicode. 2021-08-11 14:25:24 -04:00
Jean-Paul Calderone
0176583e75 Get a text-mode FilePath in a py3 compatible way 2021-08-11 13:32:04 -04:00
Jean-Paul Calderone
2244f0374e fail more informatively 2021-08-11 13:31:07 -04:00
Jean-Paul Calderone
5f6ae1f8f5 Fix mis-merge: don't try to stripe argv[0] twice 2021-08-11 13:30:52 -04:00
Jean-Paul Calderone
ffbcbf78a7 Send the warning to the parameterized stderr 2021-08-11 13:30:39 -04:00
Jean-Paul Calderone
9632b35abe Fix mismerge: Put Py3 warning back 2021-08-11 13:19:15 -04:00
Jean-Paul Calderone
15312009ce Fix mis-merge: This test moved to test_run.py 2021-08-11 12:58:51 -04:00
Jean-Paul Calderone
66d40527d1 Merge remote-tracking branch 'origin/master' into 3528.test_cli-no-mock 2021-08-11 12:56:00 -04:00
fenn-cs
a6b7c07e1c added missing parathensis, ran yapf
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2021-08-10 10:13:00 +01:00
fenn-cs
7ad3fa9e25 correct use of succeeded, remove trailing spaces and unused import
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2021-08-09 23:46:30 +01:00
fenn-cs
90e84730e5 Fixes 3757 : Refactored test_introducer in web tests to use custom base test cases
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2021-08-08 21:49:02 +01:00
Itamar Turner-Trauring
d060af641a Python 3 port is essentially done-get rid of relevant tests and tracking code. 2021-07-30 11:13:57 -04:00
Itamar Turner-Trauring
af49dcb89e On Python 2 we don't need to convert byte keys to unicode. 2021-07-05 16:35:06 -07:00
Itamar Turner-Trauring
e0b4cf057e Fix logging of bytes in Foolscap on Python 3. 2021-07-05 16:03:24 -07:00
Itamar Turner-Trauring
7deec790a6
Merge pull request #1084 from tahoe-lafs/3736.frontends-auth-python-3
Port allmydata.frontend.auth to Python 3

Fixes ticket:3736
2021-06-23 09:04:48 -04:00
Itamar Turner-Trauring
83b4fb88f4
Merge pull request #1085 from tahoe-lafs/3738.failing-unicode-upload-regression-python-2
Fix bug where uploading files with Unicode filenames failed on Python 2

Fixes ticket:3738
2021-06-23 09:04:31 -04:00
Itamar Turner-Trauring
3f98349cd9 Limit Pickle protocol to version supported by Python 2. 2021-06-16 11:53:25 -04:00
Itamar Turner-Trauring
f778d25c44 Apply same fix to success path. 2021-06-15 14:05:49 -04:00
Itamar Turner-Trauring
e8308043e3 Method that doesn't break on Python 3. 2021-06-15 14:03:58 -04:00
Itamar Turner-Trauring
3461665ccf Get rid of annoying warning. 2021-06-15 13:56:34 -04:00
Itamar Turner-Trauring
d74ef0798d Fix quoting to work on Python 2. 2021-06-15 13:46:22 -04:00
Itamar Turner-Trauring
473654ccb7 Test demonstrating the problem. 2021-06-15 13:46:06 -04:00
Itamar Turner-Trauring
2447d09fc0 Port to Python 3. 2021-06-14 11:58:48 -04:00
Itamar Turner-Trauring
aa809669db Add a couple more tests for more complete coverage. 2021-06-14 11:51:18 -04:00
Itamar Turner-Trauring
f48cf88f35 Fix flake. 2021-06-03 09:45:29 -04:00
Itamar Turner-Trauring
293cea6fd2 Port to Python 3. 2021-06-03 09:40:11 -04:00
Itamar Turner-Trauring
279d6b6542 Port to Python 3. 2021-06-03 09:39:13 -04:00
Itamar Turner-Trauring
cb1e591c6e Port to Python 3. 2021-06-03 09:37:59 -04:00
Itamar Turner-Trauring
77676c1648 Port to Python 3. 2021-06-03 09:36:22 -04:00
Itamar Turner-Trauring
cf68f55039 Port to Python 3. 2021-06-03 09:34:42 -04:00
Itamar Turner-Trauring
58d6f9f6cf Port to Python 3. 2021-06-03 09:28:10 -04:00
Itamar Turner-Trauring
53482dd8ac Port to Python 3. 2021-06-03 09:26:24 -04:00
Itamar Turner-Trauring
a910ebcc8a Fix flakes. 2021-06-02 11:31:32 -04:00
Itamar Turner-Trauring
defe16f912 Port to Python 3. 2021-06-02 11:30:19 -04:00
Itamar Turner-Trauring
9804a44c50 Port to Python 3. 2021-06-02 11:19:45 -04:00
Itamar Turner-Trauring
61fdea9043 Port to Python 3. 2021-06-02 10:19:30 -04:00
Itamar Turner-Trauring
9d5f1ad735 Port to Python 3. 2021-06-02 10:14:59 -04:00
Itamar Turner-Trauring
464b7055c2 Port to Python 3. 2021-06-02 10:12:05 -04:00
Itamar Turner-Trauring
a0744ffa8c Don't shadow builtin. 2021-06-02 09:54:57 -04:00
Itamar Turner-Trauring
43138d16d1 Merge branch '3716.allmydata-scripts-python-3-part-1' into 3718.allmydata-scripts-python-3-part-2 2021-05-28 11:28:23 -04:00
Itamar Turner-Trauring
b509ff69fc Flake fix. 2021-05-28 11:25:16 -04:00
Itamar Turner-Trauring
64f6ccd17f Make --exclude-from behavior consistent, at the cost of a minor incompatibility. 2021-05-28 09:53:28 -04:00
Itamar Turner-Trauring
69c8305ae8 Flake fix. 2021-05-27 13:55:29 -04:00
Itamar Turner-Trauring
8be4acd7ec Faking sys.stdout doesn't go well since we lookup encoding attribute. 2021-05-27 13:54:37 -04:00
Itamar Turner-Trauring
eddd9550f0 Pass test. 2021-05-27 13:26:56 -04:00
Itamar Turner-Trauring
8aa3391276 Consistent behavior. 2021-05-27 13:26:46 -04:00
Itamar Turner-Trauring
0425b64041 Match current logic. 2021-05-27 13:26:23 -04:00
Itamar Turner-Trauring
49be6906c8 Fix test. 2021-05-27 13:07:56 -04:00
Itamar Turner-Trauring
d78e9d891d Passing test. 2021-05-27 11:40:59 -04:00
Itamar Turner-Trauring
741af0b0eb Fix imports. 2021-05-26 15:27:16 -04:00
Itamar Turner-Trauring
0a9b3a4003 Don't want pdb. 2021-05-26 15:17:57 -04:00
Itamar Turner-Trauring
827e2e1d03 Merge remote-tracking branch 'origin/master' into 3716.allmydata-scripts-python-3-part-1 2021-05-26 15:06:01 -04:00
Itamar Turner-Trauring
d967c6de98
Merge pull request #1067 from tahoe-lafs/3700.byteswarning-windows
Run (and pass) Python 3 unit tests on Windows

Fixes ticket:3700
Fixes ticket:3701
2021-05-26 14:43:50 -04:00
Itamar Turner-Trauring
7f70315c83 Skip tests on Python 3. 2021-05-25 14:49:44 -04:00
Itamar Turner-Trauring
52cd90941f Actually use the encoding. 2021-05-25 14:29:22 -04:00
Itamar Turner-Trauring
2c7a4c7e07 Try to fix Windows failure on Python 3. 2021-05-25 11:45:36 -04:00
Itamar Turner-Trauring
cf299684c2 Unneeded. 2021-05-25 10:40:44 -04:00
Itamar Turner-Trauring
8ca6a72396 Write out the file in an encoding that matches what the reader expects. 2021-05-24 10:50:49 -04:00
Itamar Turner-Trauring
0966ce17aa Try to fix on Windows. 2021-05-24 10:33:21 -04:00
Itamar Turner-Trauring
7e8e93200f Don't "fix" things on Python 3 that are already fixed. 2021-05-24 10:13:08 -04:00
Itamar Turner-Trauring
9e6915ca78 Not used. 2021-05-21 11:12:41 -04:00
Itamar Turner-Trauring
1e9dfd2fce Another test. 2021-05-21 11:01:17 -04:00
Itamar Turner-Trauring
bb74b7fe0c Note this code is buggy. 2021-05-21 11:01:00 -04:00
Itamar Turner-Trauring
01db931192 A test that doesn't really increase coverage much. Ideally this would test immutable directories to test caching logic, but that's too much of a pain. Since I already have this written, going to leave in cause why not. 2021-05-18 13:35:34 -04:00
Itamar Turner-Trauring
1fa6ce97e1 Merge remote-tracking branch 'origin/master' into 3714-cli-testing-coverage 2021-05-17 12:59:57 -04:00
Itamar Turner-Trauring
073f521cc1 WIP 2021-05-17 12:59:38 -04:00
Itamar Turner-Trauring
f73f601f67 Port to Python 3. 2021-05-17 10:35:16 -04:00
Itamar Turner-Trauring
693e98e3a7 Port to Python 3. 2021-05-17 10:05:44 -04:00
Itamar Turner-Trauring
1b87312652 Port to Python 3. 2021-05-17 09:58:59 -04:00
Itamar Turner-Trauring
bf133be195 Port to Python 3. 2021-05-17 09:56:13 -04:00
Itamar Turner-Trauring
1e0bf545ba Port to Python 3. 2021-05-17 09:47:07 -04:00
Itamar Turner-Trauring
c92bf72437 Add missing comma. 2021-05-17 09:36:43 -04:00
Itamar Turner-Trauring
e0cab75cc6 Merge branch '3709-even-more-integration-tests-python-3' into 3716.allmydata-scripts-python-3-part-1 2021-05-14 10:51:52 -04:00
Itamar Turner-Trauring
0655b02050 Port to Python 3. 2021-05-14 10:50:04 -04:00
Itamar Turner-Trauring
7c170317c0 Remove some cruft. 2021-05-14 10:41:53 -04:00
Itamar Turner-Trauring
e3f0795550 Port to Python 3. 2021-05-14 10:31:26 -04:00
Itamar Turner-Trauring
bcf2374dfe Port to Python 3. 2021-05-14 10:27:07 -04:00
Itamar Turner-Trauring
a2280b7660 Port to Python 3. 2021-05-14 10:22:07 -04:00
Itamar Turner-Trauring
66f53fada8 Port to Python 3. 2021-05-14 09:46:15 -04:00
Itamar Turner-Trauring
250ca3170d Port to Python 3. 2021-05-14 09:42:13 -04:00
Itamar Turner-Trauring
04058e942c
Merge branch 'master' into 3709-even-more-integration-tests-python-3 2021-05-14 09:31:20 -04:00
Itamar Turner-Trauring
b330eb3b6f Merge remote-tracking branch 'origin/master' into 3709-even-more-integration-tests-python-3 2021-05-13 11:27:13 -04:00
Itamar Turner-Trauring
22a0f1d72e Merge remote-tracking branch 'origin/master' into 3707-more-integration-python-3 2021-05-13 11:23:36 -04:00
Itamar Turner-Trauring
330de25061
Merge pull request #1056 from tahoe-lafs/3703.integration-tests-python-3
First integration tests running on Python 3

Fixes ticket:3703
2021-05-13 11:20:54 -04:00
Itamar Turner-Trauring
4c1f65d97a Test for leading slash check. 2021-05-13 10:52:12 -04:00
Itamar Turner-Trauring
c4c053a37d Fix failing tests on Python 3. 2021-05-12 12:02:22 -04:00
Itamar Turner-Trauring
8741c33b35 Needs to be in separate list since it's not checked. 2021-05-12 11:58:02 -04:00
Itamar Turner-Trauring
c4dd8dde27 Flake. 2021-05-12 11:51:47 -04:00
Itamar Turner-Trauring
a0bdc57a5e Flake fix. 2021-05-12 11:10:42 -04:00
Itamar Turner-Trauring
7aa3c9c3ba Use passed-in encoding. 2021-05-12 11:06:26 -04:00
Itamar Turner-Trauring
22f8b9b428 Port to Python 3. 2021-05-12 09:25:52 -04:00
Itamar Turner-Trauring
079041fc1e Port to Python 3. 2021-05-12 09:22:33 -04:00
Itamar Turner-Trauring
e2ce207fdd Don't convert bytes to unicode implicitly. 2021-05-12 09:13:55 -04:00
Itamar Turner-Trauring
fba23ef91c Port to Python 3. 2021-05-11 13:34:35 -04:00
Itamar Turner-Trauring
070691caa2 Make sure it always goes to stderr. 2021-05-11 13:18:03 -04:00
Itamar Turner-Trauring
9b6067dcd1 Make test match reality, and fix corresponding bug. 2021-05-11 13:18:03 -04:00
Itamar Turner-Trauring
b8b00fa2da Port to Python 3. 2021-05-11 11:13:52 -04:00
Itamar Turner-Trauring
9baedc97db Auth token needs to be bytes, apparently. 2021-05-11 11:09:59 -04:00
Itamar Turner-Trauring
03c1376a30 Try to fix the test. 2021-05-10 13:04:44 -04:00
Itamar Turner-Trauring
37bcaf6c88 Port initialization "tests". 2021-05-10 11:51:41 -04:00
Itamar Turner-Trauring
02e699347e Mark tests as ported. 2021-05-10 11:49:21 -04:00
Itamar Turner-Trauring
430bc51e29 SFTP integration tests pass on Python 3. 2021-05-10 11:41:59 -04:00
Itamar Turner-Trauring
1257fc18c8 Additional test coverage and corresponding bug fixes for password auth on Python 3. 2021-05-10 11:10:52 -04:00
Itamar Turner-Trauring
a843210b26 Merge branch '3703.integration-tests-python-3' into 3707-more-integration-python-3 2021-05-10 10:38:02 -04:00
Itamar Turner-Trauring
150b0fd3a3 This code should only run on Python 3. 2021-05-10 10:31:12 -04:00
Itamar Turner-Trauring
905ea9cafd Make stdio emulation more realistic, to trigger problem that was previously
missed by tests.
2021-05-10 10:30:15 -04:00
Itamar Turner-Trauring
7c2f9e7d8c Fix test to match real-world types. 2021-05-10 10:19:21 -04:00
Itamar Turner-Trauring
add20d8024 First pass at integration support on Python 3. 2021-05-10 10:01:14 -04:00
Itamar Turner-Trauring
aa22c6e59b
Merge pull request #1055 from tahoe-lafs/3705.python3-normal-trial
Run all unit tests on Python 3 unconditionally

Fixes ticket:3705
2021-05-10 09:59:30 -04:00
Itamar Turner-Trauring
1fbeb6e54e It's gone. 2021-05-07 13:43:20 -04:00
Itamar Turner-Trauring
930329126d One final test module to port to Python 3 (nominally). 2021-05-07 13:28:01 -04:00
Itamar Turner-Trauring
ad05abd2f7 Just run unit tests normally on Python 3. 2021-05-07 13:25:57 -04:00
Itamar Turner-Trauring
04fc8e7046 Port to Python 3. 2021-05-07 13:21:23 -04:00
Itamar Turner-Trauring
b11cc9137b Integration test passed on Python 3. 2021-05-07 10:48:50 -04:00
Itamar Turner-Trauring
d25140b847 Fix flakes on Python 3. 2021-05-07 09:36:01 -04:00
Itamar Turner-Trauring
4ff8a2a09c Pretty sure reactor implements IReactorSocket on Windows on Python 3, but that's
still not enough for this functionality to work (and it might be a Twisted bug).
2021-05-05 12:59:06 -04:00
Itamar Turner-Trauring
da5c38b7ca Fix a NameError. 2021-05-05 12:39:42 -04:00
Itamar Turner-Trauring
8af84b7a0c Fix tests on Python 3.9 (apparently encoding is no-op on Python 3, and Python
always assumes utf-8 by default anyway for JSON).
2021-05-05 11:57:13 -04:00
Itamar Turner-Trauring
fa4be104a6 New name for module. 2021-05-05 11:31:19 -04:00
Itamar Turner-Trauring
1ed24a1616 This API is irrelevant in Python 2.5 or later, and not present in newer Python 3. 2021-05-05 11:22:17 -04:00
Itamar Turner-Trauring
65159c9961 Use modern (and actually correct on Windows!) API for getting CPU time. 2021-05-05 10:37:49 -04:00
Itamar Turner-Trauring
90240ae5ef Tests pass on Python 3. 2021-05-04 12:03:12 -04:00
Itamar Turner-Trauring
07b58e3619 All tests pass on Python 3. 2021-05-04 11:34:58 -04:00
Itamar Turner-Trauring
cc176342d4 Some progress towards test_system.py fully running on Python 3. 2021-05-04 11:22:12 -04:00
Itamar Turner-Trauring
7411da1b88 Port to Python 3. 2021-05-04 10:57:45 -04:00
Itamar Turner-Trauring
4c6d55b260 Port to Python 3. 2021-05-04 10:52:55 -04:00
Itamar Turner-Trauring
c589e97cde All tests pass on Python 3. 2021-05-04 10:40:43 -04:00
Itamar Turner-Trauring
a4af4d8e5b Even more passing tests on Python 3. 2021-05-04 10:36:27 -04:00
Itamar Turner-Trauring
deaaa8c727 More tests passing on Python 3. 2021-05-04 10:27:26 -04:00
Itamar Turner-Trauring
75deef906d More progress towards running tests on Python 3. 2021-05-04 10:12:07 -04:00
Itamar Turner-Trauring
7349855ce4 Move unicode conversion higher up. 2021-05-04 10:00:27 -04:00
Itamar Turner-Trauring
ae739dfd9e Python 3 updates. 2021-05-03 11:48:02 -04:00
Itamar Turner-Trauring
d3be3ce1e6 Start making tests pass on Python 3. 2021-05-03 11:43:31 -04:00
Itamar Turner-Trauring
1f70d5c13a Port to Python 3. 2021-05-03 11:21:23 -04:00
Itamar Turner-Trauring
f9ae91a94e Tests pass on Python 3. 2021-05-03 11:20:16 -04:00
Itamar Turner-Trauring
a7d4fed1ba Port to Python 3. 2021-05-03 11:15:10 -04:00
Itamar Turner-Trauring
9dcfa2171e Tests pass on Python 3. 2021-05-03 11:13:27 -04:00
Itamar Turner-Trauring
2b751c44db Port to Python 3. 2021-05-03 11:10:54 -04:00
Itamar Turner-Trauring
c275f9ae54 Tests pass on Python 3. 2021-05-03 10:47:30 -04:00
Itamar Turner-Trauring
99543877d6 Fix flake. 2021-05-03 10:27:43 -04:00
Itamar Turner-Trauring
b3ede6b9f2 Nicer way to say the same thing. 2021-05-03 10:25:48 -04:00
Itamar Turner-Trauring
f6b5628ce1 Port to Python 3. 2021-04-30 11:33:51 -04:00
Itamar Turner-Trauring
463f9fe802 Tests pass on Python 3. 2021-04-30 11:31:25 -04:00
Itamar Turner-Trauring
da8e0d61aa Port to Python 3. 2021-04-30 11:15:48 -04:00
Itamar Turner-Trauring
3846df8e4f All test_create_alias tests pass on Python 3. 2021-04-30 11:06:31 -04:00
Itamar Turner-Trauring
46c03f6b75 Remove duplication, and add support for testing cases where stdin/stdout/stderr
have to be bytes.
2021-04-30 11:05:56 -04:00
Itamar Turner-Trauring
2f6535e26e First test passes on Python 3. 2021-04-30 10:33:59 -04:00
Itamar Turner-Trauring
e48d85dd8b Merge branch '3679.more-cli-tests-python-3' into 3687.cli-tests-python-3 2021-04-30 10:22:47 -04:00
Itamar Turner-Trauring
e56a8cc1f3 Merge branch '3678.cli-tests-python-3' into 3679.more-cli-tests-python-3 2021-04-30 10:20:27 -04:00
Itamar Turner-Trauring
72a85ba624 Fix lint. 2021-04-30 10:19:59 -04:00
Itamar Turner-Trauring
9137da5483 Stick to Unicode when possible. 2021-04-30 10:16:41 -04:00
Itamar Turner-Trauring
ef36e0e02a Merge remote-tracking branch 'origin/master' into 3678.cli-tests-python-3 2021-04-28 13:17:37 -04:00
Itamar Turner-Trauring
904b423b48 Merge remote-tracking branch 'origin/master' into 3672.non-utf-8-bytes-in-logs 2021-04-28 13:17:07 -04:00
Itamar Turner-Trauring
2ad8a47455 Fix flake. 2021-04-26 09:59:18 -04:00
Itamar Turner-Trauring
04a09558b6 Port to Python 3. 2021-04-26 09:54:35 -04:00
Itamar Turner-Trauring
eb5211672c Tests pass on Python 3. 2021-04-26 09:46:21 -04:00
Jason R. Coombs
6142168977
Merge pull request #1038 from tahoe-lafs/3652.remove-account.url
3652 Remove STFPd account.url support.
2021-04-23 10:21:53 -04:00
Itamar Turner-Trauring
b85d735b8b Even more progress towards Python 3 tests passing. 2021-04-22 10:43:55 -04:00
Itamar Turner-Trauring
56e4385103 More progress towards Python 3 tests passing. 2021-04-22 10:36:10 -04:00
Itamar Turner-Trauring
5927e14ece Merge branch '3678.cli-tests-python-3' into 3679.more-cli-tests-python-3 2021-04-22 10:28:26 -04:00
Itamar Turner-Trauring
a393b54315 Fix BytesWarning errors. 2021-04-22 10:27:59 -04:00
Itamar Turner-Trauring
b675ca2380 Lint fix. 2021-04-22 10:23:58 -04:00
Itamar Turner-Trauring
2aac69e0df More passing tests on Python 3. 2021-04-22 10:20:26 -04:00
Itamar Turner-Trauring
416813578a Some progress towards passing tests on Python 3. 2021-04-22 10:18:59 -04:00
Itamar Turner-Trauring
86fe350bef Tests pass on Python 2. 2021-04-22 10:15:43 -04:00
Itamar Turner-Trauring
567c0f019e Test random bytes. 2021-04-22 09:39:50 -04:00
Itamar Turner-Trauring
5ebb385c10 Port to Python 3. 2021-04-21 11:58:48 -04:00
Itamar Turner-Trauring
f6e0611b07 All tests pass on Python 3. 2021-04-21 11:42:05 -04:00
Itamar Turner-Trauring
5e59b9d8d6 A little closer to passing tests on Python 3. 2021-04-21 11:32:42 -04:00
Itamar Turner-Trauring
83e16d40a4 Some tests passing on Python 3. 2021-04-21 11:18:36 -04:00
Itamar Turner-Trauring
e090891935 In PyPy encode() doesn't call iterencode(). 2021-04-21 10:39:27 -04:00
Itamar Turner-Trauring
08cb514eee Correct parameter name. 2021-04-21 10:09:26 -04:00
Itamar Turner-Trauring
6e8dde3b14 Simplify. 2021-04-21 10:09:03 -04:00
Jason R. Coombs
1b46f981c6 Remove AccountURLChecker, the code that relies on it, associated tests, and docs. 2021-04-17 17:01:15 -04:00
Itamar Turner-Trauring
abb247b3cc Fix flake. 2021-04-16 12:01:07 -04:00
Itamar Turner-Trauring
fa46efdb3a Enable BytesWarnings in integration tests. 2021-04-16 11:58:37 -04:00
Itamar Turner-Trauring
61506f87bb Make BytesWarning->exception global, to ease use in integration tests. 2021-04-16 11:55:20 -04:00
Itamar Turner-Trauring
bc9e4ac728 Support quoting any-old-bytes correctly on Python 2. 2021-04-16 11:36:53 -04:00
Itamar Turner-Trauring
51ebbae15a Fix typo. 2021-04-16 11:21:47 -04:00
Itamar Turner-Trauring
19a3481e5f
Merge pull request #1042 from tahoe-lafs/3626.streaming-logs-with-bytes
Handle bytes in log messages streamed over websocket

Fixes ticket:3626
2021-04-16 11:21:28 -04:00
Itamar Turner-Trauring
d60bc2841a Oh right, Python 2 Eliot doesn't support custom JSON encoders. 2021-04-14 11:19:04 -04:00
Itamar Turner-Trauring
32607b5ada For logging, using a new JSON bytes encoder that works on any bytes string, not
just UTF-8-encoded strings.
2021-04-14 10:42:01 -04:00
Itamar Turner-Trauring
e242bf50c7 Handle bytes in log messages. 2021-04-14 09:56:27 -04:00
Itamar Turner-Trauring
953c06a18d Fix some plain-str()-of-bytes bugs. 2021-04-13 09:53:08 -04:00
Itamar Turner-Trauring
2299c2dcc8 Fix implicit str(bytesobj). 2021-04-13 09:40:24 -04:00
Itamar Turner-Trauring
4ea1f153cc
Merge pull request #1039 from tahoe-lafs/3674.cli-tests-python-3
Port a bit more cli tests python 3

Fixes ticket:3674
2021-04-13 09:39:13 -04:00
Itamar Turner-Trauring
cbd816fbd5 Ensure warnings get turned into exceptions. Getting sneaking suspicion it's passing in filenames sometimes, not just modules. 2021-04-13 09:34:55 -04:00
Itamar Turner-Trauring
3a832efc15 Merge branch '3674.cli-tests-python-3' into 3675.byteswarning-as-error-again 2021-04-13 09:22:16 -04:00
Itamar Turner-Trauring
b0e6c86085 Better error messages. 2021-04-13 09:21:26 -04:00
Itamar Turner-Trauring
43620a3c19 Port to Python 3. 2021-04-12 12:53:17 -04:00
Itamar Turner-Trauring
c3d2a26ee5 Remove unused imports. 2021-04-12 10:27:00 -04:00
Itamar Turner-Trauring
a0302c50da Fix a BytesWarning. 2021-04-12 10:25:15 -04:00
Itamar Turner-Trauring
2554112045 Handle Python 3 case where stdout by default is Unicode. 2021-04-12 10:17:12 -04:00
Itamar Turner-Trauring
e6532305bf Match Python 3 behavior for stdout/stderr. 2021-04-12 10:17:01 -04:00
Itamar Turner-Trauring
8512bdcd8d Even more progress towards passing Python 3 tests. 2021-04-12 09:51:53 -04:00
Itamar Turner-Trauring
069fcb91eb More progress towards passing Python 3 tests. 2021-04-12 09:35:34 -04:00
Itamar Turner-Trauring
06c4ed13b7 Some progress towards passing Python 3 tests. 2021-04-12 09:28:51 -04:00
Itamar Turner-Trauring
d6406d5edb Some progress towards passing backup tests on Python 3. 2021-04-07 10:44:48 -04:00
Itamar Turner-Trauring
9a17c4a5d2 Port to Python 3. 2021-04-07 09:28:04 -04:00
Itamar Turner-Trauring
803e00f6b1 Tests pass on Python 3. 2021-04-07 09:26:28 -04:00
Itamar Turner-Trauring
6f74bb7d88 Merge remote-tracking branch 'origin/master' into 3671.more-test-utilities-python-3 2021-04-07 09:11:31 -04:00
Itamar Turner-Trauring
01f75db2da
Merge pull request #1034 from tahoe-lafs/3667.test-utilities-python-3
Port more of allmydata.test utility modules to Python 3

Fixes ticket:3667
2021-04-07 09:10:46 -04:00
Itamar Turner-Trauring
ddcca38f31 Port to Python 3. 2021-04-06 10:51:14 -04:00
Itamar Turner-Trauring
315bb672d1 Port to Python 3. 2021-04-06 10:49:00 -04:00
Itamar Turner-Trauring
3429f8bf03 Port to Python 3. 2021-04-06 10:45:58 -04:00
Itamar Turner-Trauring
2257f89d39 More semantically robust test. 2021-04-06 10:45:44 -04:00
Itamar Turner-Trauring
044c79c4db Port to Python 3. 2021-04-06 10:29:29 -04:00
Itamar Turner-Trauring
ae7680759d Another checker script. 2021-04-06 10:22:47 -04:00
Itamar Turner-Trauring
abe3fbc2e5 Empty file. 2021-04-06 10:22:30 -04:00
Itamar Turner-Trauring
7f4a99306b No need to port to Python 3. 2021-04-06 10:04:18 -04:00
Itamar Turner-Trauring
3841662ee6 Fix tests on Python 3. 2021-04-06 09:23:31 -04:00
Itamar Turner-Trauring
7b5cb13417 Flake fix. 2021-04-05 13:02:17 -04:00
Itamar Turner-Trauring
57aa798814 Delete another item that was deleted. 2021-04-05 13:01:23 -04:00
Itamar Turner-Trauring
3bc9b0d544 Port to Python 3. 2021-04-05 13:00:27 -04:00
Itamar Turner-Trauring
74e9bdd476 No point in having separate module. 2021-04-05 12:56:42 -04:00
Itamar Turner-Trauring
a11b47785f Port to Python 3. 2021-04-05 12:52:42 -04:00
Itamar Turner-Trauring
a367d333d9 Port to Python 3. 2021-04-05 12:04:09 -04:00
Itamar Turner-Trauring
625a0abb02 Port to Python 3. 2021-04-05 11:37:32 -04:00
Itamar Turner-Trauring
a37121f89c Already ported. 2021-04-05 11:34:51 -04:00
Itamar Turner-Trauring
84e32882b4 These don't belong in tests module. 2021-04-05 11:30:33 -04:00
Itamar Turner-Trauring
80385aea8e Port to Python 3. 2021-04-05 11:29:13 -04:00
Itamar Turner-Trauring
eedc8f23cf Delete some unused code. 2021-04-05 11:28:59 -04:00
Itamar Turner-Trauring
b981e90de3 Tahoe-LAFS now relies on a sufficiently new version of Twisted, which includes this bugfix. 2021-04-05 11:28:59 -04:00
Itamar Turner-Trauring
d214fe3f16 Delete unused imports. 2021-04-02 13:00:05 -04:00
Itamar Turner-Trauring
9a96fec604 Use existing IRemoteReference implementation. 2021-04-02 12:56:49 -04:00
Itamar Turner-Trauring
c21288b3dd Make it easier to read. 2021-04-02 12:49:58 -04:00
Itamar Turner-Trauring
dd6e0d5467 Switch to decode_furl(). 2021-04-02 12:49:01 -04:00
Itamar Turner-Trauring
939f1f840b Fix reference to new location. 2021-04-02 12:48:50 -04:00
Itamar Turner-Trauring
fd1860705e Port to Python 3. 2021-04-01 10:58:50 -04:00
Itamar Turner-Trauring
003e9c62a8 Delete unused code paths. 2021-04-01 10:58:27 -04:00
Itamar Turner-Trauring
e92b88195c Port to Python 3. 2021-04-01 10:51:13 -04:00
Itamar Turner-Trauring
6127fc8cc7 Tests for rrefutil. 2021-04-01 10:49:59 -04:00
Itamar Turner-Trauring
062740dc23 Probably not worth unit testing a utility function used in one place, move it to
place it's used.
2021-04-01 10:23:37 -04:00
Itamar Turner-Trauring
9f02de688c We don't support old Foolscap versions anymore. 2021-04-01 10:19:16 -04:00
Itamar Turner-Trauring
f606420d78 Make it new-style. 2021-04-01 10:14:05 -04:00
Itamar Turner-Trauring
5ac631047c Port to Python 3. 2021-04-01 10:04:01 -04:00
Itamar Turner-Trauring
de2609151e Special logic for roundtripping Unicode to Unicode is only necessary on Python 2. 2021-04-01 10:02:11 -04:00
Itamar Turner-Trauring
8439f2820b Port to Python 3. 2021-03-31 10:53:02 -04:00
Itamar Turner-Trauring
1ef33d3d69 Note download_to_data() is tested elsewhere. 2021-03-31 10:50:50 -04:00
Itamar Turner-Trauring
d3a8094630 Merge branch '3658.end-progress' into 3657.util-python-3 2021-03-31 10:43:39 -04:00
Itamar Turner-Trauring
0d0dd4dee9 Rip out all references to the unused IProgress API. 2021-03-31 10:35:25 -04:00
Itamar Turner-Trauring
1ead68d061 Start of tests for consumer.py. 2021-03-31 10:10:05 -04:00
Itamar Turner-Trauring
fbcb9bef29 Delete unused code. 2021-03-31 10:09:54 -04:00
Itamar Turner-Trauring
69ece36509
Merge pull request #1018 from tahoe-lafs/3603.scripts-runner-full
3603 Port runner script to Python 3

Fixes ticket:3656
2021-03-31 09:31:31 -04:00
Itamar Turner-Trauring
45e21f8f70 Port to Python 3. 2021-03-30 11:05:49 -04:00
Itamar Turner-Trauring
90c393b8b2 Port __init__.py modules to Python 3 (or just mark them as ported if they're empty). 2021-03-30 10:04:28 -04:00
Itamar Turner-Trauring
43f1f115cb Simplify. 2021-03-30 09:46:56 -04:00
Itamar Turner-Trauring
bc20457a61 Merge remote-tracking branch 'origin/master' into 3603.scripts-runner-full 2021-03-30 09:42:24 -04:00
Sajith Sasidharan
c392a334fc Pacify Python 3
`b"foo"` is `str` in Python 2, `bytes` in Python 3
2021-03-27 11:26:27 -04:00
Jason R. Coombs
a6147b05b1 Fix test failure in test_unicode_arguments_and_output on Python 2. 2021-03-26 11:24:39 -04:00
Jason R. Coombs
110e77b560 Mark module as ported 2021-03-26 09:52:52 -04:00
Jason R. Coombs
bfef77a396 Port runner to Python 3. 2021-03-26 09:52:47 -04:00
Jean-Paul Calderone
7ce7cf7f24
Merge pull request #1016 from LeastAuthority/3650.tahoe-invite-regression
Fix regression in `tahoe invite` w/o shares parameters

Fixes: ticket:3650
2021-03-25 20:09:55 -04:00
Itamar Turner-Trauring
8099929dec
Merge pull request #1013 from tahoe-lafs/3647.more-cli-python-3
Port allmydata.test.cli.test_invite to Python 3

Fixes ticket:3647
2021-03-25 10:19:49 -04:00
Jean-Paul Calderone
00de3b9e7e type cleanups 2021-03-24 13:54:10 -04:00
Jean-Paul Calderone
3963979fbd Test and fix tahoe invite w/o share arguments 2021-03-24 13:23:19 -04:00
Itamar Turner-Trauring
590f71ad10
Merge pull request #1012 from tahoe-lafs/3646.backupdb-python-3
Port test_backupdb to Python 3

Fixes ticket:3646
2021-03-23 16:13:44 -04:00
Jean-Paul Calderone
5b7f0f2477
Merge pull request #1004 from LeastAuthority/3638.mypy-vs-allmydata-scripts
Fix src/allmydata/scripts/ mypy errors

Fixes: ticket:3638
2021-03-23 16:06:33 -04:00
Itamar Turner-Trauring
4b0aa41256 Fix flake. 2021-03-23 11:04:00 -04:00
Itamar Turner-Trauring
15d6ab610d Port to Python 3. 2021-03-23 10:55:14 -04:00
Itamar Turner-Trauring
e140dc06ea Tests pass on Python 3. 2021-03-23 10:53:53 -04:00
Itamar Turner-Trauring
d182ba8283 Utility to dump JSON to bytes. 2021-03-23 10:53:10 -04:00
Itamar Turner-Trauring
4005d90024 Ensure the fake matches the real Wormhole interface. 2021-03-23 10:42:29 -04:00
Itamar Turner-Trauring
8396e9e24d Port to Python 3. 2021-03-23 10:07:24 -04:00
Itamar Turner-Trauring
f0e634af4f Move to correct directory. 2021-03-23 10:03:50 -04:00
Itamar Turner-Trauring
b1b70cc61c Tests pass on Python 3. 2021-03-23 10:02:01 -04:00
Itamar Turner-Trauring
4257f22d77
Merge pull request #1006 from tahoe-lafs/3640.tor-i2p-tests-python-3
Port tor and i2p provider modules to Python 3

Fixes ticket:3640
2021-03-23 09:49:58 -04:00
Itamar Turner-Trauring
28662eef0e
Merge pull request #1005 from tahoe-lafs/3634.cli-tests-python-3
Start porting CLI tests to Python 3

Fixes ticket:3634
2021-03-19 13:59:46 -04:00
Itamar Turner-Trauring
e091d4d0aa Body should be bytes. 2021-03-18 13:29:56 -04:00
Itamar Turner-Trauring
f9d0116283 Fix typo. 2021-03-18 13:29:50 -04:00
Itamar Turner-Trauring
185face21f Port to Python 3. 2021-03-18 11:57:07 -04:00
Itamar Turner-Trauring
e148fef19f Port to Python 3. 2021-03-18 11:55:42 -04:00
Itamar Turner-Trauring
be25d578c5 Port to Python 3. 2021-03-18 11:53:07 -04:00
Itamar Turner-Trauring
3ef69f2738 Port to Python 3. 2021-03-18 11:51:25 -04:00
Itamar Turner-Trauring
334093e28c All tests pass on Python 3. 2021-03-18 11:49:27 -04:00
Itamar Turner-Trauring
045b6085ff Port to Python 3. 2021-03-18 11:30:48 -04:00
Itamar Turner-Trauring
2dfaa3ac2f Ported to Python 3. 2021-03-18 11:08:23 -04:00
Itamar Turner-Trauring
2f25950944 All tests pass on Python 3. 2021-03-18 11:00:49 -04:00
Itamar Turner-Trauring
919930173e More progress towards Python 3. 2021-03-18 10:56:20 -04:00
Itamar Turner-Trauring
b7d6b97f63 Some progress towards passing tests on Python 3. 2021-03-18 10:42:15 -04:00
Itamar Turner-Trauring
34f1f43e95 Revert changes to tahoe_backup/test_backup for now. 2021-03-18 10:33:10 -04:00
Jean-Paul Calderone
0464e9f5ab Merge remote-tracking branch 'origin/master' into 3638.mypy-vs-allmydata-scripts 2021-03-17 21:23:28 -04:00
Jean-Paul Calderone
e15c4184f4
Merge pull request #1003 from LeastAuthority/3637.mypy-vs-allmydata-test
Fix src/allmydata/test mypy errors w/ Twisted 21.2.0 

Fixes: ticket:3637
2021-03-17 21:20:14 -04:00
Itamar Turner-Trauring
47cb644fbb
Merge pull request #990 from tahoe-lafs/3621.port-testing
Port testing to Python 3

Fixes ticket:3621
2021-03-17 16:05:54 -04:00
Itamar Turner-Trauring
dddcff093d
Merge pull request #975 from tahoe-lafs/3603.scripts
Port scripts.create_node to Python 3

Fixes ticket:3603
2021-03-17 16:05:23 -04:00
Itamar Turner-Trauring
56efe7ae48 Merge branch '3603.scripts' into 3634.cli-tests-python-3 2021-03-17 15:33:18 -04:00
Itamar Turner-Trauring
2eba96de61 Address review comments. 2021-03-17 15:29:00 -04:00
Jean-Paul Calderone
b879314194 Make these byte strings explicitly byte strings 2021-03-17 15:21:22 -04:00
Jean-Paul Calderone
84cc7c5b84 Tell mypy about the types of optFlags and optParameters 2021-03-17 15:21:16 -04:00
Jean-Paul Calderone
6955154824 Allow SubCommands to be defined with any Options 2021-03-17 15:17:19 -04:00
Itamar Turner-Trauring
ca125193cf Fix module name. 2021-03-17 15:08:21 -04:00
Itamar Turner-Trauring
95ba731214 Merge remote-tracking branch 'origin/master' into 3621.port-testing 2021-03-17 15:08:07 -04:00
Itamar Turner-Trauring
6f40bd1da1
Merge pull request #1001 from tahoe-lafs/3635.tests-python-3
Port more tests to Python 3

Fixes ticket:3635
2021-03-17 15:06:23 -04:00
Jean-Paul Calderone
950a03cf64 ignore two examples of this error
and link to twisted bug report about it
2021-03-17 14:34:32 -04:00
Jean-Paul Calderone
9ae3f2074f use the inherited implementation! 2021-03-17 14:34:19 -04:00
Jean-Paul Calderone
9425197832 twisted.trial.unittest has no main, oops 2021-03-17 14:34:09 -04:00
Jean-Paul Calderone
ac6b2c6177 add missing producer method to this dummy 2021-03-17 14:33:58 -04:00
Jean-Paul Calderone
4c15db2019 ignore this impossible-to-fix error
also link to a twisted bug report for making it possible
2021-03-17 14:33:32 -04:00
Itamar Turner-Trauring
706b77aaea Port to Python 3. 2021-03-15 11:08:09 -04:00
Itamar Turner-Trauring
47f2c143d0 Tests pass on Python 3. 2021-03-15 11:07:03 -04:00
Itamar Turner-Trauring
01ee67fa43 Port to Python 3. 2021-03-15 11:03:39 -04:00
Itamar Turner-Trauring
dee9f622a9 Tests pass on Python 3. 2021-03-15 11:01:56 -04:00
Itamar Turner-Trauring
3c8e18f0fc Merge remote-tracking branch 'origin/master' into 3603.scripts 2021-03-15 10:50:13 -04:00
Itamar Turner-Trauring
65967c23e4
Merge pull request #995 from tahoe-lafs/3625.client-python-3
Port allmydata.client to Python 3

Fixes ticket:3625
2021-03-15 10:49:49 -04:00
Itamar Turner-Trauring
44374487c7 Some progress towards passing tests on Python 3. 2021-03-15 10:37:03 -04:00
Itamar Turner-Trauring
4d80177b18 Merge branch '3603.scripts' into 3634.cli-tests-python-3 2021-03-15 10:36:56 -04:00
Itamar Turner-Trauring
6e9a3fa3e9 Add back hard-coded expected results. 2021-03-15 10:08:52 -04:00
Itamar Turner-Trauring
1fde7fc007 Fix import. 2021-03-15 09:58:31 -04:00
Itamar Turner-Trauring
876235382e Port to Python 3. 2021-03-15 09:50:28 -04:00
Itamar Turner-Trauring
f147669071 Tests pass on Python 3. 2021-03-15 09:44:36 -04:00
Itamar Turner-Trauring
1c59d349ba It was always bytes. 2021-03-15 09:42:18 -04:00
Itamar Turner-Trauring
425313457b Make sure we're not doing "%s" % (bytes_). 2021-03-15 09:41:56 -04:00
Chad Whitacre
6752e68d40 Review files, pick off a typo 2021-03-15 06:15:47 -04:00
Chad Whitacre
0056809a55 Clean up error message (for mypy) 2021-03-14 17:36:38 -04:00
Chad Whitacre
bde424c7f9 Finish porting testing & test_testing 2021-03-13 09:00:01 -05:00
Chad Whitacre
4b6f84b821 Port testing to Python 3 2021-03-13 07:38:13 -05:00
Itamar Turner-Trauring
68d342ee29 Get rid of trailing whitespace. 2021-03-12 11:26:14 -05:00
Itamar Turner-Trauring
7c2a0685bb Port test_create.py to Python 3. 2021-03-12 11:22:19 -05:00
Itamar Turner-Trauring
719c729d01 Appears to already be ported. 2021-03-09 11:38:50 -05:00
Itamar Turner-Trauring
9a7add2599 It was empty. 2021-03-09 11:36:11 -05:00
Itamar Turner-Trauring
183b80fe25 Fix flake. 2021-03-09 11:33:52 -05:00
Itamar Turner-Trauring
4b0b3e9a4d Port to Python 3. 2021-03-09 11:30:47 -05:00
Itamar Turner-Trauring
ba6c4adba0 All tests pass on Python 3 (albeit skipping some CLI-specific tests). 2021-03-09 11:14:17 -05:00
Itamar Turner-Trauring
6f264a60e3 A couple tests passing on Python 3. 2021-03-09 11:10:48 -05:00
Jason R. Coombs
ee99c610b3 argv_type on Windows can be either 2021-03-06 16:06:24 -05:00
Jason R. Coombs
c673726139 Alongside unicode_to_argv, declare the argv type to avoid errors on Windows now that args are actually unicode. 2021-03-06 15:37:29 -05:00
Jason R. Coombs
0838133006 Merge branch 'master' into 3603.scripts 2021-03-06 10:43:01 -05:00
Itamar Turner-Trauring
2b9e1996ec Fix Python 2 regression. 2021-03-05 10:34:56 -05:00
Itamar Turner-Trauring
5e8899516e Merge remote-tracking branch 'origin/master' into 3625.client-python-3 2021-03-05 10:27:17 -05:00
Itamar Turner-Trauring
d6fc3c078e Port to Python 3. 2021-03-05 10:26:38 -05:00
Itamar Turner-Trauring
f2970f1b16 Port to Python 3. 2021-03-05 10:19:24 -05:00
Itamar Turner-Trauring
437ab58412 Fix flakes. 2021-03-05 09:45:07 -05:00
Itamar Turner-Trauring
5dd33d295e Merge branch '3618.bb-tests-python-3' into 3624.web-python-3-part-5 2021-03-05 09:43:39 -05:00
Itamar Turner-Trauring
0125deb603 Fix typo. 2021-03-05 09:41:49 -05:00
Itamar Turner-Trauring
41f5b5f25d Merge remote-tracking branch 'origin/master' into 3618.bb-tests-python-3 2021-03-05 09:41:17 -05:00
Itamar Turner-Trauring
a29c03d34b Port to Python 3. 2021-03-04 11:02:36 -05:00
Itamar Turner-Trauring
cf418b753a All tests pass on Python 3. 2021-03-04 10:55:08 -05:00
Itamar Turner-Trauring
2c3353f2fa More tests passing on Python 3. 2021-03-03 14:42:55 -05:00
Itamar Turner-Trauring
5ec52f9885 More passing tests on Python 3. 2021-03-03 14:14:55 -05:00
Itamar Turner-Trauring
58149afeb9 Merge branch '3618.bb-tests-python-3' into 3625.client-python-3 2021-03-03 10:51:15 -05:00
Itamar Turner-Trauring
996a564c05 Private key should be bytes. 2021-03-03 10:50:44 -05:00
Chad Whitacre
de3676e955
Merge pull request #989 from tahoe-lafs/3620.port-check_results
Port check_results.py to Python 3
2021-03-02 21:40:17 -05:00
Itamar Turner-Trauring
0647b63681 Port to Python 3. 2021-03-02 09:35:34 -05:00
Itamar Turner-Trauring
7b1911620f Port to Python 3. 2021-03-02 09:31:35 -05:00
Itamar Turner-Trauring
196435784e Port to Python 3. 2021-03-02 09:24:29 -05:00
Itamar Turner-Trauring
66a0628751 Merge branch '3618.bb-tests-python-3' into 3624.web-python-3-part-5 2021-03-02 09:14:23 -05:00
Itamar Turner-Trauring
80ab032a21 Fix typo. 2021-03-02 09:14:10 -05:00
Itamar Turner-Trauring
5359207ce3 Merge branch '3618.bb-tests-python-3' into 3624.web-python-3-part-5 2021-03-02 09:09:47 -05:00
Itamar Turner-Trauring
e1ef9d49cd
Merge pull request #987 from tahoe-lafs/3617.web-python-3-part-4
Port allmydata.web to Python 3, part 4.

Fixes ticket:3617
2021-03-02 09:08:30 -05:00
Itamar Turner-Trauring
f75eda1255 Merge remote-tracking branch 'origin/master' into 3618.bb-tests-python-3 2021-03-02 09:00:09 -05:00
Itamar Turner-Trauring
6fc44f7a31 get_name() should always return bytes, apparently. 2021-03-01 10:53:25 -05:00
Chad Whitacre
4cb7a65aa1 Port check_results.py to Python 3 2021-02-27 15:40:36 -05:00
Chad Whitacre
701ce50a37
Merge pull request #977 from tahoe-lafs/3605.port-control
Port control.py to Python 3
2021-02-27 14:23:14 -05:00
Itamar Turner-Trauring
9d13e82db7 Fix flake. 2021-02-24 14:44:29 -05:00
Itamar Turner-Trauring
70c0607789 Enable BytesWarning across all tests ported to Python 3, fixing problems that caught. 2021-02-24 14:36:15 -05:00
Itamar Turner-Trauring
0af83d0e88 Fix flake. 2021-02-23 10:43:53 -05:00
Itamar Turner-Trauring
2c32318d85 Merge remote-tracking branch 'origin/master' into 3617.web-python-3-part-4 2021-02-23 10:33:52 -05:00
Itamar Turner-Trauring
99db408a46 Port to Python 3. 2021-02-23 10:03:58 -05:00
Itamar Turner-Trauring
b52ab3d230 Ported to Python 3. 2021-02-23 09:14:16 -05:00
Itamar Turner-Trauring
d0bdf1fc8a Port to Python 3. 2021-02-22 10:31:43 -05:00
Itamar Turner-Trauring
0de48ba5b2 Explanation. 2021-02-22 10:20:09 -05:00
Itamar Turner-Trauring
ba06442125 Port to Python 3. 2021-02-22 10:14:21 -05:00
Itamar Turner-Trauring
c26d94b9b3 More type annotations. 2021-02-22 10:09:16 -05:00
Itamar Turner-Trauring
595ce94f2b Clarify filename parsing, hopefully. 2021-02-22 09:59:18 -05:00
Itamar Turner-Trauring
9fb0fc4734 Merge branch '3611.web-python-3-part-2' into 3617.web-python-3-part-4 2021-02-22 09:48:58 -05:00
Chad Whitacre
f6608255f9 Port control.py to Python 3 2021-02-20 12:14:14 -05:00
Itamar Turner-Trauring
041b72f0ab Fix lint. 2021-02-18 13:19:21 -05:00
Itamar Turner-Trauring
e9bf769798 Port to Python 3. 2021-02-18 11:56:53 -05:00
Itamar Turner-Trauring
cbb2cfc028 Port to Python 3. 2021-02-18 11:55:03 -05:00
Itamar Turner-Trauring
de0365a54b Port to Python 3. 2021-02-17 16:05:47 -05:00
Itamar Turner-Trauring
64490880d3 Port to Python 3. 2021-02-17 15:44:42 -05:00
Itamar Turner-Trauring
debda0d21a Merge branch '3611.web-python-3-part-2' into 3615.web-python-3-part-3 2021-02-17 15:37:51 -05:00
Chad Whitacre
5e52c03ef6
Merge pull request #983 from tahoe-lafs/3613.port-history
Port history.py to Python 3
2021-02-16 06:57:23 -05:00
Jason R. Coombs
939988a042 Add workaround for compatibility on Python 2 where test.cli.test_create_alias expects the URL to be a byte string, broken in d02334bfd5. 2021-02-15 15:13:56 -05:00
Jason R. Coombs
6118d1a2d2 Remove runner from ported modules. 2021-02-15 14:39:27 -05:00
Jason R. Coombs
d02334bfd5 Rely on futurize to expose the moved modules. 2021-02-15 14:13:59 -05:00
Jason R. Coombs
09f3e3f6b5 Remove comment, superseded by docstring. 2021-02-15 13:26:20 -05:00
Jason R. Coombs
0de90fda3f Merge commit '2fb603e60' into 3603.scripts 2021-02-15 13:10:35 -05:00
Jason R. Coombs
2fb603e603 Rewrite doctest to pass on Python 2+3. 2021-02-15 13:10:21 -05:00
Jason R. Coombs
ebbe645cb6 Use explicit unicode literal for docstring. Now test passes on Python 2 when ALLOW_BYTES is indicated. 2021-02-15 13:06:42 -05:00
Jason R. Coombs
4cb8c420d3 Manually reviewed test_runner (no legacy map, filter, or keys found). Added docstring to tag module as fully ported. 2021-02-15 12:49:20 -05:00
Jason R. Coombs
746e1b2664 Fix test failures on Python 2 by wrapping cli calls in unicode_to_argv. 2021-02-15 12:47:26 -05:00
Jason R. Coombs
d59d64d6bd Fully port test_runner. Introduces three new errors on Python 2. 2021-02-15 12:38:37 -05:00
Jason R. Coombs
3c93605ead Add docstring to types_. 2021-02-15 12:15:41 -05:00
Itamar Turner-Trauring
520e8fe55e Pacify typechecker. 2021-02-15 11:40:47 -05:00
Itamar Turner-Trauring
9bb64abded Flake fix. 2021-02-15 11:39:30 -05:00
Itamar Turner-Trauring
5b4428b968 Merge remote-tracking branch 'origin/master' into 3611.web-python-3-part-2 2021-02-15 11:38:30 -05:00
Itamar Turner-Trauring
06cd015647 Merge remote-tracking branch 'origin/master' into 3606.test_system-web-python3 2021-02-15 11:14:41 -05:00
Itamar Turner-Trauring
e41ff1a17d
Merge pull request #979 from tahoe-lafs/3607.web-python-3-part-1
Port allmydata.web.common to Python 3

Fixes ticket:3607
2021-02-15 11:13:34 -05:00
Jason R. Coombs
30f5c71a49 Encode expected message. Fixes remaining test failures in test_runner. 2021-02-15 09:36:07 -05:00
Jason R. Coombs
f183be9d6a Decode config file on read and expect bytes in the stdout. Fixes an additional test on Python 3. 2021-02-15 09:33:54 -05:00
Jason R. Coombs
3acad6544e Decode config file on read and expect bytes in the stdout. Fixes an additional test on Python 3. 2021-02-15 09:28:14 -05:00
Jason R. Coombs
dc883c0440 Decode config file on read. Fixes two test failures on Python 3. 2021-02-15 09:24:16 -05:00
Jason R. Coombs
eefb7004c9 Add test_runner to the ported test modules. Selectively decode sys.argv on Python 2 only. Fixes 6 test failures on Python 3. 2021-02-15 09:20:45 -05:00
Chad Whitacre
6db7b4a6c3 YOLO 2021-02-13 15:50:48 -05:00
Chad Whitacre
8700aae37a ¯\_(ツ)_/¯ 2021-02-13 15:48:42 -05:00
Jason R. Coombs
df137cca0a Merge branch 'master' into 3603.scripts 2021-02-12 16:08:31 -05:00
Jean-Paul Calderone
f0ac092109 Avoid the pidfile stuff on Windows 2021-02-12 14:49:20 -05:00
Jean-Paul Calderone
e9adccd432 more logs 2021-02-12 14:42:30 -05:00
Jean-Paul Calderone
47b60c0faa oh yea I think it's this 2021-02-12 14:39:28 -05:00
Jean-Paul Calderone
6458183df2 maybe it's this 2021-02-12 14:38:43 -05:00
Jean-Paul Calderone
50e033f263 Log unhandled output from the tahoe runner helper 2021-02-12 14:37:53 -05:00
Jean-Paul Calderone
4575deb27c Attempt to address non-ascii exceptions from the option parser 2021-02-12 14:32:49 -05:00
Jean-Paul Calderone
680a5a0575 mangling no longer a thing 2021-02-12 14:26:08 -05:00
Jean-Paul Calderone
91490fc2d5 Merge remote-tracking branch 'origin/master' into 3528.test_cli-no-mock 2021-02-12 13:35:03 -05:00
Jean-Paul Calderone
11e1fabbe4 Change the platform check to one mypy can recognize :/ 2021-02-12 13:10:31 -05:00
Jean-Paul Calderone
8ffb083d38 Merge remote-tracking branch 'origin/master' into 3581.unicode_to_argv.1 2021-02-12 13:08:51 -05:00
Itamar Turner-Trauring
42c4bac845 Fix test failure. 2021-02-12 12:01:43 -05:00
Itamar Turner-Trauring
c5a426b797 More unicode-of-bytes fixes. 2021-02-12 11:47:11 -05:00
Itamar Turner-Trauring
a06956632b More unicode-of-bytes bug fixes. 2021-02-12 11:37:43 -05:00
Itamar Turner-Trauring
5561f9fa16 Merge remote-tracking branch 'origin/master' into 3607.web-python-3-part-1 2021-02-12 11:22:34 -05:00
Itamar Turner-Trauring
681572b1a5 Merge remote-tracking branch 'origin/3606.test_system-web-python3' into 3611.web-python-3-part-2 2021-02-12 10:30:51 -05:00
Itamar Turner-Trauring
b935318d5d More unicode-of-bytes issues. 2021-02-12 10:27:41 -05:00
Jean-Paul Calderone
585c554081 Clarify _TwoLoggers 2021-02-12 10:22:17 -05:00
Jean-Paul Calderone
9a9b4bb232 Use a monkey patching library for monkey patching 2021-02-12 10:14:23 -05:00
Jean-Paul Calderone
ff25ee3f71 Merge remote-tracking branch 'origin/master' into 3600.eliotutil-vs-skips 2021-02-12 10:07:44 -05:00
Itamar Turner-Trauring
60da23abdb Fix another unicode-of-bytes issue. 2021-02-12 09:53:50 -05:00
Itamar Turner-Trauring
145d6b63ee Document trinary logic. 2021-02-12 09:48:33 -05:00
Itamar Turner-Trauring
85cdd281f1 Document trinary logic. 2021-02-12 09:47:48 -05:00
Jean-Paul Calderone
9ad4d31d9d
Merge pull request #968 from LeastAuthority/3592.convergence-hasher-tag-tests
convergence hasher tag tests

Fixes: ticket:3592
2021-02-11 16:25:41 -05:00
Jean-Paul Calderone
a8b1c204d2 Mark the expected result literal as the correct type, bytes 2021-02-11 16:06:18 -05:00
Jean-Paul Calderone
5568170c24 Slightly better docs for the share count limits on convergence hash tag 2021-02-11 15:46:04 -05:00
Itamar Turner-Trauring
9f1ca2ab6f More fixes for unicode-of-bytes bugs. 2021-02-11 13:28:09 -05:00
Itamar Turner-Trauring
eebeca31f5 Fix some more unicode()-of-bytestring bugs. 2021-02-11 13:11:34 -05:00
Itamar Turner-Trauring
05a85b0ce2 Fix some unicode(bytes_object) bugs. 2021-02-11 12:53:48 -05:00
Itamar Turner-Trauring
9190f323d3 Add some type annotations. 2021-02-11 10:08:44 -05:00
Itamar Turner-Trauring
d0d771e5be The bug in Autobahn was
fixed (https://github.com/crossbario/autobahn-python/pull/1152) in March 2019, i.e.
before minimum required 19.5 version of Autobahn which came out in May 2019.
2021-02-10 14:35:49 -05:00
Itamar Turner-Trauring
3abbe76d6a Merge branch '3607.web-python-3-part-1' into 3611.web-python-3-part-2 2021-02-10 14:33:00 -05:00
Itamar Turner-Trauring
166c1a537e Fix Python 3 failure. 2021-02-10 14:26:23 -05:00
Itamar Turner-Trauring
3fd90640f3 Merge remote-tracking branch 'origin/master' into 3606.test_system-web-python3 2021-02-10 14:23:53 -05:00
Itamar Turner-Trauring
e5806301d3
Merge pull request #976 from tahoe-lafs/3596.test-web-python-3-even-more
Port test_web.py to Python 3

Fixes ticket:3596
2021-02-10 14:21:22 -05:00
Itamar Turner-Trauring
d237dcab15 Restore test coverage. 2021-02-10 14:06:42 -05:00
Itamar Turner-Trauring
66160253e3 Not necessary to be bytes. 2021-02-10 13:35:04 -05:00
Jean-Paul Calderone
9b2a9e14ae Re-add the check so we still get early failure if this ever happens 2021-02-09 21:21:31 -05:00
Jean-Paul Calderone
3beacc9c8f Merge remote-tracking branch 'origin/master' into 3581.unicode_to_argv.1 2021-02-09 21:18:58 -05:00
Jean-Paul Calderone
845e33061e
Merge pull request #964 from LeastAuthority/3588.use-pywin32-more
Use pywin32 more

Fixes: ticket:3588
2021-02-09 21:15:34 -05:00
Jean-Paul Calderone
28acc5ccb4 Duplicate the fix for the other Windows-only module 2021-02-09 14:50:29 -05:00
Jean-Paul Calderone
b26652cad1 Try to get Mypy to recognize it this way? 2021-02-09 14:36:19 -05:00
Jean-Paul Calderone
27fcfe94dd The code is 3-clause BSD licensed now. 2021-02-09 10:24:46 -05:00
Jean-Paul Calderone
541d7043d7 Some comments about unicode handling in this UnicodeOutput thing 2021-02-09 10:20:14 -05:00
Jean-Paul Calderone
ddcb43561d Try to convince Mypy it's okay 2021-02-08 19:49:02 -05:00
Jean-Paul Calderone
ab57746a85
Merge pull request #969 from LeastAuthority/3593.get_encryption_key-test
Add FileHandle.get_encryption_key test

Fixes: ticket:3593
2021-02-07 07:41:44 -05:00
Itamar Turner-Trauring
92f5001596 Port to Python 3. 2021-02-04 14:10:22 -05:00
Itamar Turner-Trauring
c44b46e0a6 More type annotation. 2021-02-04 11:44:26 -05:00
Itamar Turner-Trauring
8fdbb6db6e Nail down types. 2021-02-04 11:22:48 -05:00
Itamar Turner-Trauring
dfffa8722a Get rid of allmydata.web.common_py3. 2021-02-03 11:45:30 -05:00
Itamar Turner-Trauring
6b38c8d1c9 More of test_system now passes on Python 3. 2021-02-03 11:24:47 -05:00
Itamar Turner-Trauring
cb99b27b78 Nothing to see here, move along. 2021-02-03 10:21:41 -05:00
Itamar Turner-Trauring
2595e25258 Improve coverage, specifically of values that are bytes. 2021-02-03 10:16:34 -05:00
Itamar Turner-Trauring
a1add9a512 Clarify. 2021-02-03 10:13:19 -05:00
Itamar Turner-Trauring
c26f28584e Clarify what it does. 2021-02-03 10:11:30 -05:00
Itamar Turner-Trauring
0b57fb9df1 Merge remote-tracking branch 'origin/master' into 3596.test-web-python-3-even-more 2021-02-02 15:28:49 -05:00
Itamar Turner-Trauring
51bd4b719c Fix lint. 2021-02-02 15:28:12 -05:00
Itamar Turner-Trauring
fa3bef5b25 Port to Python 3. 2021-02-02 15:27:15 -05:00
Itamar Turner-Trauring
489b9f87b3 All tests pass on Python 3. 2021-02-02 15:14:44 -05:00
Itamar Turner-Trauring
26560a4212 More passing tests on Python 3. 2021-02-02 14:25:01 -05:00
Itamar Turner-Trauring
abf6413a89 More passing tests on Python 3. 2021-02-01 11:50:33 -05:00
Itamar Turner-Trauring
a27dc83920 More passing tests on Python 3. 2021-02-01 11:42:09 -05:00
Itamar Turner-Trauring
73537351a7 More passing tests on Python 3. 2021-02-01 11:05:36 -05:00
Itamar Turner-Trauring
438933ec8d Fix tests on Python 2. 2021-02-01 11:02:00 -05:00
Itamar Turner-Trauring
20c04f4ddb Make sure it's non-UTF-8-encodable bytes, just to make sure it's roundtripping correctly. 2021-02-01 10:46:08 -05:00
Itamar Turner-Trauring
be59682532 Fix issue with file uploads being Unicode on Python 3. 2021-02-01 10:44:14 -05:00
Jason R. Coombs
621ae58abe Avoid overthinking encoding when handling usage errors. 'test_unicode_arguments_and_output' still passes on Python 2. Ref #3603. 2021-01-31 11:13:59 -05:00
Jason R. Coombs
57cb88638a In scripts.create_node, set the encoding once and write text. 2021-01-30 12:46:44 -05:00
Jason R. Coombs
d6082d853a Declare scripts.create_node as ported. 2021-01-30 12:23:16 -05:00
Jason R. Coombs
36b7fdaecf Apply futurize to create_node. 2021-01-30 12:15:36 -05:00
Jason R. Coombs
5fc9674d3a Update escape_path for Python 3 compatibility. 2021-01-30 11:47:53 -05:00
Jason R. Coombs
210eb5b529 Add test for escape_path. 2021-01-30 11:44:36 -05:00
Jason R. Coombs
2bd244dde9 Declare scripts.runner as ported. Ref #3603. 2021-01-30 11:24:06 -05:00
Jason R. Coombs
5bf2b09b81 In scripts.runner, replace hard failure on Python 3 with 'experimental' warning. Ref #3603. Closes #3035. 2021-01-30 11:12:01 -05:00
Jason R. Coombs
00e856fed5 Declare scripts.types_ as ported (never had Python 2 support). 2021-01-30 11:00:19 -05:00
Itamar Turner-Trauring
943eabab28 Pacify flake8. 2021-01-29 10:02:16 -05:00
Itamar Turner-Trauring
6fd62eb25e Merge remote-tracking branch 'origin/master' into 3579.ftp-python-3 2021-01-28 15:15:57 -05:00
Jean-Paul Calderone
81edda8011 ... this? 2021-01-28 15:11:13 -05:00
Itamar Turner-Trauring
d1be6b4bde Prepare for merge. 2021-01-28 15:10:57 -05:00
Itamar Turner-Trauring
90a47bb859 WIP 2021-01-28 12:00:15 -05:00
Itamar Turner-Trauring
e5a7ea97c7 More tests passing on Python 3. 2021-01-28 11:44:16 -05:00
Itamar Turner-Trauring
2007323baa More passing tests on Python 3. 2021-01-28 11:19:09 -05:00
Itamar Turner-Trauring
6668842356 More passing tests on Python 3. 2021-01-27 15:43:44 -05:00
Itamar Turner-Trauring
ea10c7c937 More passing tests on Python 3. 2021-01-27 15:20:38 -05:00
Itamar Turner-Trauring
175a3ca4bb More passing tests on Python 3. 2021-01-27 12:45:36 -05:00
Itamar Turner-Trauring
4f56ce436a More passing tests on Python 3. 2021-01-27 12:39:28 -05:00
Itamar Turner-Trauring
c1391159fa More passing tests on Python 3. 2021-01-27 12:06:25 -05:00
Jean-Paul Calderone
64f3e1277e Replace eliot_logged_test with something ... else
The previous implementation relied on TestCase.addCleanup in an unreliable
way.

This implementation pushes the decoration logic in to the test method itself
on the premise that test methods that do weird stuff are better supported than
`run` methods that do weird stuff.

Also add some more tests for this behavior.
2021-01-27 11:33:09 -05:00
Itamar Turner-Trauring
9f5e1381bf Another passing Python 3 test. 2021-01-27 11:29:46 -05:00
Itamar Turner-Trauring
5a2339ced3 Another test passing on Python 3. 2021-01-26 11:09:19 -05:00
Itamar Turner-Trauring
8493d70cab Support byte keys in internal dictionaries. 2021-01-26 11:01:50 -05:00
Itamar Turner-Trauring
e271cd1b64 Another test passing on Python 3. 2021-01-26 10:20:15 -05:00
Jean-Paul Calderone
bb8348f7bb Merge remote-tracking branch 'origin/master' into 3588.use-pywin32-more 2021-01-26 09:54:59 -05:00
Itamar Turner-Trauring
49300ccc4e Merge remote-tracking branch 'origin/master' into 3584.integration-tests-sftp 2021-01-26 09:53:51 -05:00
Jean-Paul Calderone
15dbbce217 Merge remote-tracking branch 'origin/master' into 3592.convergence-hasher-tag-tests 2021-01-26 09:53:26 -05:00
Itamar Turner-Trauring
dc3871b711
Merge pull request #970 from tahoe-lafs/3590.error-in-integration-test
Fix URI redirect error that was manifesting in the integration tests

Fixes ticket:3590
2021-01-26 09:50:40 -05:00
Jean-Paul Calderone
25b453047c Merge remote-tracking branch 'origin/master' into 3593.get_encryption_key-test 2021-01-25 11:12:59 -05:00
Itamar Turner-Trauring
58745fd373 More passing Python 3 tests. 2021-01-25 10:32:28 -05:00
Itamar Turner-Trauring
59847edf9c More Python 3 fixes. 2021-01-25 10:06:05 -05:00
Itamar Turner-Trauring
b6788c4439 More Python 3 fixes. 2021-01-25 09:55:55 -05:00
Itamar Turner-Trauring
3eb62f1d0f More passing tests on Python 3. 2021-01-25 09:25:20 -05:00
Jean-Paul Calderone
e5f0dcfbb4
Merge pull request #971 from LeastAuthority/3594.read_encrypted-test
Directly test read_encrypted behavior and remove a `fireEventually` from its implementation

Fixes: ticket:3594
Fixes: ticket:3595
2021-01-25 09:14:35 -05:00
Jean-Paul Calderone
e0fa228622 expand partial/lambda into full functions for clarity 2021-01-25 08:23:40 -05:00
Jean-Paul Calderone
5a0c913f58 document the new parameter 2021-01-25 08:21:39 -05:00
Itamar Turner-Trauring
4c5ea34af6 More passing tests on Python 3. 2021-01-22 15:07:03 -05:00
Itamar Turner-Trauring
4e15b37062 Bit more progress on Python 3. 2021-01-22 11:59:26 -05:00
Itamar Turner-Trauring
27a5211385 More passing tests on Python 3. 2021-01-22 11:37:37 -05:00
Itamar Turner-Trauring
011b027c39 More passing tests on Python 3. 2021-01-22 10:14:28 -05:00
Itamar Turner-Trauring
755de5edaf Start of passing tests on Python 3. 2021-01-22 09:58:51 -05:00
Itamar Turner-Trauring
0902c8e156 Merge remote-tracking branch 'origin/master' into 3584.integration-tests-sftp 2021-01-21 13:34:51 -05:00
Itamar Turner-Trauring
23e52b1237 Simplify the unit test. 2021-01-21 09:58:58 -05:00
Jean-Paul Calderone
12087738d6 Switch from fireEventually to until 2021-01-20 13:54:37 -05:00
Jean-Paul Calderone
932481ad47 A helper for doing something repeatedly for a while 2021-01-20 12:58:03 -05:00
Jean-Paul Calderone
8be3678cb4 Directly test read_encrypted behavior 2021-01-20 11:22:22 -05:00
Itamar Turner-Trauring
e91d37e64b Fix unit test so it's actually testing the real bug. 2021-01-19 17:13:52 -05:00
Jean-Paul Calderone
11e4bcf476 Add a direct unit test for FileHandle.get_encryption_key 2021-01-19 14:41:58 -05:00
Jean-Paul Calderone
61d5f920bb Add tests for the tag construction code and make it a bit safer
Check for sane inputs, reject insane ones
2021-01-19 14:28:16 -05:00
Itamar Turner-Trauring
6979cfa205 Fix the redirect 'str has no render' bug. 2021-01-19 14:28:00 -05:00
Itamar Turner-Trauring
3166545509 Unit test reproducing the bug in the integration test. 2021-01-19 13:52:12 -05:00
Itamar Turner-Trauring
2de76cd82d
Merge branch 'master' into 3589.more-web-tests-python-3 2021-01-19 11:44:27 -05:00
Jason R. Coombs
7d468cde19 Merge branch 'master' into 3399.mypy 2021-01-15 11:17:47 -05:00
Itamar Turner-Trauring
42b31a2809 Fix flake. 2021-01-14 15:58:18 -05:00
Itamar Turner-Trauring
a2dab7c89f Only do this on Python 3. 2021-01-14 09:40:10 -05:00
Itamar Turner-Trauring
60acad32ca Merge remote-tracking branch 'origin/master' into 3589.more-web-tests-python-3 2021-01-14 09:39:18 -05:00
Itamar Turner-Trauring
c5669e16e0 Fix flake. 2021-01-13 09:56:08 -05:00
Itamar Turner-Trauring
aace119790 Fix Python 3 issue with combining bytes and unicode. 2021-01-13 09:55:54 -05:00
Jean-Paul Calderone
216efb2aed unused import 2021-01-12 16:52:43 -05:00
Jean-Paul Calderone
43dc85501f is this api less troublesome? 2021-01-12 16:03:28 -05:00
Jean-Paul Calderone
6984f2be3f Try to get the Python 2 / Windows case working 2021-01-12 15:58:07 -05:00
Jean-Paul Calderone
6c430bd4e6 re-add a direct unicode_to_argv test
harder to express the conditional in skips so the two tests become one
2021-01-12 15:16:18 -05:00
Jean-Paul Calderone
9c63703efc no effort being made to support these locales 2021-01-12 15:15:42 -05:00
Jean-Paul Calderone
44d76cb159 fix formatting mistake 2021-01-12 15:00:02 -05:00
Jean-Paul Calderone
5a145e74ef a mild warning/suggestion here 2021-01-12 14:59:16 -05:00
Jean-Paul Calderone
522f96b150 may as well leave(/restore) this 2021-01-12 14:56:37 -05:00
Jean-Paul Calderone
622d67c9b9 done with this, thanks 2021-01-12 14:55:40 -05:00
Jean-Paul Calderone
e3a805caa7 unicode_to_argv == id on win32 2021-01-12 14:44:00 -05:00
Itamar Turner-Trauring
5d77282784 Ported to Python 3. 2021-01-12 14:40:33 -05:00
Jean-Paul Calderone
183ee10035 probably more useful debug info 2021-01-12 14:39:56 -05:00
Itamar Turner-Trauring
7a3e9ab43e Tests pass on Python 3. 2021-01-12 14:39:20 -05:00
Jean-Paul Calderone
ec92f0362d this? 2021-01-12 14:36:42 -05:00
Jean-Paul Calderone
7ca3c86a35 debug nonsense 2021-01-12 14:35:03 -05:00
Itamar Turner-Trauring
03fb936716 Port to Python 3. 2021-01-12 14:25:16 -05:00
Itamar Turner-Trauring
4940da47da Tests pass on Python 3. 2021-01-12 14:24:17 -05:00
Itamar Turner-Trauring
c076e1ee26 Just fix all the putChild. 2021-01-12 14:24:11 -05:00
Jean-Paul Calderone
99f00818a8 diff shrink 2021-01-12 14:21:32 -05:00
Jean-Paul Calderone
46d3ffb2e2 diff shrink 2021-01-12 14:20:50 -05:00
Itamar Turner-Trauring
8c41f60fdb Port to Python 3. 2021-01-12 14:17:38 -05:00
Itamar Turner-Trauring
bd364feec5 Tests pass on Python 3. 2021-01-12 14:14:52 -05:00
Jean-Paul Calderone
aa4f113027 Get the monkey patching right 2021-01-12 14:11:43 -05:00
Itamar Turner-Trauring
7e5e329138 Port to Python 3. 2021-01-12 11:44:27 -05:00
Itamar Turner-Trauring
c2d69c5309 Merge all log tests into one test module. 2021-01-12 11:41:19 -05:00
Itamar Turner-Trauring
d99c94753c On Python 3 we need to make sure bytes get written to the websocket. 2021-01-12 11:38:37 -05:00
Itamar Turner-Trauring
116c59142d Port to Python 3. 2021-01-12 11:26:43 -05:00
Itamar Turner-Trauring
f717250ecd Merge remote-tracking branch 'origin/master' into 3576.port-unknown 2021-01-12 11:07:15 -05:00
Jean-Paul Calderone
82d24bfaf7 one more 2021-01-12 10:46:04 -05:00
Jean-Paul Calderone
8f498437cf whitespace 2021-01-12 10:11:23 -05:00
Jean-Paul Calderone
3dadd47416 unused import 2021-01-12 10:11:20 -05:00
Jean-Paul Calderone
ae1a0c591b Prefer to fix unicode_to_argv/argv_to_unicode instead of callers 2021-01-12 09:58:34 -05:00
Jean-Paul Calderone
7c0d2e3cd5 another un-re-shuffling 2021-01-12 09:29:24 -05:00
Jean-Paul Calderone
a9a60857b2 attempt to reduce diff noise 2021-01-12 09:28:50 -05:00
Jean-Paul Calderone
2889922a08 reign in scope - don't mess with filesystem encoding here
It is a separate can of works from argv
2021-01-12 09:27:23 -05:00
Jean-Paul Calderone
15c46924ce unused import 2021-01-12 09:27:20 -05:00
Jean-Paul Calderone
1810f4e99b Force the encoding to utf-8 more often 2021-01-11 19:31:41 -05:00
Jean-Paul Calderone
70d2fd6672 Don't have a Latin-1 io_encoding
It's bad
2021-01-11 19:31:22 -05:00
Jean-Paul Calderone
60a44b99e6 improve fixtures 2021-01-11 19:30:15 -05:00
Jean-Paul Calderone
23c34004a7 Get rid of tests for bad io_encoding values
We don't like bad io_encoding values
2021-01-11 19:29:49 -05:00
Jean-Paul Calderone
3d02545006 Remove tests based on locale behavior
We don't like locale behavior
2021-01-11 19:29:15 -05:00
Jean-Paul Calderone
de9bcc7ea8 encode Popen argv as UTF-8 on POSIX so we ignore locale 2021-01-11 19:21:20 -05:00
Jean-Paul Calderone
ec6c036f87 less cheesy list collision fix 2021-01-11 16:14:34 -05:00
Jean-Paul Calderone
b8abec6073 Get rid of the Latin-1 case
Here's a supposition: UTF-8 or bust
2021-01-11 16:00:48 -05:00
Jean-Paul Calderone
260706d330 Fix the collision with the builtin list 2021-01-11 16:00:42 -05:00
Jean-Paul Calderone
2306819db1 Get rid of unicode_to_argv and argv_to_unicode 2021-01-11 15:45:39 -05:00
Jean-Paul Calderone
1639aef197 Get rid of the argv unmangling that we no longer do 2021-01-11 15:29:32 -05:00
Jean-Paul Calderone
b81d57779a Tahoe's .pyscript is ancient history 2021-01-11 15:29:12 -05:00
Jean-Paul Calderone
5df86b4608 restore test_with_python_options now that I see what it's testing 2021-01-11 15:26:12 -05:00
Itamar Turner-Trauring
8f1864842f Fix integration tests. 2021-01-11 15:23:17 -05:00
Jean-Paul Calderone
834abfe6bf _win_subprocess didn't actually export this 2021-01-11 15:09:25 -05:00
Jean-Paul Calderone
c6d108ddb2 Make test_runner and test_windows both use the good Popen 2021-01-11 15:07:37 -05:00
Jean-Paul Calderone
73110f48da Banish getProcessOutputAndValue from test_runner
It cannot do the right thing on Windows for non-ASCII because Twisted uses
pywin32 and on Python 2 pywin32 binds CreateProcessA.
2021-01-11 14:56:46 -05:00
Jean-Paul Calderone
41d7548527 typo 2021-01-11 14:16:02 -05:00
Jean-Paul Calderone
a4c520ec2a try to go faster without losing coverage 2021-01-11 14:11:28 -05:00
Itamar Turner-Trauring
1b1d87f9f9 Merge branch '3584.integration-tests-sftp' into 3579.ftp-python-3 2021-01-11 14:05:07 -05:00
Jean-Paul Calderone
a29b061f91 explain the nested import 2021-01-11 14:04:20 -05:00
Jean-Paul Calderone
e6ee13d11b Shovel code around a bit more 2021-01-11 14:03:11 -05:00
Jean-Paul Calderone
9d7b12292c Get rid of FILE_TYPE_REMOTE 2021-01-11 13:56:42 -05:00
Itamar Turner-Trauring
ce58f63040 Merge remote-tracking branch 'origin/master' into 3584.integration-tests-sftp 2021-01-11 13:55:03 -05:00
Jean-Paul Calderone
ad48e6c005 See if we can use pywin32 GetFileType 2021-01-11 13:54:04 -05:00
Itamar Turner-Trauring
4a7da34a6a
Merge pull request #958 from tahoe-lafs/3583.rip-out-ftp
Rip out FTP support

Fixes ticket:3583
2021-01-11 13:54:00 -05:00
Jean-Paul Calderone
52896432e1 it cannot return None 2021-01-11 13:41:54 -05:00
Jean-Paul Calderone
184b9735b5 another constant we can get from pywin32 2021-01-11 13:41:48 -05:00
Jean-Paul Calderone
5c6e5970c9 get this from pywin32 too 2021-01-11 13:36:12 -05:00
Jean-Paul Calderone
cca0071cbf these aren't win32 specific 2021-01-11 13:36:04 -05:00
Jean-Paul Calderone
f61103aa80 spell the module name right 2021-01-11 13:22:14 -05:00
Jean-Paul Calderone
f5bcd272b8 skip the other test suite too 2021-01-11 12:58:27 -05:00
Jean-Paul Calderone
6de392fd23 blacklist a couple more 2021-01-11 12:43:30 -05:00
Jean-Paul Calderone
fd223136db Avoid breaking non-Windows with test_windows 2021-01-11 12:42:52 -05:00
Jean-Paul Calderone
ed713182e7 docstring 2021-01-11 12:31:13 -05:00
Jean-Paul Calderone
dc5ed66815 docstring 2021-01-11 12:31:08 -05:00
Jean-Paul Calderone
ad2df670e6 try using pywin32 for GetStdHandle 2021-01-11 11:51:01 -05:00
Jean-Paul Calderone
1751d682a2 is this cool? 2021-01-11 11:46:40 -05:00
Jean-Paul Calderone
112bfaf625 we would like this to be utf-8 corresponding to the inputs 2021-01-11 11:42:27 -05:00
Jean-Paul Calderone
ab1f6f3a59 clean up this noise 2021-01-11 11:39:56 -05:00
Jean-Paul Calderone
4e9bdfeee4 please just always work? 2021-01-11 11:38:25 -05:00
Jean-Paul Calderone
14caaa360c different debug 2021-01-11 11:33:09 -05:00
Jean-Paul Calderone
a4061619dc shuffle code around a lot 2021-01-11 11:32:12 -05:00
Jean-Paul Calderone
3adfb2a108 let it be slow 2021-01-11 11:17:57 -05:00
Jean-Paul Calderone
f4a1a6fd97 get rid of this noise 2021-01-11 11:16:49 -05:00
Jean-Paul Calderone
23d1d76242 get the name 2021-01-11 11:16:23 -05:00
Jean-Paul Calderone
8fa1b6bb1e make stdout/stderr available 2021-01-11 11:15:47 -05:00
Jean-Paul Calderone
504b2f5b1f get the syntax right 2021-01-11 11:15:20 -05:00
Jean-Paul Calderone
221f1640a5 make the container 2021-01-11 11:14:32 -05:00
Jean-Paul Calderone
08d56c87b4 that was silly 2021-01-11 11:13:45 -05:00
Jean-Paul Calderone
a0aa3fe296 try testing UnicodeOutput 2021-01-11 11:12:12 -05:00
Jean-Paul Calderone
6d499dea53 exclude nul from the tested argv values 2021-01-11 10:31:37 -05:00
Jean-Paul Calderone
c2e8d94a73 don't fail this test because it is slow 2021-01-11 10:24:25 -05:00
Jean-Paul Calderone
33f84412b4 maybe pywin32 GetCommandLine is not really GetCommandLineW 2021-01-11 10:19:17 -05:00
Jean-Paul Calderone
389d70a682 see if GetCommandLine() value is interesting 2021-01-11 10:17:02 -05:00
Jean-Paul Calderone
e2f3964451 okay this is indeed the expected 2021-01-11 10:09:54 -05:00
Jean-Paul Calderone
42f1930914 disambiguate this a bit 2021-01-11 10:08:15 -05:00
Jean-Paul Calderone
30c79bf678 make sure executable is unicode too, if that matters 2021-01-11 09:51:36 -05:00
Jean-Paul Calderone
b5f0e21ef8 testtools convention - actual value comes first 2021-01-10 20:19:15 -05:00
Jean-Paul Calderone
3bde012ea1 Create a better expectation
If we pass all this stuff to Popen we should expect to see it from get_argv() right?
2021-01-10 20:18:00 -05:00
Jean-Paul Calderone
28435d65c1 test the SUT 2021-01-10 20:16:25 -05:00
Jean-Paul Calderone
360b20a981 FilePath again 2021-01-10 20:14:05 -05:00
Jean-Paul Calderone
77c9a2c2f5 make the failures a little nicer 2021-01-10 20:13:17 -05:00
Jean-Paul Calderone
18de71666f try to work-around bugs in the Popen hotfix 2021-01-10 20:10:34 -05:00
Jean-Paul Calderone
a21b66e775 FilePath again 2021-01-10 20:06:07 -05:00
Jean-Paul Calderone
e64a4c6426 Attempt to use a parent-side API that supports unicode properly 2021-01-10 19:59:22 -05:00
Jean-Paul Calderone
6091ca2164 try to get the child source right 2021-01-10 11:23:19 -05:00
Jean-Paul Calderone
b02b930eed do better with paths 2021-01-10 11:22:00 -05:00
Jean-Paul Calderone
a73668a056 this doesn't take a list 2021-01-10 11:21:13 -05:00
Jean-Paul Calderone
b3a6f25c1c Python 2 gets an old version with no CommandLineToArgv
Thanks.
2021-01-10 11:01:30 -05:00
Jean-Paul Calderone
6b621efef2 Turns out there is also CommandLineToArgv
just not CommandLineToArgvW, but that's fine.
2021-01-10 10:48:49 -05:00
Jean-Paul Calderone
24f3d74fdf Fix the skip 2021-01-10 10:48:40 -05:00
Jean-Paul Calderone
e80bd6894f Take a first attempt at testing the argv logic directly 2021-01-10 10:39:51 -05:00
Jean-Paul Calderone
d78e72595a Use SetErrorMode and related constants from pywin32 2021-01-09 18:19:09 -05:00
Jean-Paul Calderone
1ae0311e36
Merge pull request #949 from tahoe-lafs/port-webish
Port webish/test_webish to Python 3

Fixes: ticket:3577
2021-01-08 13:51:00 -05:00
Itamar Turner-Trauring
f71dcfe9fc Lint. 2021-01-08 13:42:10 -05:00
Itamar Turner-Trauring
7a15f7e11d Switch to modern (circa 2014!) Conch API. 2021-01-08 13:32:11 -05:00
Itamar Turner-Trauring
3b29a5f707 Work with new Unicode configs. 2021-01-07 11:59:23 -05:00
Itamar Turner-Trauring
308dbba924 Fix flake. 2021-01-07 09:20:39 -05:00
Itamar Turner-Trauring
7b1bfadd21 Rip out FTP. 2021-01-06 13:39:52 -05:00
Itamar Turner-Trauring
7b091bde9b Port to Python 3. 2021-01-06 10:51:05 -05:00
Itamar Turner-Trauring
192063acfa Port to Python 3. 2021-01-06 09:59:33 -05:00
Itamar Turner-Trauring
a5e22d93cc All tests pass on Python 3. 2021-01-06 09:54:48 -05:00
Itamar Turner-Trauring
ebaf075966 Another passing test on Python 3. 2021-01-06 09:38:43 -05:00
Itamar Turner-Trauring
f3d795d9a8 More passing tests on Python 3. 2021-01-06 09:31:15 -05:00
Itamar Turner-Trauring
d82bcc5280 Another passing test on Python 3. 2021-01-06 09:26:18 -05:00
Itamar Turner-Trauring
2998057d91 Don't need byte strings for debug! 2021-01-05 16:47:34 -05:00
Itamar Turner-Trauring
06fb9496ab Another test passing on Python 3. 2021-01-05 16:35:57 -05:00
Itamar Turner-Trauring
0241244e49 Another test passing on Python 3. 2021-01-05 16:30:17 -05:00
Itamar Turner-Trauring
3a6f3f2809 Merge remote-tracking branch 'origin/master' into 3579.ftp-python-3 2021-01-05 16:05:56 -05:00
Chad Whitacre
fa15c2c8d6 Declare victory on blacklist 2021-01-05 06:45:32 -05:00
Chad Whitacre
88946900b3 Port unknown to Python 3
This is covered by test_dirnode/test_grid
2021-01-05 06:39:29 -05:00
Chad Whitacre
bd402ce1f4 Compute Content-Length more betterly 2021-01-05 06:27:46 -05:00
Chad Whitacre
dc5ac4a112
Merge pull request #946 from tahoe-lafs/3574.port-stats
Port stats to Python 3
2021-01-05 06:04:10 -05:00
Itamar Turner-Trauring
4683760ed8
Merge pull request #945 from tahoe-lafs/3566.web-tests-python-3-part-2
Port web tests to Python 3, part 2

Fixes ticket:3566
2021-01-04 15:40:52 -05:00
Jean-Paul Calderone
3c203828c5 Merge remote-tracking branch 'origin/master' into 3578.remove-encode_tail_segment 2021-01-04 15:08:27 -05:00
Jean-Paul Calderone
7a504dd99f
Merge pull request #936 from LeastAuthority/3534.test_introducer-no-mock
Remove mock from test_introducer

Fixes: ticket:3534
2021-01-04 15:06:29 -05:00
Itamar Turner-Trauring
bc19ccc77a Use method that already does this. 2021-01-04 14:36:02 -05:00
Itamar Turner-Trauring
961ad123cc Better name. 2021-01-04 14:35:33 -05:00
Itamar Turner-Trauring
6f0838e2e9 Docstring. 2021-01-04 14:34:18 -05:00
Itamar Turner-Trauring
d7db34f27a Add explanation for if statement. 2021-01-04 14:33:06 -05:00
Itamar Turner-Trauring
a46a7dc7f8 Log, don't raise. 2021-01-04 14:23:12 -05:00
Jean-Paul Calderone
af06bdb182 Merge remote-tracking branch 'origin/master' into 3575.realistic_storage_index_hash-key 2021-01-04 14:14:13 -05:00
Jean-Paul Calderone
916ddd590e Maybe a useful test to demonstrate the lower-level behavior?
Or maybe trash.  I don't know.
2021-01-04 14:13:34 -05:00
Jean-Paul Calderone
190d9a7319 Skip the pidfile test on Windows where there are no pidfiles 2021-01-04 12:13:53 -05:00
Jean-Paul Calderone
9958236c31 explain the extra coverage stuff 2021-01-04 12:06:03 -05:00
Jean-Paul Calderone
c9b3ccedb4 explain this while loop 2021-01-04 11:59:58 -05:00
Itamar Turner-Trauring
3a6b92f39f More progress to passing tests on Python 3. 2021-01-04 11:48:38 -05:00
Itamar Turner-Trauring
2bf278e55d Even more tests passing on Python 3. 2021-01-04 11:39:25 -05:00
Itamar Turner-Trauring
3d42030e01 More tests pass on Python 3. 2021-01-04 11:21:26 -05:00
Itamar Turner-Trauring
a54aeae338 Port to Python 3. 2021-01-04 11:05:59 -05:00
Itamar Turner-Trauring
744e205763 Tests pass on Python 3. 2021-01-04 11:03:38 -05:00
Chad Whitacre
c13821ecac Tack on deep_stats 2021-01-04 06:18:14 -05:00
Chad Whitacre
655be5e3a0 Port stats to Python 3 2021-01-04 06:18:14 -05:00
Jean-Paul Calderone
855521fea8
Merge pull request #935 from LeastAuthority/3529.test_connections-no-mock
Remove mock usage from test_connections.py

Fixes: ticket:3529
2021-01-02 12:48:12 -05:00
Jean-Paul Calderone
c0358b3e03 Fold _encode_tail_segment in to _encode_segment 2021-01-01 15:14:47 -05:00
Chad Whitacre
2a8fa4da7a Fix test module reference in util._python3 2020-12-29 12:54:19 -05:00
Chad Whitacre
b4b4a1aabf Port webish/test_webish to Python 3 2020-12-29 12:39:00 -05:00
Jean-Paul Calderone
30b37e17dd More of a storage_index_hash test 2020-12-29 10:48:03 -05:00
Jason R. Coombs
4a9d3bde5b Exclude allmydata.scripts.types_ module from PythonTwoRegressions. 2020-12-26 13:30:32 -05:00
Jason R. Coombs
6522221166 Suppress error on SpyHandler interface. 2020-12-26 13:12:11 -05:00
Jason R. Coombs
854c22e1ca Use compatible import for urllib.parse.quote. 2020-12-26 13:09:57 -05:00
Jason R. Coombs
cc5a1046d9 Define type for IntroducerService.VERSION, accepting bytes or str as keys for now. 2020-12-26 13:07:12 -05:00
Jason R. Coombs
3fd46f9400 Ignore additional attribute on the function. 2020-12-26 13:02:16 -05:00
Jason R. Coombs
04ab4dec3b Extract function and annotate it to satisfy typechecks for _Config._basedir 2020-12-26 13:01:27 -05:00
Jason R. Coombs
574613a892 Merge branch 'master' into 3399.mypy 2020-12-26 12:45:09 -05:00
Jason R. Coombs
01147f4627 Add reference to ticket for ambiguous MRO 2020-12-26 12:33:22 -05:00
Jason R. Coombs
1bf71fd690 Replace todo with a ticket. 2020-12-26 12:12:39 -05:00
Jason R. Coombs
5396f9f97e Replace fixme with reference to foolscap issue. 2020-12-26 12:02:47 -05:00
Jason R. Coombs
dacdf7f12d Add more detail and link to upstream issue for Twisted stubs. 2020-12-26 11:56:13 -05:00
Jason R. Coombs
384e3f5220 Merge commit 'ab2c544' into 3399.mypy 2020-12-26 11:50:15 -05:00
Jason R. Coombs
ab2c544efc Restore IDirnodeURI 2020-12-26 11:50:06 -05:00
Jason R. Coombs
b65ef3cee6 Revert "Ignores no longer needed."
This reverts commit 950ca18932.
2020-12-26 11:25:40 -05:00
Jason R. Coombs
6b6b8f8378 Push IURI implementers down to the classes that actually implement it. 2020-12-26 11:17:35 -05:00
Itamar Turner-Trauring
eb8837a4c8 More things that need to be bytes. 2020-12-23 10:09:37 -05:00
Itamar Turner-Trauring
15f2d433ae Fix tests on Python 3. 2020-12-23 10:01:44 -05:00
Itamar Turner-Trauring
3c8550b666 Python 3 fix: direct indexing of bytes returns an int. 2020-12-23 09:54:35 -05:00
Itamar Turner-Trauring
58cb757816 Sometimes these values are more extended Unicode than ASCII. 2020-12-23 09:42:42 -05:00
Itamar Turner-Trauring
f736dc6f7b Fix some tests caused by unicode rendering. 2020-12-23 09:34:48 -05:00
Itamar Turner-Trauring
c5b403bd2f Make the class new style again on Python 2. 2020-12-23 09:17:39 -05:00
Itamar Turner-Trauring
2c7dde9978 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-23 09:14:34 -05:00
Itamar Turner-Trauring
55698cc8f2 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-22 13:21:49 -05:00
Itamar Turner-Trauring
1c7956bc1a Port to Python 3. 2020-12-22 13:19:59 -05:00
Itamar Turner-Trauring
cbf348f21b Get rid of debug print. 2020-12-22 13:17:46 -05:00
Itamar Turner-Trauring
8881728ca5 Another passing test on Python 3. 2020-12-22 13:17:07 -05:00
Itamar Turner-Trauring
baa2cff29c Unbreak Python 2. 2020-12-22 13:14:18 -05:00
Itamar Turner-Trauring
013388981c Fix intermittent failing test on PyPy hopefully.
PyPy does not have refcounts, so files were only being closed when GC happened,
which meant their buffered writes never hit disk.
2020-12-22 13:04:53 -05:00
Itamar Turner-Trauring
f9ee4b239f
Merge pull request #934 from tahoe-lafs/3564.eliot-log-testing-python-3
Re-enable logging validation on Python 3.

Fixes ticket:3564
2020-12-22 11:43:36 -05:00
Itamar Turner-Trauring
74c08883f5 Another passing test on Python 3. 2020-12-22 11:36:52 -05:00
Itamar Turner-Trauring
0534979e61 Another passing test on Python 3. 2020-12-22 11:03:23 -05:00
Itamar Turner-Trauring
cabfdadc20 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-22 10:48:32 -05:00
Itamar Turner-Trauring
f30376ade6 Make sure test output can encode bytes correctly too. 2020-12-22 10:47:25 -05:00
Jean-Paul Calderone
ab7c382dec
Merge pull request #939 from LeastAuthority/3567.test_storage_client-eaddrinuse
Use a pre-bound listening socket in the test

Fixes: ticket:3567
2020-12-21 13:27:08 -05:00
Itamar Turner-Trauring
b46898f667 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:20:50 -05:00
Itamar Turner-Trauring
7fc64fdf45 Also handle bytes when serializing production Eliot log messages on Python 3. 2020-12-21 13:20:14 -05:00
Itamar Turner-Trauring
a8732a3c70 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:12:19 -05:00
Itamar Turner-Trauring
c25dd57768 Make sure we can handle bytes, plus a couple other fixes. 2020-12-21 13:12:01 -05:00
Itamar Turner-Trauring
2737229895 Another passing test. 2020-12-21 11:12:52 -05:00
Itamar Turner-Trauring
a2f042845d Another passing test. 2020-12-21 10:58:09 -05:00
Itamar Turner-Trauring
d8197d9554 Another passing test. 2020-12-21 10:52:31 -05:00
Itamar Turner-Trauring
15c7af8e72 Another passing test. 2020-12-21 10:29:59 -05:00
Itamar Turner-Trauring
98c71e51e1 More progress towards passing tests. 2020-12-21 10:04:27 -05:00
Itamar Turner-Trauring
2ec7d52d09 Some progress towards passing tests on Python 3. 2020-12-18 16:12:32 -05:00
Itamar Turner-Trauring
c71acf93fd Bytes, alas. 2020-12-18 16:10:23 -05:00
Itamar Turner-Trauring
5315d48355 Merge remote-tracking branch 'origin/master' into 3565.web-tests-python-3-part-1 2020-12-18 15:43:36 -05:00
Itamar Turner-Trauring
f964ae1782 Docstrings. 2020-12-18 15:43:27 -05:00
Itamar Turner-Trauring
50a794a911 More accurate docstring. 2020-12-18 11:34:08 -05:00
Itamar Turner-Trauring
865f3fd7d0 Improve the docstring. 2020-12-18 11:33:24 -05:00
Itamar Turner-Trauring
721b02b262 Use the function I specifically wrote for this! 2020-12-18 11:29:56 -05:00
Itamar Turner-Trauring
8f4a0379ea Correct examples. 2020-12-18 11:26:10 -05:00
Itamar Turner-Trauring
b24a9f7083 Trying to get test_grid working on Python 3. 2020-12-18 11:21:04 -05:00
Jason R. Coombs
602a06e5cb Extract Parameters type in scripts.types_. 2020-12-18 11:14:07 -05:00
Jason R. Coombs
189608e113 Remove GENERATED_FILES, unused 2020-12-18 11:07:30 -05:00
Jason R. Coombs
c2d2aba83f Add reference to ticket. 2020-12-18 11:05:55 -05:00
Jason R. Coombs
0e248cb4ef Declare signing key as required in introducer client publish. 2020-12-18 10:59:53 -05:00
Jason R. Coombs
090031cbfc Remove confirm_share_allocation from interface (unused). 2020-12-18 10:55:20 -05:00
Jason R. Coombs
d051791e95 Add reference to ticket. 2020-12-18 10:53:24 -05:00
Jason R. Coombs
ea0c10ef83 Remove set_size, unused 2020-12-18 10:51:56 -05:00
Jason R. Coombs
efd0aef284 Indicate that unichr is Python 2 only. 2020-12-18 10:36:43 -05:00
Jason R. Coombs
51b0b201b4 Expand comment to provide more context. 2020-12-18 10:33:30 -05:00
Jason R. Coombs
99da74fffb Change comment to clarify that it's the implementation that's incomplete. 2020-12-18 09:58:56 -05:00
Jason R. Coombs
950ca18932 Ignores no longer needed. 2020-12-18 09:23:27 -05:00
Jean-Paul Calderone
8e6c52b61e pre-assign a listening socket to the main tub to avoid the error 2020-12-17 10:20:22 -05:00
Itamar Turner-Trauring
6e12cce1e4 Port to Python 3. 2020-12-17 09:55:35 -05:00
Itamar Turner-Trauring
3ac64e42f7 Web test_status tests pass on Python 3. 2020-12-17 09:54:04 -05:00
Itamar Turner-Trauring
9b59e7e245 Merge remote-tracking branch 'origin/3552.test_system-python-3' into 3565.web-tests-python-3-part-1 2020-12-17 09:51:52 -05:00
Itamar Turner-Trauring
33392502d3 server IDs/node IDS should be bytes. 2020-12-17 09:50:39 -05:00
Itamar Turner-Trauring
26297c296d
Merge branch 'master' into 3552.test_system-python-3 2020-12-17 09:42:34 -05:00
Jean-Paul Calderone
6e152daf05 Put the pidfile in the right place
Seems we relied on the chdir for that to happen, previously.
2020-12-17 09:37:45 -05:00
Jean-Paul Calderone
70305131f1 docstrings 2020-12-17 09:22:43 -05:00
Jean-Paul Calderone
f88061e31c docstring 2020-12-17 09:16:05 -05:00
Jean-Paul Calderone
a363c8de67 Fix test_non_numeric_pid (and put it in a better place too) 2020-12-17 09:11:29 -05:00
Jean-Paul Calderone
bb495b6dc5 unused imports 2020-12-16 21:26:59 -05:00
Jean-Paul Calderone
240d5d1164 Remove react monkey patching by supplying an alternate reactor
Let react run and do its thing.  This gives us an even nicer way to check the
exit code.
2020-12-16 21:25:50 -05:00
Jean-Paul Calderone
faf8da82dd Get rid of the sys.exit monkey-patch
It's just an exception.  Let it get logged and then check after.
2020-12-16 21:20:16 -05:00
Jean-Paul Calderone
a04a915628 Parameterize the Options class so we can synthesize an unhandled exception 2020-12-16 21:15:24 -05:00
Jean-Paul Calderone
2746eb9ae1 Fix the broken fake_react by not using the argv feature 2020-12-16 20:58:27 -05:00
Jean-Paul Calderone
a4b0b4a01a Parameterize stderr to allmydata.scripts.runner.run 2020-12-16 20:55:00 -05:00
Jean-Paul Calderone
1f229ce9f6 All you have to do to drop it is not save it in the first place
Also it would have been dropped as soon as this function returned, anyway.
2020-12-16 20:51:11 -05:00
Jean-Paul Calderone
d5bff458b6 Parameterize argv to allmydata.scripts.runner.run 2020-12-16 20:51:01 -05:00
Jean-Paul Calderone
0ffbc7870e Okay, let KeyboardInterrupt through 2020-12-16 20:32:04 -05:00
Jean-Paul Calderone
895ba55cf7 Python 3 compatibility 2020-12-16 18:17:14 -05:00
Jean-Paul Calderone
a223f6bb60 More reliably corrupt the signature 2020-12-16 17:31:06 -05:00
Jean-Paul Calderone
4117beba6a remove unused import
yaaay
2020-12-16 16:25:51 -05:00
Jean-Paul Calderone
b200075246 whitespace 2020-12-16 16:23:05 -05:00
Jean-Paul Calderone
98000c2b66 re-implement test_unsigned_announcement without mock
and to make assertions about public behavior instead of private implementation
details
2020-12-16 16:20:38 -05:00
Jean-Paul Calderone
b2c9296f6b Use ObserverList instead of an ad hoc reimplementation 2020-12-16 16:20:00 -05:00
Jean-Paul Calderone
60e401ca69 Make ObserverList synchronous, reentrant, and exception safe
with tests
2020-12-16 16:19:33 -05:00
Jean-Paul Calderone
83ebaef86c Stop mocking safe_load
The comment implies this will cause something to break on some platform.
Let's find out.
2020-12-16 15:24:33 -05:00
Jean-Paul Calderone
d19b1cfd68
Merge pull request #933 from LeastAuthority/3533.test_root-no-mock
Remove Mock from test_root

Fixes: ticket:3533
2020-12-16 15:15:17 -05:00
Itamar Turner-Trauring
b5f2afe39c WIP porting test_status.py. 2020-12-16 14:13:46 -05:00
Itamar Turner-Trauring
67c0a4ac84 Port another test module to Python 3. 2020-12-16 13:53:49 -05:00
Jean-Paul Calderone
9f28ccb2a4 Move the last three mock-using tests to test_tor_provider
where they can be rewritten later
2020-12-16 12:07:54 -05:00
Jean-Paul Calderone
3d82ca0d25 Use boring old dependency injection to replace mocks in this test 2020-12-16 11:50:35 -05:00
Jean-Paul Calderone
3d564f97d5 Switch away from mock in a few more simple cases in test_connections.py 2020-12-16 11:48:33 -05:00
Jean-Paul Calderone
468895c74d Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_control_endpoint 2020-12-16 11:28:36 -05:00
Jean-Paul Calderone
7eb9f2ce54 Moved into allmydata.test.test_i2p_provider
This follows the local convention of using mock even though I'm trying to get
rid of mock.  This is because it keeps the test_i2p_provider suite consistent
which means it won't make removing mock from test_i2p_provider later much
harder and lets me avoid doing that work now.
2020-12-16 11:20:45 -05:00
Itamar Turner-Trauring
61c76902ca Port to Python 3. 2020-12-16 11:16:34 -05:00
Jean-Paul Calderone
8271dbf3e6 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_configdir 2020-12-16 11:15:51 -05:00
Jean-Paul Calderone
81b684b583 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir_executable 2020-12-16 11:15:21 -05:00
Itamar Turner-Trauring
f7362dc1ef Port to Python 3. 2020-12-16 11:14:55 -05:00
Jean-Paul Calderone
6d66be43b9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir 2020-12-16 11:14:46 -05:00
Jean-Paul Calderone
e84860ef15 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch 2020-12-16 11:13:52 -05:00
Itamar Turner-Trauring
acc36c34d0 Tests pass on Python 2 and Python 3. 2020-12-16 11:13:32 -05:00
Jean-Paul Calderone
ececae2ce9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_sam_endpoint 2020-12-16 11:12:36 -05:00
Jean-Paul Calderone
f7c92bf4c9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_default 2020-12-16 11:11:22 -05:00
Jean-Paul Calderone
01b31e0680 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch_executable 2020-12-16 11:06:57 -05:00
Jean-Paul Calderone
61778bc799 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch 2020-12-16 11:05:51 -05:00
Jean-Paul Calderone
71ced4c228 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_socks_endpoint 2020-12-16 11:03:37 -05:00
Jean-Paul Calderone
ec9851f6d8 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_no_i2p 2020-12-16 10:38:13 -05:00
Jean-Paul Calderone
b5d4a2579b Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_disabled 2020-12-16 10:37:41 -05:00
Jean-Paul Calderone
17d9988d45 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_no_tor 2020-12-16 10:34:33 -05:00
Jean-Paul Calderone
d3f8839f1b Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_disabled 2020-12-16 10:34:07 -05:00
Itamar Turner-Trauring
052b3d9fb1 Re-enable logging validation on Python 3. 2020-12-16 10:06:59 -05:00
Itamar Turner-Trauring
54a11dbb6a
Merge pull request #932 from tahoe-lafs/3560.test_eliotutil-python-3
Port eliotutil and tests to Python 3

Fixes ticket:3560
2020-12-16 09:40:19 -05:00
Jean-Paul Calderone
eeebd15c42 Take Mock out of `allmydata.test.test_connections.TCP` 2020-12-16 09:15:37 -05:00
Jean-Paul Calderone
2b1ea5c604 Remove the client Mock object
It wasn't used by anything so that was easy.  Clean up the test as long as
we're here.
2020-12-15 18:30:12 -05:00
Jean-Paul Calderone
c4e8262a99
Merge pull request #925 from tahoe-lafs/3532.test_node-no-mock
Remove mock from test_node

Fixes: ticket:3532
2020-12-15 14:38:07 -05:00
Jean-Paul Calderone
fee8c55f01 The listenOn is probably the most interesting part 2020-12-15 13:42:20 -05:00
Jean-Paul Calderone
7dbcb4d712 Make set_tub_locations a nicer function 2020-12-15 13:41:01 -05:00
Jean-Paul Calderone
53b782aca4 get the function name right 2020-12-15 13:40:12 -05:00
Jean-Paul Calderone
c2dc2b39da A better name 2020-12-15 13:34:04 -05:00
Jean-Paul Calderone
be559ab3a5 Turn the XXX into a TODO'd test and a ticket 2020-12-15 13:31:18 -05:00
Jean-Paul Calderone
29f0ae0554 These don't need to be methods. Also docstrings are nice. 2020-12-15 13:30:58 -05:00
Itamar Turner-Trauring
4a587836a5 Port eliotutil and tests to Python 3. 2020-12-15 10:13:46 -05:00
Itamar Turner-Trauring
6a29568888 Fix flakes. 2020-12-15 09:16:50 -05:00
Itamar Turner-Trauring
c7f2b7dd7c Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-15 09:13:32 -05:00
Jean-Paul Calderone
a97184868d oops syntax error
so what is the good of pre-commit?
2020-12-14 18:40:18 -05:00
Jean-Paul Calderone
5c6e0a2bb4 docstrings 2020-12-14 18:33:28 -05:00
Jean-Paul Calderone
677e62e73e Return the canned handler 2020-12-14 18:29:50 -05:00
Jean-Paul Calderone
b77f43e360 Simplify handler initialization 2020-12-14 18:27:02 -05:00
Jean-Paul Calderone
49330d1e4a docstring 2020-12-14 18:25:58 -05:00
Jean-Paul Calderone
4b1c6a2815 Remove these reactor parameters 2020-12-14 17:42:30 -05:00
Jean-Paul Calderone
fcbe56ba0a docstrings for the Tor and I2P address family implementations 2020-12-14 17:36:35 -05:00
Jean-Paul Calderone
18c18a0e1d explain the inconsistent naming 2020-12-14 17:33:58 -05:00
Jean-Paul Calderone
b6ea3f47c8 unused imports 2020-12-14 16:58:22 -05:00
Jean-Paul Calderone
01507e4f93 some direct tests for DaemonizeTheRealService 2020-12-14 16:57:20 -05:00
Jean-Paul Calderone
a9bcd6270a Merge remote-tracking branch 'origin/master' into 3557.GuessedAtParserWarning 2020-12-14 15:41:31 -05:00
Jean-Paul Calderone
035cd8b4ac Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 15:35:42 -05:00
Jean-Paul Calderone
39628cbb4e
Merge pull request #921 from tahoe-lafs/3550.remove-start-stop-restart-daemonize
remove start stop restart daemonize

Fixes: ticket:3550
Fixes: ticket:3523
Fixes: ticket:3524
2020-12-14 14:58:35 -05:00
Itamar Turner-Trauring
c7759cb82c Try to fix test_web.py on Python 2. 2020-12-14 13:53:12 -05:00
Itamar Turner-Trauring
37d46cfb3d Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-14 13:32:43 -05:00
Itamar Turner-Trauring
28f46e9b06 test_system.py passes on both Python 2 and Python 3. 2020-12-14 11:07:37 -05:00
Jean-Paul Calderone
bdb7c50fac You can just use multiple terminals
If you know how to daemonize stuff you can figure it out yourself I guess.
2020-12-14 09:38:16 -05:00
Jean-Paul Calderone
a0931f4999 You can pass the introducer on the command line 2020-12-14 09:38:06 -05:00
Jean-Paul Calderone
0a1c2386b9 client must be running already 2020-12-14 09:37:04 -05:00
Jean-Paul Calderone
7638064818 Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 09:32:33 -05:00
Sajith Sasidharan
b787de0acc Fix BeautifulSoup's GuessedAtParserWarning 2020-12-13 06:49:49 -05:00
Jean-Paul Calderone
34cd1efaa4 For the sake of clarity, stop talking about daemons here 2020-12-12 18:34:49 -05:00
Jean-Paul Calderone
b58b07a9d7 Fold run_common into tahoe_run since there are no other run-like commands anymore 2020-12-12 18:26:22 -05:00
Jean-Paul Calderone
39631a90bf we always use --nodaemon 2020-12-12 18:23:01 -05:00
Jean-Paul Calderone
25c98d7421 don't shadow the global 2020-12-12 18:21:35 -05:00
Jean-Paul Calderone
692285ada3 key-generator was removed 2020-12-12 18:21:16 -05:00
Jean-Paul Calderone
ed2152e2c8 We don't need to check this condition. We're always running. 2020-12-12 18:20:26 -05:00
Jean-Paul Calderone
d8da612055 Move the --nodaemon logic out of tahoe_run
We're always going to --nodaemon from now on
2020-12-12 18:20:09 -05:00
Jean-Paul Calderone
f17a5dfafc key-generator was apparently removed long ago 2020-12-12 17:40:13 -05:00
Jean-Paul Calderone
51e50671e5 Get rid of the "tahoe start" and "tahoe stop" and fix the obvious problems
This just requires the client node to already be running now.
2020-12-11 15:32:24 -05:00
Itamar Turner-Trauring
98330d7186 Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-11 13:24:04 -05:00
Itamar Turner-Trauring
9bf221dea4 Match Foolscap better. 2020-12-11 13:10:56 -05:00
Itamar Turner-Trauring
42f2f2318c Fix some Python 3 tests. 2020-12-11 13:05:21 -05:00
Itamar Turner-Trauring
cf6206ca42 Fix test_filesystem_with_cli_in_subprocess on Python 2. 2020-12-11 12:37:23 -05:00
Itamar Turner-Trauring
36f18e0afb Fix test_filesystem on Python 2. 2020-12-11 12:30:12 -05:00
Jean-Paul Calderone
9a8f72202d Check for these exceptions and report them better 2020-12-11 11:23:10 -05:00
Jean-Paul Calderone
efac902e57 Slightly better user-facing privacy error message here 2020-12-11 11:23:02 -05:00
Itamar Turner-Trauring
36e53caaeb Add test coverage for packing UnknownNode with missing read-only URI. 2020-12-11 11:14:50 -05:00
Itamar Turner-Trauring
66cd68d325 Merge remote-tracking branch 'origin/master' into 3553.nodemaker-python-3 2020-12-11 10:48:50 -05:00
Itamar Turner-Trauring
b1f478c5df Note test_system.py is only partially ported. 2020-12-11 10:48:34 -05:00
Jean-Paul Calderone
9259264d27 Get rid of the remaining mocks 2020-12-11 10:38:15 -05:00
Jean-Paul Calderone
0cdf66a991 Make the Tor/I2P "provider" interfaces explicit 2020-12-11 10:35:22 -05:00
Jean-Paul Calderone
733223c8d7 Refactor create_main_tub to make testing tub location logic easier
Then take advantage of this and simplify the tub location logic test
2020-12-11 10:34:30 -05:00
Jean-Paul Calderone
624916e06b
Merge branch 'master' into 3550.remove-start-stop-restart-daemonize 2020-12-10 19:47:47 -05:00
Jean-Paul Calderone
1c7c228f90 Merge remote-tracking branch 'origin/master' into 3549.remove-stats-gatherer 2020-12-10 18:27:54 -05:00
Jean-Paul Calderone
e8e928aced Remove the web view onto the removed metrics 2020-12-10 18:24:00 -05:00
Itamar Turner-Trauring
a2e2ee596b Some progress(?) towards passing tests. 2020-12-10 11:47:02 -05:00
Itamar Turner-Trauring
ba9e0db66e Skip test_filesystem on Python 3 for now. 2020-12-10 11:17:46 -05:00
Itamar Turner-Trauring
5c1d904f57 Skip test on Python 3 for now, since that is not going to work in short term. 2020-12-10 11:00:15 -05:00
Itamar Turner-Trauring
c356ced49b Another passing test on Python 3. 2020-12-10 10:56:41 -05:00
Itamar Turner-Trauring
36bf9224e6 More progress on Python 3, unbreak Python 2. 2020-12-10 10:52:07 -05:00
Itamar Turner-Trauring
fb621f4388 Port idlib to Python 3, making its behavior consistent across Python 2 and 3. 2020-12-10 10:11:43 -05:00
Itamar Turner-Trauring
e9b0a526bd
Merge branch 'master' into 3551.more-immutable-python-3 2020-12-10 10:06:53 -05:00
Jean-Paul Calderone
4ac95a1ede Merge remote-tracking branch 'origin/master' into 3522.test_alias-no-mock 2020-12-10 07:19:43 -05:00
Jean-Paul Calderone
6f80862ec5 Slightly clean up formatting implementation 2020-12-10 07:19:27 -05:00
Jean-Paul Calderone
066e98874b Point at do_cli_unicode here too 2020-12-10 07:17:24 -05:00
Jean-Paul Calderone
d0c22a529e json.dumps output should always be ascii 2020-12-10 07:16:00 -05:00
Jean-Paul Calderone
2f53225765 better helper name 2020-12-10 07:06:01 -05:00
Jean-Paul Calderone
4bb28cadcb motivate its existence a bit more 2020-12-10 07:04:28 -05:00
Jean-Paul Calderone
c39f7721af run_cli_bytes docstring 2020-12-10 07:03:24 -05:00
Jean-Paul Calderone
d29d9c57e7 These values aren't used for the exercised codepaths
So just use None instead.  Kind of a weak fix but a fix nonetheless.
2020-12-10 06:59:41 -05:00
Jean-Paul Calderone
89441d9169 Refactor create_connection_handlers so we don't need Tor and I2P mocks 2020-12-09 16:18:48 -05:00
Jean-Paul Calderone
e2963856d3 Dependency Injection for _tub_portlocation 2020-12-09 15:48:40 -05:00
Itamar Turner-Trauring
995f271d38 Merge branch '3553.nodemaker-python-3' into 3552.test_system-python-3 2020-12-09 15:01:01 -05:00
Itamar Turner-Trauring
96fd1861d2 Port to Python 3. 2020-12-09 14:58:54 -05:00
Itamar Turner-Trauring
bb06067c33 Port to Python 3. 2020-12-09 14:48:33 -05:00
Itamar Turner-Trauring
5cba8a4380 Port to Python 3. 2020-12-09 14:45:07 -05:00
Itamar Turner-Trauring
b1800c457d All tests pass on Python 3. 2020-12-09 14:33:56 -05:00
Itamar Turner-Trauring
ff64432282 More passing on Python 3.. 2020-12-09 14:14:07 -05:00
Itamar Turner-Trauring
59968d099c More passing tests. 2020-12-09 14:05:03 -05:00
Itamar Turner-Trauring
016240d6e6 More passing tests on Python 3. 2020-12-09 13:50:15 -05:00
Itamar Turner-Trauring
6b8fd2f29d Some progress towards passing tests on Python 3. 2020-12-09 13:45:31 -05:00
Itamar Turner-Trauring
48bef7db99 Some straightforward changes to support Python 3. 2020-12-09 13:42:35 -05:00
Itamar Turner-Trauring
63ff67a7be Ported to Python 3. 2020-12-09 13:33:01 -05:00
Itamar Turner-Trauring
eb55c10eea Tests pass on Python 3. 2020-12-09 13:28:16 -05:00
Itamar Turner-Trauring
baed5fd734 Port to Python 3. 2020-12-09 13:22:51 -05:00
Itamar Turner-Trauring
5924da93d8 More bytes. 2020-12-09 13:18:45 -05:00
Itamar Turner-Trauring
add26895cf Another passing test on Python 3. 2020-12-09 13:11:39 -05:00
Itamar Turner-Trauring
b61b0a9001 Some more progress towards Python 3. 2020-12-09 13:02:29 -05:00
Itamar Turner-Trauring
1ab1aaea47 Some more progress towards Python 3. 2020-12-09 12:59:37 -05:00
Itamar Turner-Trauring
1adb40cf3b Some more progress towards Python 3. 2020-12-09 12:52:53 -05:00
Itamar Turner-Trauring
b11161a7aa Start porting to Python 3. 2020-12-09 12:47:07 -05:00
Jean-Paul Calderone
74c3990456 This extra stop complexity is no longer needed 2020-12-09 10:57:02 -05:00
Jean-Paul Calderone
5b0190b9a1 Remove some more test code related to start/restart/stop 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
d346c90c6e This is gonna take some work 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
ca92fa4eb5 Don't think about "tahoe start" 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
4d28b0ec27 Get rid of "tahoe start", "tahoe daemonize", "tahoe stop", "tahoe restart" 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
a34fca8e7a Don't think about "tahoe start" 2020-12-09 10:51:10 -05:00
Jean-Paul Calderone
9a27254afa unused import 2020-12-09 10:39:03 -05:00
Jean-Paul Calderone
9412cf70c2 remove unused helper 2020-12-09 10:36:17 -05:00
Jean-Paul Calderone
d7ec5a19be Don't implement the stats gatherer or support configuring or talking to one 2020-12-09 10:34:16 -05:00
Jean-Paul Calderone
3fd1b336b4 Don't test stats gatherer support in the runner 2020-12-09 10:32:49 -05:00
Jean-Paul Calderone
d916c725e6 Don't set up or query a stats gatherer in test_system 2020-12-09 10:32:26 -05:00
Itamar Turner-Trauring
67549aaed5 Merge remote-tracking branch 'origin/master' into 3456.introducer-python3 2020-12-09 09:21:02 -05:00
Itamar Turner-Trauring
0cf9be18d7 Merge remote-tracking branch 'origin/master' into 3544.furls-not-bytes-maybe 2020-12-08 16:08:12 -05:00
Itamar Turner-Trauring
754b88a0b9 Fix failing test. 2020-12-08 13:47:53 -05:00
Jean-Paul Calderone
69d3dad646 Get rid of remote_host / get_remote_host
Nothing uses it and if we don't provide it we don't need getLocationHints
2020-12-08 10:37:31 -05:00
Jean-Paul Calderone
eddf7fd8f9 Remove the pre-generated key/certificate 2020-12-08 10:34:25 -05:00
Itamar Turner-Trauring
dcd865897e
Merge branch 'master' into 3544.furls-not-bytes-maybe 2020-12-08 10:30:00 -05:00
Itamar Turner-Trauring
0b7c0bf451 Document furl type. 2020-12-08 10:28:47 -05:00
Jean-Paul Calderone
d83e4790c3 Let subscribed_to get initialized right 2020-12-07 13:14:00 -05:00
Jean-Paul Calderone
d415bda72a
Merge branch 'master' into 3521.test_storage_client-no-mock 2020-12-07 12:03:50 -05:00
Jean-Paul Calderone
61ee26fb00 ticket reference 2020-12-07 10:46:20 -05:00
Jean-Paul Calderone
1a77ba5698 remove redundant u prefix 2020-12-07 10:37:25 -05:00
Jean-Paul Calderone
d6d64f6b27 fix the json case 2020-12-07 10:37:22 -05:00
Jean-Paul Calderone
87e808b392 one more switch 2020-12-07 10:18:05 -05:00
Jean-Paul Calderone
c7358e6639 Switch over to the helper in the two functions that matter for this PR 2020-12-07 10:16:48 -05:00
Jean-Paul Calderone
a8e3424ef6 remove another unrelated change that's no longer required 2020-12-07 09:55:27 -05:00
Jean-Paul Calderone
d2664121b9 backout no-longer required unrelated change 2020-12-07 09:51:34 -05:00
Jean-Paul Calderone
72744c9464 more docstrings and properly support (and use) encoding=None throughout 2020-12-07 09:47:48 -05:00
Jean-Paul Calderone
05d271c7c8 a little more exposition 2020-12-07 09:26:58 -05:00
Jean-Paul Calderone
7b3a5aceb8 These tests can't reach any of the codepaths where quote_output matters
So simplify
2020-12-07 09:21:56 -05:00
Jean-Paul Calderone
f4432d3f23 Respect the provided encoding
UTF-8 is great but if we're claiming the encoding is something else everywhere
else we can't just make it UTF-8 here.
2020-12-07 09:12:38 -05:00
Jean-Paul Calderone
56f141e170 decode instead of encoding in maybe_decode
legacy from when the bytes/unicode tower was upsidedown compared to how it is now
2020-12-07 09:12:04 -05:00
Jean-Paul Calderone
72a5b571ca Only test the cases we can make work everywhere
These tests previously (in this branch) tried to exercise more ``show_output``
logic than they can actually reach due to the requirement that argv be
interpretable.  Shrink the test suite down to just what we can squeeze through
argv and deal with fully testing ``show_output`` elsewhere.
2020-12-07 09:10:59 -05:00
Jean-Paul Calderone
93b30d0dde The implementation can't reliably see the encoding we're faking without this 2020-12-07 09:06:21 -05:00
Jean-Paul Calderone
8ca98bb8ca using run_cli_unicode, better expect unicode result 2020-12-07 09:06:00 -05:00
Jean-Paul Calderone
c12b082fa7 Put run_cli back largely how it was
Also deal with StringIO better in show_output
2020-12-06 20:37:28 -05:00
Jean-Paul Calderone
613777d166 Make sure this one is bytes too 2020-12-06 19:23:13 -05:00
Jean-Paul Calderone
5aee8b422d Oops there's another case 2020-12-06 18:39:09 -05:00
Jean-Paul Calderone
2955d22f72 note a problem with test_system 2020-12-06 18:38:51 -05:00
Jean-Paul Calderone
b464fa6483 docstring 2020-12-06 18:28:11 -05:00
Jean-Paul Calderone
77bebb9916 [wip] remove mock from test_alias, along with a bunch of encoding-related changes :/ 2020-12-06 17:00:34 -05:00
Jean-Paul Calderone
c4b58fe00b unused import 2020-12-06 11:04:19 -05:00
Jean-Paul Calderone
d29210a140 unused import 2020-12-06 11:04:05 -05:00
Jean-Paul Calderone
238590d7fd Remove mock by removing a bunch of unicode shenanigans 2020-12-06 11:03:44 -05:00
Jean-Paul Calderone
8278fa9c62 Name the pem so it gets installed
Also use the new_tub helper that reads the pem so we don't have to generate a
new cert in this test
2020-12-06 10:39:25 -05:00
Jean-Paul Calderone
386f30fa79 Remove Mock from test_threshold_reached 2020-12-06 10:30:08 -05:00
Jean-Paul Calderone
24709fa758
Merge branch 'master' into 3547.furl-py36-regression 2020-12-05 13:29:27 -05:00
Jean-Paul Calderone
d7f005badd
Merge branch 'master' into 3520.test_client-no-mock 2020-12-05 12:55:25 -05:00
Jean-Paul Calderone
ac7491680b fix unicode/bytes stuff in the affected tests 2020-12-05 09:06:45 -05:00
Jean-Paul Calderone
bdc75c3361 Merge remote-tracking branch 'origin/master' into 3539.nodemaker-weakrefdict 2020-12-05 07:23:54 -05:00
Jason R. Coombs
3eb975748a Ignore type checks in allmydata. 2020-12-04 19:56:51 -05:00
Itamar Turner-Trauring
c1a699dede Flake. 2020-12-04 11:39:57 -05:00
Itamar Turner-Trauring
22dcd726e6 Port to Python 3. 2020-12-04 11:36:17 -05:00
Itamar Turner-Trauring
15735e70bc Port to Python 3. 2020-12-04 11:35:59 -05:00
Jean-Paul Calderone
15d0207f89
Merge pull request #897 from tahoe-lafs/3504.private-introducer-furl
Deprecate tahoe.cfg [client]introducer.furl

Fixes: ticket:3504
2020-12-04 09:44:19 -05:00
Itamar Turner-Trauring
0386924d00 Fix flake. 2020-12-02 15:26:25 -05:00
Itamar Turner-Trauring
b716456019 Merge remote-tracking branch 'origin/master' into 3544.furls-not-bytes-maybe 2020-12-02 15:24:31 -05:00