ExternalVendorCode/tahoe-lafs
1
0
Fork 0
mirror of https://github.com/tahoe-lafs/tahoe-lafs.git synced 2025-04-01 16:20:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add reference to ticket for ambiguous MRO

Browse Source
This commit is contained in:
Jason R. Coombs 2020-12-26 12:33:22 -05:00
parent 1bf71fd690
commit 01147f4627
4 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/allmydata/test/no_network.py
View File

@ -261,7 +261,7 @@ def create_no_network_client(basedir):
return defer.succeed(client)
class _NoNetworkClient(_Client): # type: ignore # Cannot determine consistent MRO order
class _NoNetworkClient(_Client): # type: ignore # tahoe-lafs/ticket/3573
"""
Overrides all _Client networking functionality to do nothing.
"""

2
src/allmydata/test/test_dirnode.py
View File

@ -1587,7 +1587,7 @@ class FakeNodeMaker(NodeMaker):
def create_mutable_file(self, contents="", keysize=None, version=None):
return defer.succeed(FakeMutableFile(contents))
class FakeClient2(_Client): # type: ignore # ambiguous MRO
class FakeClient2(_Client): # type: ignore # tahoe-lafs/ticket/3573
def __init__(self):
self.nodemaker = FakeNodeMaker(None, None, None,
None, None,

6
src/allmydata/test/test_storage_client.py
View File

@ -91,11 +91,7 @@ from allmydata.interfaces import (
SOME_FURL = b"pb://abcde@nowhere/fake"
# type checks fail with:
# Cannot determine consistent method resolution order (MRO) for "NativeStorageServerWithVersion"
# even though class hierarchy is single-inheritance. Probably `implementer`
# wrappers are affecting the MRO.
class NativeStorageServerWithVersion(NativeStorageServer): # type: ignore
class NativeStorageServerWithVersion(NativeStorageServer): # type: ignore # tahoe-lafs/ticket/3573
def __init__(self, version):
# note: these instances won't work for anything other than
# get_available_space() because we don't upcall

4
src/allmydata/test/web/test_web.py
View File

@ -189,7 +189,7 @@ class FakeHistory(object):
def list_all_helper_statuses(self):
return []
class FakeDisplayableServer(StubServer): # type: ignore # Cannot determine MRO
class FakeDisplayableServer(StubServer): # type: ignore # tahoe-lafs/ticket/3573
def __init__(self, serverid, nickname, connected,
last_connect_time, last_loss_time, last_rx_time):
StubServer.__init__(self, serverid)
@ -255,7 +255,7 @@ class FakeStorageServer(service.MultiService):
def on_status_changed(self, cb):
cb(self)
class FakeClient(_Client): # type: ignore # Cannot determine MRO
class FakeClient(_Client): # type: ignore # tahoe-lafs/ticket/3573
def __init__(self):
# don't upcall to Client.__init__, since we only want to initialize a
# minimal subset