meejah
018e161f19
don't allow trailing slashes
...
This makes /uri/xxx URIs invalid if they have a trailing slash.
It seems that the former Nevow implementation would allow this, and
some tests (and, notable, "tahoe backup") did rely on using URIs
of this style.
2020-04-18 01:52:18 -06:00
meejah
8f35f78194
temporary fix for hypothesis test
2020-04-18 01:52:18 -06:00
meejah
c246b3e049
self.assertEqual not assert
2020-04-18 01:52:18 -06:00
meejah
701915783c
make unpack/pack test use Hypothesis
2020-04-18 01:52:18 -06:00
meejah
3d3feec059
encode for fail() / Exception
2020-04-18 01:52:18 -06:00
meejah
d533becc07
native strings only
2020-04-18 01:52:18 -06:00
meejah
ef5e18b6c7
unused
2020-04-18 01:52:18 -06:00
meejah
fdb3399edb
just delete test_welcome
2020-04-18 01:52:18 -06:00
meejah
b44980ca01
get rid of assert_
2020-04-18 01:52:18 -06:00
meejah
e4d556b49e
assert about connected storage servers
2020-04-18 01:52:18 -06:00
meejah
f9956f4c43
remove asserts for static text
2020-04-18 01:52:18 -06:00
meejah
9ccbe562d7
add break
2020-04-18 01:52:18 -06:00
meejah
d12fd573d3
assert for noreferrer
2020-04-18 01:52:18 -06:00
meejah
48f859f5d4
document internal callback
2020-04-18 01:52:18 -06:00
meejah
685aaf14bf
soup, not re
2020-04-18 01:52:17 -06:00
meejah
af35483fbf
soup not re
2020-04-18 01:52:17 -06:00
meejah
b71d4993c6
more soup
2020-04-18 01:52:17 -06:00
meejah
b4fab4403f
use soup, not strings
2020-04-18 01:52:17 -06:00
meejah
bd1cbde273
re/string checks -> soup
2020-04-18 01:52:17 -06:00
meejah
76516fe02e
use soup, not re
2020-04-18 01:52:17 -06:00
meejah
c489c61404
refactor
2020-04-18 01:52:17 -06:00
meejah
d5ef65d326
beautifulsoup, not re
2020-04-18 01:52:17 -06:00
meejah
bf3c71c35f
change not required
2020-04-18 01:52:17 -06:00
meejah
178c45eb0d
remove print
2020-04-18 01:52:17 -06:00
meejah
25096715fb
flake8
2020-04-18 01:52:17 -06:00
meejah
044d1cfbea
correct error
2020-04-18 01:52:17 -06:00
meejah
d0c47fe1d1
irrelevant comment
2020-04-18 01:52:17 -06:00
meejah
97a3f61c28
irrelevant comment
2020-04-18 01:52:17 -06:00
meejah
bc04c9b3db
detech empty pathname components, hopefully the same way as Nevow
2020-04-18 01:52:17 -06:00
meejah
d26ce3beb0
some things that fail, but not in quite the right way .. for reasons
2020-04-18 01:52:17 -06:00
meejah
e894795898
redirects don't have to be absolute
2020-04-18 01:52:17 -06:00
meejah
543a948d32
shadowed test name; reveal both tests
2020-04-18 01:52:17 -06:00
meejah
800b69047c
the error-message changed
2020-04-18 01:52:17 -06:00
meejah
247fc54f8c
explicit pack/unpack test
2020-04-18 01:52:17 -06:00
Sajith Sasidharan
82cd5a87fe
Use DummyRequest in storage tests
...
Using twisted.web.server.Request causes test_new_style_classes to
fail like so:
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Traceback (most recent call last):
File ".tox/coverage/lib/python2.7/site-packages/allmydata/test/test_python2_regressions.py", line 69, in test_new_style_classes
"Expected to find no classic classes.",
File ".tox/coverage/lib/python2.7/site-packages/testtools/testcase.py", line 502, in assertThat
raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = set([])
actual = set([<class allmydata.test.test_storage.JSONRequest at 0x7fd938040bb0>])
: Expected to find no classic classes.
Seems that `DummyRequest` is an acceptable new style class.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
b2b7061980
Refactor storage test helpers
...
Rewrite `renderSynchronously()` to use `renderDeferred()`
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
72b8f72080
Add docstrings to storage test helpers
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
8b7ef33b3d
Remove redundant render_json() method
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
8c92187d92
Avoid using nevow FakeRequest in storage test.
...
Use twisted.web.server.Request instead, with a DummyChannel.
There's still one line of inevitable nevow now, because of code in
web/common.py; but that should be easily replaceable once we switch
that over.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
f1fe3a7588
Get rid of WebRenderingMixin in storage test
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
110734daf0
Use a helper to exercise render() in storage test cases
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
554c477cea
Prefix member variable with "_"
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
ff019e5b12
Use BeautifulSoup to check favicon in storage page
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
c061f6830e
Use successResultOf in renderSynchronously
...
Get rid of [].append trick when dealing with the deferred.
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
e2fc1fc07e
Move renderSynchronously to test suite
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
d3ff578640
Use parentheses in test suite's import statement
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
0993e61046
Drop unused ctx argument from render_space methods
2020-04-17 15:25:42 -04:00
Sajith Sasidharan
c7a63f957d
Refactor so that test_util pass
2020-04-17 15:25:42 -04:00
Jean-Paul Calderone
2136ef46a1
Merge pull request #695 from tahoe-lafs/3284.remove-magic-folder
...
Remove magic-folder, now a stand-alone project
See https://github.com/LeastAuthority/magic-folder
Fixes: ticket:3284
2020-04-16 08:07:38 -04:00
Jean-Paul Calderone
71aa17ab0b
I assume it's utf-8
2020-04-15 09:07:23 -04:00
