Sajith Sasidharan
c14197e1bc
Make FakeDownloadStatus an instance of DownloadStatus
...
The real DownloadStatus is easy enough to instantiate. Might as well
use that, cutting some crufty code here.
2020-07-17 16:13:07 -04:00
Sajith Sasidharan
7bee9ff540
Untabify again
2020-07-08 13:56:52 -04:00
Sajith Sasidharan
4d22390b59
Untabify
2020-07-08 13:29:01 -04:00
Sajith Sasidharan
51d6307b45
Fail better when timings data isn't available
2020-07-08 13:08:35 -04:00
Sajith Sasidharan
112cfc1da5
Test if download status page can be rendered partially
2020-07-08 13:08:35 -04:00
Sajith Sasidharan
c187e2752b
Parameterize FakeDownloadResults and FakeDownloadStatus
2020-07-08 13:08:35 -04:00
Sajith Sasidharan
81216f18bf
Remove some whitespace
2020-07-08 10:15:33 -04:00
Sajith Sasidharan
d6ea30b935
Test more markup rendered by DownloadStatusElement
2020-07-07 22:20:49 -04:00
Sajith Sasidharan
0db56f99cf
Add some tests for DownloadStatusElement
2020-07-07 20:49:58 -04:00
Sajith Sasidharan
7757756a41
Use correct tag type
2020-07-07 20:45:30 -04:00
Sajith Sasidharan
0c4d24a2ac
Avoid use of deferred within an Element
...
This causes the final HTML to be rendered funny, with a bunch of
"<Deferred current result=...>", which is clearly not what we want.
2020-07-07 20:24:56 -04:00
Sajith Sasidharan
7877d8a5cc
Use an accessor
2020-07-07 19:55:14 -04:00
Sajith Sasidharan
a3bf4e0269
Remove an unused import
2020-07-06 20:18:22 -04:00
Sajith Sasidharan
e6eb387707
Remove status.RateAndTimeMixin
...
Both UploadResultsRenderer and DownloadResultsRenderer do not use
RateAndTimeMixin anymore: safe to remove it now.
Tests for methods formerly in RateAndTimeMixin have been moved to
test.web.test_util: specifically test_abbreviate_rate() and
test_abbreviate_time().
2020-07-06 17:11:30 -04:00
Sajith Sasidharan
4a47e8311f
Merge 'origin/master' into 3288.status-download-nevow-to-twisted-web
2020-07-06 16:38:23 -04:00
Sajith Sasidharan
25f5e659fc
Merge pull request #721 from sajith/3287.status-upload-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.UploadStatusPage
Fixes: ticket:3287
2020-07-06 16:20:40 -04:00
Sajith Sasidharan
61aef4caef
Merge pull request #690 from sajith/3247.storage-py-neovw-to-twt
...
Use twisted.web.template in web/storage.py
Fixes: ticket:3247
2020-07-06 16:18:34 -04:00
meejah
ffd24b9c7f
Merge pull request #728 from meejah/ticket3317-verified-fakes
...
Ticket 3317: start of verified fakes
2020-06-30 19:40:39 +00:00
meejah
80359e02e6
assert -> Exception
2020-06-30 08:17:34 -06:00
meejah
a9f4210014
streap -> stream
2020-06-30 08:15:58 -06:00
Sajith Sasidharan
88d3fa7415
Remove now-unnecessary UploadResultsPage.render_UPLOAD
2020-06-23 21:54:23 -04:00
Sajith Sasidharan
dfbb8e7743
Make UploadResultsPage a Resource
2020-06-23 21:53:39 -04:00
Sajith Sasidharan
6ab7f26faf
Make UploadStatusPage a Resource
2020-06-23 21:28:31 -04:00
Sajith Sasidharan
00e852c465
Make DownloadStatus an object
...
PythonTwoRegressions.test_new_style_classes would be unhappy without
this.
2020-06-23 20:54:49 -04:00
Sajith Sasidharan
36ecd8f384
Use render_GET()
...
Implementing `render_METHOD()` is preferred over overriding render()
2020-06-23 20:54:49 -04:00
Sajith Sasidharan
b14c0a0495
Make DownloadStatusPage a Resource
...
No need of this being a MultiFormatResource, because it renders just
HTML.
2020-06-23 20:54:49 -04:00
meejah
aedc58ef51
unused imports
2020-06-19 17:22:42 -06:00
meejah
f0ac5a2cef
more-testtools-y asserts
2020-06-19 17:19:30 -06:00
meejah
57eb875354
testtool's asserts
2020-06-19 17:16:39 -06:00
meejah
ef71fc2bfc
Get rid of ?replace= handling entirely and more-correctly support /uri variants
2020-06-19 17:15:01 -06:00
Sajith Sasidharan
7a23c8ed6c
Merge pull request #724 from sajith/3312.webui-directory-fix
...
Fix for "the webapi does not allow empty pathname components"
Fixes: ticket:3312
2020-06-17 10:55:21 -04:00
Sajith Sasidharan
fe967d208b
Merge pull request #727 from sajith/3315.operations-reload-mixin-nevow-to-twisted
...
Replace nevow with twisted.web in operations.ReloadMixin
Fixes: ticket:3315
2020-06-16 19:17:27 -04:00
Sajith Sasidharan
bd20f8d6f4
Update newsfragment text
2020-06-16 12:10:44 -04:00
meejah
6a37f32eef
use attr.s
2020-06-13 17:28:28 -06:00
meejah
939f60f620
embetter docstring
2020-06-13 17:22:17 -06:00
meejah
caf77be8ae
different words for news
2020-06-13 02:05:27 -06:00
meejah
d221787541
better docstring
2020-06-13 02:03:19 -06:00
meejah
02a543515f
replciate Tahoe's behavior for replace=true/false
2020-06-13 01:55:14 -06:00
meejah
0cbdbd9ebe
symbols, not magic-numbers
2020-06-13 01:14:45 -06:00
meejah
b952ef066c
match query args
2020-06-13 00:46:55 -06:00
meejah
24899dae8e
assert -> ValueError
2020-06-13 00:41:22 -06:00
meejah
76040b53f5
assert -> raise
2020-06-13 00:39:57 -06:00
meejah
9f6fcde2f1
more docstring
2020-06-13 00:39:12 -06:00
meejah
a38188164f
comment
2020-06-12 23:08:04 -06:00
meejah
c64e78634d
docstring
2020-06-12 23:06:33 -06:00
meejah
23b17ca02e
cleanup, docstrings
2020-06-12 23:05:32 -06:00
meejah
e79534abe8
housekeeping
2020-06-12 23:01:02 -06:00
meejah
fa597e1735
use real parser
2020-06-12 22:57:38 -06:00
meejah
949b09ce27
actually returns CREATED for new data
2020-06-12 22:08:36 -06:00
meejah
776ee5f91c
use hypothesis -- which doesn't know about Deferred, so need testtools too
2020-06-12 22:04:12 -06:00
