Commit Graph

4099 Commits

Author SHA1 Message Date
Itamar Turner-Trauring
c5669e16e0 Fix flake. 2021-01-13 09:56:08 -05:00
Jean-Paul Calderone
216efb2aed unused import 2021-01-12 16:52:43 -05:00
Jean-Paul Calderone
43dc85501f is this api less troublesome? 2021-01-12 16:03:28 -05:00
Jean-Paul Calderone
6984f2be3f Try to get the Python 2 / Windows case working 2021-01-12 15:58:07 -05:00
Jean-Paul Calderone
6c430bd4e6 re-add a direct unicode_to_argv test
harder to express the conditional in skips so the two tests become one
2021-01-12 15:16:18 -05:00
Jean-Paul Calderone
9c63703efc no effort being made to support these locales 2021-01-12 15:15:42 -05:00
Jean-Paul Calderone
44d76cb159 fix formatting mistake 2021-01-12 15:00:02 -05:00
Jean-Paul Calderone
5a145e74ef a mild warning/suggestion here 2021-01-12 14:59:16 -05:00
Itamar Turner-Trauring
5d77282784 Ported to Python 3. 2021-01-12 14:40:33 -05:00
Itamar Turner-Trauring
7a3e9ab43e Tests pass on Python 3. 2021-01-12 14:39:20 -05:00
Itamar Turner-Trauring
03fb936716 Port to Python 3. 2021-01-12 14:25:16 -05:00
Itamar Turner-Trauring
4940da47da Tests pass on Python 3. 2021-01-12 14:24:17 -05:00
Itamar Turner-Trauring
8c41f60fdb Port to Python 3. 2021-01-12 14:17:38 -05:00
Itamar Turner-Trauring
bd364feec5 Tests pass on Python 3. 2021-01-12 14:14:52 -05:00
Jean-Paul Calderone
aa4f113027 Get the monkey patching right 2021-01-12 14:11:43 -05:00
Itamar Turner-Trauring
c2d69c5309 Merge all log tests into one test module. 2021-01-12 11:41:19 -05:00
Itamar Turner-Trauring
116c59142d Port to Python 3. 2021-01-12 11:26:43 -05:00
Jean-Paul Calderone
8f498437cf whitespace 2021-01-12 10:11:23 -05:00
Jean-Paul Calderone
ae1a0c591b Prefer to fix unicode_to_argv/argv_to_unicode instead of callers 2021-01-12 09:58:34 -05:00
Jean-Paul Calderone
70d2fd6672 Don't have a Latin-1 io_encoding
It's bad
2021-01-11 19:31:22 -05:00
Jean-Paul Calderone
60a44b99e6 improve fixtures 2021-01-11 19:30:15 -05:00
Jean-Paul Calderone
23c34004a7 Get rid of tests for bad io_encoding values
We don't like bad io_encoding values
2021-01-11 19:29:49 -05:00
Jean-Paul Calderone
3d02545006 Remove tests based on locale behavior
We don't like locale behavior
2021-01-11 19:29:15 -05:00
Jean-Paul Calderone
de9bcc7ea8 encode Popen argv as UTF-8 on POSIX so we ignore locale 2021-01-11 19:21:20 -05:00
Jean-Paul Calderone
b8abec6073 Get rid of the Latin-1 case
Here's a supposition: UTF-8 or bust
2021-01-11 16:00:48 -05:00
Jean-Paul Calderone
2306819db1 Get rid of unicode_to_argv and argv_to_unicode 2021-01-11 15:45:39 -05:00
Jean-Paul Calderone
5df86b4608 restore test_with_python_options now that I see what it's testing 2021-01-11 15:26:12 -05:00
Jean-Paul Calderone
834abfe6bf _win_subprocess didn't actually export this 2021-01-11 15:09:25 -05:00
Jean-Paul Calderone
c6d108ddb2 Make test_runner and test_windows both use the good Popen 2021-01-11 15:07:37 -05:00
Jean-Paul Calderone
73110f48da Banish getProcessOutputAndValue from test_runner
It cannot do the right thing on Windows for non-ASCII because Twisted uses
pywin32 and on Python 2 pywin32 binds CreateProcessA.
2021-01-11 14:56:46 -05:00
Jean-Paul Calderone
41d7548527 typo 2021-01-11 14:16:02 -05:00
Jean-Paul Calderone
a4c520ec2a try to go faster without losing coverage 2021-01-11 14:11:28 -05:00
Itamar Turner-Trauring
1b1d87f9f9 Merge branch '3584.integration-tests-sftp' into 3579.ftp-python-3 2021-01-11 14:05:07 -05:00
Jean-Paul Calderone
a29b061f91 explain the nested import 2021-01-11 14:04:20 -05:00
Itamar Turner-Trauring
4a7da34a6a
Merge pull request #958 from tahoe-lafs/3583.rip-out-ftp
Rip out FTP support

Fixes ticket:3583
2021-01-11 13:54:00 -05:00
Jean-Paul Calderone
f61103aa80 spell the module name right 2021-01-11 13:22:14 -05:00
Jean-Paul Calderone
f5bcd272b8 skip the other test suite too 2021-01-11 12:58:27 -05:00
Jean-Paul Calderone
6de392fd23 blacklist a couple more 2021-01-11 12:43:30 -05:00
Jean-Paul Calderone
fd223136db Avoid breaking non-Windows with test_windows 2021-01-11 12:42:52 -05:00
Jean-Paul Calderone
1751d682a2 is this cool? 2021-01-11 11:46:40 -05:00
Jean-Paul Calderone
112bfaf625 we would like this to be utf-8 corresponding to the inputs 2021-01-11 11:42:27 -05:00
Jean-Paul Calderone
3adfb2a108 let it be slow 2021-01-11 11:17:57 -05:00
Jean-Paul Calderone
23d1d76242 get the name 2021-01-11 11:16:23 -05:00
Jean-Paul Calderone
8fa1b6bb1e make stdout/stderr available 2021-01-11 11:15:47 -05:00
Jean-Paul Calderone
504b2f5b1f get the syntax right 2021-01-11 11:15:20 -05:00
Jean-Paul Calderone
221f1640a5 make the container 2021-01-11 11:14:32 -05:00
Jean-Paul Calderone
08d56c87b4 that was silly 2021-01-11 11:13:45 -05:00
Jean-Paul Calderone
a0aa3fe296 try testing UnicodeOutput 2021-01-11 11:12:12 -05:00
Jean-Paul Calderone
6d499dea53 exclude nul from the tested argv values 2021-01-11 10:31:37 -05:00
Jean-Paul Calderone
c2e8d94a73 don't fail this test because it is slow 2021-01-11 10:24:25 -05:00
Jean-Paul Calderone
389d70a682 see if GetCommandLine() value is interesting 2021-01-11 10:17:02 -05:00
Jean-Paul Calderone
e2f3964451 okay this is indeed the expected 2021-01-11 10:09:54 -05:00
Jean-Paul Calderone
42f1930914 disambiguate this a bit 2021-01-11 10:08:15 -05:00
Jean-Paul Calderone
30c79bf678 make sure executable is unicode too, if that matters 2021-01-11 09:51:36 -05:00
Jean-Paul Calderone
b5f0e21ef8 testtools convention - actual value comes first 2021-01-10 20:19:15 -05:00
Jean-Paul Calderone
3bde012ea1 Create a better expectation
If we pass all this stuff to Popen we should expect to see it from get_argv() right?
2021-01-10 20:18:00 -05:00
Jean-Paul Calderone
28435d65c1 test the SUT 2021-01-10 20:16:25 -05:00
Jean-Paul Calderone
360b20a981 FilePath again 2021-01-10 20:14:05 -05:00
Jean-Paul Calderone
77c9a2c2f5 make the failures a little nicer 2021-01-10 20:13:17 -05:00
Jean-Paul Calderone
18de71666f try to work-around bugs in the Popen hotfix 2021-01-10 20:10:34 -05:00
Jean-Paul Calderone
a21b66e775 FilePath again 2021-01-10 20:06:07 -05:00
Jean-Paul Calderone
e64a4c6426 Attempt to use a parent-side API that supports unicode properly 2021-01-10 19:59:22 -05:00
Jean-Paul Calderone
6091ca2164 try to get the child source right 2021-01-10 11:23:19 -05:00
Jean-Paul Calderone
b02b930eed do better with paths 2021-01-10 11:22:00 -05:00
Jean-Paul Calderone
a73668a056 this doesn't take a list 2021-01-10 11:21:13 -05:00
Jean-Paul Calderone
24f3d74fdf Fix the skip 2021-01-10 10:48:40 -05:00
Jean-Paul Calderone
e80bd6894f Take a first attempt at testing the argv logic directly 2021-01-10 10:39:51 -05:00
Jean-Paul Calderone
1ae0311e36
Merge pull request #949 from tahoe-lafs/port-webish
Port webish/test_webish to Python 3

Fixes: ticket:3577
2021-01-08 13:51:00 -05:00
Itamar Turner-Trauring
308dbba924 Fix flake. 2021-01-07 09:20:39 -05:00
Itamar Turner-Trauring
7b1bfadd21 Rip out FTP. 2021-01-06 13:39:52 -05:00
Itamar Turner-Trauring
192063acfa Port to Python 3. 2021-01-06 09:59:33 -05:00
Itamar Turner-Trauring
a5e22d93cc All tests pass on Python 3. 2021-01-06 09:54:48 -05:00
Itamar Turner-Trauring
ebaf075966 Another passing test on Python 3. 2021-01-06 09:38:43 -05:00
Itamar Turner-Trauring
f3d795d9a8 More passing tests on Python 3. 2021-01-06 09:31:15 -05:00
Itamar Turner-Trauring
d82bcc5280 Another passing test on Python 3. 2021-01-06 09:26:18 -05:00
Itamar Turner-Trauring
2998057d91 Don't need byte strings for debug! 2021-01-05 16:47:34 -05:00
Itamar Turner-Trauring
06fb9496ab Another test passing on Python 3. 2021-01-05 16:35:57 -05:00
Itamar Turner-Trauring
0241244e49 Another test passing on Python 3. 2021-01-05 16:30:17 -05:00
Itamar Turner-Trauring
3a6f3f2809 Merge remote-tracking branch 'origin/master' into 3579.ftp-python-3 2021-01-05 16:05:56 -05:00
Chad Whitacre
dc5ac4a112
Merge pull request #946 from tahoe-lafs/3574.port-stats
Port stats to Python 3
2021-01-05 06:04:10 -05:00
Itamar Turner-Trauring
4683760ed8
Merge pull request #945 from tahoe-lafs/3566.web-tests-python-3-part-2
Port web tests to Python 3, part 2

Fixes ticket:3566
2021-01-04 15:40:52 -05:00
Jean-Paul Calderone
7a504dd99f
Merge pull request #936 from LeastAuthority/3534.test_introducer-no-mock
Remove mock from test_introducer

Fixes: ticket:3534
2021-01-04 15:06:29 -05:00
Itamar Turner-Trauring
bc19ccc77a Use method that already does this. 2021-01-04 14:36:02 -05:00
Itamar Turner-Trauring
961ad123cc Better name. 2021-01-04 14:35:33 -05:00
Itamar Turner-Trauring
6f0838e2e9 Docstring. 2021-01-04 14:34:18 -05:00
Jean-Paul Calderone
af06bdb182 Merge remote-tracking branch 'origin/master' into 3575.realistic_storage_index_hash-key 2021-01-04 14:14:13 -05:00
Itamar Turner-Trauring
3a6b92f39f More progress to passing tests on Python 3. 2021-01-04 11:48:38 -05:00
Itamar Turner-Trauring
2bf278e55d Even more tests passing on Python 3. 2021-01-04 11:39:25 -05:00
Itamar Turner-Trauring
3d42030e01 More tests pass on Python 3. 2021-01-04 11:21:26 -05:00
Itamar Turner-Trauring
a54aeae338 Port to Python 3. 2021-01-04 11:05:59 -05:00
Itamar Turner-Trauring
744e205763 Tests pass on Python 3. 2021-01-04 11:03:38 -05:00
Chad Whitacre
655be5e3a0 Port stats to Python 3 2021-01-04 06:18:14 -05:00
Jean-Paul Calderone
855521fea8
Merge pull request #935 from LeastAuthority/3529.test_connections-no-mock
Remove mock usage from test_connections.py

Fixes: ticket:3529
2021-01-02 12:48:12 -05:00
Chad Whitacre
b4b4a1aabf Port webish/test_webish to Python 3 2020-12-29 12:39:00 -05:00
Jean-Paul Calderone
30b37e17dd More of a storage_index_hash test 2020-12-29 10:48:03 -05:00
Jason R. Coombs
4a9d3bde5b Exclude allmydata.scripts.types_ module from PythonTwoRegressions. 2020-12-26 13:30:32 -05:00
Jason R. Coombs
6522221166 Suppress error on SpyHandler interface. 2020-12-26 13:12:11 -05:00
Jason R. Coombs
854c22e1ca Use compatible import for urllib.parse.quote. 2020-12-26 13:09:57 -05:00
Jason R. Coombs
3fd46f9400 Ignore additional attribute on the function. 2020-12-26 13:02:16 -05:00
Jason R. Coombs
574613a892 Merge branch 'master' into 3399.mypy 2020-12-26 12:45:09 -05:00
Jason R. Coombs
01147f4627 Add reference to ticket for ambiguous MRO 2020-12-26 12:33:22 -05:00
Jason R. Coombs
1bf71fd690 Replace todo with a ticket. 2020-12-26 12:12:39 -05:00
Jason R. Coombs
dacdf7f12d Add more detail and link to upstream issue for Twisted stubs. 2020-12-26 11:56:13 -05:00
Itamar Turner-Trauring
eb8837a4c8 More things that need to be bytes. 2020-12-23 10:09:37 -05:00
Itamar Turner-Trauring
15f2d433ae Fix tests on Python 3. 2020-12-23 10:01:44 -05:00
Itamar Turner-Trauring
3c8550b666 Python 3 fix: direct indexing of bytes returns an int. 2020-12-23 09:54:35 -05:00
Itamar Turner-Trauring
f736dc6f7b Fix some tests caused by unicode rendering. 2020-12-23 09:34:48 -05:00
Itamar Turner-Trauring
c5b403bd2f Make the class new style again on Python 2. 2020-12-23 09:17:39 -05:00
Itamar Turner-Trauring
2c7dde9978 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-23 09:14:34 -05:00
Itamar Turner-Trauring
55698cc8f2 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-22 13:21:49 -05:00
Itamar Turner-Trauring
1c7956bc1a Port to Python 3. 2020-12-22 13:19:59 -05:00
Itamar Turner-Trauring
8881728ca5 Another passing test on Python 3. 2020-12-22 13:17:07 -05:00
Itamar Turner-Trauring
baa2cff29c Unbreak Python 2. 2020-12-22 13:14:18 -05:00
Itamar Turner-Trauring
013388981c Fix intermittent failing test on PyPy hopefully.
PyPy does not have refcounts, so files were only being closed when GC happened,
which meant their buffered writes never hit disk.
2020-12-22 13:04:53 -05:00
Itamar Turner-Trauring
f9ee4b239f
Merge pull request #934 from tahoe-lafs/3564.eliot-log-testing-python-3
Re-enable logging validation on Python 3.

Fixes ticket:3564
2020-12-22 11:43:36 -05:00
Itamar Turner-Trauring
74c08883f5 Another passing test on Python 3. 2020-12-22 11:36:52 -05:00
Itamar Turner-Trauring
cabfdadc20 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-22 10:48:32 -05:00
Itamar Turner-Trauring
f30376ade6 Make sure test output can encode bytes correctly too. 2020-12-22 10:47:25 -05:00
Jean-Paul Calderone
ab7c382dec
Merge pull request #939 from LeastAuthority/3567.test_storage_client-eaddrinuse
Use a pre-bound listening socket in the test

Fixes: ticket:3567
2020-12-21 13:27:08 -05:00
Itamar Turner-Trauring
b46898f667 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:20:50 -05:00
Itamar Turner-Trauring
7fc64fdf45 Also handle bytes when serializing production Eliot log messages on Python 3. 2020-12-21 13:20:14 -05:00
Itamar Turner-Trauring
a8732a3c70 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:12:19 -05:00
Itamar Turner-Trauring
c25dd57768 Make sure we can handle bytes, plus a couple other fixes. 2020-12-21 13:12:01 -05:00
Itamar Turner-Trauring
2737229895 Another passing test. 2020-12-21 11:12:52 -05:00
Itamar Turner-Trauring
a2f042845d Another passing test. 2020-12-21 10:58:09 -05:00
Itamar Turner-Trauring
d8197d9554 Another passing test. 2020-12-21 10:52:31 -05:00
Itamar Turner-Trauring
15c7af8e72 Another passing test. 2020-12-21 10:29:59 -05:00
Itamar Turner-Trauring
98c71e51e1 More progress towards passing tests. 2020-12-21 10:04:27 -05:00
Itamar Turner-Trauring
2ec7d52d09 Some progress towards passing tests on Python 3. 2020-12-18 16:12:32 -05:00
Itamar Turner-Trauring
5315d48355 Merge remote-tracking branch 'origin/master' into 3565.web-tests-python-3-part-1 2020-12-18 15:43:36 -05:00
Itamar Turner-Trauring
50a794a911 More accurate docstring. 2020-12-18 11:34:08 -05:00
Itamar Turner-Trauring
865f3fd7d0 Improve the docstring. 2020-12-18 11:33:24 -05:00
Itamar Turner-Trauring
8f4a0379ea Correct examples. 2020-12-18 11:26:10 -05:00
Itamar Turner-Trauring
b24a9f7083 Trying to get test_grid working on Python 3. 2020-12-18 11:21:04 -05:00
Jason R. Coombs
99da74fffb Change comment to clarify that it's the implementation that's incomplete. 2020-12-18 09:58:56 -05:00
Jean-Paul Calderone
8e6c52b61e pre-assign a listening socket to the main tub to avoid the error 2020-12-17 10:20:22 -05:00
Itamar Turner-Trauring
6e12cce1e4 Port to Python 3. 2020-12-17 09:55:35 -05:00
Itamar Turner-Trauring
3ac64e42f7 Web test_status tests pass on Python 3. 2020-12-17 09:54:04 -05:00
Itamar Turner-Trauring
9b59e7e245 Merge remote-tracking branch 'origin/3552.test_system-python-3' into 3565.web-tests-python-3-part-1 2020-12-17 09:51:52 -05:00
Itamar Turner-Trauring
33392502d3 server IDs/node IDS should be bytes. 2020-12-17 09:50:39 -05:00
Itamar Turner-Trauring
26297c296d
Merge branch 'master' into 3552.test_system-python-3 2020-12-17 09:42:34 -05:00
Jean-Paul Calderone
0ffbc7870e Okay, let KeyboardInterrupt through 2020-12-16 20:32:04 -05:00
Jean-Paul Calderone
895ba55cf7 Python 3 compatibility 2020-12-16 18:17:14 -05:00
Jean-Paul Calderone
a223f6bb60 More reliably corrupt the signature 2020-12-16 17:31:06 -05:00
Jean-Paul Calderone
98000c2b66 re-implement test_unsigned_announcement without mock
and to make assertions about public behavior instead of private implementation
details
2020-12-16 16:20:38 -05:00
Jean-Paul Calderone
60e401ca69 Make ObserverList synchronous, reentrant, and exception safe
with tests
2020-12-16 16:19:33 -05:00
Jean-Paul Calderone
83ebaef86c Stop mocking safe_load
The comment implies this will cause something to break on some platform.
Let's find out.
2020-12-16 15:24:33 -05:00
Jean-Paul Calderone
d19b1cfd68
Merge pull request #933 from LeastAuthority/3533.test_root-no-mock
Remove Mock from test_root

Fixes: ticket:3533
2020-12-16 15:15:17 -05:00
Itamar Turner-Trauring
b5f2afe39c WIP porting test_status.py. 2020-12-16 14:13:46 -05:00
Itamar Turner-Trauring
67c0a4ac84 Port another test module to Python 3. 2020-12-16 13:53:49 -05:00
Jean-Paul Calderone
9f28ccb2a4 Move the last three mock-using tests to test_tor_provider
where they can be rewritten later
2020-12-16 12:07:54 -05:00
Jean-Paul Calderone
3d82ca0d25 Use boring old dependency injection to replace mocks in this test 2020-12-16 11:50:35 -05:00
Jean-Paul Calderone
3d564f97d5 Switch away from mock in a few more simple cases in test_connections.py 2020-12-16 11:48:33 -05:00
Jean-Paul Calderone
468895c74d Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_control_endpoint 2020-12-16 11:28:36 -05:00
Jean-Paul Calderone
7eb9f2ce54 Moved into allmydata.test.test_i2p_provider
This follows the local convention of using mock even though I'm trying to get
rid of mock.  This is because it keeps the test_i2p_provider suite consistent
which means it won't make removing mock from test_i2p_provider later much
harder and lets me avoid doing that work now.
2020-12-16 11:20:45 -05:00
Itamar Turner-Trauring
61c76902ca Port to Python 3. 2020-12-16 11:16:34 -05:00
Jean-Paul Calderone
8271dbf3e6 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_configdir 2020-12-16 11:15:51 -05:00
Jean-Paul Calderone
81b684b583 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir_executable 2020-12-16 11:15:21 -05:00
Itamar Turner-Trauring
f7362dc1ef Port to Python 3. 2020-12-16 11:14:55 -05:00
Jean-Paul Calderone
6d66be43b9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir 2020-12-16 11:14:46 -05:00
Jean-Paul Calderone
e84860ef15 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch 2020-12-16 11:13:52 -05:00
Itamar Turner-Trauring
acc36c34d0 Tests pass on Python 2 and Python 3. 2020-12-16 11:13:32 -05:00
Jean-Paul Calderone
ececae2ce9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_sam_endpoint 2020-12-16 11:12:36 -05:00
Jean-Paul Calderone
f7c92bf4c9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_default 2020-12-16 11:11:22 -05:00
Jean-Paul Calderone
01b31e0680 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch_executable 2020-12-16 11:06:57 -05:00
Jean-Paul Calderone
61778bc799 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch 2020-12-16 11:05:51 -05:00
Jean-Paul Calderone
71ced4c228 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_socks_endpoint 2020-12-16 11:03:37 -05:00
Jean-Paul Calderone
ec9851f6d8 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_no_i2p 2020-12-16 10:38:13 -05:00
Jean-Paul Calderone
b5d4a2579b Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_disabled 2020-12-16 10:37:41 -05:00
Jean-Paul Calderone
17d9988d45 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_no_tor 2020-12-16 10:34:33 -05:00
Jean-Paul Calderone
d3f8839f1b Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_disabled 2020-12-16 10:34:07 -05:00
Itamar Turner-Trauring
052b3d9fb1 Re-enable logging validation on Python 3. 2020-12-16 10:06:59 -05:00
Itamar Turner-Trauring
54a11dbb6a
Merge pull request #932 from tahoe-lafs/3560.test_eliotutil-python-3
Port eliotutil and tests to Python 3

Fixes ticket:3560
2020-12-16 09:40:19 -05:00
Jean-Paul Calderone
eeebd15c42 Take Mock out of `allmydata.test.test_connections.TCP` 2020-12-16 09:15:37 -05:00
Jean-Paul Calderone
2b1ea5c604 Remove the client Mock object
It wasn't used by anything so that was easy.  Clean up the test as long as
we're here.
2020-12-15 18:30:12 -05:00
Jean-Paul Calderone
c4e8262a99
Merge pull request #925 from tahoe-lafs/3532.test_node-no-mock
Remove mock from test_node

Fixes: ticket:3532
2020-12-15 14:38:07 -05:00
Jean-Paul Calderone
fee8c55f01 The listenOn is probably the most interesting part 2020-12-15 13:42:20 -05:00
Jean-Paul Calderone
7dbcb4d712 Make set_tub_locations a nicer function 2020-12-15 13:41:01 -05:00
Jean-Paul Calderone
53b782aca4 get the function name right 2020-12-15 13:40:12 -05:00
Jean-Paul Calderone
c2dc2b39da A better name 2020-12-15 13:34:04 -05:00
Jean-Paul Calderone
be559ab3a5 Turn the XXX into a TODO'd test and a ticket 2020-12-15 13:31:18 -05:00
Jean-Paul Calderone
29f0ae0554 These don't need to be methods. Also docstrings are nice. 2020-12-15 13:30:58 -05:00
Itamar Turner-Trauring
4a587836a5 Port eliotutil and tests to Python 3. 2020-12-15 10:13:46 -05:00
Itamar Turner-Trauring
6a29568888 Fix flakes. 2020-12-15 09:16:50 -05:00
Itamar Turner-Trauring
c7f2b7dd7c Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-15 09:13:32 -05:00
Jean-Paul Calderone
5c6e0a2bb4 docstrings 2020-12-14 18:33:28 -05:00
Jean-Paul Calderone
677e62e73e Return the canned handler 2020-12-14 18:29:50 -05:00
Jean-Paul Calderone
4b1c6a2815 Remove these reactor parameters 2020-12-14 17:42:30 -05:00
Jean-Paul Calderone
b6ea3f47c8 unused imports 2020-12-14 16:58:22 -05:00
Jean-Paul Calderone
01507e4f93 some direct tests for DaemonizeTheRealService 2020-12-14 16:57:20 -05:00
Jean-Paul Calderone
a9bcd6270a Merge remote-tracking branch 'origin/master' into 3557.GuessedAtParserWarning 2020-12-14 15:41:31 -05:00
Jean-Paul Calderone
035cd8b4ac Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 15:35:42 -05:00
Jean-Paul Calderone
39628cbb4e
Merge pull request #921 from tahoe-lafs/3550.remove-start-stop-restart-daemonize
remove start stop restart daemonize

Fixes: ticket:3550
Fixes: ticket:3523
Fixes: ticket:3524
2020-12-14 14:58:35 -05:00
Itamar Turner-Trauring
c7759cb82c Try to fix test_web.py on Python 2. 2020-12-14 13:53:12 -05:00
Itamar Turner-Trauring
37d46cfb3d Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-14 13:32:43 -05:00
Itamar Turner-Trauring
28f46e9b06 test_system.py passes on both Python 2 and Python 3. 2020-12-14 11:07:37 -05:00
Jean-Paul Calderone
bdb7c50fac You can just use multiple terminals
If you know how to daemonize stuff you can figure it out yourself I guess.
2020-12-14 09:38:16 -05:00
Jean-Paul Calderone
a0931f4999 You can pass the introducer on the command line 2020-12-14 09:38:06 -05:00
Jean-Paul Calderone
0a1c2386b9 client must be running already 2020-12-14 09:37:04 -05:00
Jean-Paul Calderone
7638064818 Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 09:32:33 -05:00
Sajith Sasidharan
b787de0acc Fix BeautifulSoup's GuessedAtParserWarning 2020-12-13 06:49:49 -05:00
Jean-Paul Calderone
34cd1efaa4 For the sake of clarity, stop talking about daemons here 2020-12-12 18:34:49 -05:00
Jean-Paul Calderone
b58b07a9d7 Fold run_common into tahoe_run since there are no other run-like commands anymore 2020-12-12 18:26:22 -05:00
Jean-Paul Calderone
f17a5dfafc key-generator was apparently removed long ago 2020-12-12 17:40:13 -05:00
Jean-Paul Calderone
51e50671e5 Get rid of the "tahoe start" and "tahoe stop" and fix the obvious problems
This just requires the client node to already be running now.
2020-12-11 15:32:24 -05:00
Itamar Turner-Trauring
98330d7186 Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-11 13:24:04 -05:00
Itamar Turner-Trauring
cf6206ca42 Fix test_filesystem_with_cli_in_subprocess on Python 2. 2020-12-11 12:37:23 -05:00
Itamar Turner-Trauring
36f18e0afb Fix test_filesystem on Python 2. 2020-12-11 12:30:12 -05:00
Jean-Paul Calderone
efac902e57 Slightly better user-facing privacy error message here 2020-12-11 11:23:02 -05:00
Itamar Turner-Trauring
36e53caaeb Add test coverage for packing UnknownNode with missing read-only URI. 2020-12-11 11:14:50 -05:00
Itamar Turner-Trauring
66cd68d325 Merge remote-tracking branch 'origin/master' into 3553.nodemaker-python-3 2020-12-11 10:48:50 -05:00
Jean-Paul Calderone
9259264d27 Get rid of the remaining mocks 2020-12-11 10:38:15 -05:00
Jean-Paul Calderone
733223c8d7 Refactor create_main_tub to make testing tub location logic easier
Then take advantage of this and simplify the tub location logic test
2020-12-11 10:34:30 -05:00
Jean-Paul Calderone
624916e06b
Merge branch 'master' into 3550.remove-start-stop-restart-daemonize 2020-12-10 19:47:47 -05:00
Jean-Paul Calderone
1c7c228f90 Merge remote-tracking branch 'origin/master' into 3549.remove-stats-gatherer 2020-12-10 18:27:54 -05:00
Itamar Turner-Trauring
a2e2ee596b Some progress(?) towards passing tests. 2020-12-10 11:47:02 -05:00
Itamar Turner-Trauring
ba9e0db66e Skip test_filesystem on Python 3 for now. 2020-12-10 11:17:46 -05:00
Itamar Turner-Trauring
5c1d904f57 Skip test on Python 3 for now, since that is not going to work in short term. 2020-12-10 11:00:15 -05:00
Itamar Turner-Trauring
c356ced49b Another passing test on Python 3. 2020-12-10 10:56:41 -05:00
Itamar Turner-Trauring
36bf9224e6 More progress on Python 3, unbreak Python 2. 2020-12-10 10:52:07 -05:00
Itamar Turner-Trauring
fb621f4388 Port idlib to Python 3, making its behavior consistent across Python 2 and 3. 2020-12-10 10:11:43 -05:00
Itamar Turner-Trauring
e9b0a526bd
Merge branch 'master' into 3551.more-immutable-python-3 2020-12-10 10:06:53 -05:00
Jean-Paul Calderone
4ac95a1ede Merge remote-tracking branch 'origin/master' into 3522.test_alias-no-mock 2020-12-10 07:19:43 -05:00
Jean-Paul Calderone
066e98874b Point at do_cli_unicode here too 2020-12-10 07:17:24 -05:00
Jean-Paul Calderone
2f53225765 better helper name 2020-12-10 07:06:01 -05:00
Jean-Paul Calderone
4bb28cadcb motivate its existence a bit more 2020-12-10 07:04:28 -05:00
Jean-Paul Calderone
c39f7721af run_cli_bytes docstring 2020-12-10 07:03:24 -05:00
Jean-Paul Calderone
d29d9c57e7 These values aren't used for the exercised codepaths
So just use None instead.  Kind of a weak fix but a fix nonetheless.
2020-12-10 06:59:41 -05:00
Jean-Paul Calderone
89441d9169 Refactor create_connection_handlers so we don't need Tor and I2P mocks 2020-12-09 16:18:48 -05:00
Jean-Paul Calderone
e2963856d3 Dependency Injection for _tub_portlocation 2020-12-09 15:48:40 -05:00
Itamar Turner-Trauring
995f271d38 Merge branch '3553.nodemaker-python-3' into 3552.test_system-python-3 2020-12-09 15:01:01 -05:00
Itamar Turner-Trauring
96fd1861d2 Port to Python 3. 2020-12-09 14:58:54 -05:00
Itamar Turner-Trauring
5cba8a4380 Port to Python 3. 2020-12-09 14:45:07 -05:00
Itamar Turner-Trauring
b1800c457d All tests pass on Python 3. 2020-12-09 14:33:56 -05:00
Itamar Turner-Trauring
ff64432282 More passing on Python 3.. 2020-12-09 14:14:07 -05:00
Itamar Turner-Trauring
59968d099c More passing tests. 2020-12-09 14:05:03 -05:00
Itamar Turner-Trauring
016240d6e6 More passing tests on Python 3. 2020-12-09 13:50:15 -05:00
Itamar Turner-Trauring
6b8fd2f29d Some progress towards passing tests on Python 3. 2020-12-09 13:45:31 -05:00
Itamar Turner-Trauring
63ff67a7be Ported to Python 3. 2020-12-09 13:33:01 -05:00
Itamar Turner-Trauring
eb55c10eea Tests pass on Python 3. 2020-12-09 13:28:16 -05:00
Itamar Turner-Trauring
5924da93d8 More bytes. 2020-12-09 13:18:45 -05:00
Itamar Turner-Trauring
add26895cf Another passing test on Python 3. 2020-12-09 13:11:39 -05:00
Itamar Turner-Trauring
b61b0a9001 Some more progress towards Python 3. 2020-12-09 13:02:29 -05:00
Itamar Turner-Trauring
1ab1aaea47 Some more progress towards Python 3. 2020-12-09 12:59:37 -05:00
Itamar Turner-Trauring
1adb40cf3b Some more progress towards Python 3. 2020-12-09 12:52:53 -05:00
Itamar Turner-Trauring
b11161a7aa Start porting to Python 3. 2020-12-09 12:47:07 -05:00
Jean-Paul Calderone
74c3990456 This extra stop complexity is no longer needed 2020-12-09 10:57:02 -05:00
Jean-Paul Calderone
5b0190b9a1 Remove some more test code related to start/restart/stop 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
d346c90c6e This is gonna take some work 2020-12-09 10:51:48 -05:00
Jean-Paul Calderone
ca92fa4eb5 Don't think about "tahoe start" 2020-12-09 10:51:48 -05:00