Commit Graph

7059 Commits

Author SHA1 Message Date
Itamar Turner-Trauring
6f0838e2e9 Docstring. 2021-01-04 14:34:18 -05:00
Itamar Turner-Trauring
d7db34f27a Add explanation for if statement. 2021-01-04 14:33:06 -05:00
Itamar Turner-Trauring
a46a7dc7f8 Log, don't raise. 2021-01-04 14:23:12 -05:00
Jean-Paul Calderone
af06bdb182 Merge remote-tracking branch 'origin/master' into 3575.realistic_storage_index_hash-key 2021-01-04 14:14:13 -05:00
Itamar Turner-Trauring
3a6b92f39f More progress to passing tests on Python 3. 2021-01-04 11:48:38 -05:00
Itamar Turner-Trauring
2bf278e55d Even more tests passing on Python 3. 2021-01-04 11:39:25 -05:00
Itamar Turner-Trauring
3d42030e01 More tests pass on Python 3. 2021-01-04 11:21:26 -05:00
Itamar Turner-Trauring
a54aeae338 Port to Python 3. 2021-01-04 11:05:59 -05:00
Itamar Turner-Trauring
744e205763 Tests pass on Python 3. 2021-01-04 11:03:38 -05:00
Chad Whitacre
c13821ecac Tack on deep_stats 2021-01-04 06:18:14 -05:00
Chad Whitacre
655be5e3a0 Port stats to Python 3 2021-01-04 06:18:14 -05:00
Jean-Paul Calderone
855521fea8
Merge pull request #935 from LeastAuthority/3529.test_connections-no-mock
Remove mock usage from test_connections.py

Fixes: ticket:3529
2021-01-02 12:48:12 -05:00
Jean-Paul Calderone
c0358b3e03 Fold _encode_tail_segment in to _encode_segment 2021-01-01 15:14:47 -05:00
Chad Whitacre
2a8fa4da7a Fix test module reference in util._python3 2020-12-29 12:54:19 -05:00
Chad Whitacre
b4b4a1aabf Port webish/test_webish to Python 3 2020-12-29 12:39:00 -05:00
Jean-Paul Calderone
30b37e17dd More of a storage_index_hash test 2020-12-29 10:48:03 -05:00
Jason R. Coombs
4a9d3bde5b Exclude allmydata.scripts.types_ module from PythonTwoRegressions. 2020-12-26 13:30:32 -05:00
Jason R. Coombs
6522221166 Suppress error on SpyHandler interface. 2020-12-26 13:12:11 -05:00
Jason R. Coombs
854c22e1ca Use compatible import for urllib.parse.quote. 2020-12-26 13:09:57 -05:00
Jason R. Coombs
cc5a1046d9 Define type for IntroducerService.VERSION, accepting bytes or str as keys for now. 2020-12-26 13:07:12 -05:00
Jason R. Coombs
3fd46f9400 Ignore additional attribute on the function. 2020-12-26 13:02:16 -05:00
Jason R. Coombs
04ab4dec3b Extract function and annotate it to satisfy typechecks for _Config._basedir 2020-12-26 13:01:27 -05:00
Jason R. Coombs
574613a892 Merge branch 'master' into 3399.mypy 2020-12-26 12:45:09 -05:00
Jason R. Coombs
01147f4627 Add reference to ticket for ambiguous MRO 2020-12-26 12:33:22 -05:00
Jason R. Coombs
1bf71fd690 Replace todo with a ticket. 2020-12-26 12:12:39 -05:00
Jason R. Coombs
5396f9f97e Replace fixme with reference to foolscap issue. 2020-12-26 12:02:47 -05:00
Jason R. Coombs
dacdf7f12d Add more detail and link to upstream issue for Twisted stubs. 2020-12-26 11:56:13 -05:00
Jason R. Coombs
384e3f5220 Merge commit 'ab2c544' into 3399.mypy 2020-12-26 11:50:15 -05:00
Jason R. Coombs
ab2c544efc Restore IDirnodeURI 2020-12-26 11:50:06 -05:00
Jason R. Coombs
b65ef3cee6 Revert "Ignores no longer needed."
This reverts commit 950ca18932.
2020-12-26 11:25:40 -05:00
Jason R. Coombs
6b6b8f8378 Push IURI implementers down to the classes that actually implement it. 2020-12-26 11:17:35 -05:00
Itamar Turner-Trauring
eb8837a4c8 More things that need to be bytes. 2020-12-23 10:09:37 -05:00
Itamar Turner-Trauring
15f2d433ae Fix tests on Python 3. 2020-12-23 10:01:44 -05:00
Itamar Turner-Trauring
3c8550b666 Python 3 fix: direct indexing of bytes returns an int. 2020-12-23 09:54:35 -05:00
Itamar Turner-Trauring
58cb757816 Sometimes these values are more extended Unicode than ASCII. 2020-12-23 09:42:42 -05:00
Itamar Turner-Trauring
f736dc6f7b Fix some tests caused by unicode rendering. 2020-12-23 09:34:48 -05:00
Itamar Turner-Trauring
c5b403bd2f Make the class new style again on Python 2. 2020-12-23 09:17:39 -05:00
Itamar Turner-Trauring
2c7dde9978 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-23 09:14:34 -05:00
Itamar Turner-Trauring
55698cc8f2 Merge remote-tracking branch 'origin/master' into 3566.web-tests-python-3-part-2 2020-12-22 13:21:49 -05:00
Itamar Turner-Trauring
1c7956bc1a Port to Python 3. 2020-12-22 13:19:59 -05:00
Itamar Turner-Trauring
cbf348f21b Get rid of debug print. 2020-12-22 13:17:46 -05:00
Itamar Turner-Trauring
8881728ca5 Another passing test on Python 3. 2020-12-22 13:17:07 -05:00
Itamar Turner-Trauring
baa2cff29c Unbreak Python 2. 2020-12-22 13:14:18 -05:00
Itamar Turner-Trauring
013388981c Fix intermittent failing test on PyPy hopefully.
PyPy does not have refcounts, so files were only being closed when GC happened,
which meant their buffered writes never hit disk.
2020-12-22 13:04:53 -05:00
Itamar Turner-Trauring
f9ee4b239f
Merge pull request #934 from tahoe-lafs/3564.eliot-log-testing-python-3
Re-enable logging validation on Python 3.

Fixes ticket:3564
2020-12-22 11:43:36 -05:00
Itamar Turner-Trauring
74c08883f5 Another passing test on Python 3. 2020-12-22 11:36:52 -05:00
Itamar Turner-Trauring
0534979e61 Another passing test on Python 3. 2020-12-22 11:03:23 -05:00
Itamar Turner-Trauring
cabfdadc20 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-22 10:48:32 -05:00
Itamar Turner-Trauring
f30376ade6 Make sure test output can encode bytes correctly too. 2020-12-22 10:47:25 -05:00
Jean-Paul Calderone
ab7c382dec
Merge pull request #939 from LeastAuthority/3567.test_storage_client-eaddrinuse
Use a pre-bound listening socket in the test

Fixes: ticket:3567
2020-12-21 13:27:08 -05:00
Itamar Turner-Trauring
b46898f667 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:20:50 -05:00
Itamar Turner-Trauring
7fc64fdf45 Also handle bytes when serializing production Eliot log messages on Python 3. 2020-12-21 13:20:14 -05:00
Itamar Turner-Trauring
a8732a3c70 Merge branch '3564.eliot-log-testing-python-3' into 3566.web-tests-python-3-part-2 2020-12-21 13:12:19 -05:00
Itamar Turner-Trauring
c25dd57768 Make sure we can handle bytes, plus a couple other fixes. 2020-12-21 13:12:01 -05:00
Itamar Turner-Trauring
2737229895 Another passing test. 2020-12-21 11:12:52 -05:00
Itamar Turner-Trauring
a2f042845d Another passing test. 2020-12-21 10:58:09 -05:00
Itamar Turner-Trauring
d8197d9554 Another passing test. 2020-12-21 10:52:31 -05:00
Itamar Turner-Trauring
15c7af8e72 Another passing test. 2020-12-21 10:29:59 -05:00
Itamar Turner-Trauring
98c71e51e1 More progress towards passing tests. 2020-12-21 10:04:27 -05:00
Itamar Turner-Trauring
2ec7d52d09 Some progress towards passing tests on Python 3. 2020-12-18 16:12:32 -05:00
Itamar Turner-Trauring
c71acf93fd Bytes, alas. 2020-12-18 16:10:23 -05:00
Itamar Turner-Trauring
5315d48355 Merge remote-tracking branch 'origin/master' into 3565.web-tests-python-3-part-1 2020-12-18 15:43:36 -05:00
Itamar Turner-Trauring
f964ae1782 Docstrings. 2020-12-18 15:43:27 -05:00
Itamar Turner-Trauring
50a794a911 More accurate docstring. 2020-12-18 11:34:08 -05:00
Itamar Turner-Trauring
865f3fd7d0 Improve the docstring. 2020-12-18 11:33:24 -05:00
Itamar Turner-Trauring
721b02b262 Use the function I specifically wrote for this! 2020-12-18 11:29:56 -05:00
Itamar Turner-Trauring
8f4a0379ea Correct examples. 2020-12-18 11:26:10 -05:00
Itamar Turner-Trauring
b24a9f7083 Trying to get test_grid working on Python 3. 2020-12-18 11:21:04 -05:00
Jason R. Coombs
602a06e5cb Extract Parameters type in scripts.types_. 2020-12-18 11:14:07 -05:00
Jason R. Coombs
189608e113 Remove GENERATED_FILES, unused 2020-12-18 11:07:30 -05:00
Jason R. Coombs
c2d2aba83f Add reference to ticket. 2020-12-18 11:05:55 -05:00
Jason R. Coombs
0e248cb4ef Declare signing key as required in introducer client publish. 2020-12-18 10:59:53 -05:00
Jason R. Coombs
090031cbfc Remove confirm_share_allocation from interface (unused). 2020-12-18 10:55:20 -05:00
Jason R. Coombs
d051791e95 Add reference to ticket. 2020-12-18 10:53:24 -05:00
Jason R. Coombs
ea0c10ef83 Remove set_size, unused 2020-12-18 10:51:56 -05:00
Jason R. Coombs
efd0aef284 Indicate that unichr is Python 2 only. 2020-12-18 10:36:43 -05:00
Jason R. Coombs
51b0b201b4 Expand comment to provide more context. 2020-12-18 10:33:30 -05:00
Jason R. Coombs
99da74fffb Change comment to clarify that it's the implementation that's incomplete. 2020-12-18 09:58:56 -05:00
Jason R. Coombs
950ca18932 Ignores no longer needed. 2020-12-18 09:23:27 -05:00
Jean-Paul Calderone
8e6c52b61e pre-assign a listening socket to the main tub to avoid the error 2020-12-17 10:20:22 -05:00
Itamar Turner-Trauring
6e12cce1e4 Port to Python 3. 2020-12-17 09:55:35 -05:00
Itamar Turner-Trauring
3ac64e42f7 Web test_status tests pass on Python 3. 2020-12-17 09:54:04 -05:00
Itamar Turner-Trauring
9b59e7e245 Merge remote-tracking branch 'origin/3552.test_system-python-3' into 3565.web-tests-python-3-part-1 2020-12-17 09:51:52 -05:00
Itamar Turner-Trauring
33392502d3 server IDs/node IDS should be bytes. 2020-12-17 09:50:39 -05:00
Itamar Turner-Trauring
26297c296d
Merge branch 'master' into 3552.test_system-python-3 2020-12-17 09:42:34 -05:00
Jean-Paul Calderone
0ffbc7870e Okay, let KeyboardInterrupt through 2020-12-16 20:32:04 -05:00
Jean-Paul Calderone
895ba55cf7 Python 3 compatibility 2020-12-16 18:17:14 -05:00
Jean-Paul Calderone
a223f6bb60 More reliably corrupt the signature 2020-12-16 17:31:06 -05:00
Jean-Paul Calderone
4117beba6a remove unused import
yaaay
2020-12-16 16:25:51 -05:00
Jean-Paul Calderone
b200075246 whitespace 2020-12-16 16:23:05 -05:00
Jean-Paul Calderone
98000c2b66 re-implement test_unsigned_announcement without mock
and to make assertions about public behavior instead of private implementation
details
2020-12-16 16:20:38 -05:00
Jean-Paul Calderone
b2c9296f6b Use ObserverList instead of an ad hoc reimplementation 2020-12-16 16:20:00 -05:00
Jean-Paul Calderone
60e401ca69 Make ObserverList synchronous, reentrant, and exception safe
with tests
2020-12-16 16:19:33 -05:00
Jean-Paul Calderone
83ebaef86c Stop mocking safe_load
The comment implies this will cause something to break on some platform.
Let's find out.
2020-12-16 15:24:33 -05:00
Jean-Paul Calderone
d19b1cfd68
Merge pull request #933 from LeastAuthority/3533.test_root-no-mock
Remove Mock from test_root

Fixes: ticket:3533
2020-12-16 15:15:17 -05:00
Itamar Turner-Trauring
b5f2afe39c WIP porting test_status.py. 2020-12-16 14:13:46 -05:00
Itamar Turner-Trauring
67c0a4ac84 Port another test module to Python 3. 2020-12-16 13:53:49 -05:00
Jean-Paul Calderone
9f28ccb2a4 Move the last three mock-using tests to test_tor_provider
where they can be rewritten later
2020-12-16 12:07:54 -05:00
Jean-Paul Calderone
3d82ca0d25 Use boring old dependency injection to replace mocks in this test 2020-12-16 11:50:35 -05:00
Jean-Paul Calderone
3d564f97d5 Switch away from mock in a few more simple cases in test_connections.py 2020-12-16 11:48:33 -05:00
Jean-Paul Calderone
468895c74d Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_control_endpoint 2020-12-16 11:28:36 -05:00
Jean-Paul Calderone
7eb9f2ce54 Moved into allmydata.test.test_i2p_provider
This follows the local convention of using mock even though I'm trying to get
rid of mock.  This is because it keeps the test_i2p_provider suite consistent
which means it won't make removing mock from test_i2p_provider later much
harder and lets me avoid doing that work now.
2020-12-16 11:20:45 -05:00
Itamar Turner-Trauring
61c76902ca Port to Python 3. 2020-12-16 11:16:34 -05:00
Jean-Paul Calderone
8271dbf3e6 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_configdir 2020-12-16 11:15:51 -05:00
Jean-Paul Calderone
81b684b583 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir_executable 2020-12-16 11:15:21 -05:00
Itamar Turner-Trauring
f7362dc1ef Port to Python 3. 2020-12-16 11:14:55 -05:00
Jean-Paul Calderone
6d66be43b9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch_configdir 2020-12-16 11:14:46 -05:00
Jean-Paul Calderone
e84860ef15 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_launch 2020-12-16 11:13:52 -05:00
Itamar Turner-Trauring
acc36c34d0 Tests pass on Python 2 and Python 3. 2020-12-16 11:13:32 -05:00
Jean-Paul Calderone
ececae2ce9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_sam_endpoint 2020-12-16 11:12:36 -05:00
Jean-Paul Calderone
f7c92bf4c9 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_default 2020-12-16 11:11:22 -05:00
Jean-Paul Calderone
01b31e0680 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch_executable 2020-12-16 11:06:57 -05:00
Jean-Paul Calderone
61778bc799 Duplicate of allmydata.test.test_tor_provider.CreateOnion.test_launch 2020-12-16 11:05:51 -05:00
Jean-Paul Calderone
71ced4c228 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_socks_endpoint 2020-12-16 11:03:37 -05:00
Jean-Paul Calderone
ec9851f6d8 Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_no_i2p 2020-12-16 10:38:13 -05:00
Jean-Paul Calderone
b5d4a2579b Duplicate of allmydata.test.test_i2p_provider.Provider.test_handler_disabled 2020-12-16 10:37:41 -05:00
Jean-Paul Calderone
17d9988d45 Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_no_tor 2020-12-16 10:34:33 -05:00
Jean-Paul Calderone
d3f8839f1b Duplicate of allmydata.test.test_tor_provider.Provider.test_handler_disabled 2020-12-16 10:34:07 -05:00
Itamar Turner-Trauring
052b3d9fb1 Re-enable logging validation on Python 3. 2020-12-16 10:06:59 -05:00
Itamar Turner-Trauring
54a11dbb6a
Merge pull request #932 from tahoe-lafs/3560.test_eliotutil-python-3
Port eliotutil and tests to Python 3

Fixes ticket:3560
2020-12-16 09:40:19 -05:00
Jean-Paul Calderone
eeebd15c42 Take Mock out of `allmydata.test.test_connections.TCP` 2020-12-16 09:15:37 -05:00
Jean-Paul Calderone
2b1ea5c604 Remove the client Mock object
It wasn't used by anything so that was easy.  Clean up the test as long as
we're here.
2020-12-15 18:30:12 -05:00
Jean-Paul Calderone
c4e8262a99
Merge pull request #925 from tahoe-lafs/3532.test_node-no-mock
Remove mock from test_node

Fixes: ticket:3532
2020-12-15 14:38:07 -05:00
Jean-Paul Calderone
fee8c55f01 The listenOn is probably the most interesting part 2020-12-15 13:42:20 -05:00
Jean-Paul Calderone
7dbcb4d712 Make set_tub_locations a nicer function 2020-12-15 13:41:01 -05:00
Jean-Paul Calderone
53b782aca4 get the function name right 2020-12-15 13:40:12 -05:00
Jean-Paul Calderone
c2dc2b39da A better name 2020-12-15 13:34:04 -05:00
Jean-Paul Calderone
be559ab3a5 Turn the XXX into a TODO'd test and a ticket 2020-12-15 13:31:18 -05:00
Jean-Paul Calderone
29f0ae0554 These don't need to be methods. Also docstrings are nice. 2020-12-15 13:30:58 -05:00
Itamar Turner-Trauring
4a587836a5 Port eliotutil and tests to Python 3. 2020-12-15 10:13:46 -05:00
Itamar Turner-Trauring
6a29568888 Fix flakes. 2020-12-15 09:16:50 -05:00
Itamar Turner-Trauring
c7f2b7dd7c Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-15 09:13:32 -05:00
Jean-Paul Calderone
a97184868d oops syntax error
so what is the good of pre-commit?
2020-12-14 18:40:18 -05:00
Jean-Paul Calderone
5c6e0a2bb4 docstrings 2020-12-14 18:33:28 -05:00
Jean-Paul Calderone
677e62e73e Return the canned handler 2020-12-14 18:29:50 -05:00
Jean-Paul Calderone
b77f43e360 Simplify handler initialization 2020-12-14 18:27:02 -05:00
Jean-Paul Calderone
49330d1e4a docstring 2020-12-14 18:25:58 -05:00
Jean-Paul Calderone
4b1c6a2815 Remove these reactor parameters 2020-12-14 17:42:30 -05:00
Jean-Paul Calderone
fcbe56ba0a docstrings for the Tor and I2P address family implementations 2020-12-14 17:36:35 -05:00
Jean-Paul Calderone
18c18a0e1d explain the inconsistent naming 2020-12-14 17:33:58 -05:00
Jean-Paul Calderone
b6ea3f47c8 unused imports 2020-12-14 16:58:22 -05:00
Jean-Paul Calderone
01507e4f93 some direct tests for DaemonizeTheRealService 2020-12-14 16:57:20 -05:00
Jean-Paul Calderone
a9bcd6270a Merge remote-tracking branch 'origin/master' into 3557.GuessedAtParserWarning 2020-12-14 15:41:31 -05:00
Jean-Paul Calderone
035cd8b4ac Merge remote-tracking branch 'origin/master' into 3532.test_node-no-mock 2020-12-14 15:35:42 -05:00
Jean-Paul Calderone
39628cbb4e
Merge pull request #921 from tahoe-lafs/3550.remove-start-stop-restart-daemonize
remove start stop restart daemonize

Fixes: ticket:3550
Fixes: ticket:3523
Fixes: ticket:3524
2020-12-14 14:58:35 -05:00
Itamar Turner-Trauring
c7759cb82c Try to fix test_web.py on Python 2. 2020-12-14 13:53:12 -05:00
Itamar Turner-Trauring
37d46cfb3d Merge remote-tracking branch 'origin/master' into 3552.test_system-python-3 2020-12-14 13:32:43 -05:00
Itamar Turner-Trauring
28f46e9b06 test_system.py passes on both Python 2 and Python 3. 2020-12-14 11:07:37 -05:00
Jean-Paul Calderone
bdb7c50fac You can just use multiple terminals
If you know how to daemonize stuff you can figure it out yourself I guess.
2020-12-14 09:38:16 -05:00
Jean-Paul Calderone
a0931f4999 You can pass the introducer on the command line 2020-12-14 09:38:06 -05:00