Itamar Turner-Trauring
5d2bdf5883
Explicit bytes.
2020-08-20 14:32:41 -04:00
Itamar Turner-Trauring
8136b21f46
Skip the tests we aren't porting just yet.
2020-08-20 14:24:21 -04:00
Itamar Turner-Trauring
9d34ab587a
test_storage_web now runnable on Python 3 (even if it doesn't pass).
2020-08-20 14:17:06 -04:00
Itamar Turner-Trauring
eee3978243
Explain a bit better.
2020-08-20 13:34:00 -04:00
Itamar Turner-Trauring
f227b1b241
Merge pull request #779 from tahoe-lafs/3378.encodingutil-python-3-part-2
...
Fixes ticket:3378
Port encodingutil to Python 3, part 2
2020-08-20 13:24:33 -04:00
Itamar Turner-Trauring
46b498f99c
Merge remote-tracking branch 'origin/master' into 3377.configutil-connection_status-python-3
2020-08-20 13:22:14 -04:00
Itamar Turner-Trauring
71d33469da
Merge remote-tracking branch 'origin/master' into 3378.encodingutil-python-3-part-2
2020-08-20 12:36:36 -04:00
Sajith Sasidharan
ce994ff246
Use twisted's escapeToXml
2020-08-19 15:42:01 -04:00
Sajith Sasidharan
9882d22101
Check for WebError when rendering resource in unknown format
2020-08-19 15:22:06 -04:00
Sajith Sasidharan
d87ffb5ad0
Begone, (most) nevow imports!
2020-08-19 15:22:06 -04:00
Sajith Sasidharan
d2bcebecaa
Render resource in a simpler manner
2020-08-19 15:21:28 -04:00
Sajith Sasidharan
320830cf90
Reuse MultiFormatPage tests for MultiFormatResource
2020-08-19 15:21:06 -04:00
Itamar Turner-Trauring
733b2cab36
Remove unnecessary import.
2020-08-19 13:26:57 -04:00
Itamar Turner-Trauring
8279be38c1
Finish porting to Python 3.
2020-08-19 13:25:11 -04:00
Itamar Turner-Trauring
35ac5a62e7
Tests now pass on Python 3 too.
2020-08-19 12:15:39 -04:00
Itamar Turner-Trauring
ff582c5129
Some progress towards running crawler on Python 3.
2020-08-19 11:38:59 -04:00
Itamar Turner-Trauring
e971ccf58e
Unbreak so tests pass on Python 2 again.
2020-08-19 11:12:29 -04:00
Itamar Turner-Trauring
e044309bd3
Finish port to Python 3.
2020-08-19 11:03:54 -04:00
Itamar Turner-Trauring
14f349e846
Manual porting to Python 3.
2020-08-19 11:02:26 -04:00
Itamar Turner-Trauring
416ab64335
Fix an import.
2020-08-19 10:50:44 -04:00
Itamar Turner-Trauring
80b9a9b3ce
Split the test module in two.
2020-08-18 13:03:36 -04:00
Sajith Sasidharan
d5853ccb60
Remove web.common.MultiFormatPage
2020-08-18 08:48:02 -04:00
Itamar Turner-Trauring
97c3be0509
Make quote_* and friends return unicode.
2020-08-17 13:29:49 -04:00
Itamar Turner-Trauring
03ed0fd66f
Another function that should be a no-op on Python 3.
2020-08-17 11:29:09 -04:00
Itamar Turner-Trauring
81ba354357
Merge remote-tracking branch 'origin/master' into 3373.happinessutil-python-3
2020-08-17 10:45:12 -04:00
Itamar Turner-Trauring
2cc2cb6a7f
Rename to_str() to the more accurate to_bytes().
2020-08-14 13:49:48 -04:00
Itamar Turner-Trauring
4ddbd8dbbf
Merge branch '3376.encodingutil-python-3' into 3377.configutil-connection_status-python-3
2020-08-14 13:13:23 -04:00
Itamar Turner-Trauring
2fc8f896b3
Merge remote-tracking branch 'origin/master' into 3376.encodingutil-python-3
2020-08-14 13:09:08 -04:00
Jean-Paul Calderone
bc787975da
Merge pull request #777 from tahoe-lafs/3372.ratchet-by-module.python3.6
...
Ratchet by module, not by individual test (in python3.6)
Fixes: ticket:3372
2020-08-14 11:55:30 -04:00
Jean-Paul Calderone
76e5c40fc6
Add a module to the test suite which contains all of the other ported modules
2020-08-14 11:21:32 -04:00
meejah
8f1b712a8f
Merge pull request #729 from sajith/3316.check-results-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in web.check_results
2020-08-13 23:10:19 +00:00
Itamar Turner-Trauring
a3714a9970
Fix whitespace.
2020-08-13 16:32:32 -04:00
Itamar Turner-Trauring
6e24defe4b
Merge branch '3376.encodingutil-python-3' into 3377.configutil-connection_status-python-3
2020-08-13 15:53:02 -04:00
Itamar Turner-Trauring
8167e85f7b
Fix flake8 with __all__.
2020-08-13 15:11:14 -04:00
Itamar Turner-Trauring
e113cba8d0
Address review comments.
2020-08-13 15:02:59 -04:00
Itamar Turner-Trauring
cdccb93179
Flake fixes.
2020-08-12 15:52:12 -04:00
Itamar Turner-Trauring
5a0fa7ff73
Test unicode_to_argv().
2020-08-12 15:40:52 -04:00
Itamar Turner-Trauring
e03c2a759f
Port test_encodingutil.py to Python 3.
2020-08-12 15:14:04 -04:00
Itamar Turner-Trauring
b04a65fc16
And more progress to Python 3.
2020-08-12 14:54:07 -04:00
Itamar Turner-Trauring
e9d67b8d0f
Even more progress towards Python 3 support.
2020-08-12 14:32:22 -04:00
Itamar Turner-Trauring
f7e28ffb0b
More progress towards Python 3.
2020-08-12 14:18:02 -04:00
Itamar Turner-Trauring
53bdc10e19
Some steps towards Python 3 support.
2020-08-12 13:10:10 -04:00
Itamar Turner-Trauring
e13c0cf4d3
Reorganize imports to make Python 3 support easier.
2020-08-12 10:23:30 -04:00
Itamar Turner-Trauring
14b273953a
Better fix, maybe.
2020-08-12 10:10:18 -04:00
Maciej Fijalkowski
c21acc64f0
merge master
2020-08-12 15:42:00 +02:00
Itamar Turner-Trauring
9ad5602477
Fix test failures.
2020-08-11 16:50:42 -04:00
Itamar Turner-Trauring
babe2dbc85
Port to Python 3.
2020-08-11 15:45:52 -04:00
Itamar Turner-Trauring
e24c21bef7
Make configutil tests more standalone, and less repetitive.
2020-08-11 15:38:58 -04:00
Itamar Turner-Trauring
80c7739096
Merge branch '3370.happiness-upload-python-3' into 3373.happinessutil-python-3
2020-08-11 14:54:39 -04:00
Itamar Turner-Trauring
202a7cf975
Merge remote-tracking branch 'origin/master' into 3370.happiness-upload-python-3
2020-08-11 14:53:34 -04:00
Itamar Turner-Trauring
243d02ecb1
Port to Python 3.
2020-08-11 14:08:51 -04:00
Itamar Turner-Trauring
1c9e4ec842
Move connection_status tests into their own module.
2020-08-11 14:04:52 -04:00
Itamar Turner-Trauring
b82e2ad1c5
Tests for allmydata.monitor.
2020-08-07 13:26:44 -04:00
Itamar Turner-Trauring
9c0b5eac2b
Additional testing.
2020-08-07 13:10:55 -04:00
Itamar Turner-Trauring
5384768f76
Port to Python 3.
2020-08-07 13:08:53 -04:00
Itamar Turner-Trauring
b08a78e5b4
Docstring.
2020-08-07 11:52:26 -04:00
Itamar Turner-Trauring
44143d1b08
Move tests for happinessutil.py into test_happiness.py.
2020-08-07 11:37:44 -04:00
Itamar Turner-Trauring
fb9bf5511f
Passing tests.
2020-08-07 11:09:41 -04:00
Itamar Turner-Trauring
0622b86b91
Merge remote-tracking branch 'origin/master' into 3370.happiness-upload-python-3
2020-08-06 17:03:43 -04:00
Itamar Turner-Trauring
f53ea4579d
Merge remote-tracking branch 'origin/master' into 3365.log-python-3
2020-08-06 17:03:27 -04:00
Itamar Turner-Trauring
c6d4ec0295
Port the test module to Python 3.
2020-08-06 16:33:04 -04:00
Itamar Turner-Trauring
32945b85f6
Drop int.
2020-08-06 16:14:39 -04:00
Itamar Turner-Trauring
dab690a757
Flake fixes.
2020-08-06 16:13:10 -04:00
Maciej Fijalkowski
9b9d530155
Fix some typos. Add docstring
2020-08-06 16:07:50 +02:00
Maciej Fijalkowski
b71ae461a6
use less hacks in yaml tests
2020-08-06 16:06:01 +02:00
Itamar Turner-Trauring
70851fe753
Death to newint.
2020-08-05 11:53:23 -04:00
Itamar Turner-Trauring
11c7841cd7
Merge pull request #760 from tahoe-lafs/3364.crypto-python-3
...
Fixes ticket:3364
Port allmydata.crypto to Python 3
2020-08-05 11:26:30 -04:00
Itamar Turner-Trauring
0bef1eb4e2
Support prefix that is bytes.
2020-08-05 11:25:40 -04:00
Itamar Turner-Trauring
ff7cf4d731
Test improvements.
2020-08-04 15:15:32 -04:00
Itamar Turner-Trauring
ce33101d08
Remove unused import.
2020-08-04 15:03:06 -04:00
Maciej Fijalkowski
d8bcbb901e
I think default mode is text
2020-08-04 12:26:43 +02:00
Itamar Turner-Trauring
622ed2f971
Standalone logging tests, most of them new, and an attempt to fix the parent
...
msgid logic so it's a little less broken.
2020-08-03 14:09:28 -04:00
Itamar Turner-Trauring
02daa12031
Move logging tests into their own, Python 3-compatible, module.
2020-08-03 11:33:29 -04:00
Itamar Turner-Trauring
cd50ac434a
Port to Python 3.
2020-08-03 10:59:51 -04:00
Itamar Turner-Trauring
5815547661
Remove an unnecessary conversion that breaks Python 3.
2020-08-03 10:58:37 -04:00
Itamar Turner-Trauring
3330737656
Be a bit stricter about expected outputs.
2020-08-03 10:56:47 -04:00
Itamar Turner-Trauring
34e3052814
Don't use global state for testing.
2020-08-03 10:43:21 -04:00
Maciej Fijalkowski
c178c55178
remove this import
2020-08-02 12:03:59 +02:00
Maciej Fijalkowski
bf37413e05
address the review (mostly)
2020-08-02 11:16:18 +02:00
Jean-Paul Calderone
27b6737eaf
Merge remote-tracking branch 'origin/master' into 3358.fileutil-to-python-3
...
with fijal
2020-07-30 13:38:47 -04:00
Maciej Fijalkowski
7618b295cb
Revert "merge master (I think properly)"
...
This reverts commit 6140b5ff52
, reversing
changes made to da87bd7e7f
.
2020-07-30 09:29:20 +02:00
Maciej Fijalkowski
6140b5ff52
merge master (I think properly)
2020-07-29 21:09:23 +02:00
Itamar Turner-Trauring
0a1e365ed1
Tests for gcutil.
2020-07-29 14:46:49 -04:00
Itamar Turner-Trauring
9c16a0554e
Get rid of unused code.
2020-07-29 14:38:58 -04:00
Itamar Turner-Trauring
9e4eda6912
Merge pull request #756 from tahoe-lafs/3359.statistics-python-3
...
Port statistics and dictutil to Python 3
Fixes ticket:3359
2020-07-29 13:16:17 -04:00
Maciej Fijalkowski
93c474c39b
make test_util pass under both pythons
2020-07-29 09:00:50 +02:00
Sajith Sasidharan
951250f9ff
Remove unused FAVICON_MARKUP
2020-07-28 16:13:58 -04:00
Sajith Sasidharan
4007fb4de7
Rearrange imports
2020-07-28 16:12:48 -04:00
Itamar Turner-Trauring
17b15ae085
Add another test.
2020-07-28 11:25:34 -04:00
Itamar Turner-Trauring
9ca1fdef81
Note it's ported.
2020-07-28 11:12:17 -04:00
Itamar Turner-Trauring
4dae5d867c
Add retry logic, listenOnUnused is potentially flaky.
2020-07-28 11:09:02 -04:00
Sajith Sasidharan
0f28a93879
Remove unused import
2020-07-28 08:08:48 -04:00
Sajith Sasidharan
fb5f9f0c89
Merge 'origin/master' into 3316.check-results-nevow-to-twisted-web
2020-07-28 07:54:21 -04:00
Sajith Sasidharan
ca6cf887f7
Test JSON rendering synchronously
2020-07-28 07:26:11 -04:00
Sajith Sasidharan
1b7a35e773
Do not strip tags where it is not necessary
2020-07-28 07:18:57 -04:00
Sajith Sasidharan
e6867a1355
Use docstring to describe a class
2020-07-28 07:15:39 -04:00
Sajith Sasidharan
adca146a1b
Use space as separator when removing tags
2020-07-28 07:10:44 -04:00
Sajith Sasidharan
80802a74cd
Use BeautifulSoup to remove tags
2020-07-28 06:53:52 -04:00
Sajith Sasidharan
9f5c58c173
Use super()
2020-07-28 06:27:40 -04:00
Itamar Turner-Trauring
79ae478a48
Port to Python 3.
2020-07-27 15:56:31 -04:00
Itamar Turner-Trauring
bde2f1394d
Move dictutil tests out.
2020-07-27 15:53:26 -04:00
Itamar Turner-Trauring
8d84be77d8
Port to Python 3.
2020-07-27 15:31:31 -04:00
Itamar Turner-Trauring
b140d1f1af
Move statistics tests out.
2020-07-27 15:29:01 -04:00
Itamar Turner-Trauring
ce8a575808
Test for specific ports.
2020-07-27 15:16:25 -04:00
Itamar Turner-Trauring
d91b4f0e40
Fix some tests and flake issues.
2020-07-27 15:12:09 -04:00
Itamar Turner-Trauring
361e75804c
Merge remote-tracking branch 'origin/master' into 3356.iputil-python-3
2020-07-27 13:07:12 -04:00
Itamar Turner-Trauring
817355d17e
Minimal testing for listenOnUnused.
2020-07-27 13:06:41 -04:00
Itamar Turner-Trauring
e681ca1cb9
Merge pull request #754 from tahoe-lafs/3357.version_checks-py3
...
Port version_checks to Python 3
Fixes ticket:3357
2020-07-27 12:36:28 -04:00
Itamar Turner-Trauring
9919d2c9a7
Record port status.
2020-07-27 11:46:03 -04:00
Itamar Turner-Trauring
1f34e62987
Port test module to Python 3.
2020-07-27 11:14:01 -04:00
Maciej Fijalkowski
13e292295e
Revert "futurize and make the tests pass back under py2"
...
This reverts commit 361de05980
.
2020-07-25 11:22:03 +02:00
Maciej Fijalkowski
361de05980
futurize and make the tests pass back under py2
2020-07-25 11:12:43 +02:00
Itamar Turner-Trauring
bf13401979
Move SignalMixin to common_py3.py.
2020-07-24 14:58:08 -04:00
Itamar Turner-Trauring
025afc1efe
Merge branch '3357.version_checks-py3' into 3356.iputil-python-3
2020-07-24 14:50:50 -04:00
Itamar Turner-Trauring
11cd30c425
Merge remote-tracking branch 'origin/master' into 3357.version_checks-py3
2020-07-24 14:50:39 -04:00
Itamar Turner-Trauring
e80f138868
Fix indent.
2020-07-24 14:48:56 -04:00
Itamar Turner-Trauring
e0d3e46683
Merge remote-tracking branch 'origin/master' into 3351.spans-python-3
2020-07-24 14:48:33 -04:00
Itamar Turner-Trauring
4c6a9a5610
Merge branch '3357.version_checks-py3' into 3356.iputil-python-3
2020-07-24 14:36:31 -04:00
Itamar Turner-Trauring
337a4381bb
Finish port to Python 3.
2020-07-24 14:31:36 -04:00
Itamar Turner-Trauring
65500de72f
Merge remote-tracking branch 'origin/master' into 3346.abbreviate-and-time_format-py3
2020-07-24 14:13:28 -04:00
Itamar Turner-Trauring
f84d51d795
Port to Python 3.
2020-07-24 14:12:10 -04:00
Itamar Turner-Trauring
135ade02b1
Start porting.
2020-07-24 13:47:56 -04:00
Itamar Turner-Trauring
8bcd6dd34b
Merge branch 'master' into 3346.abbreviate-and-time_format-py3
2020-07-24 11:10:38 -04:00
Itamar Turner-Trauring
dd4737f20c
Merge branch 'master' into 3353.observer-and-pipeline-py3
2020-07-24 11:08:08 -04:00
Itamar Turner-Trauring
d23394b35c
Merge remote-tracking branch 'origin/master' into 3346.abbreviate-and-time_format-py3
2020-07-23 12:27:06 -04:00
Itamar Turner-Trauring
cab1b02ba2
Use constants, since we have them.
2020-07-23 11:47:12 -04:00
Itamar Turner-Trauring
b0083e342b
Document being ported.
2020-07-23 11:47:06 -04:00
Itamar Turner-Trauring
eb688dfd7e
Fix lint.
2020-07-22 13:22:50 -04:00
Itamar Turner-Trauring
64e4af2d05
Port to Python 3.
2020-07-22 13:17:49 -04:00
Itamar Turner-Trauring
15254d08fc
A few more explicit byte strings.
2020-07-22 13:11:05 -04:00
Itamar Turner-Trauring
85c8ca6d77
Merge branch '3344.netstring-and-hashutil-to-python-3' into 3354.hashtree-to-python-3
2020-07-22 13:09:58 -04:00
Itamar Turner-Trauring
5129e1ef14
Explicitly mark bytestrings.
2020-07-22 13:08:24 -04:00
Itamar Turner-Trauring
e48aecfa1a
Move parsing tests to better location, and fix them.
2020-07-22 12:55:16 -04:00
Itamar Turner-Trauring
0763f9f90b
Port to Python 3.
2020-07-22 10:36:50 -04:00
Itamar Turner-Trauring
e427163ec8
Move pipeline tests into their own module.
2020-07-22 10:33:23 -04:00
Itamar Turner-Trauring
b4e6686211
Port to Python 3.
2020-07-22 10:29:44 -04:00
Itamar Turner-Trauring
2f608e8216
Merge remote-tracking branch 'origin/master' into 3346.abbreviate-and-time_format-py3
2020-07-22 10:11:27 -04:00
Itamar Turner-Trauring
51e9c2183c
Add missing file.
2020-07-22 10:00:15 -04:00
Itamar Turner-Trauring
2391bd9733
Merge remote-tracking branch 'origin/master' into 3351.spans-python-3
2020-07-22 09:57:08 -04:00
Itamar Turner-Trauring
e9eb93468f
Finish port to Python 3.
2020-07-22 09:56:59 -04:00
Itamar Turner-Trauring
3a8bafafc3
Merge remote-tracking branch 'origin/master' into 3344.netstring-and-hashutil-to-python-3
2020-07-22 09:36:34 -04:00
Itamar Turner-Trauring
ab24e9abb1
Manual porting to Python 3.
2020-07-21 15:14:52 -04:00
Itamar Turner-Trauring
d6f24af424
Move span tests into their own module.
2020-07-21 15:14:39 -04:00
Itamar Turner-Trauring
fa567841b5
Merge remote-tracking branch 'origin/master' into 3342-base32-and-base62-to-python-3
2020-07-21 14:40:33 -04:00
Itamar Turner-Trauring
6de05941b9
Remove unnecessary imports.
2020-07-21 14:27:08 -04:00
Itamar Turner-Trauring
4018b772a3
Port abbreviate.py. As far as I can tell, all division is already float division.
2020-07-21 14:15:39 -04:00
Itamar Turner-Trauring
7e8de10ea3
Merge branch '3342-base32-and-base62-to-python-3' into 3344.netstring-and-hashutil-to-python-3
2020-07-21 14:00:53 -04:00
Sajith Sasidharan
0f835e94f5
Merge 'origin/master' into 3254.status-status-nevow-to-twisted-web
2020-07-18 07:53:36 -04:00
Sajith Sasidharan
6dec821271
Merge pull request #720 from sajith/3288.status-download-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.DownloadStatusPage
Fixes: ticket:3288
2020-07-18 07:22:37 -04:00
Sajith Sasidharan
879a8012a0
Remove unused import
2020-07-18 06:48:36 -04:00
Sajith Sasidharan
c198c006e3
Avoid over-long lines
2020-07-17 21:02:24 -04:00
Sajith Sasidharan
fe07ab39da
Use docstrings
2020-07-17 16:22:23 -04:00
Sajith Sasidharan
c14197e1bc
Make FakeDownloadStatus an instance of DownloadStatus
...
The real DownloadStatus is easy enough to instantiate. Might as well
use that, cutting some crufty code here.
2020-07-17 16:13:07 -04:00
Sajith Sasidharan
293efd7c9f
Use actual status counter number when testing
2020-07-17 13:50:06 -04:00
Sajith Sasidharan
8fd0cf7eb6
Add a test for checking status page links
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
828ec53e24
Update status page test case
...
Link to upload status 0 should contain `/status/` prefix, or it will
navigate to `/up-0` instead of `/status/up-0`, resulting in a 404 not
found message. Same with other statuses too.
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
02d8bd061a
Test for trailing slashes after /status/
...
Both `/status` and `/status/` are treated alike; any additional
trailing slashes will be rejected.
2020-07-17 13:21:53 -04:00
Sajith Sasidharan
fe165cc99d
Do the right thing, not the simple thing
...
Seems that NixOS CI is saying that the simple thing is not the right
thing: "GET /status/down-0" etc all resulted in 404 responses on
NixOS. So we perhaps should use the actual counter value.
2020-07-16 19:07:51 -04:00
Sajith Sasidharan
06c8bbfb19
Use clearer names for tests
2020-07-16 17:25:25 -04:00
Sajith Sasidharan
66dd2d3658
Use docstrings
2020-07-16 17:19:50 -04:00
Sajith Sasidharan
8db60e3486
Do the simple thing when testing status subpaths
2020-07-16 17:16:18 -04:00
Sajith Sasidharan
95642ae02c
Use a helper to check status subpath results
2020-07-16 17:13:36 -04:00
Sajith Sasidharan
e48d930621
Clarify intention of a test case
2020-07-16 16:56:41 -04:00
Sajith Sasidharan
6a2ce9efc6
Use docstrings
2020-07-16 16:55:12 -04:00
Itamar Turner-Trauring
a4620bf176
Automated port of the test module.
2020-07-16 15:58:39 -04:00
Itamar Turner-Trauring
e90d1f38d2
Make TimezoneMixin importable on Python 3.
2020-07-16 15:44:41 -04:00
Itamar Turner-Trauring
554be90b7e
Unnecessary code, and was triggering flake8.
2020-07-16 15:27:36 -04:00
Itamar Turner-Trauring
72272cbf0b
Move out tests for time_format.
2020-07-16 15:15:26 -04:00
Itamar Turner-Trauring
545848f164
Move abbreviate tests into their own module.
2020-07-16 14:57:09 -04:00
Itamar Turner-Trauring
4da8e2ddee
Merge branch '3342-base32-and-base62-to-python-3' into 3344.netstring-and-hashutil-to-python-3
2020-07-16 14:42:09 -04:00
Itamar Turner-Trauring
8d143af43e
Another assertion.
2020-07-16 14:40:30 -04:00
Itamar Turner-Trauring
efbae9b3e3
Hard code some known values, generated on the master branch preceding these
...
changes.
2020-07-16 14:33:53 -04:00
Itamar Turner-Trauring
7abc54c429
Merge remote-tracking branch 'origin/master' into 3342-base32-and-base62-to-python-3
2020-07-16 14:21:42 -04:00
Jean-Paul Calderone
c493396148
Merge pull request #740 from tahoe-lafs/3340-unused-code-in-util
...
Delete some dead code.
Fixes: ticket:3340
2020-07-15 20:08:41 -04:00
Sajith Sasidharan
80bf5f0a53
Remove an unused import
2020-07-15 19:19:51 -04:00
Sajith Sasidharan
7f93e28a7c
Parameterize classes used in check/repair tests
2020-07-15 18:43:52 -04:00
Sajith Sasidharan
2d7095866a
Expand "deep check and repair results" page test
2020-07-15 17:10:48 -04:00
Sajith Sasidharan
8fedbd52c2
Expand "deep check and repair" test
2020-07-15 16:58:39 -04:00
Sajith Sasidharan
6969366370
Document, use, and test "join pathstring" method
2020-07-15 16:40:05 -04:00
Itamar Turner-Trauring
4800992de6
Type check assertions.
2020-07-15 14:58:58 -04:00
Sajith Sasidharan
3c079bef73
Expand "deep check results" test
2020-07-15 13:35:22 -04:00
Itamar Turner-Trauring
e3e29598e4
A couple of missing explicit byte strings.
2020-07-15 11:13:52 -04:00
Itamar Turner-Trauring
cfb11f7f4c
More explicit testing of types.
2020-07-15 11:08:06 -04:00
Itamar Turner-Trauring
093125ca43
Port to Python 3.
2020-07-15 11:05:23 -04:00
Itamar Turner-Trauring
d316ad3ebd
A more explicit test.
2020-07-15 11:02:49 -04:00
Itamar Turner-Trauring
2b89674052
Everything must be bytes.
2020-07-15 11:01:45 -04:00
Itamar Turner-Trauring
9ed91eabb3
Split out hashutil tests into their own module.
2020-07-15 10:58:05 -04:00
Sajith Sasidharan
1ed722494c
Add a FakeServer class for testing
2020-07-15 10:35:56 -04:00
Sajith Sasidharan
6322404b1e
Update "deep check results renderer" test
2020-07-14 21:44:41 -04:00
Itamar Turner-Trauring
a81e859b82
Fix flake error.
2020-07-14 13:44:56 -04:00
Itamar Turner-Trauring
27d8eb47fc
Test improvements.
2020-07-14 13:44:00 -04:00
Itamar Turner-Trauring
db41d5af6f
Merge pull request #743 from tahoe-lafs/3342-more-tests-for-base32-base62
...
Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3343
2020-07-14 13:41:20 -04:00
Itamar Turner-Trauring
f3db64ad74
Port to Python 3.
2020-07-14 11:29:09 -04:00
Itamar Turner-Trauring
9c428be0e2
Port base62 to Python 3.
2020-07-14 11:24:45 -04:00
Itamar Turner-Trauring
b1e732fb9a
Port test_base62 to Python 3.
2020-07-14 10:34:53 -04:00
Itamar Turner-Trauring
e34a01d547
A couple more asserts.
2020-07-14 10:28:22 -04:00
Itamar Turner-Trauring
459d68118c
Merge branch '3342-more-tests-for-base32-base62' into 3342-base32-and-base62-to-python-3
2020-07-14 10:26:46 -04:00
Itamar Turner-Trauring
f378edd9d8
Fix missing import.
2020-07-14 10:20:51 -04:00
Sajith Sasidharan
54e952ceda
Test for 404 responses from status page subpaths
2020-07-14 09:01:31 -04:00
Sajith Sasidharan
abd539588f
Rename nested functions for clarity
...
... and also to remove embarrassing copy-pasta mistakes.
2020-07-13 20:52:12 -04:00
Sajith Sasidharan
b48556c2cb
Add tests for status subpages
...
Coverage tests for the coverage gods
2020-07-13 20:44:30 -04:00
Itamar Turner-Trauring
ead2a79cf7
Everything should be bytes.
2020-07-13 16:21:15 -04:00
Itamar Turner-Trauring
6464e226c6
Hypothesis-based roundtrip test.
2020-07-13 16:19:48 -04:00
Itamar Turner-Trauring
828e6bc28a
Minimal tests for could_be_base32_encoded().
2020-07-13 16:18:13 -04:00
Itamar Turner-Trauring
bbfd39e6c0
Test larger variety of inputs using hypothesis.
2020-07-13 15:30:11 -04:00
Itamar Turner-Trauring
a8a7d48c12
Everything must be bytes.
2020-07-13 15:25:07 -04:00
Itamar Turner-Trauring
f27cba181e
Move existing base32 tests out of test_util.py.
2020-07-13 15:22:03 -04:00
Itamar Turner-Trauring
af916c3968
Merge branch 'master' into 3341-more-python-3-utils
2020-07-13 14:30:11 -04:00
Sajith Sasidharan
144001f380
Use a better assert in status subpath test
2020-07-11 08:30:39 -04:00
Sajith Sasidharan
6eba2fb2e6
Test "deep check results" page
...
These are some basic tests -- let's see if this improves test
coverage, and by how much.
2020-07-11 07:59:28 -04:00
Sajith Sasidharan
267b89ae5b
Remove unused import
2020-07-10 16:34:16 -04:00
Sajith Sasidharan
69ae9e6d32
Merge 'origin/master' into 3316.check-results-nevow-to-twisted-web
2020-07-10 16:33:06 -04:00
Sajith Sasidharan
f9dc2509de
Test "deep check and repair" page
2020-07-10 08:00:04 -04:00
Sajith Sasidharan
d4a02aa1cd
Remove a print statement
2020-07-09 17:14:55 -04:00
Sajith Sasidharan
5276ea5b37
Merge branch 'master' into 3254.status-status-nevow-to-twisted-web
2020-07-09 17:09:50 -04:00
Sajith Sasidharan
956c2c535d
Remove unused import
2020-07-09 17:09:12 -04:00
Sajith Sasidharan
a56d077d3d
Test HTML document generated by web.status.Status
2020-07-09 16:59:04 -04:00
Sajith Sasidharan
4b560d10cc
Move time formatter tests
...
UploadResultsRendererMixin no longer has render_time(); moving tests
for render_time() as tests for abbreviate_time() to a more appropriate
place.
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
96fbff684f
Use an inner JSONRequest class with renderJSON
...
Once nevow is removed from web/common.py, we can simplify
renderJSON(), like so:
def renderJSON():
req = Request()
req.args = {"t": ["json"]}
req.fields = {}
return resource.render(req)
But for now we have to live with an inner class that implements the
nevow.inevow.IRequest interface.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
92e83f268b
Declare JSON request interface using @implementer
...
"zope.interface.implements(IRequest)" is deprectated in favor of
"@zope.interface.implementer(IRequest)" decorator.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
d449306b19
Use DummyRequest in storage tests
...
Using twisted.web.server.Request causes test_new_style_classes to
fail like so:
Traceback (most recent call last):
Failure: testtools.testresult.real._StringException: Traceback (most recent call last):
File ".tox/coverage/lib/python2.7/site-packages/allmydata/test/test_python2_regressions.py", line 69, in test_new_style_classes
"Expected to find no classic classes.",
File ".tox/coverage/lib/python2.7/site-packages/testtools/testcase.py", line 502, in assertThat
raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = set([])
actual = set([<class allmydata.test.test_storage.JSONRequest at 0x7fd938040bb0>])
: Expected to find no classic classes.
Seems that `DummyRequest` is an acceptable new style class.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
6b61b75658
Refactor storage test helpers
...
Rewrite `renderSynchronously()` to use `renderDeferred()`
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
bdfa667a22
Add docstrings to storage test helpers
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
7e26dd42e9
Remove redundant render_json() method
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
0af744610f
Avoid using nevow FakeRequest in storage test.
...
Use twisted.web.server.Request instead, with a DummyChannel.
There's still one line of inevitable nevow now, because of code in
web/common.py; but that should be easily replaceable once we switch
that over.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
a6e6c5cee0
Get rid of WebRenderingMixin in storage test
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
8d31791940
Use a helper to exercise render() in storage test cases
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
7126d3247c
Prefix member variable with "_"
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
1469af0f3b
Use BeautifulSoup to check favicon in storage page
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
db0e6407dc
Use successResultOf
in renderSynchronously
...
Get rid of [].append trick when dealing with the deferred.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
ee8e730727
Move renderSynchronously
to test suite
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
ac9a73eddb
Use parentheses in test suite's import statement
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
dbc6b2afa0
Drop unused ctx
argument from render_space methods
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
d5af7c0d2e
Refactor so that test_util pass
2020-07-09 16:05:30 -04:00
meejah
1f4b619fda
unused imports
2020-07-09 16:05:29 -04:00
meejah
77a2f11694
more-testtools-y asserts
2020-07-09 16:05:29 -04:00
meejah
1ce760b237
testtool's asserts
2020-07-09 16:05:29 -04:00
meejah
26d7a3a957
Get rid of ?replace= handling entirely and more-correctly support /uri variants
2020-07-09 16:05:29 -04:00
meejah
eaf96b22fe
replciate Tahoe's behavior for replace=true/false
2020-07-09 16:05:29 -04:00
meejah
9d5e438c2d
use real parser
2020-07-09 16:05:29 -04:00
meejah
683c8d3e4f
actually returns CREATED for new data
2020-07-09 16:05:29 -04:00
meejah
b01995f158
use hypothesis -- which doesn't know about Deferred, so need testtools too
2020-07-09 16:05:29 -04:00
meejah
0cc020b5f2
copyright, header
2020-07-09 16:05:29 -04:00
meejah
18b62bf746
unused imports
2020-07-09 16:05:29 -04:00
meejah
05140a5881
simple test of testing/web
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
7444d6b7a9
Correct arguments to super()
...
This was incidentally found when looking at some test failures:
super(type, object) is the right invocation, and not the other way
around.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
2e160c1526
Test for failure caused by invalid path
...
A hyphen is expected when rendering /status page child nodes:
"/status/up" is wrong; "/status/up-0" is right.
2020-07-09 14:37:37 -04:00
Itamar Turner-Trauring
0cf1117165
Move the tests for deferredutil into their own module.
2020-07-09 14:20:12 -04:00
Itamar Turner-Trauring
e108ecb4b0
Fix lint.
2020-07-09 13:56:25 -04:00
Itamar Turner-Trauring
af86066eab
Delete some dead code.
2020-07-09 13:52:06 -04:00
Itamar Turner-Trauring
12d5131568
Fix pyflakes issues.
2020-07-09 13:12:30 -04:00
Sajith Sasidharan
7bee9ff540
Untabify again
2020-07-08 13:56:52 -04:00
Sajith Sasidharan
4d22390b59
Untabify
2020-07-08 13:29:01 -04:00
Sajith Sasidharan
112cfc1da5
Test if download status page can be rendered partially
2020-07-08 13:08:35 -04:00
Sajith Sasidharan
c187e2752b
Parameterize FakeDownloadResults and FakeDownloadStatus
2020-07-08 13:08:35 -04:00
Itamar Turner-Trauring
9e3bc3e888
These tests are no longer necessary, since we are no longer implementing this
...
code ourselves.
Before deleting the tests I ensured they either passed, or the failure were due
to slightly different string formatting in pyutil's assertutil.
As such I believe pyutil has the same behavior.
2020-07-08 12:16:26 -04:00
Sajith Sasidharan
81216f18bf
Remove some whitespace
2020-07-08 10:15:33 -04:00
Sajith Sasidharan
d6ea30b935
Test more markup rendered by DownloadStatusElement
2020-07-07 22:20:49 -04:00
Sajith Sasidharan
0db56f99cf
Add some tests for DownloadStatusElement
2020-07-07 20:49:58 -04:00
Itamar Turner-Trauring
3d0e4df5ce
Lint fixes.
2020-07-07 11:30:01 -04:00
Itamar Turner-Trauring
e06d41442a
Merge remote-tracking branch 'origin/master' into 3324-humanreadable-python-3
2020-07-07 11:03:33 -04:00
Sajith Sasidharan
a3bf4e0269
Remove an unused import
2020-07-06 20:18:22 -04:00
Sajith Sasidharan
e6eb387707
Remove status.RateAndTimeMixin
...
Both UploadResultsRenderer and DownloadResultsRenderer do not use
RateAndTimeMixin anymore: safe to remove it now.
Tests for methods formerly in RateAndTimeMixin have been moved to
test.web.test_util: specifically test_abbreviate_rate() and
test_abbreviate_time().
2020-07-06 17:11:30 -04:00
Sajith Sasidharan
4a47e8311f
Merge 'origin/master' into 3288.status-download-nevow-to-twisted-web
2020-07-06 16:38:23 -04:00
Sajith Sasidharan
25f5e659fc
Merge pull request #721 from sajith/3287.status-upload-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.UploadStatusPage
Fixes: ticket:3287
2020-07-06 16:20:40 -04:00
Sajith Sasidharan
61aef4caef
Merge pull request #690 from sajith/3247.storage-py-neovw-to-twt
...
Use twisted.web.template in web/storage.py
Fixes: ticket:3247
2020-07-06 16:18:34 -04:00
Itamar Turner-Trauring
f548593f37
Fix test_python3, and mark these two modules as being ported as well.
2020-07-06 14:18:18 -04:00
Itamar Turner-Trauring
b990334104
Add the builtins import to make Python 2 builtins match Python 3's.
2020-07-06 14:00:02 -04:00
Itamar Turner-Trauring
83b9bbf743
Switch definitely to _python3.py for listing modules, but also note if a module
...
has been ported in its docstring.
2020-07-03 13:28:36 -04:00
Itamar Turner-Trauring
140cb80ff7
Clarify comment.
2020-07-03 13:15:57 -04:00
Itamar Turner-Trauring
12691eb597
Only install module mappings once.
2020-07-02 14:31:33 -04:00
Itamar Turner-Trauring
70a029fb81
Tests pass on both Python 2 and Python 3.
2020-07-02 14:26:35 -04:00
Itamar Turner-Trauring
c207a0c932
Port test_humanreadable.py to Python 3.
2020-07-02 14:10:38 -04:00
Itamar Turner-Trauring
b7f88b278f
Split out tests for humanreadable into their own module, so we can port just
...
humanreadable.py in isolation.
2020-07-02 13:40:40 -04:00
meejah
ffd24b9c7f
Merge pull request #728 from meejah/ticket3317-verified-fakes
...
Ticket 3317: start of verified fakes
2020-06-30 19:40:39 +00:00
meejah
aedc58ef51
unused imports
2020-06-19 17:22:42 -06:00
meejah
f0ac5a2cef
more-testtools-y asserts
2020-06-19 17:19:30 -06:00
meejah
57eb875354
testtool's asserts
2020-06-19 17:16:39 -06:00
meejah
ef71fc2bfc
Get rid of ?replace= handling entirely and more-correctly support /uri variants
2020-06-19 17:15:01 -06:00
Sajith Sasidharan
dfb477a2b1
Remove unused import
2020-06-17 22:09:50 -04:00
Sajith Sasidharan
47f9147e16
Rename a class for consistency's sake
2020-06-17 21:46:40 -04:00
Sajith Sasidharan
1ee756c8df
Use Beautiful Soup to check for favicon
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c4be4b566c
Make TestRequest an object
...
Wouldn't pass PythonTwoRegressions.test_new_style_classes without
this.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c44a167a66
Remove WebRenderingMixin from WebResultsRendering
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
02cd42c130
Simplify WebResultsRendering.test_literal
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
77120ba70c
Update tests for ResultsRenderer classes
2020-06-17 21:18:14 -04:00
meejah
02a543515f
replciate Tahoe's behavior for replace=true/false
2020-06-13 01:55:14 -06:00
meejah
fa597e1735
use real parser
2020-06-12 22:57:38 -06:00
meejah
949b09ce27
actually returns CREATED for new data
2020-06-12 22:08:36 -06:00
meejah
776ee5f91c
use hypothesis -- which doesn't know about Deferred, so need testtools too
2020-06-12 22:04:12 -06:00
meejah
05ea0a2fe9
copyright, header
2020-06-12 22:04:03 -06:00
meejah
00e7d01a1a
unused imports
2020-06-11 15:34:40 -06:00
meejah
86a90084bb
simple test of testing/web
2020-06-11 14:14:42 -06:00
Sajith Sasidharan
cf4b3ba008
Correct arguments to super()
...
This was incidentally found when looking at some test failures:
super(type, object) is the right invocation, and not the other way
around.
2020-05-29 09:20:18 -04:00
Sajith Sasidharan
b0e3325d03
Move time formatter tests
...
UploadResultsRendererMixin no longer has render_time(); moving tests
for render_time() as tests for abbreviate_time() to a more appropriate
place.
2020-05-22 20:49:34 -04:00
Sajith Sasidharan
ab4811eaa0
Move tests for abbreviate time/rate methods to utils tests
...
RateAndTimeMixin.render_time() is really abbreviate_time(), and
RateAndTimeMixin.render_rate() is really abbreviate_rate(). This
change moves the tests to their rightful place, and exercises them
using the right names.
We're also trying to avoid use of mixins. RateAndTimeMixin will
eventually go.
2020-05-14 16:09:54 -04:00
meejah
466369dd69
Merge pull request #669 from meejah/make-pypy-work
...
Make pypy work
2020-05-13 12:44:23 -06:00
meejah
2418e90bf0
CacheDirectoryManager is unused
2020-05-06 15:22:22 -06:00
meejah
d4f29e7d6c
restore old code, run the GC
2020-05-05 13:57:17 -06:00
meejah
b54dc1e5d5
whitespace (1 line per import)
2020-05-05 13:56:59 -06:00
Sajith Sasidharan
5e4f2d88f1
Merge pull request #710 from sajith/3305.root-from-nevow-to-twisted-web
...
Move root.Root from nevow to twisted.web.template
Fixes: ticket:3305
2020-05-05 15:56:21 -04:00
Sajith Sasidharan
ab298dab9c
Make ErrorBoom a new style class
...
ErrorBoom won't pass PythonTwoRegressions.test_new_style_classes()
check otherwise.
2020-05-05 12:56:19 -04:00
Sajith Sasidharan
edd4cab42b
Replace nevow with twisted.web in test.web.test_grid
2020-05-05 11:51:28 -04:00
meejah
1e039d8364
certs big enough to make pypy happy
2020-05-04 21:59:15 -06:00
meejah
00373fc211
special-case pypy
2020-05-04 21:59:15 -06:00
meejah
13350d60c2
assertFailure instead of bespoke code
2020-05-04 21:59:15 -06:00
meejah
bddd2cc996
disable system tests on PyPy
2020-05-04 21:59:15 -06:00
meejah
29563b8f2d
assert proper errors
2020-05-04 21:59:15 -06:00
meejah
f8117320cb
tests which rely on memory-reclamation need gc.collect() on pypy
2020-05-04 21:59:15 -06:00
meejah
8965c77d63
look for correct error-string
2020-05-04 21:59:15 -06:00
meejah
9bcc465f76
unused import
2020-05-04 21:59:15 -06:00
meejah
4928d62d66
use set instead of WeakKeyDictionary
2020-05-04 21:59:15 -06:00
meejah
5175a6c6a0
asserts for systemexit
2020-05-04 21:59:15 -06:00
meejah
5071ddf124
add more 'with' statements
2020-05-04 21:59:15 -06:00
meejah
a348d3d507
relying on memory/gc bad
2020-05-04 21:59:15 -06:00
meejah
ca5e1ebe52
look at correct mock-call object
2020-05-04 21:59:15 -06:00
meejah
4b0c730adf
use 'with open' correctly
2020-05-04 21:59:15 -06:00
Sajith Sasidharan
88b369a0c2
Remove unused variables
2020-05-04 11:48:52 -04:00
Sajith Sasidharan
58a06cb57d
Update test that exercises empty nick and version
2020-05-04 09:45:36 -04:00
Sajith Sasidharan
88b7784f39
Use BeautifulSoup in test.test_system.SystemTest.test_filesystem
2020-04-30 15:09:10 -04:00
Sajith Sasidharan
6aebab28a9
Use BeautifulSoup to check rendered document
2020-04-30 10:17:48 -04:00
Sajith Sasidharan
e5733b6c90
Remove unused test code
2020-04-28 19:09:00 -04:00
Sajith Sasidharan
98322effe6
Update test to exercise services renderer
2020-04-28 19:07:57 -04:00
meejah
c385e958a8
Merge branch 'master' into ticket3252-port-web-directory.remaining.1
2020-04-23 12:24:00 -06:00
Sajith Sasidharan
b3feaae644
Use an inner JSONRequest class with renderJSON
...
Once nevow is removed from web/common.py, we can simplify
renderJSON(), like so:
def renderJSON():
req = Request()
req.args = {"t": ["json"]}
req.fields = {}
return resource.render(req)
But for now we have to live with an inner class that implements the
nevow.inevow.IRequest interface.
2020-04-21 10:29:28 -04:00
Sajith Sasidharan
201c08dbe5
Declare JSON request interface using @implementer
...
"zope.interface.implements(IRequest)" is deprectated in favor of
"@zope.interface.implementer(IRequest)" decorator.
2020-04-20 16:54:51 -04:00
meejah
8df1ed1ba6
link to tickets
2020-04-18 02:49:14 -06:00
meejah
349aefeacc
fail() takes a message, not Exception
2020-04-18 01:52:18 -06:00
meejah
018e161f19
don't allow trailing slashes
...
This makes /uri/xxx URIs invalid if they have a trailing slash.
It seems that the former Nevow implementation would allow this, and
some tests (and, notable, "tahoe backup") did rely on using URIs
of this style.
2020-04-18 01:52:18 -06:00
meejah
8f35f78194
temporary fix for hypothesis test
2020-04-18 01:52:18 -06:00
meejah
c246b3e049
self.assertEqual not assert
2020-04-18 01:52:18 -06:00
meejah
701915783c
make unpack/pack test use Hypothesis
2020-04-18 01:52:18 -06:00
meejah
3d3feec059
encode for fail() / Exception
2020-04-18 01:52:18 -06:00
meejah
d533becc07
native strings only
2020-04-18 01:52:18 -06:00
meejah
ef5e18b6c7
unused
2020-04-18 01:52:18 -06:00
meejah
fdb3399edb
just delete test_welcome
2020-04-18 01:52:18 -06:00
meejah
b44980ca01
get rid of assert_
2020-04-18 01:52:18 -06:00
meejah
e4d556b49e
assert about connected storage servers
2020-04-18 01:52:18 -06:00
meejah
f9956f4c43
remove asserts for static text
2020-04-18 01:52:18 -06:00
meejah
9ccbe562d7
add break
2020-04-18 01:52:18 -06:00
meejah
d12fd573d3
assert for noreferrer
2020-04-18 01:52:18 -06:00
meejah
48f859f5d4
document internal callback
2020-04-18 01:52:18 -06:00
meejah
685aaf14bf
soup, not re
2020-04-18 01:52:17 -06:00
meejah
af35483fbf
soup not re
2020-04-18 01:52:17 -06:00
meejah
b71d4993c6
more soup
2020-04-18 01:52:17 -06:00
meejah
b4fab4403f
use soup, not strings
2020-04-18 01:52:17 -06:00
meejah
bd1cbde273
re/string checks -> soup
2020-04-18 01:52:17 -06:00
meejah
76516fe02e
use soup, not re
2020-04-18 01:52:17 -06:00
meejah
c489c61404
refactor
2020-04-18 01:52:17 -06:00
meejah
d5ef65d326
beautifulsoup, not re
2020-04-18 01:52:17 -06:00