Sajith Sasidharan
e6eb866cef
Add missing "header" renderer
...
It does not do much here, but it is good to be consistent
2020-07-15 16:21:46 -04:00
Sajith Sasidharan
b5a465cc8d
Format "all objects" table correctly
2020-07-15 16:20:36 -04:00
Sajith Sasidharan
07c24dbe59
Add a missing super() call
2020-07-15 16:14:10 -04:00
Sajith Sasidharan
69afd292c2
Use a different format for path
...
Seems that _join_pathstring() is the wrong thing to use here.
2020-07-15 13:43:50 -04:00
Sajith Sasidharan
f547509332
Use table headers correctly
2020-07-15 13:24:32 -04:00
Sajith Sasidharan
ddfe20c8ab
Use SlotsSequenceElement correctly
2020-07-15 13:24:20 -04:00
Sajith Sasidharan
99ce9ff198
Correct argument to SlotsSequenceElement
2020-07-14 21:42:28 -04:00
Sajith Sasidharan
ef26d66e79
Use correct twisted web template directives
2020-07-14 20:50:12 -04:00
Sajith Sasidharan
b4b820ed7b
Use a helper method to get monitor counter
2020-07-14 20:47:23 -04:00
Sajith Sasidharan
b49a3eaf3a
Check for a non-standard property on request
2020-07-10 21:46:23 -04:00
Sajith Sasidharan
69ae9e6d32
Merge 'origin/master' into 3316.check-results-nevow-to-twisted-web
2020-07-10 16:33:06 -04:00
Sajith Sasidharan
427f99621f
Do more null checks
2020-07-10 06:56:29 -04:00
Sajith Sasidharan
8331e7d8ec
Remove now-unnecessary UploadResultsPage.render_UPLOAD
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
44ecfdad09
Make UploadResultsPage a Resource
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
62e803db25
Make UploadStatusPage a Resource
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
38fe7dd3f5
Remove unused import
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
f30dcc7ec6
Make Element the superclass of UploadResultsRendererMixin
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
9c14eec1e0
Avoid use of RateAndTimeMixin in UploadResultsRendererMixin
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
118ea4267c
Render abbreviated rate and time values
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
c0d83def22
Document UploadResultsPage parameter
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
0af8df7203
Document UploadStatusPage
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
855668b188
Remove unused imports
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
a0655c18d6
Handle "t=upload" in UploadResultsPage POST handling
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
6b4d27bec1
Use twisted web template in UploadResultsRendererMixin
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
2ab7b15f8b
Make UploadResultsPage a MultiFormatResource
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
71fd4f5d10
Use twisted template tags in upload results page template
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
e6f0f9d038
Make UploadStatusPage a MultiFormatResource
2020-07-09 16:05:31 -04:00
Sajith Sasidharan
d24babe873
Use twisted template tags in upload status page template
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
6379601722
Wrap renderer results in tags
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
de5d04ab79
Remove an extraneous directive
...
`t:data` is not really a Twisted template directive. Added my
mistake, removing now.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
a056f18ca9
Remove StorageStatus.renderHTTP
...
This was added to please the test suite. Pleased to remove it!
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
7126d3247c
Prefix member variable with "_"
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
0d9ec2b206
Use slots to render storage stats table
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
9dd9d98b8c
Give the suite the precise string it wants
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
56e2fa3f24
Use <t:transparent> to render node nickname and id
...
CI did not like the old way, but it passed in my system. Odd.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
0bd386384e
Mark format_recovered
as static method
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
bc8a86e106
Use Unicode strings to render space
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
0b4c235fbd
Remove redundant None
-checks on self.storage
...
When no storage is up, `storage_running()` renderer will return a big
honking `no storage server running` message, and no further renderers
will be invoked. Therefore the extra defense is probably not
required.
(I tested this hypothesis. The extra defense is not required, unless
there's something I have not seen.)
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
ee8e730727
Move renderSynchronously
to test suite
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
92f6e4bfe5
Use explicit None
-check on self.storage
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
affe10b3e9
Return result from renderHTTP
...
Bogus renderHTTP, but test failures are now down to three. We just
need to handle requests for JSON now.
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
6b5e530cb3
Add a docstring
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
abb8834be1
Rename function for clarity
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
e67fa7cd95
Add docstrings to StorageStatusElement
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
62a997ce20
Use parentheses in import statement
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
1be736e4d1
Fix test_storage.WebStatus.test_no_server failure
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
8dd4029428
Use <t:transparent /> within table cells
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
6ccb9d29cb
Use render_space methods to render space
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
dbc6b2afa0
Drop unused ctx
argument from render_space methods
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
d5af7c0d2e
Refactor so that test_util pass
2020-07-09 16:05:30 -04:00
Sajith Sasidharan
923219e54a
Use right syntax for twisted.web.template tags
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
42c3e276a3
Check storage server status before using it
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
d1f17e1019
Second version of renderSynchronously
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
805b880c2e
Add missing flattenString
import
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
75488c4aff
Add StorageStatus::renderSynchronously
...
Related to ticket:3247
test_storage.py wants a `StorageStatus::renderSynchronously()` method
and a `StorageStatus::renderHTTP()` method. Let us begin with the
goofy first-cut.
Both these methods are not only wrong, but they will also not please
the test suite. However error messages produced in CI can be shared,
and that way I can hopefully get unstuck.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
aad3557d2b
Use twisted.web.template in web/storage.py
...
Related to ticket:3247. Nevow usage has been removed, and generated
page looks the same as its former self, but tests are failing because
test_storage.py assumes that we're using nevow.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
b956d9a58c
Decode name before null check
...
Make the diff against master a tad bit smaller.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
fccc331671
Make "Refresh" link work
...
This seems to be a subtle difference from nevow: with `href="."`,
rendered link target will be `/uri/`, so clicking "Refresh" will
result in an error message like so: "GET /uri requires uri=".
With `href=""`, the rendered link target will be `/uri/URI:...`, which
is what we need.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
378b20c51a
Reject trailing empty path piece in URIs
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
d3d0d02855
Reject URIs that contain empty segments
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
5892eae580
Render self in DirectoryNodeHandler.getChild()
...
We need self.render_POST() etc. to be invoked when we have a request
such as "POST /uri/URI:DIR:..."; throwing an error here is probably
not the right thing to do.
2020-07-09 16:05:29 -04:00
Sajith Sasidharan
4dd6c86950
Use twisted web directives in web.operations.ReloadMixin
2020-07-09 16:05:28 -04:00
Sajith Sasidharan
54248f334e
Use WebError, not RuntimeError, to indicate error
...
Several problems with using RuntimeError to signal error here:
- It dumps a rather unhelpful webpage at the user.
- The exception backtrace on Tahoe console is not quite necessary here.
- It really is not a runtime error: it is just an expected failure.
- But mainly, testing for RuntimeError is harder.
2020-07-09 14:35:14 -04:00
Sajith Sasidharan
51d6307b45
Fail better when timings data isn't available
2020-07-08 13:08:35 -04:00
Sajith Sasidharan
81216f18bf
Remove some whitespace
2020-07-08 10:15:33 -04:00
Sajith Sasidharan
7757756a41
Use correct tag type
2020-07-07 20:45:30 -04:00
Sajith Sasidharan
0c4d24a2ac
Avoid use of deferred within an Element
...
This causes the final HTML to be rendered funny, with a bunch of
"<Deferred current result=...>", which is clearly not what we want.
2020-07-07 20:24:56 -04:00
Sajith Sasidharan
7877d8a5cc
Use an accessor
2020-07-07 19:55:14 -04:00
Sajith Sasidharan
e6eb387707
Remove status.RateAndTimeMixin
...
Both UploadResultsRenderer and DownloadResultsRenderer do not use
RateAndTimeMixin anymore: safe to remove it now.
Tests for methods formerly in RateAndTimeMixin have been moved to
test.web.test_util: specifically test_abbreviate_rate() and
test_abbreviate_time().
2020-07-06 17:11:30 -04:00
Sajith Sasidharan
4a47e8311f
Merge 'origin/master' into 3288.status-download-nevow-to-twisted-web
2020-07-06 16:38:23 -04:00
Sajith Sasidharan
25f5e659fc
Merge pull request #721 from sajith/3287.status-upload-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.UploadStatusPage
Fixes: ticket:3287
2020-07-06 16:20:40 -04:00
Sajith Sasidharan
61aef4caef
Merge pull request #690 from sajith/3247.storage-py-neovw-to-twt
...
Use twisted.web.template in web/storage.py
Fixes: ticket:3247
2020-07-06 16:18:34 -04:00
Sajith Sasidharan
f9e864c51c
Use simpler syntax to update map
2020-06-24 08:15:18 -04:00
Sajith Sasidharan
88d3fa7415
Remove now-unnecessary UploadResultsPage.render_UPLOAD
2020-06-23 21:54:23 -04:00
Sajith Sasidharan
dfbb8e7743
Make UploadResultsPage a Resource
2020-06-23 21:53:39 -04:00
Sajith Sasidharan
6ab7f26faf
Make UploadStatusPage a Resource
2020-06-23 21:28:31 -04:00
Sajith Sasidharan
00e852c465
Make DownloadStatus an object
...
PythonTwoRegressions.test_new_style_classes would be unhappy without
this.
2020-06-23 20:54:49 -04:00
Sajith Sasidharan
36ecd8f384
Use render_GET()
...
Implementing `render_METHOD()` is preferred over overriding render()
2020-06-23 20:54:49 -04:00
Sajith Sasidharan
b14c0a0495
Make DownloadStatusPage a Resource
...
No need of this being a MultiFormatResource, because it renders just
HTML.
2020-06-23 20:54:49 -04:00
Sajith Sasidharan
982ad8942e
Comment about nevow.url usage in web.operations.OphandleTable
2020-06-18 18:30:18 -04:00
Sajith Sasidharan
2d2e8a5872
Add comments to web.operations.OphandleTable
2020-06-18 18:29:39 -04:00
Sajith Sasidharan
bbee23b493
Rename a parameter for clarity
...
"context" is nevow terminology, whereas these are really requests.
2020-06-18 18:29:39 -04:00
Sajith Sasidharan
5ec78641db
Make web.operations.OphandleTable a twisted web Resource
2020-06-18 18:29:27 -04:00
Sajith Sasidharan
6f8af688dd
Rearrange imports
2020-06-18 18:01:18 -04:00
Sajith Sasidharan
e121cc0a84
Use the right names
...
Missed this in testing because this code was not reached in testing.
2020-06-17 22:09:50 -04:00
Sajith Sasidharan
4f213e93be
Remove an unused variable
2020-06-17 22:04:08 -04:00
Sajith Sasidharan
0483fc91c1
Remove unused import
2020-06-17 22:04:08 -04:00
Sajith Sasidharan
c3440ce213
Use a helper to query monitor counters
2020-06-17 21:53:11 -04:00
Sajith Sasidharan
47f9147e16
Rename a class for consistency's sake
2020-06-17 21:46:40 -04:00
Sajith Sasidharan
fe1b0cb7ed
Rename class variables
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
22977352bb
Document parameters of ResultsRenderer classes
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
79be795566
Remove unused want_json()
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
23a51117d2
Rename r
to check_results
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
fae4f44404
Prefer req
to ctx
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cdb3747470
Remove nevow imports
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
de99912641
Replace ctx
references with req
references
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
2e60408bf6
Wrap counters in <span> tags
...
Unless the rendered page contains strings of the form "Objects
Checked: <span>n</span>" etc, test_POST_DIRURL_deepcheck will not
pass.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
33ddac879c
Remove unused code
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
8094b3144d
Use SlotsSequenceElement to render all objects
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
4e594b09bf
Use SlotsSequenceElement to render corrupt shares
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
46cb3b6bc3
Use SlotsSequenceElement to render servers with corrupt shares
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c41bca24f5
Use SlotsSequenceElement to render deep check results problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
bbd6bde478
Use SlotsSequenceElement to render remaining corrupt shares
...
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
19f6ec7102
Use SlotsSequenceElement to render servers with corrupt shares
...
This was previously not implemented; leaving it as such.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
e0c686bb92
Use SlotsSequenceElement to render post-repair problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
f168dcd19c
Use SlotsSequenceElement to render pre-repair problems
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c7aa789a22
Fix "class has no children attribute" error
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cfb1560d15
Render "all objects" table using SlotsSequenceElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
3783349ea7
Add span tags to "deep check and repair results" template
...
Tests expect <span> tags around these numbers, let us add those.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
048840ac99
Stringify numbers
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
0d1269264a
Stringify numbers in DeepCheckResultsRenderer
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
7237fef630
Add property client to CheckAndRepairResultsRendererElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
19db5fb312
Update "deep check and repair results" template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
e4efcdd925
Make DeepCheckAndRepairResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
842b2b6be5
Use twisted tags in "deep check and repair results" template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
27e5ce090a
Update deep check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c33c0a884d
Make DeepCheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
9dcaa104c5
Use twisted tags in deep check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
0eea108123
Make CheckAndRepairResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
d9005fcccc
Use twisted tags in check and repair results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
80e9f48551
Add line breaks in a comment
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
6f1601aeeb
Stringify numbers before wrapping them up in tags
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
d2540b89d3
Use twisted web tags in ResultsBase
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
8e37bb1ebb
Make ResultsBase a base class of CheckResultsRendererElement
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
fea4e516f3
Make CheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
9d104f5893
Use twisted tags in check results template file
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
cbc414725c
Use "output" as format argument
...
Nearly everywhere else the query argument for output format is "t";
but here "t" is used for operations, and "output" is used for output
format.
The test suite will fail without this.
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
c15001269f
Avoid using a Python keyword as a renderer name
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
3901559e34
Make LiteralCheckResultsRenderer a MultiFormatResource
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
ebf23a4f0e
Use twisted web tags in literal check results template
2020-06-17 21:18:14 -04:00
Sajith Sasidharan
950d111793
Use POST target paths without pre-existing query arguments
...
`action="."` on `/uri/URI:DIR2:$DIRCAP` will render as `/uri/`, which
is not the result we want.
2020-06-17 21:16:38 -04:00
Sajith Sasidharan
55170dcd2b
Rearrange imports
2020-06-17 15:45:08 -04:00
Sajith Sasidharan
7a23c8ed6c
Merge pull request #724 from sajith/3312.webui-directory-fix
...
Fix for "the webapi does not allow empty pathname components"
Fixes: ticket:3312
2020-06-17 10:55:21 -04:00
Sajith Sasidharan
4fa2e6ad97
Use twisted web directives in web.operations.ReloadMixin
2020-06-02 11:56:59 -04:00
Sajith Sasidharan
dd14da4a55
Decode name before null check
...
Make the diff against master a tad bit smaller.
2020-05-29 21:48:04 -04:00
Sajith Sasidharan
dce73f7c2f
Make "Refresh" link work
...
This seems to be a subtle difference from nevow: with `href="."`,
rendered link target will be `/uri/`, so clicking "Refresh" will
result in an error message like so: "GET /uri requires uri=".
With `href=""`, the rendered link target will be `/uri/URI:...`, which
is what we need.
2020-05-29 21:44:10 -04:00
Sajith Sasidharan
31eba00d0f
Reject trailing empty path piece in URIs
2020-05-29 21:38:43 -04:00
Sajith Sasidharan
0633623ecc
Reject URIs that contain empty segments
2020-05-29 21:38:43 -04:00
Sajith Sasidharan
b6e00d09f9
Render self in DirectoryNodeHandler.getChild()
...
We need self.render_POST() etc. to be invoked when we have a request
such as "POST /uri/URI:DIR:..."; throwing an error here is probably
not the right thing to do.
2020-05-29 09:22:15 -04:00
Sajith Sasidharan
d3f43d31d9
Remove unused import
2020-05-23 06:17:06 -04:00
Sajith Sasidharan
93d015e468
Document status.Status
2020-05-22 22:24:09 -04:00
Sajith Sasidharan
a6e32135e8
Update status page child route handler and table renderers
...
Drop nevow-isms and use twisted.web's way of doing things.
2020-05-22 22:15:45 -04:00
Sajith Sasidharan
3357f4c5ce
Make Status a MultiFormatResource
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
81dc63b511
Use twisted template tags in status page template
2020-05-22 22:12:22 -04:00
Sajith Sasidharan
03d529c22a
Remove unused import
2020-05-22 21:33:30 -04:00
Sajith Sasidharan
9520ad71eb
Rearrange imports
2020-05-22 21:24:21 -04:00
Sajith Sasidharan
f8562530be
Make Element the superclass of UploadResultsRendererMixin
2020-05-22 21:11:42 -04:00
Sajith Sasidharan
91f8d939f8
Avoid use of RateAndTimeMixin in UploadResultsRendererMixin
2020-05-22 20:22:59 -04:00
Sajith Sasidharan
aecd90858a
Render abbreviated rate and time values
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
7be1883910
Document UploadResultsPage parameter
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
5fdd61b146
Document UploadStatusPage
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
54ac2d224a
Remove unused imports
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
7a82fd671f
Handle "t=upload" in UploadResultsPage POST handling
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
3bfa5a5c29
Use twisted web template in UploadResultsRendererMixin
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
57b1203d17
Make UploadResultsPage a MultiFormatResource
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
6470718691
Use twisted template tags in upload results page template
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
41300097c8
Make UploadStatusPage a MultiFormatResource
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
aac8dee8a0
Use twisted template tags in upload status page template
2020-05-22 19:39:32 -04:00
Sajith Sasidharan
aec6e5a9d4
Force a CircleCI build
2020-05-18 20:05:16 -04:00
Sajith Sasidharan
c23fedbcfe
Add related ticket to comment about refactoring
2020-05-18 16:56:32 -04:00
Sajith Sasidharan
0b3db59742
Add related ticket to comment about unimplemented method
2020-05-18 16:56:32 -04:00
Sajith Sasidharan
993b1e225f
Use transparent tags to render values
2020-05-18 11:01:14 -04:00
Sajith Sasidharan
c5342d8ae6
Add comments about events tables
2020-05-14 16:48:43 -04:00
Sajith Sasidharan
88e8854ad4
Wrap renderer results in tags
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
68df408229
Add a note about unimplemented DownloadStatus method
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
1fa77d8983
Avoid use of DownloadResultsRendererMixin
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
1f1f3b5f61
Remove unused render_timeline_link()
...
As it turns out, nothing is using this method.
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
f3edc8a48c
Add a note about rendering download events tables
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
b02cfa5bbe
Use more descriptive variable names
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
7e02502268
Add comments to DownloadStatusPage
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
e0241655e5
Update results renderer
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
c5b2073bf0
Avoid use of RateAndTimeMixin methods in DownloadStatusElement
2020-05-14 16:09:54 -04:00
Sajith Sasidharan
c4b63ada55
Update events tables renderer
2020-05-14 16:09:29 -04:00
Sajith Sasidharan
c14c437152
Make DownloadStatusPage a MultiFormatResource
2020-05-14 10:21:19 -04:00
Sajith Sasidharan
8a632b6668
Use twisted tags in download status page template
2020-05-14 10:14:52 -04:00
Sajith Sasidharan
a203f9c8d8
Reformat download status page template
2020-05-14 10:14:52 -04:00
Sajith Sasidharan
538503c0f8
Merge pull request #717 from sajith/3289.status-publish-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.PublishStatusPage
Fixes: ticket:3289
2020-05-14 10:09:57 -04:00
Sajith Sasidharan
78c214b7ff
Merge pull request #716 from sajith/3290.status-retrieve-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.RetrieveStatusPage
Fixes: ticket:3290
2020-05-13 19:39:23 -04:00
Sajith Sasidharan
79a44eac33
Correct docstring to ":param <type> <name>" format
2020-05-13 19:29:41 -04:00
Sajith Sasidharan
9d5d338993
Correct docstring to ":param <type> <name>" format
2020-05-13 19:04:10 -04:00
Sajith Sasidharan
d87dfaf5a0
Merge pull request #714 from sajith/3291.status-mapupdate-nevow-to-twisted-web
...
Replace nevow with twisted.web.template in status.MapupdatePage
Fixes: ticket:3291
2020-05-13 18:22:16 -04:00
Sajith Sasidharan
ebe80221d5
Add missing "param:" to init method docstring
2020-05-13 17:45:08 -04:00
Sajith Sasidharan
2e0e210c14
Make PublishStatusPage comment a docstring
2020-05-13 17:43:55 -04:00
Sajith Sasidharan
5aa0dd4085
Rename a variable for readability
...
Noticed in code review: `l` can be confused with `1` for many
typefaces.
2020-05-13 17:12:08 -04:00
Sajith Sasidharan
812f03934a
Add missing "param:" to docstring
2020-05-13 17:09:53 -04:00
Sajith Sasidharan
4af2e4b4df
Drop an unbalanced quote
2020-05-13 17:08:26 -04:00
Sajith Sasidharan
62760c0997
Make RetrieveStatusPage comment a docstring
2020-05-13 17:07:09 -04:00
Sajith Sasidharan
8e17d203cf
Add missing "param:" to docstring
2020-05-13 16:59:52 -04:00
Sajith Sasidharan
c18488872c
Make comment on MapupdateStatusPage a docstring
2020-05-13 16:54:39 -04:00
Sajith Sasidharan
3fad9a127c
Remove web.common.RenderMixin
...
Fixes: ticket:3308
2020-05-12 07:40:22 -04:00
Sajith Sasidharan
0ae045ea16
Add comments to PublishStatusPage
2020-05-11 12:47:48 -04:00
Sajith Sasidharan
9e200fc014
Render publish problems only when there are problems
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
0fba615afb
Remove RateAndTimeMixin from PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
fdf6449ba8
Use MultiFormatResource to implement PublishStatusPage
2020-05-11 11:43:04 -04:00
Sajith Sasidharan
89c4210090
Use twisted tags in publish status template page
2020-05-11 11:43:01 -04:00
Sajith Sasidharan
65cd0e8ecd
Reformat publish status template page
2020-05-11 10:38:15 -04:00
Sajith Sasidharan
3aaa87d2ba
Add notes to RetrieveStatusPage
2020-05-07 13:15:05 -04:00
Sajith Sasidharan
07f14a19f8
Drop RateAndTimeMixin from RetrieveStatusElement
2020-05-07 11:37:21 -04:00
Sajith Sasidharan
a544e8a55f
Stringify tag parameters
2020-05-07 10:55:08 -04:00
Sajith Sasidharan
de41302743
Update RetrieveStatusPage to use twisted renderers
2020-05-07 09:34:42 -04:00
Sajith Sasidharan
5fa7c4c446
Update markup in retrieve status template page
2020-05-07 09:32:01 -04:00
Sajith Sasidharan
d2375e4fe2
Reformat retrieve status page template
2020-05-06 22:42:32 -04:00
Sajith Sasidharan
13bbda1529
Render privkey only when there's a privkey
2020-05-06 13:21:26 -04:00
Sajith Sasidharan
008812d6c8
Render abbreviated time in map update results
2020-05-06 13:11:53 -04:00
Sajith Sasidharan
0c6889274d
Render problems only when there's a problem list
2020-05-06 13:10:31 -04:00
Sajith Sasidharan
bbbca6c000
Drop a newline
...
Party for consistency, partly in order to trigger a CircleCI run.
2020-05-06 10:41:58 -04:00
Sajith Sasidharan
8a71567137
Avoid use of RateAndTimeMixin in MapupdateStatusPage
2020-05-06 09:29:57 -04:00
Sajith Sasidharan
86871363ea
Add notes to MapupdateStatusPage
2020-05-06 09:06:56 -04:00
Sajith Sasidharan
1602c66250
Render map update status using twisted.web.template
...
Fixes: ticket:3291
2020-05-06 09:06:56 -04:00
Sajith Sasidharan
3b0ace1710
Merge pull request #708 from sajith/3293.status-helper-nevow-to-twisted-web
...
Render helper status page using twisted.web.template
Fixes: ticket:3293
2020-05-05 16:00:24 -04:00
Sajith Sasidharan
ccffd78ac4
Add a comma, for consistency's sake
2020-05-05 09:27:09 -04:00
Sajith Sasidharan
f5dacf9547
Drop a comma introduced by mistake
2020-05-05 09:27:09 -04:00
Sajith Sasidharan
96c8c5e953
Link to storage server the way it used to be
2020-05-05 07:43:39 -04:00
Sajith Sasidharan
7d063995f5
Update copyright years
2020-05-04 15:35:21 -04:00
Sajith Sasidharan
4ebd6250e3
Document root.Root
2020-05-04 14:20:05 -04:00
Sajith Sasidharan
96449bb99b
Ensure lists before conversion to dict
2020-05-04 14:05:33 -04:00
Sajith Sasidharan
bf0f8a736a
Remove unused imports
2020-05-04 11:48:41 -04:00
Sajith Sasidharan
df9b160a3c
Mark describe server method as static
2020-05-01 17:42:46 -04:00
Sajith Sasidharan
80a26e26b1
Refactor methods that describe server/connection
2020-05-01 17:41:51 -04:00
Sajith Sasidharan
7b4d81fe28
Rename root.Root variables
2020-05-01 17:38:24 -04:00
Sajith Sasidharan
ade7f613b8
Remove unused renderer
2020-05-01 17:07:08 -04:00
Sajith Sasidharan
df188c75df
Wrap footer elements in tags
2020-05-01 16:50:30 -04:00
Sajith Sasidharan
029c99a241
Render introducers table using SlotsSequenceElement
2020-05-01 16:45:34 -04:00
Sajith Sasidharan
1ddf07d59d
Render services table using SlotsSequenceElement
2020-05-01 16:45:04 -04:00
Sajith Sasidharan
0d8eda5e76
Rearrange imports
2020-05-01 16:07:30 -04:00
Sajith Sasidharan
053e614221
Import resource_filename from setuptools
...
Drop the nevow one
2020-05-01 16:07:21 -04:00
Sajith Sasidharan
e9796eb308
Match against root path first
2020-04-30 18:49:05 -04:00
Sajith Sasidharan
cfe4b2925e
Remove an unused method and imports
2020-04-30 18:48:06 -04:00
Sajith Sasidharan
cce6f83054
Remove unused renderers
2020-04-30 18:47:13 -04:00
Sajith Sasidharan
80ba700247
Correct usage of fillSlots
2020-04-29 12:18:39 -04:00
Sajith Sasidharan
a885f14c43
Pass now_fn to RootElement
2020-04-28 11:47:18 -04:00
Sajith Sasidharan
8ce1512501
Render import path
2020-04-28 07:57:15 -04:00
Sajith Sasidharan
32e0c779b6
Add version renderer
2020-04-28 07:56:27 -04:00
Sajith Sasidharan
d064f6b2b7
Add "rendered at" renderer
2020-04-28 07:55:10 -04:00
Sajith Sasidharan
ed6970b168
Correct fill slots usage in connection status
2020-04-28 07:52:57 -04:00
Sajith Sasidharan
5d84a25f21
Add introducers row renderer
2020-04-28 07:50:03 -04:00
Sajith Sasidharan
5155befedc
Rewrite total introducers
2020-04-28 07:48:28 -04:00
Sajith Sasidharan
44f16e77cf
Add introducers renderer
2020-04-28 07:47:36 -04:00
Sajith Sasidharan
7ba4b945a4
Use introducers renderer method in root template
2020-04-28 07:43:41 -04:00
Sajith Sasidharan
8d4949f96b
Render total introducers correctly
2020-04-28 07:42:57 -04:00
Sajith Sasidharan
a646c7decd
Fix typo
2020-04-28 07:42:07 -04:00
Sajith Sasidharan
89980a039c
Render total introducers
2020-04-28 07:41:29 -04:00
Sajith Sasidharan
2f53b2a67d
Add connected introducers renderer
2020-04-28 07:17:22 -04:00
Sajith Sasidharan
164218cf57
Update service table renderer
2020-04-28 07:14:35 -04:00
Sajith Sasidharan
907e8ccf6b
Use services renderer method in root template
2020-04-28 07:13:41 -04:00
Sajith Sasidharan
75d41843d7
Use transparent nodes
2020-04-28 04:59:46 -04:00
Sajith Sasidharan
3c4056a947
Replace nevow.static.File with twisted.web.static.File
2020-04-28 04:47:48 -04:00
Sajith Sasidharan
dcea7ea476
Render connected/known storage server status
2020-04-27 17:22:27 -04:00
Sajith Sasidharan
1713076a9d
Render services
2020-04-27 17:19:19 -04:00
Sajith Sasidharan
39d616a971
Render helper furl prefix
2020-04-27 17:11:36 -04:00