Commit Graph

6813 Commits

Author SHA1 Message Date
Itamar Turner-Trauring
587222033d Fix bad merge. 2020-12-01 11:58:56 -05:00
Itamar Turner-Trauring
d5ba1be5bc Passing tests. 2020-11-30 17:56:50 -05:00
Itamar Turner-Trauring
17ec22ab84 Even more debytification of furls. 2020-11-30 17:55:37 -05:00
Itamar Turner-Trauring
22c328d6d3 More debytification. 2020-11-30 17:41:15 -05:00
Itamar Turner-Trauring
67694889da Some progress towards ripping out furls-as-bytes. 2020-11-30 17:20:39 -05:00
Itamar Turner-Trauring
27102c0d89 Merge remote-tracking branch 'origin/master' into 3514.test-introducer-python-3 2020-11-30 16:47:21 -05:00
Itamar Turner-Trauring
8615c1ade8 Try to fix sorting on Python 3. 2020-11-30 16:45:14 -05:00
Itamar Turner-Trauring
eaca639b6f Undo changes that should probably be in a different branch. 2020-11-30 16:28:26 -05:00
Itamar Turner-Trauring
413cf75d54 Uses clearer issuperset(). 2020-11-30 16:25:24 -05:00
Itamar Turner-Trauring
9f7ae56a82 Make the explanation less nonsensical. 2020-11-30 16:24:27 -05:00
Jean-Paul Calderone
17ed8afd2f Make the new test data files installable
There's an existing rule that matches *.txt
2020-11-30 13:37:21 -05:00
Jean-Paul Calderone
ef2f7e6136 unused import 2020-11-30 13:27:46 -05:00
Jean-Paul Calderone
2ac4af7fb4 Add some direct tests for NodeMaker.create_from_uri 2020-11-30 13:26:32 -05:00
Jean-Paul Calderone
4ca45aaa93 Catch basedir type errors earlier 2020-11-30 13:23:18 -05:00
Jean-Paul Calderone
01ab8d3ee9 Don't look before you leap 2020-11-30 08:56:45 -05:00
Jean-Paul Calderone
84088e4f41 unused import 2020-11-26 21:18:58 -05:00
Jean-Paul Calderone
805378ef11 Do more path stuff with FilePath 2020-11-26 20:53:57 -05:00
Jean-Paul Calderone
a978fcf433 Replace asserts with explicit checks and TypeError 2020-11-26 19:35:39 -05:00
Jean-Paul Calderone
c82501e0dc Merge remote-tracking branch 'origin/master' into 3511.config-set-config 2020-11-26 11:01:18 -05:00
Jean-Paul Calderone
df53fdcf9b add missing docs to new set_config method 2020-11-26 10:53:42 -05:00
Jean-Paul Calderone
d81fe54faf typo fix 2020-11-26 10:50:36 -05:00
Jean-Paul Calderone
152c04e48c
Merge pull request #902 from tahoe-lafs/3512.localized-tempdir
Per-node web temp directory

Fixes: ticket:3512
2020-11-25 18:18:36 -05:00
Jean-Paul Calderone
520f4d15bf Rename _get_request to more accurate _create_request 2020-11-25 16:09:53 -05:00
Jean-Paul Calderone
8e6773c690
Merge pull request #907 from tahoe-lafs/3518.pypy-versions-None
Get rid of version_checks

Fixes: ticket:3518
2020-11-25 10:54:46 -05:00
Jean-Paul Calderone
bd9a91abf6
Merge pull request #901 from tahoe-lafs/3513.raiseException
Fix exception re-raising in no_network.py

Fixes: ticket:3513
2020-11-25 10:41:15 -05:00
Jean-Paul Calderone
a78c8056fb Get rid of the first mock use in test_threshold_reached 2020-11-24 14:51:51 -05:00
Jean-Paul Calderone
9f4be1fbf0 Speed the tests back up 2020-11-24 14:23:20 -05:00
Jean-Paul Calderone
34b5068f5c Just use a real Tub for this case 2020-11-24 14:18:04 -05:00
Jean-Paul Calderone
c3aff634a0 Add missing attribute docs 2020-11-24 14:17:52 -05:00
Jean-Paul Calderone
1a5efa5ec9 Just let the test use the real SFTPServer service 2020-11-24 14:05:00 -05:00
Jean-Paul Calderone
3321058a33 flake 2020-11-23 15:14:59 -05:00
Jean-Paul Calderone
c694e8c7e2 Delete allmydata.version_checks and related functionality
It is not Tahoe-LAFS' job to manage package installation in this way.
Instead, we can declare our dependencies in setup.py and rely on installation
management tools and packagers to create a suitable execution environment.

Making this statement in the past required going much further out on a limb
than it does today.  This code has served its purpose and can now be retired.
2020-11-23 15:10:18 -05:00
Jean-Paul Calderone
224085c139 Clean up version checks and fix the PyPy regression 2020-11-23 14:14:52 -05:00
Jean-Paul Calderone
55193f725a Avoid passing None to ensure_str 2020-11-23 10:28:04 -05:00
Itamar Turner-Trauring
661bc967d2 Port to Python 3. 2020-11-20 14:06:16 -05:00
Itamar Turner-Trauring
5b87fb4afe All tests pass on Python 2 and 3. 2020-11-20 14:01:48 -05:00
Itamar Turner-Trauring
53a6882f21 Some progress on Python 3 passing tests, some going backwards. 2020-11-20 12:02:22 -05:00
Itamar Turner-Trauring
0e198e7361 Stop hiding Twisted logs! 2020-11-20 11:16:32 -05:00
Itamar Turner-Trauring
bcc509b7a7 Some progress towards passing tests. 2020-11-19 14:23:41 -05:00
Itamar Turner-Trauring
38275cbe6f Merge remote-tracking branch 'origin/master' into 3502.mutable-python-3-part-2 2020-11-19 13:43:10 -05:00
Itamar Turner-Trauring
2ae03043b7 Another passing Python 3 test. 2020-11-19 12:04:02 -05:00
Itamar Turner-Trauring
ad893c9aa1 More passing Python 3 tests. 2020-11-19 11:47:57 -05:00
Itamar Turner-Trauring
8029a1befc First passing test on Python 3. 2020-11-19 11:45:32 -05:00
Itamar Turner-Trauring
40d372a2f6 Some progress towards passing tests on Python 3. 2020-11-19 11:11:48 -05:00
Jean-Paul Calderone
1689804877 Try doing some other thing in Windows 2020-11-19 10:15:36 -05:00
Jean-Paul Calderone
4ce2572ce9 Does Windows behave if we restrict ourselves to *just* S_IREAD?
From CPython docs:

> Note Although Windows supports chmod(), you can only set the file’s
> read-only flag with it (via the stat.S_IWRITE and stat.S_IREAD constants or
> a corresponding integer value). All other bits are ignored.
2020-11-19 09:39:34 -05:00
Jean-Paul Calderone
d727ae4a86 Try to improve the failure mode 2020-11-19 08:50:44 -05:00
Jean-Paul Calderone
594f8019d1 Better support Windows here 2020-11-18 18:29:36 -05:00
Jean-Paul Calderone
f240cb183f flake cleanup 2020-11-18 18:13:01 -05:00
Jean-Paul Calderone
92691c1b32 Be sure the temporary directory exists 2020-11-18 16:53:38 -05:00
Jean-Paul Calderone
5b0d20c453 Everything should be new-style 2020-11-18 16:53:28 -05:00
Jean-Paul Calderone
799e5a2a60 tweak comment about our test case 2020-11-18 15:52:04 -05:00
Jean-Paul Calderone
6d137ac257 Get rid of the tempfile.tempdir hackery 2020-11-18 15:51:08 -05:00
Jean-Paul Calderone
46955202e2 Hook into Twisted Web to control where request bodies are written 2020-11-18 15:47:06 -05:00
Jean-Paul Calderone
875f4d3414 Better setup error re-raising 2020-11-18 14:48:40 -05:00
Jean-Paul Calderone
862d32a90d Add _Config.set_config for presistently changing config values 2020-11-18 13:18:21 -05:00
Jean-Paul Calderone
f21e3189b5 Remove some repetition between read_config and config_from_string 2020-11-18 13:17:16 -05:00
Jean-Paul Calderone
53aa434d77 Add a helper to make a deep copy of a ConfigParser
This will help avoid unintentional side-effects
2020-11-18 13:01:08 -05:00
Jean-Paul Calderone
84647e25b7 Refine the ConfigParser generator
Limit the characters used in the section and item name strategies.
ConfigParser doesn't allow all characters in all places.
2020-11-18 12:59:23 -05:00
Jean-Paul Calderone
021615bdff Some further test_configutil improvements 2020-11-18 12:44:52 -05:00
Jean-Paul Calderone
34714d5f6b Add everything and nothing config validation helpers 2020-11-18 12:42:31 -05:00
Jean-Paul Calderone
e60c643b5f Make configutil.write_config atomic and also make it take a FilePath 2020-11-18 10:57:38 -05:00
Itamar Turner-Trauring
feb85f4c4a Always use native strings as keys. 2020-11-17 13:15:57 -05:00
Itamar Turner-Trauring
bb7ed3afc9 Fix the bug. 2020-11-17 11:25:24 -05:00
Jean-Paul Calderone
2ee0b1d3c6 flake cleanup 2020-11-16 15:05:04 -05:00
Jean-Paul Calderone
5cb1df06c4 delegate introducer furl lookup to the config object 2020-11-16 15:02:51 -05:00
Jean-Paul Calderone
60e0056ad8 don't guide folks to the deprecated config item 2020-11-16 15:02:18 -05:00
Jean-Paul Calderone
0258bb7295 note it's deprecated 2020-11-16 15:02:13 -05:00
Jean-Paul Calderone
c9f7ce8db5 write introducers.yaml instead of [client]introducer.furl 2020-11-16 15:01:52 -05:00
Jean-Paul Calderone
302b5cb01f look for the introducer furl via a more structured interface 2020-11-16 15:01:34 -05:00
Jean-Paul Calderone
0fd354396f note this is for deprecated functionality 2020-11-16 15:01:21 -05:00
Jean-Paul Calderone
69b8262f6b use a different .furl item since introducer.furl will go away 2020-11-16 15:01:05 -05:00
Jean-Paul Calderone
1946ee5023 note this is for deprecated functionality 2020-11-16 15:00:49 -05:00
Jean-Paul Calderone
4e84f5e690 write introducers.yaml instead of [client]introducer.furl in client creation 2020-11-16 15:00:20 -05:00
Jean-Paul Calderone
10600ef5ec Move write_introducer somewhere it can be used more widely 2020-11-16 14:59:42 -05:00
Jean-Paul Calderone
d27c25a26f make sure we put text into yaml 2020-11-14 18:17:34 -05:00
Jean-Paul Calderone
3ac2e9365f yea okay that one fails 2020-11-14 16:57:45 -05:00
Jean-Paul Calderone
dbb8050a8c really suffering from not having a local dev env here 2020-11-14 16:51:36 -05:00
Jean-Paul Calderone
c529d271ee "unicode" is spelled "str" now 2020-11-14 16:46:54 -05:00
Jean-Paul Calderone
06fe3869ef is pyyaml screwing it up? 2020-11-14 16:36:51 -05:00
Jean-Paul Calderone
7b2d76c7ec Another effort to make this simultaneously Py2/Py3 friendly 2020-11-14 16:12:07 -05:00
Jean-Paul Calderone
22973e6951 Attempt to make Python 3 happier 2020-11-14 12:36:22 -05:00
Jean-Paul Calderone
18e327417c Get [client]introducer.furl out of test_system 2020-11-14 11:44:28 -05:00
Jean-Paul Calderone
0f4e34c41d Take [client]introducer.furl out of the UseNode fixture 2020-11-14 11:44:28 -05:00
Jean-Paul Calderone
b6bebc514a Remove [client]introducer.furl from test_node 2020-11-14 11:44:28 -05:00
Jean-Paul Calderone
b181b577e8 Remove [client]introducer.furl from test_multi_introducers (mostly)
Leave in this one test to demonstrate the deprecated functionality still
works, until we delete it entirely.
2020-11-14 11:44:28 -05:00
Jean-Paul Calderone
fabcc079c5 we're not testing the yaml library 2020-11-14 11:44:28 -05:00
Jean-Paul Calderone
0664416f65 Remove [client]introducer.furl from test_introducer 2020-11-14 11:44:26 -05:00
Jean-Paul Calderone
b202f81fd1 move config helper to shared location 2020-11-14 10:23:07 -05:00
Jean-Paul Calderone
25666ee49c Get rid of [client]introducer.furl from test_client 2020-11-14 10:02:19 -05:00
Jean-Paul Calderone
e0f69dcfcf Get the path manipulation into _Config too 2020-11-14 09:26:07 -05:00
Jean-Paul Calderone
bef5ccd0ca Move the introducer config reading code into _Config 2020-11-14 09:12:14 -05:00
Itamar Turner-Trauring
f60c703dfd Ported to Python 3. 2020-11-12 11:24:37 -05:00
Itamar Turner-Trauring
99f54223ab Ported to Python 3. 2020-11-12 11:17:17 -05:00
Itamar Turner-Trauring
679319baf4 Ported to Python 3. 2020-11-12 11:02:51 -05:00
Itamar Turner-Trauring
180c6d7536 Port to Python 3. 2020-11-12 11:00:54 -05:00
Itamar Turner-Trauring
9e2a79ee23 Ported to Python 3. 2020-11-11 14:45:20 -05:00
Itamar Turner-Trauring
d0d7a82734 Port to Python 3. 2020-11-11 14:25:58 -05:00
Itamar Turner-Trauring
d238242d73 Port to Python 3. 2020-11-11 14:09:49 -05:00
Itamar Turner-Trauring
b4803fbc3b Port to Python 3. 2020-11-11 14:05:22 -05:00
Itamar Turner-Trauring
2ae031f54c Merge remote-tracking branch 'origin/master' into 3500.mutable-tests-python-3 2020-11-11 11:41:45 -05:00
Itamar Turner-Trauring
1aeb46aadc Restored sorted. 2020-11-11 10:52:57 -05:00
Itamar Turner-Trauring
7c9b8542c1 Fix flake. 2020-11-09 15:12:38 -05:00
Itamar Turner-Trauring
874111be81 Merge remote-tracking branch 'origin/3496.mutable-tests-python-3-part-3' into 3500.mutable-tests-python-3 2020-11-09 15:09:33 -05:00
Itamar Turner-Trauring
da636984fe Merge remote-tracking branch 'origin/master' into 3500.mutable-tests-python-3 2020-11-09 15:09:16 -05:00
Itamar Turner-Trauring
fcc491bf3b Port to Python 3. 2020-11-09 15:08:56 -05:00
Itamar Turner-Trauring
d8c1b2fba7 Port to Python 3. 2020-11-09 15:02:33 -05:00
Itamar Turner-Trauring
6b61c06882 All tests pass on Python 3. 2020-11-09 15:00:55 -05:00
Itamar Turner-Trauring
e41e660917
Merge branch 'master' into 3496.mutable-tests-python-3-part-3 2020-11-09 14:37:46 -05:00
Itamar Turner-Trauring
c768e0f670
Merge pull request #888 from tahoe-lafs/3475.mutable-tests-part-2-python-3
Port mutable tests to Python 3, part 2 of N

Fixes ticket:3475
2020-11-09 14:36:28 -05:00
Itamar Turner-Trauring
d31667d58c Ported to Python 3. 2020-11-09 14:15:40 -05:00
Itamar Turner-Trauring
2b9e269d3a Tests pass on Python 3. 2020-11-09 14:13:14 -05:00
Itamar Turner-Trauring
da6dfcd86d Ported to Python 3. 2020-11-09 14:00:11 -05:00
Itamar Turner-Trauring
b2e72ef562 Port to Python 3. 2020-11-09 13:55:28 -05:00
Itamar Turner-Trauring
3d5d46fe7c Port to Python 3. 2020-11-09 13:48:22 -05:00
Itamar Turner-Trauring
0e27e7eba1 Merge branch '3496.mutable-tests-python-3-part-3' into 3500.mutable-tests-python-3 2020-11-09 13:46:19 -05:00
Itamar Turner-Trauring
f5f0ce2477 Re-enable sorting. 2020-11-09 13:41:03 -05:00
Chad Whitacre
fe07078859 Turn web service back on in test for Python 3 2020-11-06 19:44:08 -05:00
Itamar Turner-Trauring
9dd0faf528 Ported to Python 3. 2020-11-06 11:41:34 -05:00
Itamar Turner-Trauring
55ec994450 Tests pass on Python 3. 2020-11-06 11:40:34 -05:00
Itamar Turner-Trauring
2e6f8ca10b Ported to Python 3. 2020-11-06 11:32:14 -05:00
Itamar Turner-Trauring
55623d0175 Ported to Python 3. 2020-11-06 11:27:59 -05:00
Itamar Turner-Trauring
dfdaac7474 Ported to Python 3. 2020-11-06 11:25:48 -05:00
Itamar Turner-Trauring
bcc6d91444 Tests pass on Python 3. 2020-11-06 11:24:07 -05:00
Itamar Turner-Trauring
6017b11910 Merge branch '3475.mutable-tests-part-2-python-3' into 3496.mutable-tests-python-3-part-3 2020-11-06 11:20:54 -05:00
Itamar Turner-Trauring
eab228f22a
Merge pull request #887 from tahoe-lafs/3465.storage_client-python-3-take-2
Port storage_client to Python 3

Fixes ticket:3465
2020-11-06 11:18:31 -05:00
Itamar Turner-Trauring
84a33625bd Port to Python 3. 2020-11-06 10:21:33 -05:00
Itamar Turner-Trauring
31ee2e18f3 Tests pass on Python 3. 2020-11-06 10:20:18 -05:00
Itamar Turner-Trauring
836d41a92d Ported to Python 3. 2020-11-06 10:12:56 -05:00
Itamar Turner-Trauring
e4734468e5 Ported to Python 3. 2020-11-06 10:11:09 -05:00
Itamar Turner-Trauring
95df57382f Tests pass on Python 3. 2020-11-06 10:09:11 -05:00
Itamar Turner-Trauring
e17be38d69 Start porting test infrastructure to Python 3 compatibility. 2020-11-06 10:04:46 -05:00
Itamar Turner-Trauring
cd01d4dafa Test for Python 2 BytesKeyDict and UnicodeKeyDict behavior. 2020-11-05 10:15:38 -05:00
Itamar Turner-Trauring
a49ef086b6 No need for explicit unicode. 2020-11-05 10:09:52 -05:00
Itamar Turner-Trauring
f57ba3c927 Can't send unicode over foolscap. 2020-11-04 14:13:08 -05:00
Itamar Turner-Trauring
813594bbac Go back to the way it was. 2020-11-04 13:45:41 -05:00
Itamar Turner-Trauring
2c8a91fb6e
Merge pull request #883 from tahoe-lafs/3493.node-to-python-3
Port allmydata.node to python 3

Fixes ticket:3493
2020-11-04 13:44:21 -05:00
Itamar Turner-Trauring
0a6321cc9a Tests and additional check for typed key dicts. 2020-11-04 13:36:08 -05:00
Itamar Turner-Trauring
dc818757b6 Port to Python 3. 2020-11-04 13:22:34 -05:00
Itamar Turner-Trauring
2b557287c8 Lint fix. 2020-11-04 13:21:13 -05:00
Itamar Turner-Trauring
d407cb5005 Port to Python 3. 2020-11-04 13:19:16 -05:00
Itamar Turner-Trauring
f34597ac61 All tests pass on Python 3. 2020-11-04 13:09:55 -05:00
Itamar Turner-Trauring
d30014f8f5 The Resource dictionary is keyed by bytes, so storing unicode means you don't
get the cached resource!
2020-11-03 11:14:25 -05:00
Itamar Turner-Trauring
f6eb4aef57 Work consistently across Python 2 and 3. 2020-11-03 10:41:13 -05:00
Itamar Turner-Trauring
3edc1cb29e The dictionary is unicode, not bytes. 2020-11-03 10:41:02 -05:00
Itamar Turner-Trauring
60992174ff twisted.web expects bytes. 2020-11-03 10:40:53 -05:00
Itamar Turner-Trauring
672c440091 Better error reporting. 2020-11-03 10:40:41 -05:00
Itamar Turner-Trauring
e3a0f61dca More passing tests. 2020-11-03 10:04:24 -05:00
Itamar Turner-Trauring
35c304cd82 Workaround for Eliot flaw. 2020-11-03 10:04:16 -05:00
Jean-Paul Calderone
540c70f835
Merge pull request #871 from exarkun/2928.remote-allocate_tcp_port-test_node.py
Remove `allocate_tcp_port` from test_node.py

Fixes: ticket:2928
2020-10-31 19:24:09 -04:00
Jean-Paul Calderone
7ad55e0fba Merge remote-tracking branch 'origin/master' into 2928.remote-allocate_tcp_port-test_node.py 2020-10-31 11:42:01 -04:00
Jean-Paul Calderone
651c42ac0f remove unused import 2020-10-31 11:41:20 -04:00
Jean-Paul Calderone
4d469d7b64 The test is faster now, leave the max_examples setting alone 2020-10-30 21:05:46 -04:00
Itamar Turner-Trauring
92a4a5afcc Closer to more passing tests, maybe. 2020-10-30 15:04:00 -04:00
Itamar Turner-Trauring
45a2fcc3f2 Fix for Python 2. 2020-10-30 14:49:25 -04:00
Itamar Turner-Trauring
e79d1adeea Fix lint. 2020-10-30 14:35:09 -04:00
Itamar Turner-Trauring
d52f6747f6 Some progress towards passing tests. 2020-10-30 14:21:16 -04:00
Itamar Turner-Trauring
6264cf15b1 Fix some failing tests. 2020-10-30 14:08:09 -04:00
Chad Whitacre
266b707d25
Merge pull request #861 from tahoe-lafs/3474.easy-ports
Port some easy files to Python 3
2020-10-30 13:33:34 -04:00
Itamar Turner-Trauring
6b4be7aee3 Should be unicode. 2020-10-30 11:23:30 -04:00
Itamar Turner-Trauring
36d1056ad0 Delete dead code, note porting. 2020-10-30 11:21:14 -04:00
Itamar Turner-Trauring
468beb05f6 Port to Python 3. 2020-10-29 14:09:18 -04:00
Itamar Turner-Trauring
dce368016b Duplicates test coverage in test_connections. 2020-10-29 14:01:05 -04:00
Itamar Turner-Trauring
c3248524f0 Drop support for '\#', never was used by anything as far as we know. 2020-10-29 13:51:29 -04:00
Itamar Turner-Trauring
0cf6ca86fb Improve test coverage. 2020-10-29 13:36:31 -04:00
Itamar Turner-Trauring
fa0dbcfd0e Configs are always unicode now. 2020-10-29 10:26:07 -04:00
Chad Whitacre
a10c2606f4
Merge pull request #868 from tahoe-lafs/3468.offloaded-test-coverage
More test coverage for the upload helper
2020-10-28 15:20:34 -04:00
Chad Whitacre
d04b6c103a Pick off a couple of easy ports 2020-10-28 14:57:10 -04:00
Itamar Turner-Trauring
6f2027e824 Fix lint. 2020-10-27 16:59:43 -04:00
Itamar Turner-Trauring
20a64d5767 Test new fileutil behavior. 2020-10-27 14:24:23 -04:00
Itamar Turner-Trauring
f1b281123d Fix tests. 2020-10-27 14:24:20 -04:00
Itamar Turner-Trauring
bcb6822171 Merge branch '3485.backported-configparser-for-py-2' into 3479.test-node-python-3 2020-10-27 14:06:35 -04:00
Itamar Turner-Trauring
b62bd13bee Merge remote-tracking branch 'origin/master' into 3479.test-node-python-3 2020-10-27 14:02:27 -04:00
Itamar Turner-Trauring
b79504a43b Refactor to unify different code paths. 2020-10-27 13:59:45 -04:00
Itamar Turner-Trauring
0d270e1290 Create ConfigParsers in a consistent manner. 2020-10-27 11:48:25 -04:00
Itamar Turner-Trauring
207111fb9c Documentation fixes. 2020-10-27 11:43:27 -04:00
Itamar Turner-Trauring
1a7bb06587 SafeConfigParser has been replaced by ConfigParser. 2020-10-27 09:35:09 -04:00
Itamar Turner-Trauring
c76afc9ece Try to fix some failing unit tests in ASCII locale. 2020-10-27 08:54:28 -04:00
Itamar Turner-Trauring
d5333ae9f9 Merge remote-tracking branch 'origin/master' into 3485.backported-configparser-for-py-2 2020-10-26 16:53:19 -04:00
Itamar Turner-Trauring
4a54377208 Some more fixes. 2020-10-26 16:48:18 -04:00
Itamar Turner-Trauring
4dc1adc817 Some progress towards passing Python 2 tests. 2020-10-26 16:37:00 -04:00
Itamar Turner-Trauring
76697c8c1b It's already unicode. 2020-10-26 14:33:59 -04:00
Itamar Turner-Trauring
375ed5096c Config parsing now always returns Unicode. 2020-10-26 12:12:49 -04:00
Itamar Turner-Trauring
f50fd8e474 Switch to new configparser backport. 2020-10-26 12:12:46 -04:00
Jean-Paul Calderone
25ee76104a
Merge pull request #872 from tahoe-lafs/3486.netifaces
Switch to netifaces

Fixes: ticket:3486
2020-10-26 11:55:31 -04:00
Chad Whitacre
338ee89e63 Stick with unicode (new str) for file path parts
This seems to be the pattern, e.g.:

https://github.com/tahoe-lafs/tahoe-lafs/blob/master/src/allmydata/client.py#L229
2020-10-23 12:52:32 -04:00
Chad Whitacre
725291c2aa Merge branch 'master' into 3468.offloaded-test-coverage 2020-10-23 12:08:48 -04:00
Chad Whitacre
f0657aec69
Merge pull request #853 from tahoe-lafs/3346.port-immutable-offloaded
Port immutable.offloaded to Python 3
2020-10-23 12:05:20 -04:00
Jean-Paul Calderone
96c848b2ad flakes 2020-10-23 09:50:31 -04:00
Jean-Paul Calderone
c60d62d858 Direct test for the new implementation 2020-10-23 09:32:13 -04:00
Jean-Paul Calderone
931bdef2a2 Get rid of the old implementation and related unused code
Also put in the new implementation, though now it needs tests because *there
were no direct tests for the old one*.
2020-10-23 09:23:16 -04:00
Jean-Paul Calderone
a5e889f707 flakes 2020-10-22 15:31:39 -04:00
Jean-Paul Calderone
606617cbfd clean up the tub location tests a bit 2020-10-22 14:41:28 -04:00
Jean-Paul Calderone
ea257681bb Stop starting the services so that we stop binding the ports 2020-10-22 14:36:49 -04:00
Jean-Paul Calderone
8e41c2d3e1 whitespace 2020-10-22 14:36:45 -04:00
Jean-Paul Calderone
83dbcdb3bf Switch away from EmptyNode since it's gone from master 2020-10-22 14:31:33 -04:00
Jean-Paul Calderone
af5531d81b Merge remote-tracking branch 'origin/master' into 2928.remote-allocate_tcp_port-test_node.py 2020-10-22 14:31:21 -04:00
Jean-Paul Calderone
a58fd5c88e remove unused attribute 2020-10-22 07:23:02 -04:00
Jean-Paul Calderone
e97b5f6bb4 document get_arg req parameter 2020-10-22 07:22:51 -04:00
Jean-Paul Calderone
8401547b35 docstring for TahoeLAFSRequest 2020-10-22 07:22:41 -04:00
Jean-Paul Calderone
e3b1d4f536 enforce the type requirement 2020-10-22 07:17:52 -04:00
Jean-Paul Calderone
c8b9a0265a get_root docs 2020-10-22 07:16:57 -04:00
Jean-Paul Calderone
612cbb583a combine common_web and common_tweb now that there is no nevow renderer 2020-10-22 07:13:13 -04:00
Jean-Paul Calderone
0f574dc019 docstring for the helper 2020-10-21 14:47:56 -04:00
Jean-Paul Calderone
d1599a924e Test and fix cap censoring in HTTP access logs 2020-10-21 14:42:30 -04:00
Jean-Paul Calderone
b2999d283f Somewhat clarify this test 2020-10-21 12:37:34 -04:00
Jean-Paul Calderone
62f5fb9d28 Make sure the JSON is given back as bytes 2020-10-21 12:27:08 -04:00
Jean-Paul Calderone
444c3e6ce4 typo fix 2020-10-21 12:23:43 -04:00
Jean-Paul Calderone
37016f4ab5 pyflakes 2020-10-21 12:21:44 -04:00
Jean-Paul Calderone
c31300fd0d Handle interrupted connections 2020-10-21 12:21:01 -04:00
Jean-Paul Calderone
14b9dc090d Replace some ctx names with req 2020-10-21 10:12:48 -04:00
Jean-Paul Calderone
03a144755d Nevow is no longer a dependency 2020-10-21 10:02:32 -04:00
Jean-Paul Calderone
7eecf51dc5 Just talk about rendering, not Nevow 2020-10-21 10:02:22 -04:00
Jean-Paul Calderone
6500f742dc Twisted Web handles UnsupportedMethod for us 2020-10-21 10:02:10 -04:00
Jean-Paul Calderone
816ca79d8a Talk about os.stat and tracebacks instead of Nevow 2020-10-21 10:01:57 -04:00
Jean-Paul Calderone
2ba34a4759 Talk about Nevow as a proper noun where necessary 2020-10-21 10:01:46 -04:00
Jean-Paul Calderone
a577f1e48d pyflakes 2020-10-21 09:49:03 -04:00
Jean-Paul Calderone
80549f5f02 Make this request a little more realistic 2020-10-21 09:46:21 -04:00
Jean-Paul Calderone
7d54af7928 re-use our other renderer 2020-10-21 09:46:14 -04:00
Jean-Paul Calderone
27c2fd80c8 re-use our other renderer 2020-10-21 09:46:00 -04:00
Jean-Paul Calderone
c8db069960 Get rid of no-longer used Nevow exception handler 2020-10-21 09:45:41 -04:00
Jean-Paul Calderone
c64a71a642 Re-arrange some of the requestReceived logic and switch to t.web Site 2020-10-21 09:45:11 -04:00
Jean-Paul Calderone
538cefed3d Update Twisted Web-based render to use our request
Also to do one other thing Twisted Web does for resources automatically -
handle UnsupportedMethod
2020-10-21 08:51:45 -04:00
Jean-Paul Calderone
637bb2e576 De-Nevow `render` 2020-10-21 08:51:25 -04:00
Jean-Paul Calderone
304a9880e6 De-Nevow `get_root` 2020-10-21 08:50:53 -04:00
Jean-Paul Calderone
743ead71a4 De-Nevow `get_arg` 2020-10-21 08:50:37 -04:00
Jean-Paul Calderone
7f02128973 [wip] test form posts 2020-10-21 08:29:41 -04:00
Jean-Paul Calderone
0dcc3e13c0 Remove unused imports 2020-10-21 08:21:29 -04:00
Jean-Paul Calderone
7ca8ede88c Merge remote-tracking branch 'origin/master' into 3428.dont-return-deferred-to-twistedweb.2 2020-10-21 07:35:10 -04:00
Jean-Paul Calderone
f602382244 Comments about __get__ calls 2020-10-21 07:34:27 -04:00
Jean-Paul Calderone
7ce2122e71 one more reference 2020-10-21 07:26:12 -04:00
Jean-Paul Calderone
e8761c98ad A comment about what _finish is here for 2020-10-21 07:25:48 -04:00
Jean-Paul Calderone
d8b6e36c6f docstring for StaticResource 2020-10-21 07:23:16 -04:00
Jean-Paul Calderone
dbe2d4efd7 It isn't the root, it's wherever we actually are 2020-10-21 07:22:00 -04:00
Jean-Paul Calderone
a91dba5f5b _finish docstring 2020-10-21 07:18:41 -04:00
Jean-Paul Calderone
1ed74604c7 Use twisted.web.server.Request instead of DummyRequest in the tests
Always prefer the real thing if possible
2020-10-21 07:15:36 -04:00
Jean-Paul Calderone
3192715e37 everything newstyle 2020-10-19 14:37:03 -04:00
Jean-Paul Calderone
a9e9efb336 direct tests for @render_exception 2020-10-19 14:26:12 -04:00
Jean-Paul Calderone
b68c08cff9 Yank direct support for URLPath from common.py 2020-10-19 12:33:15 -04:00
Jean-Paul Calderone
72e60f8301 Fix imports 2020-10-18 11:12:44 -04:00
Jean-Paul Calderone
e710fd883a Add a Twisted Web-based renderer and start using it on Python 3
This could be the thing that eventually replaces the Nevow-based testing
renderer on Python 2 as well.
2020-10-18 11:00:57 -04:00
Jean-Paul Calderone
84acf4e50f Accept unicode return values and encode them to UTF-8
Nevow accepts unicode in most places it accepts bytes and does the usual
sloppy Python 2 thing, lets one or the other get implicitly re-coded,
typically using the ascii codec.

We'll go with UTF-8 because that fails less often than ASCII.  We may want to
clean up the code at some point so we're not accidentally slinging both bytes
and text around as if they were the same thing.
2020-10-18 10:58:09 -04:00
Jean-Paul Calderone
fc1f43c7a3 How does it go without the type check
This is for py36:

> TypeError: helper_furl must be bytes, got 'pb://kl5iekm6itcyjejirxva2upthepsasnn@bogus:1234/frekgeq7gsongibyeuvzmvqoyf4h5pcx' instead
2020-10-16 19:07:28 -04:00
Jean-Paul Calderone
a403d25146 Merge remote-tracking branch 'origin/master' into 3468.offloaded-test-coverage 2020-10-16 14:34:35 -04:00
Jean-Paul Calderone
85bb0a7834 Get rid of the original token-based authorization helper
It was only used by magic-folder and that's gone now.  We have a different
authorization helper for other things now, allmydata.web.private.
2020-10-16 14:14:15 -04:00
Jean-Paul Calderone
292f136547 pyflakes 2020-10-16 13:21:07 -04:00
Jean-Paul Calderone
a22426011b import and naming cleanups post-merge 2020-10-16 12:49:36 -04:00
Itamar Turner-Trauring
8e618b9383 Fix Python 2 issue. 2020-10-16 11:25:29 -04:00
Itamar Turner-Trauring
6aa96bbb8d Port test_node.py to Python 3. 2020-10-16 11:23:38 -04:00
Itamar Turner-Trauring
f7a89f76e7 All tests pass on Python 3. 2020-10-16 11:20:10 -04:00
Itamar Turner-Trauring
51d472e221 More progress towards passing tests on Python 3. 2020-10-16 11:13:11 -04:00
Itamar Turner-Trauring
f689d59a40 More passing tests on Python 3. 2020-10-16 10:55:33 -04:00
Itamar Turner-Trauring
bcd7cdf86f Some passing tests on Python 3. 2020-10-16 10:47:49 -04:00
Jean-Paul Calderone
32051f93b9 Merge remote-tracking branch 'origin/master' into 3428.dont-return-deferred-to-twistedweb.2 2020-10-16 10:37:54 -04:00
Itamar Turner-Trauring
c2fe5a65a6
Merge pull request #847 from tahoe-lafs/3459.test-checker-python-3
Port test_checker.py to Python 3

Fixes ticket:3459
2020-10-16 10:31:25 -04:00
Jean-Paul Calderone
a73a919a20 flakes 2020-10-16 10:22:42 -04:00
Jean-Paul Calderone
a1f1f00be7 Use the more feaetureful rendering helper 2020-10-16 09:53:30 -04:00
Jean-Paul Calderone
31207e4b6b don't double-apply the renderer logic
since that leads to double-finishing requests too
2020-10-16 09:53:24 -04:00
Jean-Paul Calderone
0faa24d344 Add a mess of eliot logging to request handling 2020-10-16 09:53:19 -04:00
Jean-Paul Calderone
0339ba97b9 Turn getChild None and Deferred results into something Twisted Web can manage 2020-10-16 09:52:41 -04:00
Jean-Paul Calderone
fa02e46033 maybeDeferred always returns a Deferred 2020-10-16 09:52:33 -04:00
Jean-Paul Calderone
f733a244aa Just gonna produce text instead 2020-10-16 09:52:26 -04:00
Jean-Paul Calderone
d38ae4d6dd Stop reading server module attributes all the time
It jumps through a ton of deprecation machinery that is at least tedious in
the debugger, if not wasteful at runtime.
2020-10-16 09:52:18 -04:00
Jean-Paul Calderone
07246b3509 Render requests more thoroughly 2020-10-16 09:52:10 -04:00
Jean-Paul Calderone
df949868b6 Stop explicitly finishing and then returning a string 2020-10-16 09:51:50 -04:00
Jean-Paul Calderone
69c7c40510 handle Deferred from render 2020-10-16 09:51:42 -04:00
Jean-Paul Calderone
f15086d995
Merge pull request #844 from tahoe-lafs/3460.improved-got_announcement
Improved `_got_announcement`

Fixes: ticket:3460
2020-10-16 08:55:11 -04:00
Jean-Paul Calderone
99fe617069
Merge pull request #857 from tahoe-lafs/3470.oneshotobserverlist-immediately
Make OneShotObserverList immediate

Fixes: ticket:3470
2020-10-15 17:37:31 -04:00
Jean-Paul Calderone
733d393a07
Merge pull request #840 from tahoe-lafs/3454.unskip-test_python3
Unskip the Python 3 porting test on Python 2

Fixes: ticket:3454
2020-10-15 17:32:59 -04:00
Jean-Paul Calderone
4d56b5f4ed
Merge pull request #858 from tahoe-lafs/3471.immediate-localwrapper
Allow LocalWrapper to be immediate

Fixes: ticket:3471
2020-10-15 13:15:35 -04:00
Jean-Paul Calderone
2960a270ce Declare and document what LocalWrapper is/does 2020-10-15 12:00:03 -04:00
Itamar Turner-Trauring
707ab50606 Test BytesJSONEncoder with Unicode. 2020-10-15 08:37:09 -04:00
Itamar Turner-Trauring
1c976990a1 Make comment more meaningful. 2020-10-15 08:34:56 -04:00
Itamar Turner-Trauring
e6a196c144 Get rid of hopefully unnecessary sort. 2020-10-15 08:33:51 -04:00
Itamar Turner-Trauring
b658a66e7f Merge remote-tracking branch 'origin/master' into 3459.test-checker-python-3 2020-10-15 08:32:53 -04:00
Itamar Turner-Trauring
b094a00458
Merge pull request #860 from tahoe-lafs/3473-mutable-tests-part-1-python-3
Port allmydata.mutable.tests to Python 3: part 1 of N

Fixes ticket:3473
2020-10-15 08:27:45 -04:00
Itamar Turner-Trauring
fecbbb6733 Port to Python 3. 2020-10-14 16:05:02 -04:00
Itamar Turner-Trauring
7faea936df Tests pass on Python 3. 2020-10-14 16:03:53 -04:00
Itamar Turner-Trauring
b5e54f2ed2 Port to Python 3. 2020-10-14 15:50:02 -04:00
Itamar Turner-Trauring
fa92fde04a Port to Python 3. 2020-10-14 15:46:37 -04:00
Itamar Turner-Trauring
43f5a25ec2 Tests pass on Python 3. 2020-10-14 15:45:09 -04:00
Jean-Paul Calderone
40e0ef0fad Directly test CHKCheckerAndUEBFetcher cases 2020-10-14 12:02:56 -04:00
Jean-Paul Calderone
b0159a898e Parameterize the callRemote scheduling 2020-10-14 11:08:40 -04:00
Jean-Paul Calderone
5a51d98479 Add missing chk_upload, document two new attrs, and move them up 2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
9a18843bb1 finish the comment 2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
555b751af0 Further expand existing test coverage by reducing fake quantities
Helper_fake_upload is replaced by more narrowly focused CHKUploadHelper_fake
2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
4e46f9ae12 expand the already-uploaded test for the helper to cover more
shrink the amount of fake code being used and increase the amount of real code
being used
2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
ef11eeb4a2 exercise concurrent upload 2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
8eb518a221 docstring for Helper._active_uploads 2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
c88c2846e2 Point folks at docs for this 2020-10-14 10:58:50 -04:00
Jean-Paul Calderone
5974f5adf9 Stop using eventually in OneShotObserverList 2020-10-14 10:56:50 -04:00
Itamar Turner-Trauring
c0f486a9f6 Work on Python 3. 2020-10-13 09:51:25 -04:00
Itamar Turner-Trauring
50925fcec1 Get rid of more no-longer-needed moves. 2020-10-13 09:49:39 -04:00
Itamar Turner-Trauring
3ea18ca3fc As better alternative to common_py3, make common.py import on Python 3. 2020-10-13 09:45:03 -04:00
Chad Whitacre
a0963fc2da Keep future.builtins imports consistent
- remove int from a stock import
- comment a non-stock import
2020-10-13 08:39:25 -04:00
Chad Whitacre
574c63d350 Port immutable.offloaded to Python 3 2020-10-12 07:25:44 -04:00
Itamar Turner-Trauring
17f0676b3f
Merge branch 'master' into 3459.test-checker-python-3 2020-10-09 10:22:17 -04:00
Ross Patterson
cc8c9c0bdf
Merge pull request #851 from tahoe-lafs/3464.cleanup-bbb-comments
#3455: Address feedback, BBB comments
2020-10-08 13:49:34 -07:00
Ross Patterson
95f2d53f92 chore(refs #3455) Address feedback, BBB comments
https://github.com/tahoe-lafs/tahoe-lafs/pull/845#issuecomment-704469561
2020-10-07 12:28:41 -07:00
Itamar Turner-Trauring
d519d4b2fa
Merge branch 'master' into 3463.more-immutable-python-3 2020-10-07 13:22:04 -04:00