Merge pull request #840 from tahoe-lafs/3454.unskip-test_python3

Unskip the Python 3 porting test on Python 2

Fixes: ticket:3454
This commit is contained in:
Jean-Paul Calderone 2020-10-15 17:32:59 -04:00 committed by GitHub
commit 733d393a07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions

0
newsfragments/3454.minor Normal file
View File

View File

@ -8,7 +8,7 @@ from __future__ import absolute_import
from __future__ import division
from __future__ import print_function
from future.utils import PY2
from future.utils import PY2, native_str
if PY2:
from builtins import filter, map, zip, ascii, chr, hex, input, next, oct, open, pow, round, super, bytes, dict, list, object, range, str, max, min # noqa: F401
@ -44,10 +44,9 @@ class Python3PortingEffortTests(SynchronousTestCase):
),
),
)
if PY2:
test_finished_porting.skip = "For some reason todo isn't working on Python 2 now"
else:
test_finished_porting.todo = "https://tahoe-lafs.org/trac/tahoe-lafs/milestone/Support%20Python%203 should be completed"
test_finished_porting.todo = native_str(
"https://tahoe-lafs.org/trac/tahoe-lafs/milestone/Support%20Python%203 should be completed",
)
def test_ported_modules_exist(self):
"""