Commit Graph

13096 Commits

Author SHA1 Message Date
Jean-Paul Calderone
21f848f0e3 Merge remote-tracking branch 'upstream/master' 2021-10-23 07:32:26 -04:00
Jean-Paul Calderone
8705c33b9a
Merge pull request #33 from tahoe-lafs/LFS-01-005
Fix item LFS-01-005 from the Cure53 audit

Fixes: ticket:3823
2021-10-23 07:30:01 -04:00
Jean-Paul Calderone
cb675df48d remove unused encoding of storage index 2021-10-22 16:10:24 -04:00
Jean-Paul Calderone
194499aafe remove unused import 2021-10-22 16:09:54 -04:00
Jean-Paul Calderone
8d15d61ff2 put the news fragment in the right place 2021-10-22 15:58:48 -04:00
Jean-Paul Calderone
5837841c09 mention corruption advisories in the news fragment too 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
6449ad03de Do not record corruption advisories if there is no available space 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
f789339a79 Have MutableShare file only write a new lease if there is room for it
This is analagous to the earlier ShareFile change.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
dd1ab2afe8 Add a helper to compute the size of a lease in a mutable share 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
e0ed04c103 use SyncTestCase to get expectThat 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
4defc641a2 Have ShareFile only write a new lease if there is room for it
StorageServer passes available space down so it can make the decision.
ShareFile has to do it because `add_or_renew_lease` only *sometimes* adds a
lease and only ShareFile knows when that is.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
1264c3be1e Use _add_or_renew_leases helper consistently in StorageServer
This will make it easier to add a new argument to the underlying
`add_or_renew_lease` call.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
b3aa1e224f Add a helper to LeaseInfo for computing size
This lets some code LBYL and avoid writing if the lease won't fit in the
immutable share in the space available.
2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
c774256937 Add a test for `remote_add_lease` with respect to reserved space 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
bb5b26638d news fragment 2021-10-22 15:56:45 -04:00
Jean-Paul Calderone
7e52966223
Merge pull request #32 from tahoe-lafs/LFS-01-008
Fix item LFS-01-008 from the Cure53 audit

Fixes: ticket:3822
2021-10-22 15:56:02 -04:00
Jean-Paul Calderone
82e4704415 Merge remote-tracking branch 'remediate/master' into LFS-01-008 2021-10-22 15:27:15 -04:00
Jean-Paul Calderone
ff577066a0
Merge pull request #31 from tahoe-lafs/LFS-01-007
Fix item LFS-01-007 from the Cure53 audit

Fixes: ticket:3821
2021-10-22 15:26:22 -04:00
Jean-Paul Calderone
ce30f9dd06 clean up copyediting errors 2021-10-22 15:04:45 -04:00
Jean-Paul Calderone
7f3d9316d2 Give the news fragment its real name 2021-10-22 12:59:26 -04:00
Jean-Paul Calderone
bcdfb8155c give the news fragment its proper name 2021-10-22 12:53:17 -04:00
Jean-Paul Calderone
bb31215134 Merge remote-tracking branch 'remediate/master' into LFS-01-007 2021-10-22 12:35:57 -04:00
Jean-Paul Calderone
d8c466e9a7 try to explain lease_count_format more clearly 2021-10-22 12:35:11 -04:00
Jean-Paul Calderone
a22787e879
Merge pull request #30 from tahoe-lafs/LFS-01-001
Fix item LFS-01-001 from the Cure53 audit

Fixes: ticket:3819
2021-10-22 12:20:38 -04:00
Jean-Paul Calderone
6c0ca0b885 try making windows let us use longer paths 2021-10-22 11:42:13 -04:00
Jean-Paul Calderone
a8d3555ebb reference the eventually-public ticket number 2021-10-21 15:24:53 -04:00
Itamar Turner-Trauring
211640a4cd
Merge pull request #1143 from tahoe-lafs/3800-lease-istorageserver-tests
IStorageServer tests for leases

Fixes ticket:3800
2021-10-21 14:37:46 -04:00
meejah
1e53570930
Merge pull request #1145 from meejah/3735.tarballs
3735: only release .tar.gz and wheels
2021-10-21 11:18:16 -06:00
meejah
b8ff0e7fa9 news 2021-10-20 20:19:36 -06:00
meejah
027df09828 release two things: wheels, and a .tar.gz source dist 2021-10-20 16:10:23 -06:00
meejah
ffb20d3bbf
Merge pull request #1144 from tahoe-lafs/3754.release-1.16.0-rc1
release 1.16.0
2021-10-20 16:04:05 -06:00
meejah
a7ce84f4d5 correct names, dates 2021-10-19 18:02:29 -06:00
meejah
4bfb9d2170 correct previous-release version 2021-10-19 17:25:34 -06:00
meejah
1e6265b87c update relnotes 2021-10-19 17:24:29 -06:00
fenn-cs
e1dfee1d7b put notes under correct categories
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2021-10-19 23:20:38 +01:00
Itamar Turner-Trauring
2a5dbcb05e Tests for mutable leases. 2021-10-19 09:30:38 -04:00
Itamar Turner-Trauring
4b8b6052f3 Finish testing leases on immutables. 2021-10-19 09:05:48 -04:00
Jean-Paul Calderone
3cd9a02c81 Reject negative lengths in MutableShareFile._read_share_data and readv 2021-10-18 20:22:52 -04:00
Jean-Paul Calderone
5e58b62979 Add a test for negative offset or length to MutableShareFile.readv 2021-10-18 20:22:52 -04:00
Jean-Paul Calderone
4a5e4be006 news fragment 2021-10-18 20:22:52 -04:00
Jean-Paul Calderone
df64bbb1e4 fail to encode the lease count *before* changing anything
This preserves the failure behavior - `struct.error` is raised - but leaves
the actual share file contents untouched if the new lease count cannot be
encoded.

There are still two separate write operations so it is conceivable that some
other problem could cause `write_lease_record` to happen but
`write_encoded_num_leases` not to happen.  As far as I can tell we have
severely limited options for addressing that problem in general as long as
share files are backed by a POSIX filesystem.

However, by removing the failure mode that depends on user input, it may be
that this is all that is needed to close the *security* hole.
2021-10-18 20:17:41 -04:00
Jean-Paul Calderone
f60bbbd3e2 make it possible to test this behavior of add_lease 2021-10-18 20:17:41 -04:00
Jean-Paul Calderone
7d04e6ab86 news fragment 2021-10-18 20:17:41 -04:00
Itamar Turner-Trauring
b7be91e3d0 First test for leases. 2021-10-18 13:17:07 -04:00
Jean-Paul Calderone
040dbf3267
Merge pull request #1142 from LeastAuthority/3815.security-towncrier-type
Add towncrier "security" type

Fixes: ticket:3815
2021-10-18 13:02:11 -04:00
Itamar Turner-Trauring
2b40610a27 "Server" is extremely ambiguous, so let's just call this a client, which it is. 2021-10-18 12:55:30 -04:00
Itamar Turner-Trauring
58112ba75b Plan of implementation for lease tests. 2021-10-18 12:50:29 -04:00
Itamar Turner-Trauring
4c7e50360c
Merge pull request #1139 from tahoe-lafs/3812-test-advise-corrupt-share
Tests for IStorageServer.advise_corrupt_share

Fixes ticket:3812
2021-10-18 12:39:41 -04:00
Jean-Paul Calderone
f2ef72e935 newsfragment in temporary location 2021-10-18 08:14:42 -04:00
Jean-Paul Calderone
30ae30e325 fix the whitespace :/ 2021-10-18 08:11:49 -04:00