2023-05-30 21:38:56 +00:00
|
|
|
From 26c97b6fb7d291f55e0e4a410d266d1355118ed9 Mon Sep 17 00:00:00 2001
|
|
|
|
|
From: Robert Marko <robimarko@gmail.com>
|
|
|
|
|
Date: Wed, 31 May 2023 20:21:26 +0200
|
|
|
|
|
Subject: [PATCH] mmc: core: disable TRIM on Kingston EMMC04G-M627
|
|
|
|
|
|
|
|
|
|
It seems that Kingston EMMC04G-M627 despite advertising TRIM support does
|
|
|
|
|
not work when the core is trying to use REQ_OP_WRITE_ZEROES.
|
|
|
|
|
|
|
|
|
|
We are seeing I/O errors in OpenWrt under 6.1 on Zyxel NBG7815 that we did
|
|
|
|
|
not previously have and tracked it down to REQ_OP_WRITE_ZEROES.
|
|
|
|
|
|
|
|
|
|
Trying to use fstrim seems to also throw errors like:
|
|
|
|
|
[93010.835112] I/O error, dev loop0, sector 16902 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 2
|
|
|
|
|
|
|
|
|
|
Disabling TRIM makes the error go away, so lets add a quirk for this eMMC
|
|
|
|
|
to disable TRIM.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Robert Marko <robimarko@gmail.com>
|
|
|
|
|
---
|
|
|
|
|
drivers/mmc/core/quirks.h | 7 +++++++
|
|
|
|
|
1 file changed, 7 insertions(+)
|
|
|
|
|
|
|
|
|
|
--- a/drivers/mmc/core/quirks.h
|
|
|
|
|
+++ b/drivers/mmc/core/quirks.h
|
2023-07-20 09:51:10 +00:00
|
|
|
@@ -131,6 +131,13 @@ static const struct mmc_fixup __maybe_un
|
2023-05-30 21:38:56 +00:00
|
|
|
MMC_QUIRK_TRIM_BROKEN),
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
+ * Kingston EMMC04G-M627 advertises TRIM but it does not seems to
|
|
|
|
|
+ * support being used to offload WRITE_ZEROES.
|
|
|
|
|
+ */
|
|
|
|
|
+ MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
|
|
|
|
|
+ MMC_QUIRK_TRIM_BROKEN),
|
|
|
|
|
+
|
|
|
|
|
+ /*
|
|
|
|
|
* Some SD cards reports discard support while they don't
|
|
|
|
|
*/
|
|
|
|
|
MMC_FIXUP(CID_NAME_ANY, CID_MANFID_SANDISK_SD, 0x5344, add_quirk_sd,
|
