2018-01-08 12:42:27 +00:00
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
|
|
|
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
|
mac80211: rt2x00: remove errornous duplicate condition
https://patchwork.kernel.org/patch/11224189/
--
On 2019-10-28 06:07, wbob wrote:
> Hello Roman,
>
> while reading around drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> I stumbled on what I think is an edit of yours made in error in march
> 2017:
>
> https://github.com/torvalds/linux/commit/41977e86#diff-dae5dc10da180f3b055809a48118e18aR5281
>
> RT6352 in line 5281 should not have been introduced as the "else if"
> below line 5291 can then not take effect for a RT6352 device. Another
> possibility is for line 5291 to be not for RT6352, but this seems
> very unlikely. Are you able to clarify still after this substantial time?
>
> 5277: static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
> ...
> 5279: } else if (rt2x00_rt(rt2x00dev, RT5390) ||
> 5280: rt2x00_rt(rt2x00dev, RT5392) ||
> 5281: rt2x00_rt(rt2x00dev, RT6352)) {
> ...
> 5291: } else if (rt2x00_rt(rt2x00dev, RT6352)) {
> ...
Hence remove errornous line 5281 to make the driver actually
execute the correct initialization routine for MT7620 chips.
As it was requested by Stanislaw Gruszka remove setting values of
MIMO_PS_CFG and TX_PIN_CFG. MIMO_PS_CFG is responsible for MIMO
power-safe mode (which is disabled), hence we can drop setting it.
TX_PIN_CFG is set correctly in other functions, and as setting this
value breaks some devices, rather don't set it here during init, but
only modify it later on.
Fixes: 41977e86c984 ("rt2x00: add support for MT7620")
Reported-by: wbob <wbob@jify.de>
Reported-by: Roman Yeryomin <roman@advem.lv>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
--
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2019-11-03 17:31:02 +00:00
|
|
|
@@ -8422,6 +8422,58 @@ static void rt2800_init_rfcsr_5592(struc
|
2018-01-08 12:42:27 +00:00
|
|
|
rt2800_led_open_drain_enable(rt2x00dev);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
+void rt2800_rf_self_txdc_cal(struct rt2x00_dev *rt2x00dev)
|
|
|
|
|
+{
|
|
|
|
|
+ u8 rfb5r1_org, rfb7r1_org, rfvalue;
|
|
|
|
|
+ u32 mac0518, mac051c, mac0528, mac052c;
|
|
|
|
|
+ u8 i;
|
|
|
|
|
+
|
|
|
|
|
+ rt2x00_info(rt2x00dev, "RF Tx self calibration start\n");
|
|
|
|
|
+ mac0518 = rt2800_register_read(rt2x00dev, RF_CONTROL0);
|
|
|
|
|
+ mac051c = rt2800_register_read(rt2x00dev, RF_BYPASS0);
|
|
|
|
|
+ mac0528 = rt2800_register_read(rt2x00dev, RF_CONTROL2);
|
|
|
|
|
+ mac052c = rt2800_register_read(rt2x00dev, RF_BYPASS2);
|
|
|
|
|
+
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS0, 0x0);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS2, 0x0);
|
|
|
|
|
+
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_CONTROL0, 0xC);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS0, 0x3306);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_CONTROL2, 0x3330);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS2, 0xfffff);
|
|
|
|
|
+ rfb5r1_org = rt2800_rfcsr_read_bank(rt2x00dev, 5, 1);
|
|
|
|
|
+ rfb7r1_org = rt2800_rfcsr_read_bank(rt2x00dev, 7, 1);
|
|
|
|
|
+
|
|
|
|
|
+ rt2800_rfcsr_write_bank(rt2x00dev, 5, 1, 0x4);
|
|
|
|
|
+ for (i = 0; i < 100; i = i + 1) {
|
|
|
|
|
+ udelay(50);
|
|
|
|
|
+ rfvalue = rt2800_rfcsr_read_bank(rt2x00dev, 5, 1);
|
|
|
|
|
+ if((rfvalue & 0x04) != 0x4)
|
|
|
|
|
+ break;
|
|
|
|
|
+ }
|
|
|
|
|
+ rt2800_rfcsr_write_bank(rt2x00dev, 5, 1, rfb5r1_org);
|
|
|
|
|
+
|
|
|
|
|
+ rt2800_rfcsr_write_bank(rt2x00dev, 7, 1, 0x4);
|
|
|
|
|
+ for (i = 0; i < 100; i = i + 1) {
|
|
|
|
|
+ udelay(50);
|
|
|
|
|
+ rfvalue = rt2800_rfcsr_read_bank(rt2x00dev, 7, 1);
|
|
|
|
|
+ if((rfvalue & 0x04) != 0x4)
|
|
|
|
|
+ break;
|
|
|
|
|
+ }
|
|
|
|
|
+ rt2800_rfcsr_write_bank(rt2x00dev, 7, 1, rfb7r1_org);
|
|
|
|
|
+
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS0, 0x0);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS2, 0x0);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_CONTROL0, mac0518);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS0, mac051c);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_CONTROL2, mac0528);
|
|
|
|
|
+ rt2800_register_write(rt2x00dev, RF_BYPASS2, mac052c);
|
|
|
|
|
+
|
|
|
|
|
+ rt2x00_info(rt2x00dev, "RF Tx self calibration end\n");
|
|
|
|
|
+
|
|
|
|
|
+}
|
|
|
|
|
+EXPORT_SYMBOL_GPL(rt2800_rf_self_txdc_cal);
|
|
|
|
|
+
|
|
|
|
|
static void rt2800_bbp_core_soft_reset(struct rt2x00_dev *rt2x00dev,
|
|
|
|
|
bool set_bw, bool is_ht40)
|
|
|
|
|
{
|
mac80211: rt2x00: remove errornous duplicate condition
https://patchwork.kernel.org/patch/11224189/
--
On 2019-10-28 06:07, wbob wrote:
> Hello Roman,
>
> while reading around drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> I stumbled on what I think is an edit of yours made in error in march
> 2017:
>
> https://github.com/torvalds/linux/commit/41977e86#diff-dae5dc10da180f3b055809a48118e18aR5281
>
> RT6352 in line 5281 should not have been introduced as the "else if"
> below line 5291 can then not take effect for a RT6352 device. Another
> possibility is for line 5291 to be not for RT6352, but this seems
> very unlikely. Are you able to clarify still after this substantial time?
>
> 5277: static int rt2800_init_registers(struct rt2x00_dev *rt2x00dev)
> ...
> 5279: } else if (rt2x00_rt(rt2x00dev, RT5390) ||
> 5280: rt2x00_rt(rt2x00dev, RT5392) ||
> 5281: rt2x00_rt(rt2x00dev, RT6352)) {
> ...
> 5291: } else if (rt2x00_rt(rt2x00dev, RT6352)) {
> ...
Hence remove errornous line 5281 to make the driver actually
execute the correct initialization routine for MT7620 chips.
As it was requested by Stanislaw Gruszka remove setting values of
MIMO_PS_CFG and TX_PIN_CFG. MIMO_PS_CFG is responsible for MIMO
power-safe mode (which is disabled), hence we can drop setting it.
TX_PIN_CFG is set correctly in other functions, and as setting this
value breaks some devices, rather don't set it here during init, but
only modify it later on.
Fixes: 41977e86c984 ("rt2x00: add support for MT7620")
Reported-by: wbob <wbob@jify.de>
Reported-by: Roman Yeryomin <roman@advem.lv>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
--
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
2019-11-03 17:31:02 +00:00
|
|
|
@@ -9029,6 +9081,7 @@ static void rt2800_init_rfcsr_6352(struc
|
2018-01-08 12:42:27 +00:00
|
|
|
rt2800_rfcsr_write_dccal(rt2x00dev, 5, 0x00);
|
|
|
|
|
rt2800_rfcsr_write_dccal(rt2x00dev, 17, 0x7C);
|
|
|
|
|
|
|
|
|
|
+ rt2800_rf_self_txdc_cal(rt2x00dev);
|
|
|
|
|
rt2800_bw_filter_calibration(rt2x00dev, true);
|
|
|
|
|
rt2800_bw_filter_calibration(rt2x00dev, false);
|
|
|
|
|
}
|
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.h
|
|
|
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.h
|
2019-08-03 10:30:38 +00:00
|
|
|
@@ -242,6 +242,7 @@ void rt2800_link_tuner(struct rt2x00_dev
|
2018-01-08 12:42:27 +00:00
|
|
|
const u32 count);
|
|
|
|
|
void rt2800_gain_calibration(struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
void rt2800_vco_calibration(struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
+void rt2800_rf_self_txdc_cal(struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
|
|
|
|
|
int rt2800_enable_radio(struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
void rt2800_disable_radio(struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
|
|
|
|
|
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
|
2019-11-21 21:20:20 +00:00
|
|
|
@@ -562,6 +562,7 @@ struct rt2x00lib_ops {
|
2018-01-08 12:42:27 +00:00
|
|
|
struct link_qual *qual, const u32 count);
|
|
|
|
|
void (*gain_calibration) (struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
void (*vco_calibration) (struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
+ void (*rf_self_txdc_cal) (struct rt2x00_dev *rt2x00dev);
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Data queue handlers.
|
