Commit Graph

321 Commits

Author SHA1 Message Date
Victor Woeltjen
f63038a83f [Telemetry] Move formatter spec
Move spec for formatting of telemetry values from the
plot bundle to the telemetry bundle, to reflect its
exposure as a reusable service exposed by that bundle.
WTD-599.
2014-12-24 11:39:29 -08:00
Victor Woeltjen
1ed67629e6 [Telemetry] Add missing JSDoc
Add missing in-line documentation to ScrollingListPopulator;
noticed in the context of work done for WTD-599,
refactoring of time- and value-formatting for telemetry
into a reusable, injectable service.
2014-12-24 11:33:19 -08:00
Victor Woeltjen
44b16f9dd9 [Telemetry] Use telemetryFormatter in scrolling list
Use the injected telemetryFormatter in scrolling
list views, instead of replicating this functionality.
WTD-599.
2014-12-24 11:23:59 -08:00
Victor Woeltjen
74f2af1011 [Telemetry] Expose telemetryFormatter
Expose telemetryFormatter as a service; additionally, fix
some structural issues to make sure this is passed around
as needed among plot components. WTD-599.
2014-12-24 11:14:38 -08:00
Victor Woeltjen
fc0376296d [Telemetry] Refactor plot to use TelemetryFormatter
Refactor plot view to use an injected telemetry formatter,
instead of explicitly including moment. WTD-599.
2014-12-24 10:59:34 -08:00
Victor Woeltjen
b080f90f64 [Telemetry] Move formatter implementation
Move implementation of formatter used for display
of domain values out of plot, and into the telemetry
bundle, from which it can be exposed as a general-use
service. WTD-599.
2014-12-24 10:34:43 -08:00
Victor Woeltjen
453b853a75 [Telemetry] Add skeleton formatter
Add skeleton for implementation of a formatter for
telemetry data, including reorganizing libraries
such that moment.min.js only occurs once. WTD-599.
2014-12-24 10:28:58 -08:00
bwyu
217b622db7 Merge remote-tracking branch 'origin/wtd627' into open-master 2014-12-19 17:52:13 -08:00
bwyu
51376fb38a Merge remote-tracking branch 'origin/open608' into open-master 2014-12-18 13:25:29 -08:00
Victor Woeltjen
24048024f6 [Browse] Test auto-expand fix
Add a test to verify fix for WTD-627 (specifically, verify
that a node does not auto-expand if a selection is made
in some other subtree.)
2014-12-17 15:41:44 -08:00
Victor Woeltjen
4d94ab6fd6 [Browse] Fix tree node autoexpand/highlighting
Repair tree node auto-expand/highlight behavior, to
address WTD-627. Specifically:

* Check the full path when deciding to highlight,
  instead of just the parent. This avoids duplicate highlighting
  in cases where the same parent is visible in two subtrees.
* Don't make a redundant getId call in path-checking;
  domain object paths have already been mapped to identifier
  paths at this point. This avoids erroneous auto-expansion of
  the whole tree.
2014-12-17 15:32:20 -08:00
Victor Woeltjen
4a572decf3 [Indicators] Fill in specs
Fill in specs to ensure code coverage for scripts introduced
to support indicators as a category of extension. WTD-608.
2014-12-16 14:06:19 -08:00
Victor Woeltjen
8ce693af0a [Indicators] Add skeleton specs
Add skeleton specs for the bottom bar controller (introduced
to handle display of indicators introduced as extensions)
and the Couch indicator (introduced to exercise the above,
and to report connection status relative to the Couch
database.) WTD-608.
2014-12-16 13:47:25 -08:00
Victor Woeltjen
ff8572f055 [Indicators] Add tooltip
Add tooltips to indicators, using a description field
from the provided indicator. WTD-608.
2014-12-16 13:43:51 -08:00
Victor Woeltjen
5c71491549 [Indicators] Add JSDoc to CouchIndicator
Add in-line documentation to the CouchDB status indicator
added to exercise/demonstrate support of the indicators
category-of-extension, WTD-608.
2014-12-16 13:36:40 -08:00
Victor Woeltjen
1a50f50310 [Indicators] Support template override
Allow indicators to include their own custom templates.
WTD-608.
2014-12-16 13:23:20 -08:00
Victor Woeltjen
c1ea620341 [Indicators] Implement CouchDB indicator
Initial implementation of an indicator which reflects
current connection to CouchDB. WTD-608.
2014-12-16 13:22:46 -08:00
Victor Woeltjen
8cfcd2cd15 [Indicators] Begin adding Couch indicator
Begin adding indicator to display connection status for
CouchDB. WTD-608.
2014-12-15 10:37:16 -08:00
Victor Woeltjen
48bcb662c6 [Indicators] Add notion of indicators
Add indicators as a category-of-extension, utilized
from the bottom bar to populate its contents.
WTD-608.
2014-12-15 10:17:02 -08:00
Victor Woeltjen
921aad9e2f [Plot] Update plot immediately on mode change
Make sure current telemetry is drawn immediately upon
switching between Overlaid and Stacked plot modes.
WTD-625.
2014-12-12 15:14:20 -08:00
Victor Woeltjen
662412a31d [Plot] Avoid displaying bad labels
Avoid displaying bad labels for tick marks, or in the
coordinates shown on hover. Done in the context of
refactoring to support WTD-625.
2014-12-12 15:07:06 -08:00
Victor Woeltjen
b1158ce230 [Plot] Add JSDoc for stack plots
Add JSDoc for new classes introduced (and revised interfaces
exposed by existing classes) to support stacked plots,
WTD-625.
2014-12-12 14:37:06 -08:00
Victor Woeltjen
80852177c7 [Plot] Complete specs related to stacked mode
Add specs for SubPlot, which was introduced to support
presenting multiple plot areas within a single plot
view (stacked plots, WTD-625.)
2014-12-12 13:20:50 -08:00
Victor Woeltjen
c8c50f8fb1 [Plot] Add specs for plotting modes
Add specs for stacked/overlaid plot modes. WTD-625.
2014-12-12 12:56:26 -08:00
Victor Woeltjen
112d94e189 [Plot] Specs for PlotModeOptions
Add specs for PlotModeOptions, introduced to
allow switching between Stacked and Overlaid
mode for WTD-625.
2014-12-12 11:20:04 -08:00
Victor Woeltjen
7ea63fce8c [Plot] Add specs for PlotPanZoomStackGroup
Add specs to verify the behavior of PlotPanZoomStackGroup,
which is responsible for synchronizing the domain axis
between multiple sub-plots in a stacked plot view.
WTD-625.
2014-12-12 11:10:52 -08:00
Victor Woeltjen
a2d22a4558 [Plot] Restore coverage on PlotController
Restore full test coverage on PlotController after
refactoring for WTD-625, stacked plots.
2014-12-12 10:08:58 -08:00
Victor Woeltjen
4586146da2 [Plot] Remove failing specs
Remove specs which fail due to refactoring for
WTD-625.
2014-12-12 09:49:44 -08:00
Victor Woeltjen
a677ed258e [Plot] Add skeleton specs for stacked plots
Add skeleton specs for classes introduced to support
stacked plot mode, WTD-625.
2014-12-12 09:44:05 -08:00
Victor Woeltjen
06036ce8b3 [Plot] Restore range tick marks
Restore range tick marks; these were lost in refactoring
to support multiple subplots-per-view due to a missed
occurrence of an out-of-date interface usage. WTD-625.
2014-12-11 19:36:01 -08:00
Victor Woeltjen
188e98a78b [Plot] Update stacked plots immediately
When changes to pan-zoom bounds are made in one
subplot, this will effect the pan-zoom bounds of
other subplots. Ensure this occurs immediately.
WTD-625.
2014-12-11 19:33:09 -08:00
Victor Woeltjen
9c1d72f917 [Plot] Integrate PlotPanZoomStackGroup
Utilize PlotPanZoomStackGroup; that is, utilize changes
such that a set of pan-zoom stacks can be treated as one,
while their domain axis synchronizes, and their range
axis does not. WTD-625.
2014-12-11 19:21:52 -08:00
Victor Woeltjen
0ce0517e09 [Plot] Initially implement synced pan/zoom stack
Initially implement a synchronized pan/zoom stack,
which maintains the same domain axis bounds for all
subplots in a stacked plot view, but allows each to
have independent range axes. WTD-625.
2014-12-11 17:27:44 -08:00
Victor Woeltjen
9344809998 [Plot] Restrict hover coordinates
Only show hover coordinates in a stacked plot for
the plot which the user is specifically hovering
over. WTD-625.
2014-12-11 17:09:08 -08:00
Victor Woeltjen
1b6ce10dd9 [Plot] Change style when stacked
Change plot style when in stacked plot mode, such that
plots stack as expected. (Without this change, the
gl-plot class's height of 100% will cause all plots to
fill the full vertical space, effectively acting
overlaid.) WTD-625.
2014-12-11 17:02:07 -08:00
Victor Woeltjen
cd8deca1b3 [Plot] Add initial stack-plot implementation
Add initial implementation of stacked mode for
Plot view. Note that this will not stack correctly
due to markup/style issues. WTD-625.
2014-12-10 20:16:23 -08:00
Victor Woeltjen
eb90a3eeba [Plot] Fix refactoring issues
Fix issues related to refactoring of view-level
to subplot-level behavior, such that previous
functionality is restored. This refactoring
supports introduction of a stacked-plot mode,
for WTD-625.
2014-12-10 20:04:10 -08:00
Victor Woeltjen
784b2b6186 [Plot] Begin refactoring for stacked plots
Begin refactoring Plot view to support stacked plots;
separate out behavior which needs to occur per-plot
from area which should occur per-view, and add a
handler for the Overlay mode. WTD-625.
2014-12-10 19:51:27 -08:00
Victor Woeltjen
1c3d2d923f [Plot] Add notion of subplots to template
Add notion of subplots to the plot template; these
are elements within a stacked plot. WTD-625.
2014-12-10 18:55:47 -08:00
Victor Woeltjen
01f1a92d09 [Plot] Get/set from overlay switcher
Get/set mode from the plot mode switcher; only show
the switcher if there is more than one mode available
(which should only occur when there is more than one
telemetry object in the plot.) WTD-625.
2014-12-10 18:38:42 -08:00
Victor Woeltjen
3a0e80d360 [Plot] Add switcher for Stacked/Overlaid
Add switcher to handle changing between Stacked and Overlaid
plots. WTD-625.
2014-12-10 18:29:18 -08:00
Victor Woeltjen
4173dd748b [Telemetry] Keep telemetryObjects reference
Return the same value from getTelemetryObjects if thes e
haven't changed, to permit this return value to be
watched directly without appearing unstable. Supports
the addition of stacked plot controls, which need
to be conditioned on the number of telemetry objects
present. WTD-625.
2014-12-10 18:28:38 -08:00
Victor Woeltjen
03179284f4 [Persistence] Deactivate example
Deactivate example persistence; this was left in
the set of active bundles erroneously in WTD-602.
2014-12-10 13:40:06 -08:00
bwyu
ce608eedc3 Merge remote-tracking branch 'origin/wtd535' into open-master 2014-12-09 14:12:50 -08:00
bwyu
a9d6009610 Merge conflicts with wtd593 2014-12-09 13:33:58 -08:00
bwyu
91e5ba75de Merge conflicts for wtd537 2014-12-09 11:22:21 -08:00
bwyu
32ae75088f Merge remote-tracking branch 'origin/wtd576' into open-master 2014-12-09 01:38:13 -08:00
bwyu
ed6c06b453 Merged conflicts with wtd534 2014-12-08 18:07:49 -08:00
bwyu
301153cc1b Merge remote-tracking branch 'origin/wtd533' into open-master
Conflicts:
	bundles.json
2014-12-08 17:29:19 -08:00
Victor Woeltjen
b1f8a54dab [Layout] Update specs
Update specs to reflect changes made to the manner in
which a view may persist view configuration changes,
for WTD-535.
2014-12-06 09:45:43 -08:00