David Tsay
f13714e0c4
rename telemetry subscription calls
2020-03-23 13:53:19 -07:00
David Tsay
26ffe8efde
remove comment
2020-03-23 13:05:48 -07:00
David Tsay
e4a6c21101
load composition using less code
2020-03-20 15:08:45 -07:00
David Tsay
d51dd8b7d0
fix broken tests
2020-03-20 15:00:24 -07:00
David Tsay
aed5377ad2
use existing var instead of recalculating
...
on listener should be off in destroy()
2020-03-20 11:44:05 -07:00
David Tsay
cbeb25c583
request telemetry from all conditions
...
if conditions have no criteria (isDefault) then nothing will be requested
2020-03-20 10:16:02 -07:00
David Tsay
b38a9ad4ce
exclude default condition when requesting telemetry
2020-03-20 10:12:02 -07:00
David Tsay
ecf3e19f16
remove listener on destroy
2020-03-19 20:30:27 -07:00
David Tsay
3b82fd5d8b
Merge branch 'topic-conditionals' into dave/conditions-telemetry
2020-03-19 20:28:40 -07:00
David Tsay
1f3ec77bf1
Merge branch 'topic-conditionals' into fix-enum-metadata
2020-03-19 20:15:05 -07:00
David Tsay
3f61db2067
pass telemetry down to criteria. criteria listens to corresponding endpoints.
2020-03-19 17:30:02 -07:00
Joshi
5332d136b7
Fix small bug with inputCount
2020-03-19 15:16:12 -07:00
Joshi
983ed7f0e7
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into fix-enum-metadata
2020-03-19 14:06:25 -07:00
David Tsay
11978cd869
remove straggler call
...
linting fix
2020-03-19 10:22:48 -07:00
David Tsay
00d1b5e69f
avoid multiple instantiations of condtionManager if possible
2020-03-19 10:18:57 -07:00
David Tsay
6731283cf8
Merge pull request #2734 from nasa/condition-description
...
Condition dynamic summary description based on criteria
2020-03-18 15:25:19 -07:00
David Tsay
6b4cd25417
Merge branch 'topic-conditionals' into dave/conditions-telemetry
2020-03-18 10:58:17 -07:00
Joel McKinnon
0cd2799d00
added isLastCriterion comp method
2020-03-18 10:24:43 -07:00
David Tsay
243b9cac24
subscribe to telemetry
2020-03-18 10:21:53 -07:00
Joel McKinnon
316e0f24cf
added fieldName prop to telemetry object, computed props for canEvaluateCriteria, getConjunction, simplified getRule method
2020-03-18 10:18:42 -07:00
Joshi
05f94edb49
Merge branch 'topic-conditionals' of https://github.com/nasa/openmct into topic-conditionals
2020-03-18 09:29:10 -07:00
Joshi
e22458f09e
Merge branch 'master' of https://github.com/nasa/openmct into topic-conditionals
2020-03-18 09:28:53 -07:00
Joel McKinnon
cc2df8401b
vue style render of description
2020-03-17 17:36:55 -07:00
Shefali Joshi
43a82ec05f
Conditional styles for drawing objects ( #2740 )
...
* Hardcoded prototype - conditional styles for display layout or generator domain objects only.
* Adds background colors list
* Show conditional styles for subObjectViews and telemetryViews
* Uses telemetry provider to determine which style is active
* Removes hardcoded conditionSet work used for prototype
* Add default styles to conditionalStyles when a condition set is added to the domain object.
* Use EventEmitter alias instead of eventEmitter3 in imports
* Change StyleRuleManager to accept conditionStyle objects instead of domainObjects
* Uses a map for conditional styles instead of a list in order to improve performance
* Use in-built api to check for identifier equality
* Removes unnecessary object get call.
* Adds conditional styles for drawing objects
* Removes hard coded conditionSetIdentifier
* Fixes small conditionManager bug
2020-03-17 14:42:15 -07:00
David Tsay
60aecfe27e
Merge branch 'topic-conditionals' into dave/conditions-telemetry
2020-03-17 12:00:57 -07:00
Joel McKinnon
b0bb723357
resolve merge, address review comments
2020-03-17 10:31:19 -07:00
David Tsay
b7fffeab1c
conditionManager controls subscriptions
2020-03-16 21:57:42 -07:00
David Tsay
e339d743ed
remove uneccessary update call
2020-03-16 16:01:12 -07:00
David Tsay
84f0d49d6f
code is documentation
2020-03-16 15:35:13 -07:00
David Tsay
090e89d524
remove testing aid
2020-03-16 15:34:12 -07:00
David Tsay
90dd53e954
Merge branch 'topic-conditionals' into dave/condition-telemetry-request
2020-03-16 15:31:19 -07:00
Joshi
6ab60ab52e
ConditionSet view listens to a listener from conditionCollection to display current output.
2020-03-16 15:00:16 -07:00
Joshi
8975bc8c55
Handles enum meta data for criteria
...
Ensures metadata with sources are also handled correctly
2020-03-16 13:36:33 -07:00
Joshi
f090f7ffe7
Removes comment.
2020-03-16 10:51:33 -07:00
Joshi
94b5617e63
Since we're observing for changes to the conditionSet domain object, we don't need to re-fetch it with persist.
2020-03-16 10:50:11 -07:00
David Tsay
41c79c6032
[Conditions] ConditionManager should observe its own mutations ( #2748 )
...
* change blur listener to change listener to watch for immediate updates to input
* move observe ConditionManager logic into ConditionManager
2020-03-16 10:14:46 -07:00
Joshi
83c648cc26
Addresses comments
2020-03-13 14:24:47 -07:00
Joshi
76e7fec1a0
Ensures the conditionManager is in sync with outside changes so that composition is not thrown away.
2020-03-13 14:08:14 -07:00
Joshi
09bfd80f69
Fix bug with telemetry disappearing
2020-03-13 12:50:06 -07:00
David Tsay
15a7d03e74
rename function for clarity
2020-03-13 09:36:17 -07:00
David Tsay
1dc9743484
remove unecessary get call
2020-03-13 09:26:46 -07:00
Joshi
8f05c57d1a
Fixes clone condition bug
2020-03-13 09:09:50 -07:00
Joshi
81caa27cba
Fixes failing tests
2020-03-12 14:38:39 -07:00
Joshi
74a7ef2565
Fix bug with removeCondition
2020-03-12 14:06:43 -07:00
Joshi
649575fd2d
Moves domain object observe logic to the condition set telemetry provider
2020-03-12 13:29:50 -07:00
Joel McKinnon
b75b7a958a
added input types and fixed bug for isDefined, isUndefined comparisons
2020-03-12 13:14:54 -07:00
Joshi
625b39d722
Fix typo
2020-03-12 13:06:56 -07:00
Joshi
65f80f4c45
Resubscribe to the conditionSet telemetry provider when the condition set domain object changes.
2020-03-12 13:05:03 -07:00
Joshi
02cd3048c8
Removed conditions as domain objects
2020-03-12 12:33:04 -07:00
Joel McKinnon
63feaef988
reinitialize rule string in forEach
2020-03-11 15:22:17 -07:00
