ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2024-12-20 13:43:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use existing var instead of recalculating

Browse Source 
on listener should be off in destroy()
This commit is contained in:
David Tsay 2020-03-20 11:44:05 -07:00
parent cbeb25c583
commit aed5377ad2
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/condition/criterion/TelemetryCriterion.js
View File

@ -45,7 +45,6 @@ export default class TelemetryCriterion extends EventEmitter {
this.input = telemetryDomainObjectDefinition.input;
this.metadata = telemetryDomainObjectDefinition.metadata;
this.telemetryObjectIdAsString = this.objectAPI.makeKeyString(this.telemetry);
this.on(`subscription:${this.telemetryObjectIdAsString}`, this.handleSubscription);
this.objectAPI.get(this.telemetryObjectIdAsString).then((obj) => this.initialize(obj));
}
@ -129,7 +128,7 @@ export default class TelemetryCriterion extends EventEmitter {
}
);
return this.objectAPI.get(this.objectAPI.makeKeyString(this.telemetry))
return this.objectAPI.get(this.telemetryObjectIdAsString)
.then((obj) => {
if (!obj || !this.isValid()) {
return this.formatData({});
@ -148,7 +147,7 @@ export default class TelemetryCriterion extends EventEmitter {
}
destroy() {
this.on(`subscription:${this.telemetryObjectIdAsString}`, this.handleSubscription);
this.off(`subscription:${this.telemetryObjectIdAsString}`, this.handleSubscription);
this.emitEvent('criterionRemoved');
delete this.telemetryObjectIdAsString;
delete this.telemetryObject;