Commit Graph

194 Commits

Author SHA1 Message Date
Victor Woeltjen
a947ff1274 [Fixed Position] Add element factory
Add element factory, which will take on responsibility
for populating initial states of elements and (if necessary)
prompting for user input. WTD-880.
2015-02-20 12:21:28 -08:00
Victor Woeltjen
f1a8e84a93 [Fixed Position] Allow adding elements
Allow adding of elements (without any element-specific
properties beyond type.) WTD-880.
2015-02-20 11:53:50 -08:00
Victor Woeltjen
6fca03521b [Fixed Position] Add initial element templates
Add element templates for fixed position elements introduced
via the Add button, WTD-880.
2015-02-20 11:39:29 -08:00
Victor Woeltjen
2be58579dc [Fixed Position] Add 'Add' menu button
Add UI for the Add button in fixed position view,
WTD-880.
2015-02-20 11:30:04 -08:00
Victor Woeltjen
1015e97b3e [Fixed Position] Add tests for FixedController
Add additional test cases for controller for Fixed Position
view to meet code coverage after changes for WTD-879.
2015-02-19 16:24:45 -08:00
Victor Woeltjen
3cfcd027e0 [Fixed Position] Fill in specs for selection proxies
Fill in specs for fixed position views selection proxies,
WTD-879.
2015-02-19 13:29:43 -08:00
Victor Woeltjen
7882dd1401 [Fixed Position] Add spec for selection
Add spec for selection manager for layout and fixed position
views, WTD-879.
2015-02-19 13:06:55 -08:00
Victor Woeltjen
14cbb9fb40 [Fixed Position] Add placeholder specs
Add placeholder specs for classes added to support
selection of elements in a fixed position view,
WTD-879.
2015-02-19 12:21:39 -08:00
Victor Woeltjen
7498e340d6 [Fixed Position] Rename accessor
Rename utility function used by fixed position elements
to be more accurate. WTD-879.
2015-02-19 12:10:43 -08:00
Victor Woeltjen
83872946bf [Fixed Position] Fix grid size spec
Fix spec which ensures that FixedController correctly
populates background grid based on user-defined grid
size, after changes for WTD-879.
2015-02-19 10:22:12 -08:00
Victor Woeltjen
9a50f6d84d [Fixed Position] Fix globals
Fix globals to pass JSLint check in command line build. WTD-879.
2015-02-19 09:37:02 -08:00
Victor Woeltjen
5df41966a4 [Fixed Position] Disable failing specs
Disable failing specs after significant rewrite of
FixedController to handle element selection, WTD-879.
2015-02-19 09:13:45 -08:00
Victor Woeltjen
7bd41a9f80 [Fixed Position] Allow dragging of elements
Restore dragging behavior to elements in a fixed position
view, WTD-879.
2015-02-18 20:29:54 -08:00
Victor Woeltjen
5680710c06 [Fixed Position] Implement remove
Implement remove button for selected elements in fixed
position view. WTD-879.
2015-02-18 20:12:55 -08:00
Victor Woeltjen
f66fb0a32d [Fixed Position] Add remove button
Add a 'remove' button when elements are selected in
fixed position view, WTD-879.
2015-02-18 19:56:54 -08:00
Victor Woeltjen
a4dd730764 [Fixed Position] Allow select/deselect
Allow select/deselect of individual elements in fixed position
view, WTD-879.
2015-02-18 19:51:42 -08:00
Victor Woeltjen
cd98fd475d [Fixed Position] Begin using proxies
Begin using proxies for elements in fixed position view,
WTD-879.
2015-02-18 19:41:27 -08:00
Victor Woeltjen
f24f62dedc [Fixed Position] Begin adding element proxy classes
Begin adding proxy classes to allow the toolbar to interact with
elements in a fixed position view, WTD-879.
2015-02-18 19:26:06 -08:00
Victor Woeltjen
466a169562 [Fixed Position] Continue refactoring controller
Continue refactoring Fixed Position controller for
selection support, WTD-879.
2015-02-18 15:11:52 -08:00
Victor Woeltjen
bf36141e91 [Fixed Position] Begin refactoring controller
Begin refactoring Fixed Position controller to facilitate
selection support, as well as multiple types of elements;
WTD-879.
2015-02-18 13:50:25 -08:00
Victor Woeltjen
8662689974 [Fixed Position] Begin breaking apart template
Begin breaking apart template to allow multiple
types of fixed position elements, WTD-879.
2015-02-18 13:19:59 -08:00
Victor Woeltjen
97b844563d [Fixed Position] Add proxy object
Add proxy object to represent the selection of the fixed position
view itself, WTD-879.
2015-02-18 09:03:50 -08:00
Victor Woeltjen
4be2a3f1cd [Fixed Position] Add selection manager
Add utility class so that layouts/fixed position views
can track their current selection state more simply.
WTD-879.
2015-02-18 08:55:58 -08:00
Victor Woeltjen
7a680873e3 [Fixed Position] Begin adding placeholder toolbar
Begin adding placeholder toolbar for fixed position view,
WTD-879.
2015-02-17 16:29:42 -08:00
Victor Woeltjen
7fced99390 [Fixed Position] Add placeholder toolbar definition
Add a mostly-empty toolbar definition to Fixed Position view,
WTD-879.
2015-02-17 16:15:25 -08:00
Victor Woeltjen
156f053421 [Fixed Position] Add specs for drop
Add specs related to positioning of objects based on
drop position, WTD-877.
2015-02-17 10:50:02 -08:00
Victor Woeltjen
553101100b [Fixed Position] Refresh subscriptions
Refresh subscriptions when composition changes, such as due to
a drag-drop addition of an element to the view. WTD-877.
2015-02-17 10:34:13 -08:00
Victor Woeltjen
136dddab86 [Fixed Position] Position elements where dropped
Position elements where they are dropped in Fixed Position
view, WTD-877
2015-02-17 10:27:37 -08:00
Victor Woeltjen
ef4ed50605 [Layout] Separate out handleDrop
Separate drop-handling into a non-anonymous function in
LayoutController to satisfy code style guidelines;
WTD-877.
2015-02-17 10:25:31 -08:00
Victor Woeltjen
01d953bf45 [Layout] Position frames on drop
Position frames within a layout based on the position
where they were dropped into the layout, WTD-877.
2015-02-17 10:23:10 -08:00
Victor Woeltjen
e158f2811c [Views] Wire in drop gesture
Support drop gesture from fixed position view and from
layout view, WTD-877.
2015-02-17 10:03:48 -08:00
Victor Woeltjen
8d6b218646 [Fixed Position] Add initial spec
Add initial spec for FixedController to satisfy minimum
coverage requirements, in preparation for review. WTD-889.
2015-02-17 09:03:23 -08:00
Victor Woeltjen
c2b1775d75 [Fixed Position] Free up resources
Free up resources when a fixed position view is destroyed,
WTD-889.
2015-02-17 08:35:32 -08:00
Victor Woeltjen
71a132d374 [Fixed Position] Improve doc of FixedController
Improve documentation for Fixed Position controller, WTD-889.
2015-02-17 08:32:35 -08:00
Victor Woeltjen
c6064dfe6c Merge branch 'open615' into open889
Merge in work-in-progress for WTD-615 (Fixed Position View)
into topic branch for WTD-889 (a sub-issue of WTD-615, which
has been broken down into discrete chunks to support
development.

Conflicts:
	platform/telemetry/src/TelemetrySubscription.js
2015-02-17 08:26:34 -08:00
bwyu
7c4cbb3107 Merge remote-tracking branch 'origin/open852' into open-master 2015-02-11 15:39:23 -08:00
bwyu
471e86bd6d Merge remote-tracking branch 'origin/open840' into open-master 2015-02-11 13:19:07 -08:00
Victor Woeltjen
7c5c96ff1d [Plot] Use GL-reported buffer size
Use the buffer width/height reported by WebGL when
configuring the viewport to ensure that data aligns
correctly to canvas size when drawn. WTD-852.
2015-02-09 16:10:20 -08:00
Victor Woeltjen
790397ae0f [Plot] Add test for buffer size
Add test case for usage of drawing buffer size as
reported by WebGL (instead of assuming we always got
the full size we requested.) WTD-852.
2015-02-09 16:07:05 -08:00
bwyu
61bb85df58 Merge remote-tracking branch 'origin/open751' into open-master 2015-02-06 18:08:12 -08:00
Victor Woeltjen
f78226bc69 [Plot] Unsubscribe on destroy
Unsubscribe when a plot view is destroyed; this avoids resource
leaks which cause WTD-840.
2015-02-05 17:37:47 -08:00
Victor Woeltjen
63345bbd3b [Plot] Add test for resource release
Add test to detect plot failing to release its subscriptions,
which causes WTD-840.
2015-02-05 17:34:37 -08:00
Victor Woeltjen
4ac25ab093 Merge branch 'open751' into open840
Merge in necessary changes to reproduce WTD-840 in order to
address WTD-840
2015-02-05 17:23:06 -08:00
bwyu
def47addb3 Merge remote-tracking branch 'origin/open734' into open-master 2015-02-04 12:24:23 -08:00
bwyu
bc5d657015 Merge remote-tracking branch 'origin/open716' into open-master 2015-02-03 11:11:36 -08:00
Victor Woeltjen
494cce9b2f [Plot] Complete specs for plot updater
Complete specs for plot updater; particularly, address
case (and fix bug in case) where maximum buffer size
has been hit. WTD-751.
2015-02-03 10:35:03 -08:00
Victor Woeltjen
ed0e0709c5 [Plot] Spec for plot updater
Spec for plot updater, added for WTD-751.
2015-02-02 18:14:08 -08:00
Victor Woeltjen
2ea4e7a47a [Plot] Update plot controller spec
Update plot controller spec to reflect changes introduced
for WTD-751 and WTD-784.
2015-02-02 16:17:17 -08:00
Victor Woeltjen
e6f1328d9d [Plot] Update specs
Update specs with minor changes related to using
telemetrySubscriber to populate plot with streaming
data, WTD-751 and WTD-784.
2015-02-02 15:44:36 -08:00
Victor Woeltjen
757665683e [Plot] Use a lossless subscription
Utilize lossless subscription to ensure that points are not
overwritten before being plotted from live telemetry.
WTD-784.
2015-01-30 15:36:57 -08:00
Victor Woeltjen
b1485e716c [Plot] Fix disappearing plot bug
Fix buffer resize operation as plots fill, WTD-782.
2015-01-30 12:28:39 -08:00
Victor Woeltjen
4fb750c0e0 [Plot] Update/suppress specs
Update specs and suppress failures; intermediate commit
for updates to plot for WTD-751.
2015-01-29 12:34:58 -08:00
Victor Woeltjen
a0137b341e [Plot] Fix bug for panels
Fix bug wherein number of points-to-plot is misreported
with multiple traces in a plot; clean up on modifications
to plot to self-cache streaming telemetry, to remove
other cache, WTD-751.
2015-01-29 12:27:04 -08:00
Victor Woeltjen
230ba3eb5c [Plot] Add comments
Add comments to plot code introduced to handle
subscribed telemetry only, to work around removal
of the cache to reduce memory usage, WTD-751.
2015-01-29 12:10:00 -08:00
Victor Woeltjen
5e2e0b4116 [Plot] Fix wiring on plot updater
Fix usages of the plot updater, introduced to track real-time
telemetry to remove the need to cache values elsewhere. This
allows memory usage to be decreased for WTD-751.
2015-01-29 11:22:31 -08:00
Victor Woeltjen
57f20ba110 [Plot] Amend plot updater
Amend plot updater to correctly expose information for real-time
plotting without history, allowing removal of cache to free
memory; WTD-751.
2015-01-29 11:19:22 -08:00
Victor Woeltjen
b615a3c888 [Plot] Wire in updater
Wire in updater for use in plots (to cache values at
the plot level, allowing removal of a global cache to
reduce memory consumption for WTD-751.)
2015-01-29 09:51:18 -08:00
Victor Woeltjen
f3900cdd2a [Plot] Add PlotUpdater
Add PlotUpdater, which will track streaming data from within
the plot. Allows removal of the cache for WTD-751.
2015-01-29 09:05:40 -08:00
Victor Woeltjen
a0f216764b [Plot] Cancel interval correctly
Fix approach used for interval cancellation associated
with resource leak closing for WTD-717; this avoids the
exception observed in WTD-750.
2015-01-28 15:53:13 -08:00
Victor Woeltjen
b915a90305 [Views] Fix glyphs
Use correct glyphs for Plot, Scrolling, and Items views.
WTD-734.
2015-01-27 14:50:45 -08:00
Victor Woeltjen
2b4517cff6 [Layout] Update on composition change
Update frame positions when model.composition changes,
instead of when model changes. Ensures correct display
after changes to avoid redrawing on every update,
WTD-716.
2015-01-27 10:22:50 -08:00
Victor Woeltjen
6947e0aa42 [Performance] Update specs
Add tests to verify that directives stop polling after their
scope is destroyed (to prevent resource leaks); those changes
address resource leaks identified in the context of WTD-717.
2015-01-27 08:50:11 -08:00
Victor Woeltjen
5ee872713f [Performance] Release interval from mct-chart
Stop checking for size changes after scope is destroyed
in mct-chart; part of ongoing resolution of resource leaks
which may contribute to WTD-717.
2015-01-26 17:56:52 -08:00
Victor Woeltjen
082b555644 [Fixed Position] Persist drag positions
Persist element positions after drag in fixed position view,
WTD-615.
2015-01-16 09:47:29 -08:00
Victor Woeltjen
ec211a067a [Fixed Position] Show telemetry values
Show telemetry values in cells in fixed position views.
WTD-615.
2015-01-15 19:16:15 -08:00
Victor Woeltjen
b2c9b0a2fb [Fixed Position] Position/style telemetry cells
Position telemetry elements in fixed position view appropriately.
WTD-615.
2015-01-15 19:03:34 -08:00
Victor Woeltjen
bd068f31c5 [Fixed Position] Fill available area with grid
Fill available space with background grid for fixed position
view, WTD-615.
2015-01-15 18:53:59 -08:00
Victor Woeltjen
b2bfa2b09b [Fixed Position] Populate background grid
Add a background grid to fixed position view, WTD-615.
2015-01-15 18:48:11 -08:00
Victor Woeltjen
d453e59308 [Fixed Position] Expose controller
Expose Fixed Position controller in order to begin implementing
Fixed Position view and editing behavior. WTD-615.
2015-01-15 18:36:48 -08:00
Victor Woeltjen
1b2ebf1250 [Fixed] Add Fixed Position controller
Add controller for fixed position view (initially, as copied
from Layout view.) WTD-615.
2015-01-15 18:29:31 -08:00
Victor Woeltjen
7f21cc044d [Fixed Position] Initial template
Add initial template, declaration for fixed position view,
WTD-615.
2015-01-14 17:50:35 -08:00
Victor Woeltjen
0ef6c59643 [Plot] Add a key to view definition
Add a value for key to the definition of Plot view;
this avoids defaulting to Plot as a view for all
objects, WTD-628.
2015-01-06 10:03:24 -08:00
Victor Woeltjen
5414c4c2d0 [Telemetry] Update scrolling list specs
Update specs for columns in scrolling list view to reflect
that the formatting of domain/range values for display
has now been moved into a reusable injectable service for
WTD-599.
2014-12-24 12:22:55 -08:00
Victor Woeltjen
78b636dafe [Telemetry] Update plot specs
Update plot specs to reflect refactoring out of formatter
for telemetry values, WTD-599.
2014-12-24 12:17:05 -08:00
Victor Woeltjen
f63038a83f [Telemetry] Move formatter spec
Move spec for formatting of telemetry values from the
plot bundle to the telemetry bundle, to reflect its
exposure as a reusable service exposed by that bundle.
WTD-599.
2014-12-24 11:39:29 -08:00
Victor Woeltjen
1ed67629e6 [Telemetry] Add missing JSDoc
Add missing in-line documentation to ScrollingListPopulator;
noticed in the context of work done for WTD-599,
refactoring of time- and value-formatting for telemetry
into a reusable, injectable service.
2014-12-24 11:33:19 -08:00
Victor Woeltjen
44b16f9dd9 [Telemetry] Use telemetryFormatter in scrolling list
Use the injected telemetryFormatter in scrolling
list views, instead of replicating this functionality.
WTD-599.
2014-12-24 11:23:59 -08:00
Victor Woeltjen
74f2af1011 [Telemetry] Expose telemetryFormatter
Expose telemetryFormatter as a service; additionally, fix
some structural issues to make sure this is passed around
as needed among plot components. WTD-599.
2014-12-24 11:14:38 -08:00
Victor Woeltjen
fc0376296d [Telemetry] Refactor plot to use TelemetryFormatter
Refactor plot view to use an injected telemetry formatter,
instead of explicitly including moment. WTD-599.
2014-12-24 10:59:34 -08:00
Victor Woeltjen
b080f90f64 [Telemetry] Move formatter implementation
Move implementation of formatter used for display
of domain values out of plot, and into the telemetry
bundle, from which it can be exposed as a general-use
service. WTD-599.
2014-12-24 10:34:43 -08:00
Victor Woeltjen
453b853a75 [Telemetry] Add skeleton formatter
Add skeleton for implementation of a formatter for
telemetry data, including reorganizing libraries
such that moment.min.js only occurs once. WTD-599.
2014-12-24 10:28:58 -08:00
Victor Woeltjen
921aad9e2f [Plot] Update plot immediately on mode change
Make sure current telemetry is drawn immediately upon
switching between Overlaid and Stacked plot modes.
WTD-625.
2014-12-12 15:14:20 -08:00
Victor Woeltjen
662412a31d [Plot] Avoid displaying bad labels
Avoid displaying bad labels for tick marks, or in the
coordinates shown on hover. Done in the context of
refactoring to support WTD-625.
2014-12-12 15:07:06 -08:00
Victor Woeltjen
b1158ce230 [Plot] Add JSDoc for stack plots
Add JSDoc for new classes introduced (and revised interfaces
exposed by existing classes) to support stacked plots,
WTD-625.
2014-12-12 14:37:06 -08:00
Victor Woeltjen
80852177c7 [Plot] Complete specs related to stacked mode
Add specs for SubPlot, which was introduced to support
presenting multiple plot areas within a single plot
view (stacked plots, WTD-625.)
2014-12-12 13:20:50 -08:00
Victor Woeltjen
c8c50f8fb1 [Plot] Add specs for plotting modes
Add specs for stacked/overlaid plot modes. WTD-625.
2014-12-12 12:56:26 -08:00
Victor Woeltjen
112d94e189 [Plot] Specs for PlotModeOptions
Add specs for PlotModeOptions, introduced to
allow switching between Stacked and Overlaid
mode for WTD-625.
2014-12-12 11:20:04 -08:00
Victor Woeltjen
7ea63fce8c [Plot] Add specs for PlotPanZoomStackGroup
Add specs to verify the behavior of PlotPanZoomStackGroup,
which is responsible for synchronizing the domain axis
between multiple sub-plots in a stacked plot view.
WTD-625.
2014-12-12 11:10:52 -08:00
Victor Woeltjen
a2d22a4558 [Plot] Restore coverage on PlotController
Restore full test coverage on PlotController after
refactoring for WTD-625, stacked plots.
2014-12-12 10:08:58 -08:00
Victor Woeltjen
4586146da2 [Plot] Remove failing specs
Remove specs which fail due to refactoring for
WTD-625.
2014-12-12 09:49:44 -08:00
Victor Woeltjen
a677ed258e [Plot] Add skeleton specs for stacked plots
Add skeleton specs for classes introduced to support
stacked plot mode, WTD-625.
2014-12-12 09:44:05 -08:00
Victor Woeltjen
06036ce8b3 [Plot] Restore range tick marks
Restore range tick marks; these were lost in refactoring
to support multiple subplots-per-view due to a missed
occurrence of an out-of-date interface usage. WTD-625.
2014-12-11 19:36:01 -08:00
Victor Woeltjen
188e98a78b [Plot] Update stacked plots immediately
When changes to pan-zoom bounds are made in one
subplot, this will effect the pan-zoom bounds of
other subplots. Ensure this occurs immediately.
WTD-625.
2014-12-11 19:33:09 -08:00
Victor Woeltjen
9c1d72f917 [Plot] Integrate PlotPanZoomStackGroup
Utilize PlotPanZoomStackGroup; that is, utilize changes
such that a set of pan-zoom stacks can be treated as one,
while their domain axis synchronizes, and their range
axis does not. WTD-625.
2014-12-11 19:21:52 -08:00
Victor Woeltjen
0ce0517e09 [Plot] Initially implement synced pan/zoom stack
Initially implement a synchronized pan/zoom stack,
which maintains the same domain axis bounds for all
subplots in a stacked plot view, but allows each to
have independent range axes. WTD-625.
2014-12-11 17:27:44 -08:00
Victor Woeltjen
9344809998 [Plot] Restrict hover coordinates
Only show hover coordinates in a stacked plot for
the plot which the user is specifically hovering
over. WTD-625.
2014-12-11 17:09:08 -08:00
Victor Woeltjen
1b6ce10dd9 [Plot] Change style when stacked
Change plot style when in stacked plot mode, such that
plots stack as expected. (Without this change, the
gl-plot class's height of 100% will cause all plots to
fill the full vertical space, effectively acting
overlaid.) WTD-625.
2014-12-11 17:02:07 -08:00
Victor Woeltjen
cd8deca1b3 [Plot] Add initial stack-plot implementation
Add initial implementation of stacked mode for
Plot view. Note that this will not stack correctly
due to markup/style issues. WTD-625.
2014-12-10 20:16:23 -08:00
Victor Woeltjen
eb90a3eeba [Plot] Fix refactoring issues
Fix issues related to refactoring of view-level
to subplot-level behavior, such that previous
functionality is restored. This refactoring
supports introduction of a stacked-plot mode,
for WTD-625.
2014-12-10 20:04:10 -08:00
Victor Woeltjen
784b2b6186 [Plot] Begin refactoring for stacked plots
Begin refactoring Plot view to support stacked plots;
separate out behavior which needs to occur per-plot
from area which should occur per-view, and add a
handler for the Overlay mode. WTD-625.
2014-12-10 19:51:27 -08:00