Commit Graph

184 Commits

Author SHA1 Message Date
Victor Woeltjen
622f1f8be7 [Plot] Add JSDoc
Add inline comments to Plot scripts. WTD-533.
2014-12-02 14:40:11 -08:00
Victor Woeltjen
870172ec6f [Plot] Complete specs for plot
Complete specs for transitioned plot view, WTD-533.
2014-12-02 11:08:21 -08:00
Victor Woeltjen
2f475fc17a [Plot] Fill in specs
Fill in specs for elements used by the PlotController
in order to improve coverage of the plot bundle.
WTD-533.
2014-12-02 10:11:46 -08:00
Victor Woeltjen
ae05ed903b [Plot] Add skeleton specs
Add skeleton specs for remaining plot scripts.
WTD-533.
2014-12-01 19:45:23 -08:00
Victor Woeltjen
86711735b7 [Plot] Organize plot elements
Place elements of the PlotController into a separate
directory inside of the source folder for the plot
plug-in, in preparation for review and integration.
Part of ongoing plot transition to Angular, WTD-533.
2014-12-01 18:21:51 -08:00
Victor Woeltjen
ad802e674e [Plot] Spec for PlotController
Fill in spec for PlotController, which is the primary
handler of logic associated with plot views, transitioned
for WTD-533.
2014-12-01 18:13:03 -08:00
Victor Woeltjen
c9300e8611 [Plot] Initial spec for PlotController
Add initial spec for PlotController, the main controller
to support the plot view. WTD-533.
2014-12-01 16:44:16 -08:00
Victor Woeltjen
e1298db760 [Plot] Separate out plot axis
Separate plot axis (as prepared for the plot's
Angular template) into its own script. WTD-533
2014-12-01 16:35:38 -08:00
Victor Woeltjen
bb708e9a05 [Plot] Separate out formatter
Separate out plot label formatter to simplify PlotController,
to simplify test and maintenance. WTD-533
2014-12-01 15:28:20 -08:00
Victor Woeltjen
5bfa9c76a7 [Plot] Separate out positioning
Separate out pixel-to-plot-coordinate conversion into its
own script, to simplify PlotController for testing and
maintainability. WTD-533.
2014-12-01 14:14:31 -08:00
Victor Woeltjen
1b4286344d [Plot] Separate out pan/zoom stack
Create a separate script/class for the pan-zoom stack,
to simplify PlotController for testability and
maintainability. WTD-533.
2014-12-01 13:48:38 -08:00
Victor Woeltjen
ac00c52589 [Plot] Rename plot preparer
Rename the script used to prepare plot data for
rendering. WTD-533.
2014-12-01 13:27:30 -08:00
Victor Woeltjen
14d152102b [Plot] Include plot as an active bundle
Include the Plot view among active bundles, as well as
the sine wave generator from the example bundles to
support development. WTD-533.
2014-12-01 13:26:01 -08:00
Victor Woeltjen
f3b83e0db7 [Plot] Icons for plot controls
Add icons for plot pan/zoom controls, to step
back through or undo pan/zoom states. WTD-533.
2014-12-01 13:04:24 -08:00
Victor Woeltjen
3909ddcd14 [Plot] Add sine wave generator example
Add sine wave generator as an example of a domain object which
exposes telemetry, to support transition of the Plot view.
WTD-533.
2014-12-01 10:24:38 -08:00
Victor Woeltjen
7836fe5fbb [Plot] Make PlotPalette constructor-like
Make PlotPalette look like a constructor, in order
to remain consistent with code style guidelines.
WTD-533.
2014-12-01 10:16:59 -08:00
Victor Woeltjen
8cb3ce4fd9 [Plot] Rename GLPlot to GLChart
Rename the GLPlot script (which handles drawing
of lines/boxes to canvas elements) to GLChart,
to distinguish it from the broader plot view.
WTD-533.
2014-12-01 10:12:07 -08:00
Victor Woeltjen
b556b5e4f2 [Plot] Bring in scripts from sandbox branch
Bring in scripts for plotting from the sandbox
branch to begin transitioning/integrating plot
view. WTD-533.
2014-12-01 09:41:39 -08:00
Victor Woeltjen
55c2d15cdc [Telemetry] Add JSDoc
Add JSDoc and in-line comments to scripts in the
platform/telemetry bundle, for WTD-575.
2014-11-28 20:59:41 -08:00
Victor Woeltjen
f8a0544435 [Telemetry] Add specs
Add specs for scripts in bundle platform/telemetry,
for WTD-575.
2014-11-28 20:29:30 -08:00
Victor Woeltjen
4fcb59e181 [Telemetry] Remove unused scripts
Remove unused scripts from the platform/telemetry
bundle in preparation for integration. WTD-575.
2014-11-28 18:41:38 -08:00
Victor Woeltjen
052f07f725 [Telemetry] Code style
Fix code style, remove Promise from globals where
unused. Part of ongoing preparation of platform/telemetry
bundle for integration, WTD-575.
2014-11-28 18:39:19 -08:00
Victor Woeltjen
51de44a3e5 [Telemetry] Bring in telemetry bundle
Bring in initial state for the platform/telemetry
bundle, which provides general-purpose telemetry
conventions and infrastructure to support creating
domain objects which expose telemetry data.
WTD-575.
2014-11-28 16:06:54 -08:00
Victor Woeltjen
0bacc03e58 [Common UI] Fix FullscreenActionSpec
Fix FullscreenActionSpec such that it will execute on
command line; the global screenfull dependency behaves
differently during attempts to spy on methods from
the command line build, so replace it entirely.

Concludes work on WTD-574 in preparation to submit for
review.
2014-11-25 23:08:47 -08:00
Victor Woeltjen
b0cb8a8455 [Common UI] Fix Save/Cancel quirk
Fix a defect in the Save/Cancel buttons in Edit mode
that was causing the first click to be missed; this
was due to Angular's inability to detect when a
native promise (as opposed to one from ) had been
resolved.

Since the Editor capability is introduced indirectly
and is a few degrees of separation removed from
the declared extension layer (where we would be able
to get a reference to ), and all we need to do is
make something look Promise-like, a convenience
function to do this is added.

Part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 22:58:34 -08:00
Victor Woeltjen
52ec1aeb89 [Common UI] Complete remaining specs
Complete remaining specs to achieve full test coverage
for common user interface bundles being transitioned
as part of WTD-574.
2014-11-25 22:48:12 -08:00
Victor Woeltjen
3aa551c4ea [Common UI] Fill in CreationService spec
Fill in specs for CreationService, which supports the
Create action, which, in turn, is included to support
the Create button in Browse mode. Part of the transition
of common user interface elements for WTD-574.
2014-11-25 22:35:30 -08:00
Victor Woeltjen
48ff8c4c03 [Common UI] Continue filling in Browse specs
Continue filling in specs for scripts introduced as part
of bundle platform/commonUI/browse, which is responsible
for browse mode. WTD-574.
2014-11-25 20:26:37 -08:00
Victor Woeltjen
528f6bdf56 [Common UI] Spec for ViewSwitcherController
Fill in spec for the controller which maintains a set of
applicable and selected view options to populate the
view switcher. Part of Browse mode and, in turn, part
of the common user interface elements that are being
transitioned for WTD-574.
2014-11-25 19:46:56 -08:00
Victor Woeltjen
9bc05f27a5 [Common UI] Skeleton specs for Browse
Add skeleton specs for browse mode. WTD-574.
2014-11-25 18:30:30 -08:00
Victor Woeltjen
36fab50825 [Common UI] Add in-line docs for Browse
Add in-line docs for bundle platform/commonUI/browse,
which implements Browse mode, one of the common user
interface bundles being transitioned in WTD-574.
2014-11-25 16:53:22 -08:00
Victor Woeltjen
b97e2d0324 [Common UI] Add JSDoc, remove UUIDService
Add JSDoc to Create-related classes and remove the
UUIDService (replaced by third-party lib) to reduce
amount of code to cover and prepare for code review,
as part of ongoing transition of common user interface
elements, WTD-574.
2014-11-25 16:14:09 -08:00
Victor Woeltjen
242d40fab2 [Common UI] Fill in dialog specs
Fill in specs for bundle platform/commonUI/dialog,
which provides the ability to show dialogs. One
of the common user interface elements being transitioned
for WTD-574.
2014-11-25 15:59:04 -08:00
Victor Woeltjen
f04e02359a [Common UI] Skeleton spec for dialogs
Skeleton specs for bundle platform/commonUI/dialog,
responsible for displaying dialog overlays. Part of
ongoing transition of common user interface elements
for WTD-574.
2014-11-25 14:44:16 -08:00
Victor Woeltjen
0faf4c934e [Common UI] Refactor dialogs
Refactor bundle platform/commonUI/dialog such that
the concerns of showing dialogs (including showing
a single instance thereof) and managing changes to
the DOM are more cleanly separated. This simplifies
testing and satisfies code style guidelines for
this bundle, in preparation for its inclusion among
common user interface bundles to be transitioned
in WTD-574.
2014-11-25 14:39:40 -08:00
Victor Woeltjen
6cce00d601 [Common UI] Add JSDoc to DialogService
Add in-line documentation to the dialog service,
exposed by bundle platform/commonUI/dialog, one
of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 13:31:30 -08:00
Victor Woeltjen
d950fe14e5 [Common UI] Finish JSDoc for edit mode
Complete in-line documentation for bundle
platform/commonUI/edit (Edit Mode), one of the
common user interface bundles being transitioned
for WTD-574.
2014-11-25 12:50:06 -08:00
Victor Woeltjen
4c0e5e963e [Common UI] Add JSDoc for edit actions
Add in-line documentation for actions that are introduced
by the bundle platform/commonUI/edit, which introduces
Edit mode. One of the common user interface bundles being
transitioned for WTD-574.
2014-11-25 11:53:53 -08:00
Victor Woeltjen
c432a4eb1e [Common UI] Complete specs for edit mode
Add specs for remaining capabilities and capability
wrappers employed by Edit mode. Completes coverage
for bundle platform/commonUI/edit, which is being
transitioned along with other commonUI bundles in
WTD-574.
2014-11-25 10:51:23 -08:00
Victor Woeltjen
7ddfcbca9b [Common UI] Fill in spec for RemoveAction
Fill in spec for the Remove action, included as part of
the bundle platform/commonUI/edit. WTD-574.
2014-11-25 10:08:50 -08:00
Victor Woeltjen
19b4dc3fa3 [Common UI] Spec for EditAction
Fill in spec for the Edit action, which enters Edit mode
Part of bundle platform/commonUI/edit, being transitioned
for WTD-574.
2014-11-25 09:48:54 -08:00
Victor Woeltjen
2f7746df53 [Common UI] Add specs for Save/Cancel
Add specs for the save and cancel conclude-editing
actions, part of bundle platform/commonUI/edit
(Edit Mode) which is transitioned among the various
common UI bundles. WTD-574
2014-11-25 09:35:55 -08:00
Victor Woeltjen
d7fbd596ef [Common UI] Specs for edit controllers
Add specs for controllers used to support Edit mode,
one of the common UI elements being transitioned for
WTD-574.
2014-11-24 17:29:42 -08:00
Victor Woeltjen
093ccb637f [Common UI] Amend ActionGroupControllerSpec
Amend ActionGroupControllerSpec (introduced for WTD-574,
transition of common UI elements) such that it handles
the case where no action capability is defined.
2014-11-24 17:09:56 -08:00
Victor Woeltjen
88f3221938 [Common UI] Add skeleton specs for edit mode
Add empty files which will contain specs for
bundle platform/commonUI/edit, which is responsible
for Edit mode. WTD-574.
2014-11-24 17:07:17 -08:00
Victor Woeltjen
80430234d6 [Common UI] Add JSDoc
Add JSDoc to remaining scripts in bundle
platform/commonUI/general. WTD-574.
2014-11-24 16:39:52 -08:00
Victor Woeltjen
2f43e8cd7f [Common UI] Document TreeNodeController
Add in-line documentation to TreeNodeController, and update
glossary with some clarifying definition.

Additionally, change name from tree-item to tree-node for
consistency.

Part of ongoing transition of commonUI bundles, WTD-574.
2014-11-24 15:42:15 -08:00
Victor Woeltjen
e0b201aa17 [Common UI] Add spec for mct-container
Add spec for the mct-container directive, introduced
as part of the general user interface support bundle,
platform/commonUI/general. WTD-574.
2014-11-24 15:22:03 -08:00
Victor Woeltjen
2b1fdc2204 [Common UI] Add specs for controllers
Add specs for controllers in the commonUI/general bundle.
WTD-574.
2014-11-24 15:10:29 -08:00
Victor Woeltjen
b026e313be [Common UI] Add skeleton specs
Add skeleton specs for bundle platform/commonUI/general.
WTD-574.
2014-11-24 13:39:52 -08:00