Victor Woeltjen
cae775f9bc
[Entanglement] Add policies for Copy and Move
...
...to ensure that these are only performed on creatable and
mutable targets, respectively.
2016-03-29 13:10:35 -07:00
Victor Woeltjen
d6ec7e9ab8
[Build] Remove unused variables from specs
...
...to satisfy JSHint.
2016-03-04 12:56:14 -08:00
Victor Woeltjen
f34ef8c4c8
[Build] Add global declarations to mocks
2016-03-04 11:53:08 -08:00
Victor Woeltjen
a1a7b2b8ce
[Build] Remove unused variables
...
...to satisfy JSHint
2016-03-04 11:41:48 -08:00
Victor Woeltjen
c00d77dcb1
[Build] Relocate operators
...
...in multi-line expressions, to satisfy JSHint.
2016-03-04 11:02:57 -08:00
Victor Woeltjen
ac5ac8d34e
[Build] Remove boilerplate from scripts
...
No longer necessary after JSHint configuration.
2016-03-04 10:46:38 -08:00
Victor Woeltjen
43d497e069
[Create] Clarify function naming
...
Per review feedback,
https://github.com/nasa/openmctweb/pull/666#discussion_r52625960
2016-02-11 09:49:26 -08:00
Victor Woeltjen
53a49a671b
[Create] Test optional filter parameter
2016-02-10 14:31:56 -08:00
Victor Woeltjen
99a454f943
[Create] Update CopyService spec
...
...to reflect API usage after #656
2016-02-10 14:21:09 -08:00
Victor Woeltjen
cb53e1aaee
[Create] Add object, not ID
...
Add domain object, and not its identifier, when suing
add method of composition from CopyTask, for consistency
with test expectations.
2016-02-10 14:17:36 -08:00
Victor Woeltjen
0f231838ec
[Create] Update test inputs to CopyTask
...
...to reflect changes for #656
2016-02-10 14:05:04 -08:00
Victor Woeltjen
72df464f0f
[Create] Utilize passed-in filter
...
...when determining which objects should be cloned.
2016-02-10 13:38:53 -08:00
Victor Woeltjen
f602aa9247
[Create] Add filter to copyService
...
Add an optional parameter to method signature of
copyService, used to determine if a domain object should
or should not be cloned.
This will be used to support usages of copyService
where links should remain links;
https://github.com/nasa/openmctweb/pull/666/files#r52525612
2016-02-10 13:29:56 -08:00
Victor Woeltjen
b37b82133e
[Create] Return cloned object in context
...
...to allow copyService to be used in the context of a
Save As action, with an appropriate navigation change.
2016-02-10 12:23:10 -08:00
Victor Woeltjen
aebae27391
[Tests] Remove suite.json files
...
Remove obsolete suite.json files; #482
2016-02-02 09:35:50 -08:00
Henry
b8b5fdcabf
[Copy] #497 Removed extraenuous persist call
2016-01-22 11:32:20 -08:00
Victor Woeltjen
86daad5fbd
[API Refactor] Remove obsolete UUID dependency
...
...in association with cleanup of requirejs config,
https://github.com/nasa/openmctweb/pull/469/files#r49642503
2016-01-13 12:22:44 -08:00
Victor Woeltjen
cec197f888
[API Refactor] Remove bundle.json files
2016-01-08 15:32:18 -08:00
Victor Woeltjen
de53247d56
[API] Convert JSON bundles to imperative form
2016-01-07 15:08:08 -08:00
Victor Woeltjen
5f96861c44
[Duplicate] Handle single-element ID arrays
...
Avoid type coercion related errors when testing to
see if a value is an ID that needs to be remapped.
2015-12-17 15:10:15 -08:00
Victor Woeltjen
995d71f901
[Duplicate] Add test case
...
Add test case for single-element string arrays, to
replicate bug around type coercion.
https://github.com/nasa/openmctweb/issues/444
2015-12-17 15:07:16 -08:00
Henry
6302e45c10
Fixed bug in copying #428
2015-12-17 13:47:31 -08:00
Henry
83e77303aa
[Copy] Duplication of layouts does not retain position and size of all elements. #428
2015-12-16 11:11:20 -08:00
Victor Woeltjen
19f07aa398
[Duplicate] Add trailing newline
2015-12-08 16:34:36 -08:00
Victor Woeltjen
46f9b31cff
[Duplicate] Test rewriting of identifiers
2015-12-08 16:27:46 -08:00
Victor Woeltjen
e32feb29e2
[Duplicate] Rewrite identifiers in clones
...
Traverse object models of clones and rewrite domain object
identifiers that have changed during duplication.
Addresses https://github.com/nasa/openmctweb/issues/332
2015-12-08 15:45:45 -08:00
akhenry
3447e735dc
Merge pull request #362 from nasa/open346
...
[Entanglement] Add "Set Primary Location" action
2015-12-04 13:48:27 -08:00
Henry
b388c76e45
[copy] #338 Modified check to set object location, added setLocation flag, Removed unused parameter
2015-12-03 19:00:44 -08:00
Henry
57efe4e0d1
Removed UUID reference
2015-12-03 17:10:28 -08:00
Henry
6aa77ff468
#338 fixed failing test
2015-12-03 16:41:06 -08:00
Henry
96249e6bcc
Removed redundant line in test spec
2015-12-03 15:51:27 -08:00
Henry
6e391098a3
Fixed jslint error
2015-12-03 15:32:26 -08:00
Henry
baec0f9719
#338 added new test case for creation of links when object type is not createable
2015-12-03 15:28:07 -08:00
Henry
6aab9f4e34
Added test for linking
2015-12-03 14:47:42 -08:00
Henry
734e979c94
#338 Fixed failing tests after refactor
2015-12-03 12:49:54 -08:00
Henry
3b427c31a2
Fixed error with not properly referenced
2015-12-02 19:18:50 -08:00
Henry
cee0ecf0ef
Removed use of composition and mutation because they trigger the search indexer too early and it tries to retrieve objects that have not been persisted yet
2015-12-02 19:10:10 -08:00
Henry
9953e16415
#338 Copy now using target persistence space
2015-12-02 14:06:22 -08:00
Victor Woeltjen
571f6d183a
[Entanglement] Expose Set Primary Location
2015-12-01 16:26:19 -08:00
Victor Woeltjen
1292e39c46
[Entanglement] Implement Set Primary Location
2015-12-01 16:20:30 -08:00
Victor Woeltjen
6fe3f82fb1
[Entanglement] Add test for Set Primary Location
...
https://github.com/nasa/openmctweb/issues/346
2015-12-01 15:59:37 -08:00
Victor Woeltjen
c8d77bc2db
[Entanglement] Allow cross-space linking
...
Allow links across spaces; only disallow move or copy.
Addresses WTD-1587
2015-11-30 15:27:10 -08:00
Victor Woeltjen
7974ffdda2
Merge remote-tracking branch 'github/master' into open245b
...
...in preparation to complete merge nasa/openmctweb#257
Conflicts:
platform/entanglement/src/actions/CopyAction.js
platform/entanglement/src/actions/LinkAction.js
platform/entanglement/src/actions/MoveAction.js
2015-11-21 07:05:51 -08:00
Victor Woeltjen
04ce2f985a
[Persistence] Add JSDoc
...
Add JSDoc to classes added/modified to support multiple persistence
spaces, nasa/openmctweb#245 .
2015-11-10 14:16:07 -08:00
Victor Woeltjen
bd85392b54
[Persistence] Test cross-space policy
...
Verify that move/copy/link across spaces is disallowed.
2015-11-10 13:29:12 -08:00
Victor Woeltjen
adf119007b
[Persistence] Test validator
...
Exercise the validation function provided by move/copy/link
actions when prompting for a location with a dialog.
2015-11-10 12:46:58 -08:00
Victor Woeltjen
7114e9b150
[Persistence] Update move/copy/link specs
...
...to reflect re-consultation of policyService when the action
context changes due to dialog input.
2015-11-10 12:40:52 -08:00
Victor Woeltjen
49b983cd3a
[Persistence] Fix cross-space policy
...
Fix logic in cross-space policy; only disallow when a move, copy
or link would really cross spaces.
2015-11-10 10:57:48 -08:00
Victor Woeltjen
0c096db8bd
[Persistence] Suppress Move/Copy/Link
...
Disallow move/copy/link when crossing persistence spaces,
nasa/openmctweb#245
2015-11-10 10:44:21 -08:00
Victor Woeltjen
2866574dc0
[Actions] Define applicability
...
Define applicability of Move/Copy/Link using appliesTo, to avoid
errors being thrown due to lack of context during instantiation.
Addresses immediate cause of nasa/openmctweb#120 .
2015-11-09 16:28:04 -08:00
Henry
148a5eb248
JSLint issue
2015-11-06 10:14:59 -08:00
Henry
31d3ec5d20
Removed usage of function.prototype.bind
2015-11-06 10:06:17 -08:00
Henry
2f658348a8
Fixed JSLint
2015-11-05 17:40:22 -08:00
Henry
793ed7ebe6
[UI] Progress indicator for pending operations - Refactoring for code clarity
2015-11-05 17:32:52 -08:00
Henry
e1c6c76612
Refactored some CopyService functions out to CopyTask
2015-11-05 16:39:46 -08:00
Henry
aa2a835cb1
Created CopyTask class
2015-11-05 16:19:01 -08:00
Henry
21a37db15b
#127 fixed failing test caused by fix for persistence spaces
2015-11-05 11:50:56 -08:00
Henry
5b3f780204
[UI] Progress indicator for pending operations (e.g. duplicate) #249- Fixed serious issue with persistence
2015-11-05 11:38:41 -08:00
Andrew Henry
3443780ac7
Improved commenting
2015-11-04 22:09:28 -08:00
Andrew Henry
8e85675732
Made changes to error reporting
2015-11-04 22:07:26 -08:00
Andrew Henry
2bdc95eb95
Restored MoveActionSpec.js and LinkActionSpec.js
2015-11-04 21:11:26 -08:00
Andrew Henry
f2efb07d93
Remove UUID path
2015-11-04 21:05:55 -08:00
Andrew Henry
863c3f1720
Fixed jslint issues
2015-11-04 20:48:22 -08:00
Andrew Henry
b73f9fc19e
Merged from master
2015-11-04 20:30:49 -08:00
Andrew Henry
10e711f717
Removed commented code
2015-11-04 20:26:24 -08:00
Andrew Henry
529dde57b9
Added test for notification to CopyActionSpec
2015-11-04 20:26:24 -08:00
Henry
7d1a1acc11
Adding tests for Copy Action
2015-11-04 20:26:23 -08:00
Henry
5e1b0f38b7
Migrated to using notifications and fixed tests
2015-11-04 20:26:23 -08:00
Andrew Henry
4e69ca50fb
Fixed blocking dialog
2015-11-04 20:26:23 -08:00
Andrew Henry
05481dcab5
reverted AbstractComposeAction
2015-11-04 20:26:23 -08:00
Andrew Henry
fa7131ad5c
Refactoring to use promises notifications
2015-11-04 20:26:23 -08:00
Henry
bd1c3cb7da
All test cases passing + added test cases for copy
2015-11-04 20:26:23 -08:00
Henry
cbd21212d1
Original tests that are still valid are passing
2015-11-04 20:26:23 -08:00
Henry
5cd458a733
Updating tests
2015-11-04 20:26:23 -08:00
Andrew Henry
2f90a89065
Fixed more failing tests
2015-11-04 20:26:23 -08:00
Henry
4312857fd4
Fixed failing tests
2015-11-04 20:26:22 -08:00
Andrew Henry
6c4c53dde7
Debugging test failures
2015-11-04 20:26:17 -08:00
Andrew Henry
4eaeea1e14
Fixed bugs in copy
2015-10-29 21:39:50 -07:00
Henry
f44819a7fe
Improvements to copy notifications
2015-10-29 17:40:17 -07:00
Henry
05722d9b11
Added error handling
2015-10-29 17:15:20 -07:00
Henry
92a3fa3e4c
Added error handling, and refactored CopyAction slightly
2015-10-29 16:40:51 -07:00
Andrew Henry
e37fa75289
Added basic notifications on copy
2015-10-28 17:16:53 -07:00
Andrew Henry
ee314ab387
Added notifications
2015-10-28 17:05:05 -07:00
Henry
6d08c81b3b
First iteration of duplication complete
2015-10-20 12:18:30 -07:00
Andrew Henry
89e763b515
Incremental commit of Duplication
2015-10-20 09:25:31 -07:00
Henry
2a1388772a
Incremental commit of duplication
2015-10-19 17:32:43 -07:00
Victor Woeltjen
8e2a2eeba5
[Entanglement] Add license headers
...
...per code review feedback from nasa/openmctweb#175
2015-10-19 12:08:49 -07:00
Andrew Henry
fa3821b50f
Update of CopyService with new copy algorithm (incomplete)
2015-10-18 20:58:17 -07:00
Victor Woeltjen
bf41d82a78
[Entanglement] Restore missing specs
...
Restore specs which had been omitted from suite.json (but currently
succeed for the relevant scripts); done in the context of
nasa/openmctweb#147
2015-10-06 16:50:35 -07:00
Victor Woeltjen
a4944717a1
[Location] Test getOriginal method
2015-10-06 16:47:37 -07:00
Victor Woeltjen
70bbd3cf97
[Entanglement] Add test cases for Go To Original
2015-10-06 16:37:37 -07:00
Victor Woeltjen
e3afaf0842
[Entanglement] Add Go To Original
...
nasa/openmctweb#147
2015-10-06 16:26:08 -07:00
Victor Woeltjen
60f2f9fb6c
[Location] Add getOriginal method
...
Add a getOriginal method to the location capability, to simplify
loading of original versions of objects. nasa/openmctweb#147
2015-10-06 16:18:51 -07:00
Pete Richards
70bc17c79f
Merge remote-tracking branch 'github-open/open97' into open-master
2015-09-23 13:44:48 -07:00
Victor Woeltjen
fa60d62039
[Entanglement] Simplify test case
...
...per review feedback from nasa/openmctweb#98
2015-09-23 12:49:04 -07:00
Victor Woeltjen
082122ddec
[Entanglement] Move policyService.allow.andReturn
...
...to locations where the specified return value
can be more closely correlated to the relevant
test cases. nasa/openmctweb#98
2015-09-23 12:46:23 -07:00
Victor Woeltjen
6dbccd5000
[Entanglement] Update test cases around error-throwing
...
...per code review feedback, nasa/openmctweb#97
2015-09-23 12:43:03 -07:00
Victor Woeltjen
97892869ae
[Entanglement] Move composition check up
...
Move check for composition up higher in the sequence of
if-blocks in the validation step of linking; remove
fallback to [] for undefined composition, which is no
longer necessary as a consequence of this.
nasa/openmctweb#98
2015-09-22 15:53:27 -07:00
Victor Woeltjen
8db334e45b
Revert "[LinkService] Reorder/refactor validation"
...
This reverts commit c17269ba8b
2015-09-22 15:51:15 -07:00
Victor Woeltjen
4743833f7c
[Entanglement] Verify revalidation
...
Verify that move/copy/link revalidate when performed and
throw errors when moving/copying/linking would be invalid.
nasa/openmctweb#98
2015-09-22 15:49:22 -07:00
