mirror of
https://github.com/nasa/openmct.git
synced 2025-04-16 15:29:20 +00:00
[Entanglement] Move composition check up
Move check for composition up higher in the sequence of if-blocks in the validation step of linking; remove fallback to [] for undefined composition, which is no longer necessary as a consequence of this. nasa/openmctweb#98
This commit is contained in:
parent
8db334e45b
commit
97892869ae
@ -45,14 +45,17 @@ define(
|
||||
if (parentCandidate.getId() === object.getId()) {
|
||||
return false;
|
||||
}
|
||||
if ((parentCandidate.getModel().composition || []).indexOf(object.getId()) !== -1) {
|
||||
if (!parentCandidate.hasCapability('composition')) {
|
||||
return false;
|
||||
}
|
||||
if (parentCandidate.getModel().composition.indexOf(object.getId()) !== -1) {
|
||||
return false;
|
||||
}
|
||||
return this.policyService.allow(
|
||||
"composition",
|
||||
parentCandidate.getCapability('type'),
|
||||
object.getCapability('type')
|
||||
) && parentCandidate.hasCapability('composition');
|
||||
);
|
||||
};
|
||||
|
||||
LinkService.prototype.perform = function (object, parentObject) {
|
||||
|
Loading…
x
Reference in New Issue
Block a user