Andrew Henry
04a18248c7
Added reference to Angular memory leak best practices
2020-06-17 15:38:17 -07:00
Andrew Henry
d462db60de
Add note on convenience function for test cleanup
2020-06-17 15:31:35 -07:00
Andrew Henry
8962b0c88b
Merge branch 'master' into testing-guidelines
2020-05-28 15:48:12 -07:00
Nikhil
8363c65312
[Notebook] display bounds change notification only if bounds changed ( #3062 ) Resolves ( #3051 )
...
* display bounds change notification only if bounds changed
* avoid empty notification messages.
2020-05-28 12:29:32 -07:00
Deep Tailor
04598b6cf1
Bug fixes for plots ( #3019 ) ( #3069 )
...
* prevent plots from breaking when more than one NaN is received.
* fix y axis label issue
* dont emit a viewport change event when marquee doesnt happen
2020-05-28 09:58:22 -07:00
Andrew Henry
3876151a4b
Added guidelines to testing documentation
...
Migrating our testing guidelines into the open source repository in the interests of transparency, and to assist contributors to the project.
2020-05-27 13:57:46 -07:00
Joel McKinnon
43628ad9d6
Lodash upgrade and cleanup ( #2990 )
...
* Upgrades lodash
* Replaces some usage of lodash with native functions.
* Adds linting to catch cases where native functions could be used instead of lodash functions
* Renamed testTools to testUtils
Co-authored-by: Joshi <simplyrender@gmail.com>
Co-authored-by: David Tsay <david.e.tsay@nasa.gov>
Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-05-27 10:59:02 -07:00
Andrew Henry
67bea86bc8
Added headless mode start option ( #3065 )
...
* Added headless mode start option. Fixes #3064
2020-05-26 11:39:55 -07:00
Shefali Joshi
4eb4cbfffc
Merge pull request #3020 from nasa/updated-checklists
...
Add details about pull requests to contributing guide
2020-05-19 09:30:05 -07:00
Shefali Joshi
eda01abcbc
Merge branch 'master' into updated-checklists
2020-05-18 12:12:26 -07:00
David Tsay
694b8f4666
provide format for name metadata ( #3054 )
2020-05-18 11:40:05 -07:00
David Tsay
bbb271a678
clarify value hints ( #2673 )
...
remove confusing comments regarding domain - input and range - output
2020-05-15 14:48:25 -07:00
Deep Tailor
fec1438806
dont emit a viewport change event when marquee doesnt happen ( #3036 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-05-15 14:35:13 -07:00
Nikhil
28f19ec310
[Notebook] Clicking on an embed in a notebook entry does not result in bounds change #3034 ( #3042 )
2020-05-14 14:56:41 -07:00
Shefali Joshi
f934454c25
Fixes computation of result when telemetry is not used by an object ( #3040 )
...
* Resolves issue #30307
Don't compute the result of a condition if telemetry datum is not being used by that condition
* Adds tests for condition results
2020-05-13 14:30:45 -07:00
Andrew Henry
eb49ffae02
Update CONTRIBUTING.md
2020-05-13 09:21:00 -07:00
Andrew Henry
5751012872
Update CONTRIBUTING.md
2020-05-13 09:20:03 -07:00
Andrew Henry
aa041e04cf
Merge remote-tracking branch 'origin/update-contributing-guidelines' into updated-checklists
2020-05-11 17:13:53 -07:00
Andrew Henry
24e7ea143a
Added more details on the process around pull requests
2020-05-11 17:12:25 -07:00
Andrew Henry
79d5d9c4d0
Update CONTRIBUTING.md
2020-05-11 16:15:17 -07:00
Andrew Henry
b5bfdc4418
Update CONTRIBUTING.md
2020-05-11 15:56:49 -07:00
Andrew Henry
59730c60ec
Update CONTRIBUTING.md
2020-05-11 15:54:25 -07:00
Shefali Joshi
4a87a5d847
Show object styles in preview modal ( #3018 )
...
* Adds conditional styles to Preview window
2020-05-11 14:25:39 -07:00
Deep Tailor
421c09ec2c
Allow users to lazy load Tabs ( #2958 )
...
* lazy load tabs
* remove listener on destroy
* fix lint error
* Store current tab position on domainObject
* remove lodash dependency and use keystring
2020-05-08 10:36:13 -07:00
Nikhil
0679b246b8
[Notebook]: Remove default section/page from localstorage on notebook delete ( #2900 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-05-07 16:13:32 -07:00
Deep Tailor
83f9c6c528
improve plot gestures - and clean up ( #3013 )
2020-05-06 10:33:59 -07:00
Andrew Henry
a5f3ba6259
Use evalAsync instead of digest() ( #3001 )
...
Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-05-05 12:23:41 -07:00
Shefali Joshi
a70facf0c8
Merge pull request #3000 from nasa/upgrade-moment
...
Upgrade moment to 2.25.3
2020-05-05 11:01:39 -07:00
Andrew Henry
447fe94325
Merge branch 'upgrade-moment' of https://github.com/nasa/openmct into upgrade-moment
2020-05-05 10:36:43 -07:00
Andrew Henry
8e2b666766
Upgraded moment version to 2.25.3
2020-05-05 10:36:33 -07:00
Shefali Joshi
dcbfbdbb89
Merge branch 'master' into upgrade-moment
2020-05-05 10:12:50 -07:00
Shefali Joshi
4c76bf34ab
Highlight currently winning Condition in Condition Set Edit and Read-only views ( #2936 )
...
* Preview condition styles on selecting that condition or one of it's styles
Co-authored-by: charlesh88 <charlesh88@gmail.com>
2020-05-05 09:55:42 -07:00
Andrew Henry
81b7a9d3e0
Merge branch 'master' into upgrade-moment
2020-05-01 16:47:26 -07:00
Andrew Henry
dc573c479c
Upgrade moment to 2.24.0
2020-05-01 16:25:49 -07:00
Nikhil
23303c910e
Don't allow recursive Preview actions #2775 ( #2869 )
...
* Don't allow recursive Preview actions #2775
* actionsToBeIncluded and actionsToBeSkipped passed in as options object.
* Revert "actionsToBeIncluded and actionsToBeSkipped passed in as options object."
This reverts commit f501d0b4ba
.
* Revert "Don't allow recursive Preview actions #2775 "
This reverts commit 5563cbea3a
.
* Don't allow recursive Preview actions
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-05-01 09:33:10 -07:00
Nikhil
3282934cf6
fix test coverage. ( #2951 )
...
* fix test coverage.
* changes per comments + added test-coverage script to increase max-old-space-size of V8
ref: https://nodejs.org/api/cli.html#cli_max_old_space_size_size_in_mbytes
* renamed test:coverage and test:debug.
* circle-ci to use test:coverage.
* reduced test coverage thresholds.
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 16:57:53 -07:00
Nikhil
c157fab081
[Notebook] Save snapshot dropdown should be available from "view large" overlay #2922 ( #2926 )
...
* [Notebook] Save snapshot dropdown should be available from "view large" overlay #2922\
* Significant improvements to Snapshot styling
* [Notebook] Embed links aren't navigating #2979
Co-authored-by: charlesh88 <charlesh88@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 16:39:20 -07:00
Nikhil
7c07b66cc9
[Notebook] : Error in event handler for "updateSection": "TypeError: Cannot read property 'id' of undefined" #2921 ( #2924 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 16:30:09 -07:00
Shefali Joshi
7a906ccf5c
Preview condition styles on selecting that condition or one of it's styles ( #2925 )
...
* Preview condition styles on selecting that condition or one of it's styles
* Do not evaluate conditional styles in edit mode
Co-authored-by: charlesh88 <charlesh88@gmail.com>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 13:00:43 -07:00
Nikhil
ff7debfb81
[Notebook] Entries and Embeds need to use the same timesystem #2920 ( #2923 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 11:56:08 -07:00
Joel McKinnon
92ba103f45
modified eslint script and fixed errors found ( #2905 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 11:53:07 -07:00
Nikhil
2c2d8d6b56
[Notebook]: Unnecessary notification "Time bounds changed to fixed timespan mode" #2843 ( #2866 )
...
* [Notebook]: Unnecessary notification "Time bounds changed to fixed timespan mode" #2843
* removed stopclock call.
Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-04-30 10:47:49 -07:00
Charles Hacskaylo
cfadb9f4fd
Fixes #2901 ( #2902 )
...
- Mod PreviewAction to prevent folders from being previewed;
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-30 09:48:16 -07:00
David Tsay
396817b2d1
handle non-valid requests ( #2984 )
...
Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-04-29 15:24:12 -07:00
David Tsay
96eb6d6b74
[Conditionals] evaluation fixes ( #2981 )
...
* change single output to state and value
* do not send telemetryObjects to telemetry api request cal
* normalize data on requests
Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-04-29 14:56:07 -07:00
Shefali Joshi
cb5d47f66f
Use only the values required for description ( #2919 )
...
Co-authored-by: Andrew Henry <akhenry@gmail.com>
2020-04-28 16:58:58 -07:00
Shefali Joshi
ea90d02d66
Show the Styles tab for non creatable layout objects including condition sets ( #2975 )
2020-04-28 13:10:29 -07:00
David Tsay
95f73d8eb8
[Conditionals] fix #2961 in master ( #2969 )
...
* use correct id for telemetry requests
* request and subscription data cache should be mutually exclusive
use latest timestamp for any/all requests
* do not add prop to datum
remove unnecessary if check
Co-authored-by: Deep Tailor <deep.j.tailor@nasa.gov>
2020-04-28 13:02:23 -07:00
Joel McKinnon
a37c686993
Merge pull request #2968 from nasa/revert-2885-lodash-upgrade-test
...
Revert "Lodash upgrade"
2020-04-24 11:55:44 -07:00
Deep Tailor
f12166097c
Revert "Lodash upgrade ( #2885 )"
...
This reverts commit d103a22fa0
.
2020-04-24 11:53:31 -07:00