ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-02-11 13:16:15 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: 🤖 beep boop beep, you forgot an await 🤖 (#7630)

Browse Source 
* fix: 🤖 beep boop beep, you forgot an `await` 🤖

* add e2e test

---------

Co-authored-by: Scott Bell <scott@traclabs.com>
This commit is contained in:
Jesse Mazzella 2024-03-20 13:20:48 -07:00 committed by GitHub
parent 1d5ddc545e
commit f504ee29cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js
View File

@ -292,6 +292,16 @@ test.describe('Basic Condition Set Use', () => {
await expect(page.getByRole('menuitem', { name: /Conditions View/ })).toBeVisible(); await expect(page.getByRole('menuitem', { name: /Conditions View/ })).toBeVisible();
await expect(page.getByRole('menuitem', { name: /Plot/ })).toBeVisible(); await expect(page.getByRole('menuitem', { name: /Plot/ })).toBeVisible();
await expect(page.getByRole('menuitem', { name: /Telemetry Table/ })).toBeVisible(); await expect(page.getByRole('menuitem', { name: /Telemetry Table/ })).toBeVisible();
await page.getByLabel('Plot').click();
await expect(
page.getByLabel('Plot Legend Collapsed').getByText('Test Condition Set')
).toBeVisible();
await page.getByLabel('Open the View Switcher Menu').click();
await page.getByLabel('Telemetry Table').click();
await expect(page.getByRole('searchbox', { name: 'output filter input' })).toBeVisible();
await page.getByLabel('Open the View Switcher Menu').click();
await page.getByLabel('Conditions View').click();
await expect(page.getByText('Current Output')).toBeVisible();
}); });
test('ConditionSet has correct outputs when telemetry is and is not available', async ({ test('ConditionSet has correct outputs when telemetry is and is not available', async ({
page page

2
src/plugins/condition/ConditionManager.js
View File

@ -364,7 +364,7 @@ export default class ConditionManager extends EventEmitter {
let nextLegOptions = { ...options }; let nextLegOptions = { ...options };
delete nextLegOptions.onPartialResponse; delete nextLegOptions.onPartialResponse;
const results = Promise.all( const results = await Promise.all(
this.conditions.map((condition) => condition.requestLADConditionResult(nextLegOptions)) this.conditions.map((condition) => condition.requestLADConditionResult(nextLegOptions))
); );