From f504ee29ccf72070b4326ecffd08bb71e85314c1 Mon Sep 17 00:00:00 2001 From: Jesse Mazzella Date: Wed, 20 Mar 2024 13:20:48 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=A4=96=20beep=20boop=20beep,=20you?= =?UTF-8?q?=20forgot=20an=20`await`=20=F0=9F=A4=96=20(#7630)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: 🤖 beep boop beep, you forgot an `await` 🤖 * add e2e test --------- Co-authored-by: Scott Bell --- .../plugins/conditionSet/conditionSet.e2e.spec.js | 10 ++++++++++ src/plugins/condition/ConditionManager.js | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js b/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js index fbfb316999..7cdfae0708 100644 --- a/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js +++ b/e2e/tests/functional/plugins/conditionSet/conditionSet.e2e.spec.js @@ -292,6 +292,16 @@ test.describe('Basic Condition Set Use', () => { await expect(page.getByRole('menuitem', { name: /Conditions View/ })).toBeVisible(); await expect(page.getByRole('menuitem', { name: /Plot/ })).toBeVisible(); await expect(page.getByRole('menuitem', { name: /Telemetry Table/ })).toBeVisible(); + await page.getByLabel('Plot').click(); + await expect( + page.getByLabel('Plot Legend Collapsed').getByText('Test Condition Set') + ).toBeVisible(); + await page.getByLabel('Open the View Switcher Menu').click(); + await page.getByLabel('Telemetry Table').click(); + await expect(page.getByRole('searchbox', { name: 'output filter input' })).toBeVisible(); + await page.getByLabel('Open the View Switcher Menu').click(); + await page.getByLabel('Conditions View').click(); + await expect(page.getByText('Current Output')).toBeVisible(); }); test('ConditionSet has correct outputs when telemetry is and is not available', async ({ page diff --git a/src/plugins/condition/ConditionManager.js b/src/plugins/condition/ConditionManager.js index c1fd59cb35..be51360300 100644 --- a/src/plugins/condition/ConditionManager.js +++ b/src/plugins/condition/ConditionManager.js @@ -364,7 +364,7 @@ export default class ConditionManager extends EventEmitter { let nextLegOptions = { ...options }; delete nextLegOptions.onPartialResponse; - const results = Promise.all( + const results = await Promise.all( this.conditions.map((condition) => condition.requestLADConditionResult(nextLegOptions)) );