ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-04-17 15:59:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Creation] Rename creation capability

Browse Source 
...to instantiation, to distinguish from creation (which
typically includes persistence.)
This commit is contained in:
Victor Woeltjen 2015-11-06 14:07:53 -08:00
parent bdc99950c6
commit d059116782
6 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
platform/commonUI/browse/src/creation/CreationService.js
View File

@ -68,7 +68,7 @@ define(
*/
CreationService.prototype.createObject = function (model, parent) {
var persistence = parent.getCapability("persistence"),
newObject = parent.useCapability("creation", model),
newObject = parent.useCapability("instantiation", model),
newObjectPersistence = newObject.getCapability("persistence"),
self = this;

10
platform/commonUI/browse/test/creation/CreationServiceSpec.js
View File

@ -91,14 +91,14 @@ define(
);
mockCreationCapability = jasmine.createSpyObj(
"creation",
["create", "invoke"]
["instantiate", "invoke"]
);
mockCapabilities = {
mutation: mockMutationCapability,
persistence: mockPersistenceCapability,
composition: mockCompositionCapability,
context: mockContextCapability,
creation: mockCreationCapability
instantiation: mockCreationCapability
};
mockNewPersistenceCapability = jasmine.createSpyObj(
"new-persistence",
@ -130,9 +130,9 @@ define(
mockPromise([mockNewObject])
);
mockCompositionCapability.add.andReturn(mockPromise(true));
mockCreationCapability.create.andReturn(mockNewObject);
mockCreationCapability.instantiate.andReturn(mockNewObject);
mockCreationCapability.invoke.andCallFake(function (model) {
return mockCreationCapability.create(model);
return mockCreationCapability.instantiate(model);
});
creationService = new CreationService(
@ -144,7 +144,7 @@ define(
it("allows new objects to be created", function () {
var model = { someKey: "some value" };
creationService.createObject(model, mockParentObject);
expect(mockCreationCapability.create)
expect(mockCreationCapability.instantiate)
.toHaveBeenCalledWith(model);
});

4
platform/core/bundle.json
View File

@ -200,8 +200,8 @@
"depends": [ "$q" ]
},
{
"key": "creation",
"implementation": "capabilities/CreationCapability.js",
"key": "instantiation",
"implementation": "capabilities/InstantiationCapability.js",
"depends": [ "$injector" ]
}
],

4
platform/core/src/capabilities/CreationCapability.js → platform/core/src/capabilities/InstantiationCapability.js
View File

@ -61,7 +61,7 @@ define(
*
* @returns {DomainObject} the new domain object
*/
CreationCapability.prototype.create = function (model) {
CreationCapability.prototype.instantiate = function (model) {
var id = uuid(),
capabilities = this.getCapabilities(model);
return new DomainObjectImpl(id, model, capabilities);
@ -72,7 +72,7 @@ define(
* @see {platform/core.CreationCapability#create}
*/
CreationCapability.prototype.invoke =
CreationCapability.prototype.create;
CreationCapability.prototype.instantiate;
return CreationCapability;
}

18
platform/core/test/capabilities/CreationCapabilitySpec.js → platform/core/test/capabilities/InstantiationCapabilitySpec.js
View File

@ -25,14 +25,14 @@
* ContextCapability. Created by vwoeltje on 11/6/14.
*/
define(
["../../src/capabilities/CreationCapability"],
function (CreationCapability) {
["../../src/capabilities/InstantiationCapability"],
function (InstantiationCapability) {
'use strict';
describe("The 'creation' capability", function () {
describe("The 'instantiation' capability", function () {
var mockInjector,
mockCapabilityService,
creation;
instantiation;
beforeEach(function () {
mockInjector = jasmine.createSpyObj("$injector", ["get"]);
@ -46,12 +46,12 @@ define(
mockCapabilityService : undefined;
});
creation = new CreationCapability(mockInjector);
instantiation = new InstantiationCapability(mockInjector);
});
it("aliases 'create' as 'invoke'", function () {
expect(creation.invoke).toBe(creation.create);
it("aliases 'instantiate' as 'invoke'", function () {
expect(instantiation.invoke).toBe(instantiation.instantiate);
});
describe("when creating an object", function () {
@ -71,7 +71,7 @@ define(
testModel = { someKey: "some value" };
domainObject = creation.create(testModel);
domainObject = instantiation.instantiate(testModel);
});
it("loads capabilities from the capability service", function () {
@ -92,7 +92,7 @@ define(
it("provides unique identifiers", function () {
expect(domainObject.getId()).toEqual(jasmine.any(String));
expect(creation.create(testModel).getId())
expect(instantiation.instantiate(testModel).getId())
.not.toEqual(domainObject.getId());
});
});

2
platform/core/test/suite.json
View File

@ -8,8 +8,8 @@
"capabilities/ContextCapability",
"capabilities/ContextualDomainObject",
"capabilities/CoreCapabilityProvider",
"capabilities/CreationCapability",
"capabilities/DelegationCapability",
"capabilities/InstantiationCapability",
"capabilities/MetadataCapability",
"capabilities/MutationCapability",
"capabilities/PersistenceCapability",