ExternalVendorCode/openmct
1
0
Fork 0
mirror of https://github.com/nasa/openmct.git synced 2025-02-06 11:09:21 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

A couple of fixes for percy flakiness (#5752)

Browse Source 
* deflake

* disable percy temporarily

* lower concurrency

* doc some changes

* Revert "disable percy temporarily"

This reverts commit 46f2bcf9c430572d4ddd9c7ec1d0b1ea9a219d00.
This commit is contained in:
John Hill 2022-09-13 11:18:12 -07:00 committed by GitHub
parent f20bb4de10
commit a65757d197
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
e2e/.percy.yml
View File

@ -2,4 +2,5 @@ version: 2
snapshot: snapshot:
widths: [1024, 2000] widths: [1024, 2000]
min-height: 1440 # px min-height: 1440 # px
discovery:
concurrency: 2 # https://github.com/percy/cli/discussions/1067

10
e2e/playwright-visual.config.js
View File

@ -4,11 +4,11 @@
/** @type {import('@playwright/test').PlaywrightTestConfig<{ theme: string }>} */ /** @type {import('@playwright/test').PlaywrightTestConfig<{ theme: string }>} */
const config = { const config = {
retries: 0, // visual tests should never retry due to snapshot comparison errors retries: 1, // visual tests should never retry due to snapshot comparison errors. Leaving as a shim
testDir: 'tests/visual', testDir: 'tests/visual',
testMatch: '**/*.visual.spec.js', // only run visual tests testMatch: '**/*.visual.spec.js', // only run visual tests
timeout: 90 * 1000, timeout: 60 * 1000,
workers: 1, //Limit to 1 for CircleCI Agent workers: 1, //Lower stress on Circle CI Agent for Visual tests https://github.com/percy/cli/discussions/1067
webServer: { webServer: {
command: 'cross-env NODE_ENV=test npm run start', command: 'cross-env NODE_ENV=test npm run start',
url: 'http://localhost:8080/#', url: 'http://localhost:8080/#',
@ -19,8 +19,8 @@ const config = {
baseURL: 'http://localhost:8080/', baseURL: 'http://localhost:8080/',
headless: true, // this needs to remain headless to avoid visual changes due to GPU rendering in headed browsers headless: true, // this needs to remain headless to avoid visual changes due to GPU rendering in headed browsers
ignoreHTTPSErrors: true, ignoreHTTPSErrors: true,
screenshot: 'on', screenshot: 'only-on-failure',
trace: 'on', trace: 'on-first-retry',
video: 'off' video: 'off'
}, },
projects: [ projects: [