From a65757d197f6911240522c51c29da63f27df0b93 Mon Sep 17 00:00:00 2001 From: John Hill Date: Tue, 13 Sep 2022 11:18:12 -0700 Subject: [PATCH] A couple of fixes for percy flakiness (#5752) * deflake * disable percy temporarily * lower concurrency * doc some changes * Revert "disable percy temporarily" This reverts commit 46f2bcf9c430572d4ddd9c7ec1d0b1ea9a219d00. --- e2e/.percy.yml | 3 ++- e2e/playwright-visual.config.js | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/e2e/.percy.yml b/e2e/.percy.yml index fc3ff095de..11495d9d4a 100644 --- a/e2e/.percy.yml +++ b/e2e/.percy.yml @@ -2,4 +2,5 @@ version: 2 snapshot: widths: [1024, 2000] min-height: 1440 # px - +discovery: + concurrency: 2 # https://github.com/percy/cli/discussions/1067 diff --git a/e2e/playwright-visual.config.js b/e2e/playwright-visual.config.js index bc29772742..1123de8087 100644 --- a/e2e/playwright-visual.config.js +++ b/e2e/playwright-visual.config.js @@ -4,11 +4,11 @@ /** @type {import('@playwright/test').PlaywrightTestConfig<{ theme: string }>} */ const config = { - retries: 0, // visual tests should never retry due to snapshot comparison errors + retries: 1, // visual tests should never retry due to snapshot comparison errors. Leaving as a shim testDir: 'tests/visual', testMatch: '**/*.visual.spec.js', // only run visual tests - timeout: 90 * 1000, - workers: 1, //Limit to 1 for CircleCI Agent + timeout: 60 * 1000, + workers: 1, //Lower stress on Circle CI Agent for Visual tests https://github.com/percy/cli/discussions/1067 webServer: { command: 'cross-env NODE_ENV=test npm run start', url: 'http://localhost:8080/#', @@ -19,8 +19,8 @@ const config = { baseURL: 'http://localhost:8080/', headless: true, // this needs to remain headless to avoid visual changes due to GPU rendering in headed browsers ignoreHTTPSErrors: true, - screenshot: 'on', - trace: 'on', + screenshot: 'only-on-failure', + trace: 'on-first-retry', video: 'off' }, projects: [