ExternalVendorCode/onefuzz
1
0
Fork 0
mirror of https://github.com/microsoft/onefuzz.git synced 2025-06-12 01:58:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some allow(clippy::uninit_vec) (#2111)

Browse Source 
Closes #1595. Leaving one instance of `allow(clippy::uninit_vec)` in `pipe_handle.rs` as it is more difficult to remove. (Maybe there's  another crate we could use for pipes?)

To satisfy clippy, instead of creating the vec and then resizing it straight away (exposing uninitialized data), write into the `spare_capacity_mut()` (which is `&mut [MaybeUninit<_>]`) and then resize it afterwards.
This commit is contained in:
George Pollard
2022-07-08 13:24:11 +12:00
committed by GitHub
parent 6bf77a6230
commit e37f56dd05
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/agent/debugger/src/breakpoint.rs
View File

@ -1,8 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
#![allow(clippy::uninit_vec)]
use std::{
collections::{btree_map::Range, BTreeMap},
ops::RangeBounds,
@ -269,10 +267,16 @@ impl BreakpointCollection {
fn bulk_read_process_memory(&self, process_handle: HANDLE) -> Result<Vec<u8>> {
let mut buffer: Vec<u8> = Vec::with_capacity(self.bulk_region_size());
process::read_memory_array(
process_handle,
self.min_breakpoint_addr as _,
buffer.spare_capacity_mut(),
)?;
unsafe {
buffer.set_len(self.bulk_region_size());
}
process::read_memory_array(process_handle, self.min_breakpoint_addr as _, &mut buffer)?;
Ok(buffer)
}

6
src/agent/win-util/src/process.rs
View File

@ -1,8 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
#![allow(clippy::uninit_vec)]
use std::{
ffi::OsString,
mem::{size_of, MaybeUninit},
@ -112,10 +110,10 @@ pub fn read_narrow_string(
len: usize,
) -> Result<String> {
let mut buf: Vec<u8> = Vec::with_capacity(len);
read_memory_array(process_handle, remote_address, buf.spare_capacity_mut())?;
unsafe {
buf.set_len(len);
}
read_memory_array::<u8>(process_handle, remote_address, &mut buf[..])?;
Ok(String::from_utf8_lossy(&buf).into())
}
@ -125,10 +123,10 @@ pub fn read_wide_string(
len: usize,
) -> Result<OsString> {
let mut buf: Vec<u16> = Vec::with_capacity(len);
read_memory_array(process_handle, remote_address, buf.spare_capacity_mut())?;
unsafe {
buf.set_len(len);
}
read_memory_array::<u16>(process_handle, remote_address, &mut buf[..])?;
Ok(OsString::from_wide(&buf))
}