TODO: eventually refactor this out or silence no encrypted lvm found echos in code: who use encrypted LVM nowadays? I think this was pre QubesOS 3.2 era but not even sure anymore.
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Otherwise qemu roms which injects distinct public key with entropy at each build are wiped.
TODO : revisit approach when flashrom/flashprog/qemu supports 16MB SPI flash emulation so we can use flashprog to flash internally, which will require refactoring
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Repro:
sudo sed -i 's/# CONFIG_USE_BLOBS is not set/CONFIG_USE_BLOBS=y/g' config/coreboot-*
sudo git restore config/coreboot-kgpe-d16_server.config config/coreboot-kgpe-d16_workstation-usb_keyboard.config config/coreboot-kgpe-d16_workstation.config
./docker_repro.sh
find ./boards/ -type d | awk -F "/" {'print $3'} | while read board; do make BOARD=$board coreboot.save_in_oldconfig_format_in_place; done
Test @miczyg1 hypothesis from https://github.com/linuxboot/heads/issues/1940#issuecomment-2772425103
- We use git repo for coreboot 24.12 as opposed to tarball for previous 22.04.01
- 3rdparty microcode git submodule might be empty for some reason if not instructed to be synced by kconfig)
- TODO: Review https://github.com/linuxboot/heads/issues/1940#issuecomment-2772425103
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
First layer cache of CircleCI is reused when second cache is invalidated: that is, to not compiled musl-cross-make from source for x86/ppc64 at each build when any other thing changed under Heads.
Unfortunately, https://github.com/linuxboot/heads/pull/1947 was incomplete in that regard, as showed per build:
- last save cache step https://app.circleci.com/pipelines/github/tlaurion/heads/3270/workflows/07dee00e-926e-4023-b8a7-669078e6ef31/jobs/66483
- first layer cache saving https://app.circleci.com/pipelines/github/tlaurion/heads/3270/workflows/07dee00e-926e-4023-b8a7-669078e6ef31/jobs/66483
- Warning: could not archive /root/heads/build/ppc64/musl-cross-make-38e52db8358c043ae82b346a2e6e66bc86a53bc1 - Not found
- Warning: could not archive /root/heads/build/x86/musl-cross-make-38e52db8358c043ae82b346a2e6e66bc86a53bc1 - Not found
It is also irrelevant to bind first layer cache with .circleci/config.yml, nor Makefile related changes. After all the first layer is related to reusing musl-cross-make to reduce build times on CI
Therefore, only flake.lock and modules/musl-cross-make is relevant to be part of hashed files that should nto change to construct/reuse that cache
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Board name was changed due to being untested. It still builds, so the
packages still sync to mirrors for now.
Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm>
Unfortunately the helper doesn't deal well with board inclusion: sed call is imperfect, and board config needs to be manually edited.
TODO: fix the helper when it will be the time to move back to tested/untested
Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Not necessary anymore as properly fixed by coreboot patch 0004 in 3466272a69f1345340f5eeda05a5dd338883f8eb
This reverts commit aa2b15dd055b3db18e0e60bf4a008d3e6b95c270.
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
With 3466272a69f1345340f5eeda05a5dd338883f8eb T480 thermal codepath does not break other boards anymore.
We move it back to circleci and maintained.
This reverts commit 730fdd1b25384bacc8e491c543709f5967651ffb.
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
still not fixing things properly but at least it should now be possible to build older thinkpads without regressions.
prior, some code was just commented or unreachable. now we make this explicit with preprocessor directives.
heads should build all boards on this coreboot version from the same coreboot tree.
use CONFIG_BOARD_LENOVO_SKLKBL_THINKPAD_COMMON to decide what to compile
this should work for T480, T480S and older thinkpads
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
