Unit tests fixed

This commit is contained in:
Piotr Pekala 2019-02-28 01:45:01 -08:00
parent 18a80468d0
commit 06290a2dec
3 changed files with 115 additions and 0 deletions

View File

@ -79,9 +79,59 @@ describe('QemuVmTemplateDetailsComponent', () => {
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.qemuTemplate = {
adapters: 0,
custom_adapters: []
} as QemuTemplate;
component.onSave();
expect(mockedQemuService.saveTemplate).toHaveBeenCalled();
});
it('should not call save template when template name is empty', () => {
spyOn(mockedQemuService, 'saveTemplate').and.returnValue(of({} as QemuTemplate));
component.generalSettingsForm.controls['templateName'].setValue('');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.qemuTemplate = {
adapters: 0,
custom_adapters: []
} as QemuTemplate;
component.onSave();
expect(mockedQemuService.saveTemplate).not.toHaveBeenCalled();
});
it('should not call save template when default name is empty', () => {
spyOn(mockedQemuService, 'saveTemplate').and.returnValue(of({} as QemuTemplate));
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.qemuTemplate = {
adapters: 0,
custom_adapters: []
} as QemuTemplate;
component.onSave();
expect(mockedQemuService.saveTemplate).not.toHaveBeenCalled();
});
it('should call save template when symbol is empty', () => {
spyOn(mockedQemuService, 'saveTemplate').and.returnValue(of({} as QemuTemplate));
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('');
component.qemuTemplate = {
adapters: 0,
custom_adapters: []
} as QemuTemplate;
component.onSave();
expect(mockedQemuService.saveTemplate).not.toHaveBeenCalled();
});
});

View File

@ -68,9 +68,58 @@ describe('VirtualBoxTemplateDetailsComponent', () => {
it('should call save template', () => {
spyOn(mockedVirtualBoxService, 'saveTemplate').and.returnValue(of({} as VirtualBoxTemplate));
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.generalSettingsForm.controls['ram'].setValue('256');
component.networkForm.controls['adapters'].setValue('1');
component.networkForm.controls['nameFormat'].setValue('{}');
component.networkForm.controls['size'].setValue('256');
component.virtualBoxTemplate = {
adapters: 0,
custom_adapters: []
} as VirtualBoxTemplate;
component.onSave();
expect(mockedVirtualBoxService.saveTemplate).toHaveBeenCalled();
});
it('should not call save template when general settings are not filled', () => {
spyOn(mockedVirtualBoxService, 'saveTemplate').and.returnValue(of({} as VirtualBoxTemplate));
component.generalSettingsForm.controls['templateName'].setValue('');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.generalSettingsForm.controls['ram'].setValue('256');
component.networkForm.controls['adapters'].setValue('1');
component.networkForm.controls['nameFormat'].setValue('{}');
component.networkForm.controls['size'].setValue('256');
component.virtualBoxTemplate = {
adapters: 0,
custom_adapters: []
} as VirtualBoxTemplate;
component.onSave();
expect(mockedVirtualBoxService.saveTemplate).not.toHaveBeenCalled();
});
it('should not call save template when network settings are not filled', () => {
spyOn(mockedVirtualBoxService, 'saveTemplate').and.returnValue(of({} as VirtualBoxTemplate));
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.generalSettingsForm.controls['ram'].setValue('256');
component.networkForm.controls['adapters'].setValue('');
component.networkForm.controls['nameFormat'].setValue('{}');
component.networkForm.controls['size'].setValue('256');
component.virtualBoxTemplate = {
adapters: 0,
custom_adapters: []
} as VirtualBoxTemplate;
component.onSave();
expect(mockedVirtualBoxService.saveTemplate).not.toHaveBeenCalled();
});
});

View File

@ -71,6 +71,10 @@ describe('VmwareTemplateDetailsComponent', () => {
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.vmwareTemplate = {
adapters: 0,
custom_adapters: []
} as VmwareTemplate;
component.onSave();
@ -82,6 +86,10 @@ describe('VmwareTemplateDetailsComponent', () => {
component.generalSettingsForm.controls['templateName'].setValue('');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.vmwareTemplate = {
adapters: 0,
custom_adapters: []
} as VmwareTemplate;
component.onSave();
@ -93,6 +101,10 @@ describe('VmwareTemplateDetailsComponent', () => {
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('');
component.generalSettingsForm.controls['symbol'].setValue('symbol');
component.vmwareTemplate = {
adapters: 0,
custom_adapters: []
} as VmwareTemplate;
component.onSave();
@ -104,6 +116,10 @@ describe('VmwareTemplateDetailsComponent', () => {
component.generalSettingsForm.controls['templateName'].setValue('template name');
component.generalSettingsForm.controls['defaultName'].setValue('default name');
component.generalSettingsForm.controls['symbol'].setValue('');
component.vmwareTemplate = {
adapters: 0,
custom_adapters: []
} as VmwareTemplate;
component.onSave();