mirror of
https://github.com/genodelabs/genode.git
synced 2024-12-24 07:46:42 +00:00
eba9c15746
The patch adjust the code of the base, base-<kernel>, and os repository. To adapt existing components to fix violations of the best practices suggested by "Effective C++" as reported by the -Weffc++ compiler argument. The changes follow the patterns outlined below: * A class with virtual functions can no longer publicly inherit base classed without a vtable. The inherited object may either be moved to a member variable, or inherited privately. The latter would be used for classes that inherit 'List::Element' or 'Avl_node'. In order to enable the 'List' and 'Avl_tree' to access the meta data, the 'List' must become a friend. * Instead of adding a virtual destructor to abstract base classes, we inherit the new 'Interface' class, which contains a virtual destructor. This way, single-line abstract base classes can stay as compact as they are now. The 'Interface' utility resides in base/include/util/interface.h. * With the new warnings enabled, all member variables must be explicitly initialized. Basic types may be initialized with '='. All other types are initialized with braces '{ ... }' or as class initializers. If basic types and non-basic types appear in a row, it is nice to only use the brace syntax (also for basic types) and align the braces. * If a class contains pointers as members, it must now also provide a copy constructor and assignment operator. In the most cases, one would make them private, effectively disallowing the objects to be copied. Unfortunately, this warning cannot be fixed be inheriting our existing 'Noncopyable' class (the compiler fails to detect that the inheriting class cannot be copied and still gives the error). For now, we have to manually add declarations for both the copy constructor and assignment operator as private class members. Those declarations should be prepended with a comment like this: /* * Noncopyable */ Thread(Thread const &); Thread &operator = (Thread const &); In the future, we should revisit these places and try to replace the pointers with references. In the presence of at least one reference member, the compiler would no longer implicitly generate a copy constructor. So we could remove the manual declaration. Issue #465
158 lines
4.6 KiB
C++
158 lines
4.6 KiB
C++
/*
|
|
* \brief Connection to file-system service
|
|
* \author Norman Feske
|
|
* \date 2012-04-05
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2012-2017 Genode Labs GmbH
|
|
*
|
|
* This file is part of the Genode OS framework, which is distributed
|
|
* under the terms of the GNU Affero General Public License version 3.
|
|
*/
|
|
|
|
#ifndef _INCLUDE__FILE_SYSTEM_SESSION__CONNECTION_H_
|
|
#define _INCLUDE__FILE_SYSTEM_SESSION__CONNECTION_H_
|
|
|
|
#include <file_system_session/client.h>
|
|
#include <base/connection.h>
|
|
#include <base/allocator.h>
|
|
#include <util/retry.h>
|
|
|
|
namespace File_system {
|
|
|
|
struct Connection_base;
|
|
struct Connection;
|
|
|
|
/* recommended packet transmission buffer size */
|
|
enum { DEFAULT_TX_BUF_SIZE = 128*1024 };
|
|
|
|
}
|
|
|
|
|
|
/**
|
|
* The base implementation of a File_system connection
|
|
*/
|
|
struct File_system::Connection_base : Genode::Connection<Session>, Session_client
|
|
{
|
|
/**
|
|
* Issue session request
|
|
*
|
|
* \noapi
|
|
*/
|
|
Genode::Capability<File_system::Session> _session(Genode::Parent &parent,
|
|
char const *label,
|
|
char const *root,
|
|
bool writeable,
|
|
size_t tx_buf_size)
|
|
{
|
|
return session(parent,
|
|
"ram_quota=%ld, "
|
|
"cap_quota=%ld, "
|
|
"tx_buf_size=%ld, "
|
|
"label=\"%s\", "
|
|
"root=\"%s\", "
|
|
"writeable=%d",
|
|
8*1024*sizeof(long) + tx_buf_size,
|
|
CAP_QUOTA,
|
|
tx_buf_size,
|
|
label, root, writeable);
|
|
}
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \param tx_buffer_alloc allocator used for managing the
|
|
* transmission buffer
|
|
* \param label session label
|
|
* \param root root directory of session
|
|
* \param writeable session is writable
|
|
* \param tx_buf_size size of transmission buffer in bytes
|
|
*/
|
|
Connection_base(Genode::Env &env,
|
|
Genode::Range_allocator &tx_block_alloc,
|
|
char const *label = "",
|
|
char const *root = "/",
|
|
bool writeable = true,
|
|
size_t tx_buf_size = DEFAULT_TX_BUF_SIZE)
|
|
:
|
|
Genode::Connection<Session>(env, _session(env.parent(), label, root,
|
|
writeable, tx_buf_size)),
|
|
Session_client(cap(), tx_block_alloc, env.rm())
|
|
{ }
|
|
|
|
/**
|
|
* Constructor
|
|
*
|
|
* \noapi
|
|
* \deprecated Use the constructor with 'Env &' as first
|
|
* argument instead
|
|
*/
|
|
Connection_base(Genode::Range_allocator &tx_block_alloc,
|
|
size_t tx_buf_size = DEFAULT_TX_BUF_SIZE,
|
|
char const *label = "",
|
|
char const *root = "/",
|
|
bool writeable = true) __attribute__((deprecated))
|
|
:
|
|
Genode::Connection<Session>(_session(*Genode::env_deprecated()->parent(), label,
|
|
root, writeable, tx_buf_size)),
|
|
Session_client(cap(), tx_block_alloc, *Genode::env_deprecated()->rm_session())
|
|
{ }
|
|
};
|
|
|
|
|
|
/**
|
|
* A File_system connection that upgrades its RAM quota
|
|
*/
|
|
struct File_system::Connection : File_system::Connection_base
|
|
{
|
|
/* reuse constructor */
|
|
using Connection_base::Connection_base;
|
|
|
|
/**
|
|
* Extend session quota on demand while calling an RPC function
|
|
*
|
|
* \noapi
|
|
*/
|
|
template <typename FUNC>
|
|
auto _retry(FUNC func) -> decltype(func())
|
|
{
|
|
enum { UPGRADE_ATTEMPTS = ~0U };
|
|
return Genode::retry<Out_of_ram>(
|
|
[&] () {
|
|
return Genode::retry<Out_of_caps>(
|
|
[&] () { return func(); },
|
|
[&] () { File_system::Connection_base::upgrade_caps(2); },
|
|
UPGRADE_ATTEMPTS);
|
|
},
|
|
[&] () { File_system::Connection_base::upgrade_ram(8*1024); },
|
|
UPGRADE_ATTEMPTS);
|
|
}
|
|
|
|
Dir_handle dir(Path const &path, bool create) override
|
|
{
|
|
return _retry([&] () {
|
|
return Session_client::dir(path, create); });
|
|
}
|
|
|
|
File_handle file(Dir_handle dir, Name const &name, Mode mode, bool create) override
|
|
{
|
|
return _retry([&] () {
|
|
return Session_client::file(dir, name, mode, create); });
|
|
}
|
|
|
|
Symlink_handle symlink(Dir_handle dir, Name const &name, bool create) override
|
|
{
|
|
return _retry([&] () {
|
|
return Session_client::symlink(dir, name, create); });
|
|
}
|
|
|
|
Node_handle node(Path const &path) override
|
|
{
|
|
return _retry([&] () {
|
|
return Session_client::node(path); });
|
|
}
|
|
};
|
|
|
|
#endif /* _INCLUDE__FILE_SYSTEM_SESSION__CONNECTION_H_ */
|